)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"02dbe5a8b511165f4e91725df429d3653d1a6b48","unresolved":false,"context_lines":[{"line_number":13,"context_line":"but the containers running with docker."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"The submission is proposed for tripleo-common only for"},{"line_number":16,"context_line":"stable/stein, the master patch needs to ve modev to the"},{"line_number":17,"context_line":"tripleo-ansible repository as all the Ansible automation"},{"line_number":18,"context_line":"is moved to that new repository."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7faddb67_453441fc","line":16,"updated":"2019-07-17 11:35:24.000000000","message":"nit: to be moved","commit_id":"63af004713385730291df9a26c7c72e683f23367"}],"roles/tripleo-container-stop/tasks/container_stop.yaml":[{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"02dbe5a8b511165f4e91725df429d3653d1a6b48","unresolved":false,"context_lines":[{"line_number":11,"context_line":"        podman stop {{ container }}"},{"line_number":12,"context_line":"    fi"},{"line_number":13,"context_line":"    if type docker \u0026\u003e /dev/null \u0026\u0026 docker exec {{ container }} /bin/true; then"},{"line_number":14,"context_line":"        docker stop {{ container }}"},{"line_number":15,"context_line":"    fi"},{"line_number":16,"context_line":"  delegate_to: \"{{ tripleo_delegate_to_item }}\""},{"line_number":17,"context_line":"  with_items: \"{{ tripleo_delegate_to }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7faddb67_a8162c48","line":14,"updated":"2019-07-17 11:35:24.000000000","message":"I\u0027m just wondering, what would occur if the container is already stopped? would this task give any error?","commit_id":"63af004713385730291df9a26c7c72e683f23367"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"1df467860b97414437dbf5233cbe856e86450605","unresolved":false,"context_lines":[{"line_number":11,"context_line":"        podman stop {{ container }}"},{"line_number":12,"context_line":"    fi"},{"line_number":13,"context_line":"    if type docker \u0026\u003e /dev/null \u0026\u0026 docker exec {{ container }} /bin/true; then"},{"line_number":14,"context_line":"        docker stop {{ container }}"},{"line_number":15,"context_line":"    fi"},{"line_number":16,"context_line":"  delegate_to: \"{{ tripleo_delegate_to_item }}\""},{"line_number":17,"context_line":"  with_items: \"{{ tripleo_delegate_to }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7faddb67_39593034","line":14,"in_reply_to":"7faddb67_a8162c48","updated":"2019-07-17 15:13:29.000000000","message":"Hey nope do not fail **I tested several times.","commit_id":"63af004713385730291df9a26c7c72e683f23367"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"aaaddefa0fb5952fc1a536351a0d7db24469e6e0","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    # but we might have the containers running with docker."},{"line_number":9,"context_line":"    set -eu"},{"line_number":10,"context_line":"    if command -v podman \u0026\u0026 podman exec {{ container }} /bin/true; then"},{"line_number":11,"context_line":"        podman stop {{ container }}"},{"line_number":12,"context_line":"    fi"},{"line_number":13,"context_line":"    if type docker \u0026\u003e /dev/null \u0026\u0026 docker exec {{ container }} /bin/true; then"},{"line_number":14,"context_line":"        systemctl stop tripleo_{{ container }}.service"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7faddb67_82a539a4","line":11,"updated":"2019-07-18 12:33:26.000000000","message":"The systemctl stopping should go here :)","commit_id":"b5bb16182185dda4396e1a2b270ef030f46b0413"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"6dab5f1ce1c70c6c1bbecfb29705d00cdbe28451","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    if type docker \u0026\u003e /dev/null \u0026\u0026 docker exec {{ container }} /bin/true; then"},{"line_number":14,"context_line":"        docker stop {{ container }}"},{"line_number":15,"context_line":"    fi"},{"line_number":16,"context_line":"  delegate_to: \"{{ tripleo_delegate_to_item }}\""},{"line_number":17,"context_line":"  with_items: \"{{ tripleo_delegate_to }}\""},{"line_number":18,"context_line":"  loop_control:"},{"line_number":19,"context_line":"    loop_var: tripleo_delegate_to_item"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7faddb67_9deb5076","line":16,"updated":"2019-07-19 06:19:36.000000000","message":"I have a nit about the delegate_to. It\u0027s normal that you have shape the role to fit your needs and as you\u0027re running it from an external_task, you require the delegate_to to be able to stop those containers. However, what if I want to stop the container in the same node I\u0027m running the task from? or in all the nodes specified in the playbook this role would be invoked from? It isn\u0027t a blocking comment, but it\u0027s something we need to address if we want this role to be reusable.","commit_id":"b42236c109ddbde2aea3d1e6d466fdac9fe92999"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"61358bef4cb9b04932110f0315f85f20e0be3ac5","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    if type docker \u0026\u003e /dev/null \u0026\u0026 docker exec {{ container }} /bin/true; then"},{"line_number":14,"context_line":"        docker stop {{ container }}"},{"line_number":15,"context_line":"    fi"},{"line_number":16,"context_line":"  delegate_to: \"{{ tripleo_delegate_to_item }}\""},{"line_number":17,"context_line":"  with_items: \"{{ tripleo_delegate_to }}\""},{"line_number":18,"context_line":"  loop_control:"},{"line_number":19,"context_line":"    loop_var: tripleo_delegate_to_item"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7faddb67_9301ff6c","line":16,"in_reply_to":"7faddb67_9deb5076","updated":"2019-07-19 09:50:19.000000000","message":"Yeahp, this is why we have this https://review.opendev.org/#/c/669345/11/roles/tripleo-container-stop/defaults/main.yaml\n\nI fixed a nit here.","commit_id":"b42236c109ddbde2aea3d1e6d466fdac9fe92999"}]}