)]}'
{"roles/tripleo-hieradata/tasks/hieradata_vars.yaml":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"e512c15403ddf38947e5c726bed790bbbe4ac4aa","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    dest: \"{{ dest_path | default(\u0027/etc/puppet/hieradata/\u0027 ~ item ~ \u0027.json\u0027) }}\""},{"line_number":5,"context_line":"  loop:"},{"line_number":6,"context_line":"    - host_vars"},{"line_number":7,"context_line":"    - group_vars"},{"line_number":8,"context_line":"    - global_vars"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"7faddb67_90f61563","line":7,"updated":"2019-07-15 21:58:21.000000000","message":"you could call this role_vars, b/c it\u0027s data that is specific to the Heat role.","commit_id":"51e580073733e0ce51b955fae55e19b155fc6e26"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"1cf77b8242e0839ee8bb69f1dfc64b42d4b44af2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    dest: \"{{ dest_path | default(\u0027/etc/puppet/hieradata/\u0027 ~ item ~ \u0027.json\u0027) }}\""},{"line_number":5,"context_line":"  loop:"},{"line_number":6,"context_line":"    - host_vars"},{"line_number":7,"context_line":"    - group_vars"},{"line_number":8,"context_line":"    - global_vars"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"7faddb67_107545cb","line":7,"in_reply_to":"7faddb67_90f61563","updated":"2019-07-15 22:15:47.000000000","message":"Done","commit_id":"51e580073733e0ce51b955fae55e19b155fc6e26"}],"roles/tripleo-hieradata/templates/all_nodes_merged.j2":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"0223c0bd21d9d2960b41c309a6a962b2e442febe","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  {{ \u0027\"boostrap_node_id\": \"\u0027 ~ bootstrap_node_id ~ \u0027\"\u0027 }},"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  \"ctlplane\": \"{{ ctlplane_ip }}\","},{"line_number":6,"context_line":"  \"ctlplane_subnet\": \"{{ ctlplane_ip ~ \u0027/\u0027 ~ ctlplane_subnet_cidr }}\","}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"7faddb67_e75c8dee","line":3,"updated":"2019-07-12 15:26:54.000000000","message":"var name is bootstrap_nodeid","commit_id":"9b4122c54c736d7ac3f1da8bf830478409a2e05d"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a491eaa5571c80fc896a4204352e17442c3cea5e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  {{ \u0027\"boostrap_node_id\": \"\u0027 ~ bootstrap_node_id ~ \u0027\"\u0027 }},"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  \"ctlplane\": \"{{ ctlplane_ip }}\","},{"line_number":6,"context_line":"  \"ctlplane_subnet\": \"{{ ctlplane_ip ~ \u0027/\u0027 ~ ctlplane_subnet_cidr }}\","}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"7faddb67_e7100dab","line":3,"in_reply_to":"7faddb67_e75c8dee","updated":"2019-07-12 15:43:43.000000000","message":"It\u0027s confusing.\n\nhttp://logs.openstack.org/17/669917/10/check/tripleo-ci-centos-7-undercloud-containers/d47c1e4/logs/undercloud/home/zuul/undercloud_install.log.txt.gz#_2019-07-12_04_36_38\n\nwe have bootstrap_node_id in the tripleo inventory and bootstrap_nodeid in the stack.","commit_id":"9b4122c54c736d7ac3f1da8bf830478409a2e05d"}],"roles/tripleo-hieradata/templates/global_vars.j2":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"105b76cce4649f6df2048b45757f2878b97892f9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  \"tripleo::clouddomain\": \"{{cloud_domain}}\","},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  \"enabled_services\": {{ enabled_services | unique | to_nice_json }},"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"7faddb67_7064b922","line":3,"updated":"2019-07-15 22:01:38.000000000","message":"this data will need to be passed into separate stacks as part of the split-controlplane work, so we just want to make sure that anything added here doesn\u0027t break that work.\n\nfor example, we may need the clouddomain to be different between the two stacks, and adding the value here would break that.","commit_id":"51e580073733e0ce51b955fae55e19b155fc6e26"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"6b407f62167138003a3230dfc81897db3b770c61","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  \"tripleo::clouddomain\": \"{{cloud_domain}}\","},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  \"enabled_services\": {{ enabled_services | unique | to_nice_json }},"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"7faddb67_a1c890a5","line":3,"in_reply_to":"7faddb67_6b77eaa1","updated":"2019-07-16 22:20:46.000000000","message":"it would only be the case for other variables in this file that you added that were previously *not* in the all_nodes data.\n\nNot every global variable needs (or can be) shared between stacks when doing multi-stack/split-controlplane.\n\nIt\u0027s not just a case of combining the files, we have to understand how the data is used. In this case, all_nodes is meant to be shared when doing multi-stack.","commit_id":"51e580073733e0ce51b955fae55e19b155fc6e26"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"1cf77b8242e0839ee8bb69f1dfc64b42d4b44af2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  \"tripleo::clouddomain\": \"{{cloud_domain}}\","},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  \"enabled_services\": {{ enabled_services | unique | to_nice_json }},"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"7faddb67_6b77eaa1","line":3,"in_reply_to":"7faddb67_7064b922","updated":"2019-07-15 22:15:47.000000000","message":"wouldn\u0027t it be the case for other variables in this file then? I see a bunch of variables which can be different between the two stacks. I start to wonder how to handle it and if my patch is actually relevant then.","commit_id":"51e580073733e0ce51b955fae55e19b155fc6e26"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"18e0864012ee02201ad39fb7c50d0050bb7994f0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  \"tripleo::clouddomain\": \"{{cloud_domain}}\","},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  \"enabled_services\": {{ enabled_services | unique | to_nice_json }},"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"7faddb67_a8fcecb4","line":3,"in_reply_to":"7faddb67_a1c890a5","updated":"2019-07-17 12:01:26.000000000","message":"\u003e it would only be the case for other variables in this file that you\n \u003e added that were previously *not* in the all_nodes data.\n \u003e \n\n\nI agree, if global_vars has precedence over the all_nodes it breaks\ne.g. multi cell deployment. I tried this patch in a cell deployment\nand on the nodes we won\u0027t get the \u003cservice\u003e_cell_node_names created\nfrom [1] . \nWhats the intend to have the duplicate information in all_nodes and \nglobal_vars? \n\n[1] https://review.opendev.org/#/c/670486/\n\n \u003e Not every global variable needs (or can be) shared between stacks\n \u003e when doing multi-stack/split-controlplane.\n \u003e \n \u003e It\u0027s not just a case of combining the files, we have to understand\n \u003e how the data is used. In this case, all_nodes is meant to be shared\n \u003e when doing multi-stack.","commit_id":"51e580073733e0ce51b955fae55e19b155fc6e26"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"0e41a8a90836fb00780da5fd00d275c3cec2284f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  \"tripleo::clouddomain\": \"{{cloud_domain}}\","},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  \"enabled_services\": {{ enabled_services | unique | to_nice_json }},"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"7faddb67_6837d400","line":3,"in_reply_to":"7faddb67_a8fcecb4","updated":"2019-07-17 12:43:37.000000000","message":"To answer Martin\u0027s question: it was for backward compatibility until https://review.opendev.org/669917 is landed.\nI need to rework this file based on James\u0027s comment.","commit_id":"51e580073733e0ce51b955fae55e19b155fc6e26"}],"roles/tripleo-hieradata/templates/host_vars.j2":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"e512c15403ddf38947e5c726bed790bbbe4ac4aa","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  {# todo: try removing them #}"},{"line_number":22,"context_line":"  \"{{ networks[network][\u0027name\u0027] }}\": \"\","},{"line_number":23,"context_line":"  \"{{ networks[network][\u0027name\u0027] }}_subnet\": \"\","},{"line_number":24,"context_line":"  \"{{ networks[network][\u0027name\u0027] }}_uri\": \"\","},{"line_number":25,"context_line":"  {%- endif %}"},{"line_number":26,"context_line":"{%- endfor %}"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"7faddb67_1002253e","line":24,"updated":"2019-07-15 21:58:21.000000000","message":"looks like you dropped the loop.last logic from net_ip_map.j2 to not add the comma if it\u0027s the last loop iteration.\n\nwas that intentional?","commit_id":"51e580073733e0ce51b955fae55e19b155fc6e26"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"0852ed03b87280d4ea189405de590bd455f8b07f","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  {# todo: try removing them #}"},{"line_number":22,"context_line":"  \"{{ networks[network][\u0027name\u0027] }}\": \"\","},{"line_number":23,"context_line":"  \"{{ networks[network][\u0027name\u0027] }}_subnet\": \"\","},{"line_number":24,"context_line":"  \"{{ networks[network][\u0027name\u0027] }}_uri\": \"\""},{"line_number":25,"context_line":"  {%- endif %}"},{"line_number":26,"context_line":"{%- endfor %}"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"7faddb67_f060a903","line":24,"updated":"2019-07-15 22:03:23.000000000","message":"you can\u0027t just drop the comma, it\u0027s still needed on every loop iteration except the last one","commit_id":"8bbf96658baf57b0691e4d1390b09a36b5e81d20"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c9ad376cddd41c1105247cc0a04f7779ecfeb13a","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  {# todo: try removing them #}"},{"line_number":22,"context_line":"  \"{{ networks[network][\u0027name\u0027] }}\": \"\","},{"line_number":23,"context_line":"  \"{{ networks[network][\u0027name\u0027] }}_subnet\": \"\","},{"line_number":24,"context_line":"  \"{{ networks[network][\u0027name\u0027] }}_uri\": \"\""},{"line_number":25,"context_line":"  {%- endif %}"},{"line_number":26,"context_line":"{%- endfor %}"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"7faddb67_6b612aa9","line":24,"in_reply_to":"7faddb67_f060a903","updated":"2019-07-15 22:30:01.000000000","message":"Done","commit_id":"8bbf96658baf57b0691e4d1390b09a36b5e81d20"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c9ad376cddd41c1105247cc0a04f7779ecfeb13a","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  {# todo: try removing them #}"},{"line_number":22,"context_line":"  \"{{ networks[network][\u0027name\u0027] }}\": \"\","},{"line_number":23,"context_line":"  \"{{ networks[network][\u0027name\u0027] }}_subnet\": \"\","},{"line_number":24,"context_line":"  \"{{ networks[network][\u0027name\u0027] }}_uri\": \"\""},{"line_number":25,"context_line":"  {%- endif %}"},{"line_number":26,"context_line":"{%- endfor %}"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"7faddb67_eb743a6a","line":24,"in_reply_to":"7faddb67_f060a903","updated":"2019-07-15 22:30:01.000000000","message":"Done","commit_id":"8bbf96658baf57b0691e4d1390b09a36b5e81d20"}]}