)]}'
{"tripleo_common/actions/baremetal_deploy.py":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"8829297d1780da36beaf8dd3e421c1fe42d15372","unresolved":false,"context_lines":[{"line_number":387,"context_line":"            # ensure each instance has a unique non-empty hostname"},{"line_number":388,"context_line":"            for inst in role_instances:"},{"line_number":389,"context_line":"                gen_name \u003d None"},{"line_number":390,"context_line":"                print(\u0027hostname_map %s\u0027 % hostname_map)"},{"line_number":391,"context_line":"                while not gen_name or gen_name in hostname_map:"},{"line_number":392,"context_line":"                    gen_name \u003d _build_hostname("},{"line_number":393,"context_line":"                        hostname_format, index, self.stackname)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_8b9b4616","line":390,"updated":"2019-07-15 23:33:22.000000000","message":"NO!","commit_id":"a4cc905019d651c80b2b0dc0a3e0f62b9ea6b7cf"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"052bbedf2c5c12c11069ecb113376e9ad3215df7","unresolved":false,"context_lines":[{"line_number":392,"context_line":"            parameter_defaults[\u0027%sDeployedServerCount\u0027 % name] \u003d ("},{"line_number":393,"context_line":"                len(role_instances))"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"            index \u003d 0"},{"line_number":396,"context_line":"            # ensure each instance has a unique non-empty hostname"},{"line_number":397,"context_line":"            for inst in role_instances:"},{"line_number":398,"context_line":"                gen_name \u003d None"},{"line_number":399,"context_line":"                while not gen_name or gen_name in hostname_map:"},{"line_number":400,"context_line":"                    gen_name \u003d _build_hostname("}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_fbc26234","line":397,"range":{"start_line":395,"start_character":0,"end_line":397,"end_character":39},"updated":"2019-08-08 08:46:32.000000000","message":"This will fill the gaps, e.g. if we have compute-0 and compute-2, it will create compute-1. I\u0027m not sure it\u0027s a great idea, to be honest. I wonder if we should have generated instances start with compute-3 and leave the gap intact.","commit_id":"955e6a3f3128b7a04576d7e18e3d2bd4ca8881ac"}]}