)]}'
{"container-images/tripleo_kolla_template_overrides.j2":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"313fdc8074a946feac85f35be5a4094c27691f99","unresolved":false,"context_lines":[{"line_number":239,"context_line":"{% set nova_libvirt_packages_append \u003d ["},{"line_number":240,"context_line":"    \u0027openstack-nova-migration\u0027,"},{"line_number":241,"context_line":"    \u0027openssl-perl\u0027,"},{"line_number":242,"context_line":"    \u0027docker\u0027,"},{"line_number":243,"context_line":"    \u0027podman\u0027,"},{"line_number":244,"context_line":"    \u0027seccomp\u0027"},{"line_number":245,"context_line":"] %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"7faddb67_09631b1c","line":242,"updated":"2019-07-29 15:13:39.000000000","message":"I think we\u0027d only need docker in the list here for the Rocky and Queens backports of it?","commit_id":"cbfc2e164aff8aa1555719438b67706171fdc98a"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"3ad46c2c9e293a95da5a02c8b77c622ea43dab9c","unresolved":false,"context_lines":[{"line_number":239,"context_line":"{% set nova_libvirt_packages_append \u003d ["},{"line_number":240,"context_line":"    \u0027openstack-nova-migration\u0027,"},{"line_number":241,"context_line":"    \u0027openssl-perl\u0027,"},{"line_number":242,"context_line":"    \u0027docker\u0027,"},{"line_number":243,"context_line":"    \u0027podman\u0027,"},{"line_number":244,"context_line":"    \u0027seccomp\u0027"},{"line_number":245,"context_line":"] %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"7faddb67_895f0b40","line":242,"in_reply_to":"7faddb67_09631b1c","updated":"2019-07-29 15:15:44.000000000","message":"\u003e I think we\u0027d only need docker in the list here for the Rocky and\n \u003e Queens backports of it?\n\nFor Rocky/Queens yes, but for Stein we\u0027d need podman.","commit_id":"cbfc2e164aff8aa1555719438b67706171fdc98a"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"9cd25d8a1158d84b4661001e43bbc01b48824ab8","unresolved":false,"context_lines":[{"line_number":238,"context_line":"{% set nova_libvirt_packages_append \u003d ["},{"line_number":239,"context_line":"    \u0027openstack-nova-migration\u0027,"},{"line_number":240,"context_line":"    \u0027openssl-perl\u0027,"},{"line_number":241,"context_line":"    \u0027docker\u0027,"},{"line_number":242,"context_line":"    \u0027podman\u0027,"},{"line_number":243,"context_line":"    \u0027seccomp\u0027"},{"line_number":244,"context_line":"] %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7faddb67_f90aed1d","line":241,"updated":"2019-07-31 09:43:33.000000000","message":"I guess it should be podman only","commit_id":"bed363197e00944aa039bd78478fba06a4920a69"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"67800470df8031154c9a0bd75c829fe23f18be97","unresolved":false,"context_lines":[{"line_number":238,"context_line":"{% set nova_libvirt_packages_append \u003d ["},{"line_number":239,"context_line":"    \u0027openstack-nova-migration\u0027,"},{"line_number":240,"context_line":"    \u0027openssl-perl\u0027,"},{"line_number":241,"context_line":"    \u0027docker\u0027,"},{"line_number":242,"context_line":"    \u0027podman\u0027,"},{"line_number":243,"context_line":"    \u0027seccomp\u0027"},{"line_number":244,"context_line":"] %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7faddb67_996ad9b0","line":241,"in_reply_to":"7faddb67_19290989","updated":"2019-07-31 09:53:32.000000000","message":"but there may be packaging problems, for example\ndocker rpm will not be supported, we should not add it here, only for the stable backports, where we do support it.","commit_id":"bed363197e00944aa039bd78478fba06a4920a69"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"0e2c32489defb48d4a559ff13f923f0e24fc1a79","unresolved":false,"context_lines":[{"line_number":238,"context_line":"{% set nova_libvirt_packages_append \u003d ["},{"line_number":239,"context_line":"    \u0027openstack-nova-migration\u0027,"},{"line_number":240,"context_line":"    \u0027openssl-perl\u0027,"},{"line_number":241,"context_line":"    \u0027docker\u0027,"},{"line_number":242,"context_line":"    \u0027podman\u0027,"},{"line_number":243,"context_line":"    \u0027seccomp\u0027"},{"line_number":244,"context_line":"] %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7faddb67_816a5b7e","line":241,"in_reply_to":"7faddb67_4b4ec46f","updated":"2019-07-31 13:53:39.000000000","message":"So I would fixup this so by default we include podman but if not python3, include docker\n\n{% if distro_python_version.startswith(\u00272\u0027) %}\n{% set nova_libvirt_packages_append \u003d nova_libvirt_packages_append + [\u0027docker\u0027] %}\n{% endif %}","commit_id":"bed363197e00944aa039bd78478fba06a4920a69"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"242c3652777edb6745da9e8d76f4ae62c27a33e0","unresolved":false,"context_lines":[{"line_number":238,"context_line":"{% set nova_libvirt_packages_append \u003d ["},{"line_number":239,"context_line":"    \u0027openstack-nova-migration\u0027,"},{"line_number":240,"context_line":"    \u0027openssl-perl\u0027,"},{"line_number":241,"context_line":"    \u0027docker\u0027,"},{"line_number":242,"context_line":"    \u0027podman\u0027,"},{"line_number":243,"context_line":"    \u0027seccomp\u0027"},{"line_number":244,"context_line":"] %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7faddb67_b9e4750e","line":241,"in_reply_to":"7faddb67_996ad9b0","updated":"2019-07-31 10:19:17.000000000","message":"Just as a reference, we have the same config for the neutron containers:\n\nhttps://github.com/openstack/tripleo-common/blob/master/container-images/tripleo_kolla_template_overrides.j2#L146-L150","commit_id":"bed363197e00944aa039bd78478fba06a4920a69"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"f29bed22662cee62073fdcfc72724f549f06630c","unresolved":false,"context_lines":[{"line_number":238,"context_line":"{% set nova_libvirt_packages_append \u003d ["},{"line_number":239,"context_line":"    \u0027openstack-nova-migration\u0027,"},{"line_number":240,"context_line":"    \u0027openssl-perl\u0027,"},{"line_number":241,"context_line":"    \u0027docker\u0027,"},{"line_number":242,"context_line":"    \u0027podman\u0027,"},{"line_number":243,"context_line":"    \u0027seccomp\u0027"},{"line_number":244,"context_line":"] %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7faddb67_cb13945b","line":241,"in_reply_to":"7faddb67_b9e4750e","updated":"2019-07-31 11:01:38.000000000","message":"It doesn\u0027t mean that neutron code is correct.","commit_id":"bed363197e00944aa039bd78478fba06a4920a69"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"22049d1f6874a2260b73c655d8838fd72f0550fc","unresolved":false,"context_lines":[{"line_number":238,"context_line":"{% set nova_libvirt_packages_append \u003d ["},{"line_number":239,"context_line":"    \u0027openstack-nova-migration\u0027,"},{"line_number":240,"context_line":"    \u0027openssl-perl\u0027,"},{"line_number":241,"context_line":"    \u0027docker\u0027,"},{"line_number":242,"context_line":"    \u0027podman\u0027,"},{"line_number":243,"context_line":"    \u0027seccomp\u0027"},{"line_number":244,"context_line":"] %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7faddb67_4b4ec46f","line":241,"in_reply_to":"7faddb67_cb13945b","updated":"2019-07-31 11:06:10.000000000","message":"Thats not what I wanted to say. I just wanted to point that\nif we need to think about a packaging problem, that we have\nit in multiple places/containers.","commit_id":"bed363197e00944aa039bd78478fba06a4920a69"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"50ca864f6b98ace6533a15e9ea4eb432c9c804c1","unresolved":false,"context_lines":[{"line_number":238,"context_line":"{% set nova_libvirt_packages_append \u003d ["},{"line_number":239,"context_line":"    \u0027openstack-nova-migration\u0027,"},{"line_number":240,"context_line":"    \u0027openssl-perl\u0027,"},{"line_number":241,"context_line":"    \u0027docker\u0027,"},{"line_number":242,"context_line":"    \u0027podman\u0027,"},{"line_number":243,"context_line":"    \u0027seccomp\u0027"},{"line_number":244,"context_line":"] %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7faddb67_19290989","line":241,"in_reply_to":"7faddb67_f90aed1d","updated":"2019-07-31 09:45:36.000000000","message":"as long as we don\u0027t have podman in the overcloud upstream\nI\u0027d say we still need docker as the fallback.","commit_id":"bed363197e00944aa039bd78478fba06a4920a69"}]}