)]}'
{"roles/tripleo-hieradata/tasks/main.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"13694149d2675f661237ed422eff7ae88c4c5c9b","unresolved":false,"context_lines":[{"line_number":43,"context_line":"#   foo: bar3"},{"line_number":44,"context_line":"- name: Copy hieradata files for all hosts"},{"line_number":45,"context_line":"  when: hieradata_template !\u003d \"\" and not hieradata_per_host|bool"},{"line_number":46,"context_line":"  ignore_errors: yes"},{"line_number":47,"context_line":"  include: all_hosts.yaml"},{"line_number":48,"context_line":"  vars:"},{"line_number":49,"context_line":"    hieradata_content: \"{{ lookup(\u0027file\u0027, hieradata_template ~ \u0027.rendered\u0027) | from_yaml }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_02c069e0","line":46,"updated":"2019-08-05 15:37:08.000000000","message":"why ignore errors?","commit_id":"9a25d23d096c85136f109b8bafd6043ae0052350"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"2dd456c73a4113594c2ceb267b3ce99251b98664","unresolved":false,"context_lines":[{"line_number":43,"context_line":"#   foo: bar3"},{"line_number":44,"context_line":"- name: Copy hieradata files for all hosts"},{"line_number":45,"context_line":"  when: hieradata_template !\u003d \"\" and not hieradata_per_host|bool"},{"line_number":46,"context_line":"  ignore_errors: yes"},{"line_number":47,"context_line":"  include: all_hosts.yaml"},{"line_number":48,"context_line":"  vars:"},{"line_number":49,"context_line":"    hieradata_content: \"{{ lookup(\u0027file\u0027, hieradata_template ~ \u0027.rendered\u0027) | from_yaml }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_427e61af","line":46,"in_reply_to":"7faddb67_02c069e0","updated":"2019-08-05 15:44:20.000000000","message":"It seems \u0027vars\u0027 are evaluated before \u0027when\u0027 conditions to skip the task and the file lookup fails. We probably would remove these tasks in subsequent patch.","commit_id":"9a25d23d096c85136f109b8bafd6043ae0052350"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"6fd6fb850073d6d9b890f62381db31979d9ab00e","unresolved":false,"context_lines":[{"line_number":43,"context_line":"#   foo: bar3"},{"line_number":44,"context_line":"- name: Copy hieradata files for all hosts"},{"line_number":45,"context_line":"  when: hieradata_template !\u003d \"\" and not hieradata_per_host|bool"},{"line_number":46,"context_line":"  ignore_errors: yes"},{"line_number":47,"context_line":"  include: all_hosts.yaml"},{"line_number":48,"context_line":"  vars:"},{"line_number":49,"context_line":"    hieradata_content: \"{{ lookup(\u0027file\u0027, hieradata_template ~ \u0027.rendered\u0027) | from_yaml }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_d1777a9f","line":46,"in_reply_to":"7faddb67_427e61af","updated":"2019-08-05 23:35:05.000000000","message":"If we\u0027re going to ignore errors, I think we need to split this apart so the fact setting ignores the error but the include doesn\u0027t get ignored","commit_id":"9a25d23d096c85136f109b8bafd6043ae0052350"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"b96b915e61547c1d00c6cbedfb2a2aea08e87837","unresolved":false,"context_lines":[{"line_number":43,"context_line":"#   foo: bar3"},{"line_number":44,"context_line":"- name: Copy hieradata files for all hosts"},{"line_number":45,"context_line":"  when: hieradata_template !\u003d \"\" and not hieradata_per_host|bool"},{"line_number":46,"context_line":"  ignore_errors: yes"},{"line_number":47,"context_line":"  include: all_hosts.yaml"},{"line_number":48,"context_line":"  vars:"},{"line_number":49,"context_line":"    hieradata_content: \"{{ lookup(\u0027file\u0027, hieradata_template ~ \u0027.rendered\u0027) | from_yaml }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_5d24f80c","line":46,"in_reply_to":"7faddb67_d1777a9f","updated":"2019-08-06 10:47:52.000000000","message":"This is a temporary change for https://review.opendev.org/#/c/673731/ to pass. I plan to remove the tasks in https://review.opendev.org/674722 as they are not required anymore. Can\u0027t do that before the tht patch.","commit_id":"9a25d23d096c85136f109b8bafd6043ae0052350"}],"roles/tripleo-hieradata/templates/extraconfig.j2":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"c6a56458bd96546351a7d8cab86dd007e6759e5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7faddb67_5d43a63f","updated":"2019-08-05 15:51:04.000000000","message":"This file is actually already created when the extraconfig key is present. Is the intention just to make it pretty json?","commit_id":"9a25d23d096c85136f109b8bafd6043ae0052350"}]}