)]}'
{"id":"openstack%2Ftripleo-common~674055","triplet_id":"openstack%2Ftripleo-common~master~I169b07553b171fcacb532bf58acc4200e270bfbb","project":"openstack/tripleo-common","branch":"master","topic":"swift-proxy-healthcheck","hashtags":[],"change_id":"I169b07553b171fcacb532bf58acc4200e270bfbb","subject":"Fix swift-proxy healthcheck","status":"MERGED","created":"2019-08-01 14:43:33.000000000","updated":"2019-08-02 22:09:28.000000000","submitted":"2019-08-02 16:49:18.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"674055-1564764559277-04ad8034","meta_rev_id":"2b6ec6544de2982202f8ec2ebb38a76f05ea5db0","_number":674055,"virtual_id_number":674055,"owner":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"value":2,"date":"2019-08-02 16:49:18.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-08-01 18:20:08.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"recommended":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"all":[{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":1,"date":"2019-08-01 16:58:13.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},{"value":2,"date":"2019-08-02 13:24:29.000000000","_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":2,"date":"2019-08-02 07:04:44.000000000","_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"all":[{"value":0,"date":"2019-08-02 06:48:48.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},{"value":1,"date":"2019-08-02 13:24:29.000000000","_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-01 16:58:13.000000000","updated_by":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"reviewer":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"state":"REVIEWER"},{"updated":"2019-08-01 18:20:08.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-08-02 06:48:48.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2019-08-02 07:04:44.000000000","updated_by":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"reviewer":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"state":"REVIEWER"},{"updated":"2019-08-02 13:24:29.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2019-08-02 16:49:18.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"f846119d373f59c1cc5efd848019d6c4239d44e9","author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"date":"2019-08-01 14:43:33.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d6aa6dd8456facc4de85c768f721db5846bea423","author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"date":"2019-08-01 16:58:13.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"4f9818bf04cc013539470d9f41a1a15f0ec1eee3","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-08-01 18:20:08.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001 http://logs.rdoproject.org/55/674055/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001/572678e/ : SUCCESS in 3h 34m 54s\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset035 http://logs.rdoproject.org/55/674055/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset035/26d3136/ : SUCCESS in 2h 44m 23s","accounts_in_message":[],"_revision_number":1},{"id":"38fc0ee2769bce667646aa85def9154d9c4f0dae","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-02 01:39:07.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://logs.opendev.org/55/674055/1/check/openstack-tox-cover/dd40f90/cover/ : SUCCESS in 4m 19s\n- openstack-tox-pep8 https://logs.opendev.org/55/674055/1/check/openstack-tox-pep8/aa9ce22/ : SUCCESS in 4m 15s\n- openstack-tox-py27 https://logs.opendev.org/55/674055/1/check/openstack-tox-py27/ad434f2/ : SUCCESS in 4m 39s\n- openstack-tox-py36 https://logs.opendev.org/55/674055/1/check/openstack-tox-py36/b8267ae/ : SUCCESS in 3m 32s\n- openstack-tox-py37 https://logs.opendev.org/55/674055/1/check/openstack-tox-py37/9867e14/ : SUCCESS in 4m 26s\n- openstack-tox-docs https://logs.opendev.org/55/674055/1/check/openstack-tox-docs/d44f78d/html/ : SUCCESS in 4m 36s\n- tripleo-ci-centos-7-containers-multinode https://logs.opendev.org/55/674055/1/check/tripleo-ci-centos-7-containers-multinode/207232c/ : SUCCESS in 2h 25m 46s\n- tripleo-ci-centos-7-undercloud-containers https://logs.opendev.org/55/674055/1/check/tripleo-ci-centos-7-undercloud-containers/f3686c2/ : SUCCESS in 1h 49m 02s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades https://logs.opendev.org/55/674055/1/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades/34fbb35/ : SUCCESS in 2h 32m 36s (non-voting)\n- tripleo-ci-centos-7-standalone https://logs.opendev.org/55/674055/1/check/tripleo-ci-centos-7-standalone/4b742de/ : SUCCESS in 1h 46m 39s\n- tripleo-ci-fedora-28-standalone https://logs.opendev.org/55/674055/1/check/tripleo-ci-fedora-28-standalone/c8ed674/ : FAILURE in 1h 00m 34s (non-voting)\n- tripleo-ci-centos-7-standalone-upgrade https://logs.opendev.org/55/674055/1/check/tripleo-ci-centos-7-standalone-upgrade/bd6e77a/ : FAILURE in 3h 05m 08s (non-voting)\n- tripleo-ci-centos-7-containerized-undercloud-upgrades https://logs.opendev.org/55/674055/1/check/tripleo-ci-centos-7-containerized-undercloud-upgrades/c4aac1b/ : TIMED_OUT in 3h 13m 14s (non-voting)\n- openstack-tox-linters https://logs.opendev.org/55/674055/1/check/openstack-tox-linters/3b126fd/ : SUCCESS in 4m 03s\n- openstack-tox-py35 https://logs.opendev.org/55/674055/1/check/openstack-tox-py35/eb706f1/ : SUCCESS in 6m 30s\n- openstack-tox-lower-constraints https://logs.opendev.org/55/674055/1/check/openstack-tox-lower-constraints/501933c/ : SUCCESS in 7m 45s","accounts_in_message":[],"_revision_number":1},{"id":"baad822fdcb7d06b0b5b3a099d7da591504d7227","author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"date":"2019-08-02 07:04:44.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"1e5f85d22bccf1dc0e01d9341a34c0625b900f3a","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-08-02 13:24:29.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"a11bfd62512a03ccdf78f0a29f6bb3b537261c55","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-02 13:24:48.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"0271a04589e342779cf1db71eabbc4ed7f207292","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-02 16:49:18.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://logs.opendev.org/55/674055/1/gate/openstack-tox-pep8/1c19988/ : SUCCESS in 3m 55s\n- openstack-tox-py27 https://logs.opendev.org/55/674055/1/gate/openstack-tox-py27/f9a4c15/ : SUCCESS in 4m 16s\n- openstack-tox-py36 https://logs.opendev.org/55/674055/1/gate/openstack-tox-py36/802d698/ : SUCCESS in 3m 37s\n- openstack-tox-py37 https://logs.opendev.org/55/674055/1/gate/openstack-tox-py37/ab7698e/ : SUCCESS in 3m 32s\n- openstack-tox-docs https://logs.opendev.org/55/674055/1/gate/openstack-tox-docs/80a0570/html/ : SUCCESS in 3m 19s\n- tripleo-ci-centos-7-containers-multinode https://logs.opendev.org/55/674055/1/gate/tripleo-ci-centos-7-containers-multinode/6839848/ : SUCCESS in 2h 50m 48s\n- tripleo-ci-centos-7-standalone https://logs.opendev.org/55/674055/1/gate/tripleo-ci-centos-7-standalone/c1b18cd/ : SUCCESS in 1h 55m 18s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates https://logs.opendev.org/55/674055/1/gate/tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates/10c00d5/ : SUCCESS in 2h 26m 53s\n- tripleo-ci-centos-7-undercloud-containers https://logs.opendev.org/55/674055/1/gate/tripleo-ci-centos-7-undercloud-containers/255398b/ : SUCCESS in 1h 40m 04s\n- openstack-tox-linters https://logs.opendev.org/55/674055/1/gate/openstack-tox-linters/c233f85/ : SUCCESS in 4m 41s\n- openstack-tox-lower-constraints https://logs.opendev.org/55/674055/1/gate/openstack-tox-lower-constraints/936ec3a/ : SUCCESS in 6m 31s","accounts_in_message":[],"_revision_number":1},{"id":"c78b6bc232ee221d8a09728d3dfb7cca74855897","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-02 16:49:19.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"a6c5fdeb8429c7b4e138b0f9ccd6981e52819568","author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"date":"2019-08-02 22:09:28.000000000","message":"Patch Set 1: Cherry Picked\n\nThis patchset was cherry picked to branch stable/stein as commit e2c5deba1d1fce3c9001364f51aa09565223aee3","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"3ddb77e34096a095909ea4dc5a18d478eeb93cab","revisions":{"3ddb77e34096a095909ea4dc5a18d478eeb93cab":{"kind":"REWORK","_number":1,"created":"2019-08-01 14:43:33.000000000","uploader":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"ref":"refs/changes/55/674055/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tripleo-common","ref":"refs/changes/55/674055/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tripleo-common refs/changes/55/674055/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tripleo-common refs/changes/55/674055/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tripleo-common refs/changes/55/674055/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tripleo-common refs/changes/55/674055/1"}}},"commit":{"parents":[{"commit":"3784506054df93a097a8970ee5472f53a4e531aa","subject":"Merge \"Properly close web request\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-common/commit/3784506054df93a097a8970ee5472f53a4e531aa"}]}],"author":{"name":"Martin Schuppert","email":"mschuppert@redhat.com","date":"2019-08-01 14:41:40.000000000","tz":120},"committer":{"name":"Martin Schuppert","email":"mschuppert@redhat.com","date":"2019-08-01 14:41:40.000000000","tz":120},"subject":"Fix swift-proxy healthcheck","message":"Fix swift-proxy healthcheck\n\nWith the current swift-proxy healthcheck the container status is\nunhealty even the service is up.\n\nThe used ps/grep won\u0027t return the swift proxy processes as the\noutput gets truncated:\n\n()[root@overcloud-controller-0 /]$ ps -e\n    PID TTY          TIME CMD\n      1 ?        00:00:00 dumb-init\n      6 ?        00:02:52 swift-proxy-ser\n     28 ?        00:00:25 swift-proxy-ser\n   4753 pts/1    00:00:00 sh\n   4797 pts/1    00:00:00 ps\n\nAs a result we end up in the else, checking the cache.\n\nThis moves the if to use pgrep instead.\n\nChange-Id: I169b07553b171fcacb532bf58acc4200e270bfbb\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-common/commit/3ddb77e34096a095909ea4dc5a18d478eeb93cab"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-common/commit/3ddb77e34096a095909ea4dc5a18d478eeb93cab"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}