)]}'
{"tripleo_common/utils/config.py":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"748ec946bb77eb76c4a73a0a279f492a654aea24","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def get_deployment_data(self, stack,"},{"line_number":60,"context_line":"                            nested_depth\u003dconstants.NESTED_DEPTH):"},{"line_number":61,"context_line":"        deployments \u003d self.client.resources.list("},{"line_number":62,"context_line":"            stack,"},{"line_number":63,"context_line":"            nested_depth\u003dnested_depth,"},{"line_number":64,"context_line":"            filters\u003ddict(name\u003dconstants.TRIPLEO_DEPLOYMENT_RESOURCE),"},{"line_number":65,"context_line":"            with_detail\u003dTrue)"},{"line_number":66,"context_line":"        # Sort by creation time"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_c6834cca","side":"PARENT","line":63,"range":{"start_line":61,"start_character":22,"end_line":63,"end_character":38},"updated":"2019-08-05 08:56:23.000000000","message":"what about this place? looks pretty same to me, shall we change it as well?","commit_id":"e4cea93c4ce3193974338d161fb8b190c25da679"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"aefc4e990238f4a2c8146442fe80b47e967dd972","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def get_deployment_data(self, stack,"},{"line_number":60,"context_line":"                            nested_depth\u003dconstants.NESTED_DEPTH):"},{"line_number":61,"context_line":"        deployments \u003d self.client.resources.list("},{"line_number":62,"context_line":"            stack,"},{"line_number":63,"context_line":"            nested_depth\u003dnested_depth,"},{"line_number":64,"context_line":"            filters\u003ddict(name\u003dconstants.TRIPLEO_DEPLOYMENT_RESOURCE),"},{"line_number":65,"context_line":"            with_detail\u003dTrue)"},{"line_number":66,"context_line":"        # Sort by creation time"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_468bdcbe","side":"PARENT","line":63,"range":{"start_line":61,"start_character":22,"end_line":63,"end_character":38},"in_reply_to":"7faddb67_c6834cca","updated":"2019-08-05 09:01:15.000000000","message":"No it can\u0027t be changed here as we get all deployments for overcloud (root stack) with it.\n\nhttps://github.com/openstack/tripleo-common/blob/master/tripleo_common/utils/config.py#L284","commit_id":"e4cea93c4ce3193974338d161fb8b190c25da679"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"e7301b056337c9ea32420ab92771ee0c36651207","unresolved":false,"context_lines":[{"line_number":356,"context_line":"                parent_stack \u003d deployment_stack.parent"},{"line_number":357,"context_line":"                resources \u003d self.client.resources.list("},{"line_number":358,"context_line":"                    name,"},{"line_number":359,"context_line":"                    nested_depth\u003dconstants.NESTED_DEPTH,"},{"line_number":360,"context_line":"                    filters\u003ddict(physical_resource_id\u003dparent_stack))"},{"line_number":361,"context_line":"                if not resources:"},{"line_number":362,"context_line":"                    message \u003d \"The deployment resource grandparent name\" \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_c60eec8a","side":"PARENT","line":359,"updated":"2019-08-05 08:55:39.000000000","message":"I think this change makes the NESTED_DEPTH constant redundant?\nCan we just remove it?\nSee http://codesearch.openstack.org/?q\u003dNESTED_DEPTH\u0026i\u003dnope\u0026files\u003d\u0026repos\u003d","commit_id":"e4cea93c4ce3193974338d161fb8b190c25da679"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"aefc4e990238f4a2c8146442fe80b47e967dd972","unresolved":false,"context_lines":[{"line_number":356,"context_line":"                parent_stack \u003d deployment_stack.parent"},{"line_number":357,"context_line":"                resources \u003d self.client.resources.list("},{"line_number":358,"context_line":"                    name,"},{"line_number":359,"context_line":"                    nested_depth\u003dconstants.NESTED_DEPTH,"},{"line_number":360,"context_line":"                    filters\u003ddict(physical_resource_id\u003dparent_stack))"},{"line_number":361,"context_line":"                if not resources:"},{"line_number":362,"context_line":"                    message \u003d \"The deployment resource grandparent name\" \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_066884f2","side":"PARENT","line":359,"in_reply_to":"7faddb67_c60eec8a","updated":"2019-08-05 09:01:15.000000000","message":"No, as it\u0027s used in L60","commit_id":"e4cea93c4ce3193974338d161fb8b190c25da679"}]}