)]}'
{"tripleo_common/image/builder/buildah.py":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"e78d52f851f95410a77dd8ddaae852426ed5c6c9","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                done, not_done \u003d futures.wait("},{"line_number":175,"context_line":"                    future_to_build,"},{"line_number":176,"context_line":"                    timeout\u003dself.build_timeout,"},{"line_number":177,"context_line":"                    # keep ALL_COMPLETED here to avoid checking incomplete runs"},{"line_number":178,"context_line":"                    return_when\u003dfutures.ALL_COMPLETED"},{"line_number":179,"context_line":"                )"},{"line_number":180,"context_line":"            # NOTE(cloudnull): Once the job has been completed all completed"},{"line_number":181,"context_line":"            #                  jobs are checked for exceptions. If any jobs"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_3a48be2c","line":178,"range":{"start_line":177,"start_character":0,"end_line":178,"end_character":53},"updated":"2019-08-27 14:54:47.000000000","message":"I think we want to keep FIRST_EXCEPTION here. Without this we\u0027d allow all jobs to run even when there\u0027s a thread failure.\n\nFrom the docs - https://docs.python.org/3/library/concurrent.futures.html\n\n  FIRST_EXCEPTION\n\n    The function will return when any future finishes by \n    raising an exception. If no future raises an exception \n    then it is equivalent to ALL_COMPLETED.\n\nI think going back to will return us to a state where container builds fail silently.","commit_id":"00d3daead85c9e4feb756d2ab466506ed5e915a1"}]}