)]}'
{"tripleo_common/actions/ansible.py":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"cdd1f18a7e9da7406ebfaa8bae67ba46a3197286","unresolved":false,"context_lines":[{"line_number":640,"context_line":"                *command, cwd\u003dself.work_dir,"},{"line_number":641,"context_line":"                env_variables\u003denv_variables,"},{"line_number":642,"context_line":"                log_errors\u003dprocessutils.LogErrors.ALL)"},{"line_number":643,"context_line":"            if self.trash_output:"},{"line_number":644,"context_line":"                stdout \u003d \"\""},{"line_number":645,"context_line":"                stderr \u003d \"\""},{"line_number":646,"context_line":"            return {\"stderr\": stderr, \"stdout\": stdout,"},{"line_number":647,"context_line":"                    \"log_path\": os.path.join(self.work_dir, \u0027ansible.log\u0027)}"},{"line_number":648,"context_line":"        finally:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_036f2f60","line":645,"range":{"start_line":643,"start_character":0,"end_line":645,"end_character":27},"updated":"2019-09-03 21:37:25.000000000","message":"Looks like this should solve the bug but we loose logging. What if you added something like this:\n\nif self.trash_output:\n    with open(os.path.join(self.work_dir, \u0027ansible.log\u0027)) as log:\n      log.write(stdout)\n      log.write(stderr)\n    stdout \u003d \"\"\n    stderr \u003d \"\"","commit_id":"c7d44bc2ca67c40098982c88e9625aacd25b780d"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"116e2d1b92f1b12e8087b12672508cdaa5571389","unresolved":false,"context_lines":[{"line_number":640,"context_line":"                *command, cwd\u003dself.work_dir,"},{"line_number":641,"context_line":"                env_variables\u003denv_variables,"},{"line_number":642,"context_line":"                log_errors\u003dprocessutils.LogErrors.ALL)"},{"line_number":643,"context_line":"            if self.trash_output:"},{"line_number":644,"context_line":"                stdout \u003d \"\""},{"line_number":645,"context_line":"                stderr \u003d \"\""},{"line_number":646,"context_line":"            return {\"stderr\": stderr, \"stdout\": stdout,"},{"line_number":647,"context_line":"                    \"log_path\": os.path.join(self.work_dir, \u0027ansible.log\u0027)}"},{"line_number":648,"context_line":"        finally:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_a3b65bdb","line":645,"range":{"start_line":643,"start_character":0,"end_line":645,"end_character":27},"in_reply_to":"7faddb67_036f2f60","updated":"2019-09-03 21:38:44.000000000","message":"If you prefer the added logging could be in a separate review.","commit_id":"c7d44bc2ca67c40098982c88e9625aacd25b780d"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"1faea642b51785d6055aee70f9fa9b407c355c0f","unresolved":false,"context_lines":[{"line_number":640,"context_line":"                *command, cwd\u003dself.work_dir,"},{"line_number":641,"context_line":"                env_variables\u003denv_variables,"},{"line_number":642,"context_line":"                log_errors\u003dprocessutils.LogErrors.ALL)"},{"line_number":643,"context_line":"            if self.trash_output:"},{"line_number":644,"context_line":"                stdout \u003d \"\""},{"line_number":645,"context_line":"                stderr \u003d \"\""},{"line_number":646,"context_line":"            return {\"stderr\": stderr, \"stdout\": stdout,"},{"line_number":647,"context_line":"                    \"log_path\": os.path.join(self.work_dir, \u0027ansible.log\u0027)}"},{"line_number":648,"context_line":"        finally:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_43ff6733","line":645,"range":{"start_line":643,"start_character":0,"end_line":645,"end_character":27},"in_reply_to":"7faddb67_a3b65bdb","updated":"2019-09-03 21:54:02.000000000","message":"Actually, I misunderstood. It\u0027s the ANSIBLE_LOG_PATH env file or ansible.cfg [default] ansible_log path param which results in the saving of the log. This shouldn\u0027t affect the ansible log run.","commit_id":"c7d44bc2ca67c40098982c88e9625aacd25b780d"}]}