)]}'
{"id":"openstack%2Ftripleo-common~679504","triplet_id":"openstack%2Ftripleo-common~master~I60dfcf001ec48f6f9a39e59131a502cf3e379a2b","project":"openstack/tripleo-common","branch":"master","topic":"valid","hashtags":[],"change_id":"I60dfcf001ec48f6f9a39e59131a502cf3e379a2b","subject":"config-download: validate that roles don\u0027t start with a digit","status":"ABANDONED","created":"2019-08-30 20:06:50.000000000","updated":"2019-08-30 21:06:41.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"232189a595907c4f1f795a5a0e30d9bc3103a11b","_number":679504,"virtual_id_number":679504,"owner":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"actions":{},"labels":{"Verified":{"all":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}]},"pending_reviewers":{},"reviewer_updates":[],"messages":[{"id":"9eebfe17c64823ac8256ea1569816f684926ccf6","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2019-08-30 20:06:50.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3b679f3e97ea8a20e119e3a7a9359316943ece1a","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2019-08-30 20:08:24.000000000","message":"Patch Set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"7f00176c81c7a7b27ceceb121c5a30405e4e2f24","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2019-08-30 20:20:39.000000000","message":"Patch Set 2: Workflow-1","accounts_in_message":[],"_revision_number":2},{"id":"d16d32a5a1ef4697b849eca973acac5832dfb420","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2019-08-30 20:22:03.000000000","message":"Patch Set 2:\n\nWIP now, maybe there is a solution to make it work with digit","accounts_in_message":[],"_revision_number":2},{"id":"cea18a4c992930f9e89e9a52c70c164e228dd482","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2019-08-30 20:41:39.000000000","message":"Patch Set 3: Published edit on patch set 2.","accounts_in_message":[],"_revision_number":3},{"id":"abf1834fabf30fbef7de25e202f808f66df012d1","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2019-08-30 21:06:41.000000000","message":"Abandoned\n\nhttps://review.opendev.org/#/c/679514/","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"81ee3e917294aa7fd852c30c2a4ec5e75637e14b","revisions":{"749a244c3edb3e188530d179841f29b334b583f6":{"kind":"REWORK","_number":1,"created":"2019-08-30 20:06:50.000000000","uploader":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"ref":"refs/changes/04/679504/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tripleo-common","ref":"refs/changes/04/679504/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tripleo-common refs/changes/04/679504/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tripleo-common refs/changes/04/679504/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tripleo-common refs/changes/04/679504/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tripleo-common refs/changes/04/679504/1"}}},"commit":{"parents":[{"commit":"f4c3c1bbbb9d3834a47ef937857dda1c31dfe45d","subject":"Merge \"OvS DPDK derive parameters timeout issue\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-common/commit/f4c3c1bbbb9d3834a47ef937857dda1c31dfe45d"}]}],"author":{"name":"Emilien Macchi","email":"emilien@redhat.com","date":"2019-08-30 19:46:20.000000000","tz":-240},"committer":{"name":"Emilien Macchi","email":"emilien@redhat.com","date":"2019-08-30 20:04:32.000000000","tz":-240},"subject":"config-download: validate that roles don\u0027t start with a digit","message":"config-download: validate that roles don\u0027t start with a digit\n\nAnsible seems to not being able to process template files which start\nwith a digit e.g. 1029uCompute:\n\n  FAILED! \u003d\u003e {\"msg\": \"template error while templating string:\n  expected token \u0027end of print statement\u0027, got \u0027uCompute_pre_deployments\u0027.\n  String: {{ 1029uCompute_pre_deployments|default([]) }}\"}\n\nThis patch validates the role name before generating the config, and if\nthe role starts with a digit, we raise and quit.\n\nChange-Id: I60dfcf001ec48f6f9a39e59131a502cf3e379a2b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-common/commit/749a244c3edb3e188530d179841f29b334b583f6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-common/commit/749a244c3edb3e188530d179841f29b334b583f6"}]},"branch":"refs/heads/master"},"5abc3ae669d2dc18cacfa657460adec1ab3a11db":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2019-08-30 20:08:24.000000000","uploader":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"ref":"refs/changes/04/679504/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tripleo-common","ref":"refs/changes/04/679504/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tripleo-common refs/changes/04/679504/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tripleo-common refs/changes/04/679504/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tripleo-common refs/changes/04/679504/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tripleo-common refs/changes/04/679504/2"}}},"commit":{"parents":[{"commit":"f4c3c1bbbb9d3834a47ef937857dda1c31dfe45d","subject":"Merge \"OvS DPDK derive parameters timeout issue\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-common/commit/f4c3c1bbbb9d3834a47ef937857dda1c31dfe45d"}]}],"author":{"name":"Emilien Macchi","email":"emilien@redhat.com","date":"2019-08-30 19:46:20.000000000","tz":-240},"committer":{"name":"Emilien Macchi","email":"emilien@redhat.com","date":"2019-08-30 20:08:23.000000000","tz":0},"subject":"config-download: validate that roles don\u0027t start with a digit","message":"config-download: validate that roles don\u0027t start with a digit\n\nAnsible seems to not being able to process template files which start\nwith a digit e.g. 1029uCompute:\n\n  FAILED! \u003d\u003e {\"msg\": \"template error while templating string:\n  expected token \u0027end of print statement\u0027, got \u0027uCompute_pre_deployments\u0027.\n  String: {{ 1029uCompute_pre_deployments|default([]) }}\"}\n\nThis patch validates the role name before generating the config, and if\nthe role starts with a digit, we raise and quit.\n\nCloses-Bug: #1842141\nChange-Id: I60dfcf001ec48f6f9a39e59131a502cf3e379a2b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-common/commit/5abc3ae669d2dc18cacfa657460adec1ab3a11db"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-common/commit/5abc3ae669d2dc18cacfa657460adec1ab3a11db"}]},"branch":"refs/heads/master"},"81ee3e917294aa7fd852c30c2a4ec5e75637e14b":{"kind":"REWORK","_number":3,"created":"2019-08-30 20:41:39.000000000","uploader":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"ref":"refs/changes/04/679504/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tripleo-common","ref":"refs/changes/04/679504/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tripleo-common refs/changes/04/679504/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tripleo-common refs/changes/04/679504/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tripleo-common refs/changes/04/679504/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tripleo-common refs/changes/04/679504/3"}}},"commit":{"parents":[{"commit":"f4c3c1bbbb9d3834a47ef937857dda1c31dfe45d","subject":"Merge \"OvS DPDK derive parameters timeout issue\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-common/commit/f4c3c1bbbb9d3834a47ef937857dda1c31dfe45d"}]}],"author":{"name":"Emilien Macchi","email":"emilien@redhat.com","date":"2019-08-30 19:46:20.000000000","tz":-240},"committer":{"name":"Emilien Macchi","email":"emilien@redhat.com","date":"2019-08-30 20:41:37.000000000","tz":0},"subject":"config-download: validate that roles don\u0027t start with a digit","message":"config-download: validate that roles don\u0027t start with a digit\n\nAnsible seems to not being able to process template files which start\nwith a digit e.g. 1029uCompute:\n\n  FAILED! \u003d\u003e {\"msg\": \"template error while templating string:\n  expected token \u0027end of print statement\u0027, got \u0027uCompute_pre_deployments\u0027.\n  String: {{ 1029uCompute_pre_deployments|default([]) }}\"}\n\nThis patch validates the role name before generating the config, and if\nthe role starts with a digit, we raise and quit.\n\nCloses-Bug: #1842141\nChange-Id: I60dfcf001ec48f6f9a39e59131a502cf3e379a2b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-common/commit/81ee3e917294aa7fd852c30c2a4ec5e75637e14b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-common/commit/81ee3e917294aa7fd852c30c2a4ec5e75637e14b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
