)]}'
{"tripleo_common/image/image_uploader.py":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"0a14209c34aa87ff79847193074f20885a00a74c","unresolved":false,"context_lines":[{"line_number":336,"context_line":"                \u0027Modifying image %s failed\u0027 % target_image)"},{"line_number":337,"context_line":"        else:"},{"line_number":338,"context_line":"            if log_path and os.path.isfile(log_path):"},{"line_number":339,"context_line":"                log_f \u003d \u0027/var/log/tripleo-container-image-prepare-ansible.log\u0027"},{"line_number":340,"context_line":"                with open(log_path) as f:"},{"line_number":341,"context_line":"                    with open(log_f, \u0027w+\u0027) as af:"},{"line_number":342,"context_line":"                        af.write(f.read())"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_81ba02be","line":339,"updated":"2019-09-30 17:16:08.000000000","message":"This probably won\u0027t work well because this is multi-threaded.","commit_id":"e2d6c64637697e79145ec6f3c8ff0c9a3e92dd4a"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"f9cedd2476627c17bd987b0eec755306c89ce44e","unresolved":false,"context_lines":[{"line_number":361,"context_line":"            raise ImageUploaderException("},{"line_number":362,"context_line":"                \u0027Modifying image %s failed\u0027 % target_image)"},{"line_number":363,"context_line":"        else:"},{"line_number":364,"context_line":"            log_f \u003d \u0027/var/log/tripleo-container-image-prepare-ansible.log\u0027"},{"line_number":365,"context_line":"            fallback_log_f \u003d \u0027/tmp/tripleo-container-image-prepare-ansible.log\u0027"},{"line_number":366,"context_line":"            if log_path and os.path.isfile(log_path):"},{"line_number":367,"context_line":"                with open(log_path) as f:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_35df810d","line":364,"range":{"start_line":364,"start_character":21,"end_line":364,"end_character":73},"updated":"2019-11-11 14:57:54.000000000","message":"We need to add this to the quickstart log collection.  Also given that the log file can be configurable, should we use the passed in log file name/location and add ansible somewhere in the name? Or should we always use this location. I\u0027m ok with this for now, but just wondering if there\u0027s other options we should investigate","commit_id":"6c3252fd0cae2fb4990fe520e55ebb86ca691bee"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"f3d1355478e392dff2b6277770bf70a5b3f09928","unresolved":false,"context_lines":[{"line_number":361,"context_line":"            raise ImageUploaderException("},{"line_number":362,"context_line":"                \u0027Modifying image %s failed\u0027 % target_image)"},{"line_number":363,"context_line":"        else:"},{"line_number":364,"context_line":"            log_f \u003d \u0027/var/log/tripleo-container-image-prepare-ansible.log\u0027"},{"line_number":365,"context_line":"            fallback_log_f \u003d \u0027/tmp/tripleo-container-image-prepare-ansible.log\u0027"},{"line_number":366,"context_line":"            if log_path and os.path.isfile(log_path):"},{"line_number":367,"context_line":"                with open(log_path) as f:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_a6268dca","line":364,"range":{"start_line":364,"start_character":21,"end_line":364,"end_character":73},"in_reply_to":"3fa7e38b_35df810d","updated":"2019-11-18 23:17:21.000000000","message":"I think I\u0027ll change this up so it adds a log file into whatever the basename is of the configured log file.","commit_id":"6c3252fd0cae2fb4990fe520e55ebb86ca691bee"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"8d3ea3a279419d07e5747700e0d7703dba4f25f9","unresolved":false,"context_lines":[{"line_number":354,"context_line":"            )"},{"line_number":355,"context_line":"            result \u003d action.run(None)"},{"line_number":356,"context_line":"            log_path \u003d result.get(\u0027log_path\u0027)"},{"line_number":357,"context_line":"            if log_path and os.path.isfile(log_path):"},{"line_number":358,"context_line":"                with open(log_path) as f:"},{"line_number":359,"context_line":"                    for line in f:"},{"line_number":360,"context_line":"                        LOG.info(line.rstrip())"},{"line_number":361,"context_line":"            shutil.rmtree(work_dir)"},{"line_number":362,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":363,"context_line":"            LOG.error(\u0027%s\\nError running playbook in directory: %s\u0027"},{"line_number":364,"context_line":"                      % (e.stdout, work_dir))"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_c1f7f3d3","side":"PARENT","line":361,"range":{"start_line":357,"start_character":0,"end_line":361,"end_character":35},"updated":"2019-11-19 00:10:38.000000000","message":"note, the restream process has all been removed. Ansible will now write the log file in the configured location once.","commit_id":"5f82d33d55c59c6eb4bdaadfd683d8d5bf673b93"}]}