)]}'
{"tripleo_common/utils/config.py":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f7cacbf59858d35dad81cd96bfa7d3596b099d81","unresolved":false,"context_lines":[{"line_number":507,"context_line":"            server_role \u003d server_roles.get(server)"},{"line_number":508,"context_line":"            server_role_vars \u003d role_host_vars.get(server_role, dict())"},{"line_number":509,"context_line":"            ansible_host_vars \u003d None"},{"line_number":510,"context_line":"            if role_host_vars and server_role:"},{"line_number":511,"context_line":"                servers_ansible_host_vars \u003d ["},{"line_number":512,"context_line":"                    v for k, v in server_role_vars.items()"},{"line_number":513,"context_line":"                    if k.startswith(server)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_f86ef9fc","line":510,"range":{"start_line":510,"start_character":15,"end_line":510,"end_character":29},"updated":"2019-11-26 13:54:48.000000000","message":"shouldn\u0027t this check if server_role_vars is not empty perhaps?","commit_id":"d8679da62e38d02cd0dca7248a2506793e954e18"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"311711cdd72157a7486017f4a630c69dd40c4a1b","unresolved":false,"context_lines":[{"line_number":507,"context_line":"            server_role \u003d server_roles.get(server)"},{"line_number":508,"context_line":"            server_role_vars \u003d role_host_vars.get(server_role, dict())"},{"line_number":509,"context_line":"            ansible_host_vars \u003d None"},{"line_number":510,"context_line":"            if role_host_vars and server_role:"},{"line_number":511,"context_line":"                servers_ansible_host_vars \u003d ["},{"line_number":512,"context_line":"                    v for k, v in server_role_vars.items()"},{"line_number":513,"context_line":"                    if k.startswith(server)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_7ee99117","line":510,"range":{"start_line":510,"start_character":15,"end_line":510,"end_character":29},"in_reply_to":"3fa7e38b_f86ef9fc","updated":"2019-11-26 14:57:09.000000000","message":"If it is empty the condition will not be met.\n\nIn this way","commit_id":"d8679da62e38d02cd0dca7248a2506793e954e18"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"311711cdd72157a7486017f4a630c69dd40c4a1b","unresolved":false,"context_lines":[{"line_number":507,"context_line":"            server_role \u003d server_roles.get(server)"},{"line_number":508,"context_line":"            server_role_vars \u003d role_host_vars.get(server_role, dict())"},{"line_number":509,"context_line":"            ansible_host_vars \u003d None"},{"line_number":510,"context_line":"            if role_host_vars and server_role:"},{"line_number":511,"context_line":"                servers_ansible_host_vars \u003d ["},{"line_number":512,"context_line":"                    v for k, v in server_role_vars.items()"},{"line_number":513,"context_line":"                    if k.startswith(server)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_7e60b1a5","line":510,"range":{"start_line":510,"start_character":15,"end_line":510,"end_character":29},"in_reply_to":"3fa7e38b_f86ef9fc","updated":"2019-11-26 14:57:09.000000000","message":"role_host_vars is defined on https://review.opendev.org/#/c/695998/2/tripleo_common/utils/config.py@228 as a dict or empty set, so if it is empty, the condition will not be met.\n\nexample - https://pasted.tech/pastes/47c9821dbc8c7f4db6c7b1fd82ee7bee5b1169a2","commit_id":"d8679da62e38d02cd0dca7248a2506793e954e18"}]}