)]}'
{"tripleo_common/image/image_uploader.py":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"8ae15c3350bfb94b50b1d41bb8c67e99c8b8317c","unresolved":false,"context_lines":[{"line_number":591,"context_line":"            return \u0027%sv2%s\u0027 % (mirror, path)"},{"line_number":592,"context_line":"        else:"},{"line_number":593,"context_line":"            if (cls.is_insecure_registry(registry_host\u003dnetloc) and"},{"line_number":594,"context_line":"                  netloc not in cls.no_verify_registries):"},{"line_number":595,"context_line":"                scheme \u003d \u0027http\u0027"},{"line_number":596,"context_line":"            else:"},{"line_number":597,"context_line":"                scheme \u003d \u0027https\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_65c38459","line":594,"updated":"2020-01-07 17:55:11.000000000","message":"I think this is the wrong place for this logic. the is_insecure_registry should have the logic for this","commit_id":"dcd0225267b170e27d57810da53b6127c60e13cd"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c24d4b14fe17024dd20dcc03ea432d07fa725203","unresolved":false,"context_lines":[{"line_number":591,"context_line":"            return \u0027%sv2%s\u0027 % (mirror, path)"},{"line_number":592,"context_line":"        else:"},{"line_number":593,"context_line":"            if (cls.is_insecure_registry(registry_host\u003dnetloc) and"},{"line_number":594,"context_line":"                  netloc not in cls.no_verify_registries):"},{"line_number":595,"context_line":"                scheme \u003d \u0027http\u0027"},{"line_number":596,"context_line":"            else:"},{"line_number":597,"context_line":"                scheme \u003d \u0027https\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_50eac40d","line":594,"in_reply_to":"3fa7e38b_0543b06c","updated":"2020-01-07 18:44:49.000000000","message":"So this got flipped at some point via https://review.opendev.org/#/c/674919/37\n\nI really don\u0027t like messing with these two things because there are so many random cases for this. I really do think something else is going on.","commit_id":"dcd0225267b170e27d57810da53b6127c60e13cd"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c2ca73031156be43b188702034fc00c0c418173f","unresolved":false,"context_lines":[{"line_number":591,"context_line":"            return \u0027%sv2%s\u0027 % (mirror, path)"},{"line_number":592,"context_line":"        else:"},{"line_number":593,"context_line":"            if (cls.is_insecure_registry(registry_host\u003dnetloc) and"},{"line_number":594,"context_line":"                  netloc not in cls.no_verify_registries):"},{"line_number":595,"context_line":"                scheme \u003d \u0027http\u0027"},{"line_number":596,"context_line":"            else:"},{"line_number":597,"context_line":"                scheme \u003d \u0027https\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_5d733450","line":594,"in_reply_to":"3fa7e38b_50eac40d","updated":"2020-01-16 16:42:35.000000000","message":"Ok so i\u0027ve been able to reproduce the original issue (missing CA for registry). This does fix it.","commit_id":"dcd0225267b170e27d57810da53b6127c60e13cd"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"42c409244db4c71773efda051353cdee5eaf6ec2","unresolved":false,"context_lines":[{"line_number":591,"context_line":"            return \u0027%sv2%s\u0027 % (mirror, path)"},{"line_number":592,"context_line":"        else:"},{"line_number":593,"context_line":"            if (cls.is_insecure_registry(registry_host\u003dnetloc) and"},{"line_number":594,"context_line":"                  netloc not in cls.no_verify_registries):"},{"line_number":595,"context_line":"                scheme \u003d \u0027http\u0027"},{"line_number":596,"context_line":"            else:"},{"line_number":597,"context_line":"                scheme \u003d \u0027https\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_0543b06c","line":594,"in_reply_to":"3fa7e38b_65bf04ab","updated":"2020-01-07 18:27:06.000000000","message":"the is_insecure_registry does that determination if it\u0027s http/https.","commit_id":"dcd0225267b170e27d57810da53b6127c60e13cd"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"2c2e24ba626e0a7701f07b3c9bc14ced00a6871b","unresolved":false,"context_lines":[{"line_number":591,"context_line":"            return \u0027%sv2%s\u0027 % (mirror, path)"},{"line_number":592,"context_line":"        else:"},{"line_number":593,"context_line":"            if (cls.is_insecure_registry(registry_host\u003dnetloc) and"},{"line_number":594,"context_line":"                  netloc not in cls.no_verify_registries):"},{"line_number":595,"context_line":"                scheme \u003d \u0027http\u0027"},{"line_number":596,"context_line":"            else:"},{"line_number":597,"context_line":"                scheme \u003d \u0027https\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_65bf04ab","line":594,"in_reply_to":"3fa7e38b_65c38459","updated":"2020-01-07 18:07:01.000000000","message":"Sure, but the trick will be distinguishing between an insecure registries that support HTTPS from ones that only support HTTP.","commit_id":"dcd0225267b170e27d57810da53b6127c60e13cd"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"fe449914f96f57875d4ea45245a1bc995da47d64","unresolved":false,"context_lines":[{"line_number":910,"context_line":"                    # uploader ignores the certificate problem, but they are"},{"line_number":911,"context_line":"                    # still inscure so we return True here while we\u0027ll still"},{"line_number":912,"context_line":"                    # use https when we access the registry. LP#1833751"},{"line_number":913,"context_line":"                    return True"},{"line_number":914,"context_line":"                except requests.exceptions.SSLError:"},{"line_number":915,"context_line":"                    # So nope, it\u0027s really not a certificate verification issue"},{"line_number":916,"context_line":"                    cls.insecure_registries.add(registry_host)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_10576ccb","line":913,"range":{"start_line":913,"start_character":27,"end_line":913,"end_character":31},"updated":"2020-01-07 18:51:14.000000000","message":"there might be a logic issue, i\u0027ll have to double check the test cases we have listed. I want to say switching this to false ends up causing other issues","commit_id":"dcd0225267b170e27d57810da53b6127c60e13cd"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"0835c4736f71cbac023ed8056c9a39f8d6ce7a89","unresolved":false,"context_lines":[{"line_number":910,"context_line":"                    # uploader ignores the certificate problem, but they are"},{"line_number":911,"context_line":"                    # still inscure so we return True here while we\u0027ll still"},{"line_number":912,"context_line":"                    # use https when we access the registry. LP#1833751"},{"line_number":913,"context_line":"                    return True"},{"line_number":914,"context_line":"                except requests.exceptions.SSLError:"},{"line_number":915,"context_line":"                    # So nope, it\u0027s really not a certificate verification issue"},{"line_number":916,"context_line":"                    cls.insecure_registries.add(registry_host)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_701580e5","line":913,"range":{"start_line":913,"start_character":27,"end_line":913,"end_character":31},"in_reply_to":"3fa7e38b_10576ccb","updated":"2020-01-07 19:13:28.000000000","message":"My read of the history is that it was originally False, then changed to True to fix an issue (see LP). So switching back to False might address my issue, but would regress the prior issue.","commit_id":"dcd0225267b170e27d57810da53b6127c60e13cd"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"8ae15c3350bfb94b50b1d41bb8c67e99c8b8317c","unresolved":false,"context_lines":[{"line_number":899,"context_line":"            try:"},{"line_number":900,"context_line":"                s.get(\u0027https://%s/v2\u0027 % registry_host, timeout\u003d30)"},{"line_number":901,"context_line":"            except requests.exceptions.SSLError:"},{"line_number":902,"context_line":"                # Might be just a TLS certificate validation issue"},{"line_number":903,"context_line":"                # Just retry without the verification"},{"line_number":904,"context_line":"                try:"},{"line_number":905,"context_line":"                    s.get(\u0027https://%s/v2\u0027 % registry_host, timeout\u003d30,"},{"line_number":906,"context_line":"                          verify\u003dFalse)"},{"line_number":907,"context_line":"                    cls.no_verify_registries.add(registry_host)"},{"line_number":908,"context_line":"                    # Techinically these type of registries are insecure when"},{"line_number":909,"context_line":"                    # the container engine tries to do a pull. The python"},{"line_number":910,"context_line":"                    # uploader ignores the certificate problem, but they are"},{"line_number":911,"context_line":"                    # still inscure so we return True here while we\u0027ll still"},{"line_number":912,"context_line":"                    # use https when we access the registry. LP#1833751"},{"line_number":913,"context_line":"                    return True"},{"line_number":914,"context_line":"                except requests.exceptions.SSLError:"},{"line_number":915,"context_line":"                    # So nope, it\u0027s really not a certificate verification issue"},{"line_number":916,"context_line":"                    cls.insecure_registries.add(registry_host)"},{"line_number":917,"context_line":"                    return True"},{"line_number":918,"context_line":"            except Exception:"},{"line_number":919,"context_line":"                # for any other error assume it is a secure registry, because:"},{"line_number":920,"context_line":"                # - it is secure registry"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_45bd28d5","line":917,"range":{"start_line":902,"start_character":0,"end_line":917,"end_character":31},"updated":"2020-01-07 17:55:11.000000000","message":"I think this is the logic that should handle what you\u0027re trying to do.","commit_id":"dcd0225267b170e27d57810da53b6127c60e13cd"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"0835c4736f71cbac023ed8056c9a39f8d6ce7a89","unresolved":false,"context_lines":[{"line_number":899,"context_line":"            try:"},{"line_number":900,"context_line":"                s.get(\u0027https://%s/v2\u0027 % registry_host, timeout\u003d30)"},{"line_number":901,"context_line":"            except requests.exceptions.SSLError:"},{"line_number":902,"context_line":"                # Might be just a TLS certificate validation issue"},{"line_number":903,"context_line":"                # Just retry without the verification"},{"line_number":904,"context_line":"                try:"},{"line_number":905,"context_line":"                    s.get(\u0027https://%s/v2\u0027 % registry_host, timeout\u003d30,"},{"line_number":906,"context_line":"                          verify\u003dFalse)"},{"line_number":907,"context_line":"                    cls.no_verify_registries.add(registry_host)"},{"line_number":908,"context_line":"                    # Techinically these type of registries are insecure when"},{"line_number":909,"context_line":"                    # the container engine tries to do a pull. The python"},{"line_number":910,"context_line":"                    # uploader ignores the certificate problem, but they are"},{"line_number":911,"context_line":"                    # still inscure so we return True here while we\u0027ll still"},{"line_number":912,"context_line":"                    # use https when we access the registry. LP#1833751"},{"line_number":913,"context_line":"                    return True"},{"line_number":914,"context_line":"                except requests.exceptions.SSLError:"},{"line_number":915,"context_line":"                    # So nope, it\u0027s really not a certificate verification issue"},{"line_number":916,"context_line":"                    cls.insecure_registries.add(registry_host)"},{"line_number":917,"context_line":"                    return True"},{"line_number":918,"context_line":"            except Exception:"},{"line_number":919,"context_line":"                # for any other error assume it is a secure registry, because:"},{"line_number":920,"context_line":"                # - it is secure registry"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_10fd2c6c","line":917,"range":{"start_line":902,"start_character":0,"end_line":917,"end_character":31},"in_reply_to":"3fa7e38b_10f0ccfb","updated":"2020-01-07 19:13:28.000000000","message":"I think I\u0027m seeing the reverse of what\u0027s described in that LP.\n- docker-registry.upshift.redhat.com does NOT appear in the generated containers-prepare-parameter.yaml file\n- The prepare command fails (per my LP description) when it attempts to upload the ceph container.\n\nFWIW, I\u0027m encountering this using downstream OSP-15, but confirmed tripleo-common (openstack-tripleo-common-10.8.2-0.20190913130445.4754dea.el8ost.noarch) includes https://review.opendev.org/669761","commit_id":"dcd0225267b170e27d57810da53b6127c60e13cd"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"79042156846f5981aaf5610ba54e8e7792196db9","unresolved":false,"context_lines":[{"line_number":899,"context_line":"            try:"},{"line_number":900,"context_line":"                s.get(\u0027https://%s/v2\u0027 % registry_host, timeout\u003d30)"},{"line_number":901,"context_line":"            except requests.exceptions.SSLError:"},{"line_number":902,"context_line":"                # Might be just a TLS certificate validation issue"},{"line_number":903,"context_line":"                # Just retry without the verification"},{"line_number":904,"context_line":"                try:"},{"line_number":905,"context_line":"                    s.get(\u0027https://%s/v2\u0027 % registry_host, timeout\u003d30,"},{"line_number":906,"context_line":"                          verify\u003dFalse)"},{"line_number":907,"context_line":"                    cls.no_verify_registries.add(registry_host)"},{"line_number":908,"context_line":"                    # Techinically these type of registries are insecure when"},{"line_number":909,"context_line":"                    # the container engine tries to do a pull. The python"},{"line_number":910,"context_line":"                    # uploader ignores the certificate problem, but they are"},{"line_number":911,"context_line":"                    # still inscure so we return True here while we\u0027ll still"},{"line_number":912,"context_line":"                    # use https when we access the registry. LP#1833751"},{"line_number":913,"context_line":"                    return True"},{"line_number":914,"context_line":"                except requests.exceptions.SSLError:"},{"line_number":915,"context_line":"                    # So nope, it\u0027s really not a certificate verification issue"},{"line_number":916,"context_line":"                    cls.insecure_registries.add(registry_host)"},{"line_number":917,"context_line":"                    return True"},{"line_number":918,"context_line":"            except Exception:"},{"line_number":919,"context_line":"                # for any other error assume it is a secure registry, because:"},{"line_number":920,"context_line":"                # - it is secure registry"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_0b06611c","line":917,"range":{"start_line":902,"start_character":0,"end_line":917,"end_character":31},"in_reply_to":"3fa7e38b_10fd2c6c","updated":"2020-01-07 19:38:05.000000000","message":"So if it\u0027s not in the DockerInsecureRegistryAddress, it\u0027ll fall back to http which means this is working as expected.  In order for it not to fall back to http, you\u0027d have to include it in DockerInsecureRegistryAddress and this code would allow it to still use https (even thought he cert isn\u0027t valid).","commit_id":"dcd0225267b170e27d57810da53b6127c60e13cd"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"2c2e24ba626e0a7701f07b3c9bc14ced00a6871b","unresolved":false,"context_lines":[{"line_number":899,"context_line":"            try:"},{"line_number":900,"context_line":"                s.get(\u0027https://%s/v2\u0027 % registry_host, timeout\u003d30)"},{"line_number":901,"context_line":"            except requests.exceptions.SSLError:"},{"line_number":902,"context_line":"                # Might be just a TLS certificate validation issue"},{"line_number":903,"context_line":"                # Just retry without the verification"},{"line_number":904,"context_line":"                try:"},{"line_number":905,"context_line":"                    s.get(\u0027https://%s/v2\u0027 % registry_host, timeout\u003d30,"},{"line_number":906,"context_line":"                          verify\u003dFalse)"},{"line_number":907,"context_line":"                    cls.no_verify_registries.add(registry_host)"},{"line_number":908,"context_line":"                    # Techinically these type of registries are insecure when"},{"line_number":909,"context_line":"                    # the container engine tries to do a pull. The python"},{"line_number":910,"context_line":"                    # uploader ignores the certificate problem, but they are"},{"line_number":911,"context_line":"                    # still inscure so we return True here while we\u0027ll still"},{"line_number":912,"context_line":"                    # use https when we access the registry. LP#1833751"},{"line_number":913,"context_line":"                    return True"},{"line_number":914,"context_line":"                except requests.exceptions.SSLError:"},{"line_number":915,"context_line":"                    # So nope, it\u0027s really not a certificate verification issue"},{"line_number":916,"context_line":"                    cls.insecure_registries.add(registry_host)"},{"line_number":917,"context_line":"                    return True"},{"line_number":918,"context_line":"            except Exception:"},{"line_number":919,"context_line":"                # for any other error assume it is a secure registry, because:"},{"line_number":920,"context_line":"                # - it is secure registry"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_85e800a7","line":917,"range":{"start_line":902,"start_character":0,"end_line":917,"end_character":31},"in_reply_to":"3fa7e38b_45bd28d5","updated":"2020-01-07 18:07:01.000000000","message":"The problem is the URL builder was only checking this function\u0027s boolean response. Returning True on L917 causes the URL builder to choose HTTP.","commit_id":"dcd0225267b170e27d57810da53b6127c60e13cd"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c24d4b14fe17024dd20dcc03ea432d07fa725203","unresolved":false,"context_lines":[{"line_number":899,"context_line":"            try:"},{"line_number":900,"context_line":"                s.get(\u0027https://%s/v2\u0027 % registry_host, timeout\u003d30)"},{"line_number":901,"context_line":"            except requests.exceptions.SSLError:"},{"line_number":902,"context_line":"                # Might be just a TLS certificate validation issue"},{"line_number":903,"context_line":"                # Just retry without the verification"},{"line_number":904,"context_line":"                try:"},{"line_number":905,"context_line":"                    s.get(\u0027https://%s/v2\u0027 % registry_host, timeout\u003d30,"},{"line_number":906,"context_line":"                          verify\u003dFalse)"},{"line_number":907,"context_line":"                    cls.no_verify_registries.add(registry_host)"},{"line_number":908,"context_line":"                    # Techinically these type of registries are insecure when"},{"line_number":909,"context_line":"                    # the container engine tries to do a pull. The python"},{"line_number":910,"context_line":"                    # uploader ignores the certificate problem, but they are"},{"line_number":911,"context_line":"                    # still inscure so we return True here while we\u0027ll still"},{"line_number":912,"context_line":"                    # use https when we access the registry. LP#1833751"},{"line_number":913,"context_line":"                    return True"},{"line_number":914,"context_line":"                except requests.exceptions.SSLError:"},{"line_number":915,"context_line":"                    # So nope, it\u0027s really not a certificate verification issue"},{"line_number":916,"context_line":"                    cls.insecure_registries.add(registry_host)"},{"line_number":917,"context_line":"                    return True"},{"line_number":918,"context_line":"            except Exception:"},{"line_number":919,"context_line":"                # for any other error assume it is a secure registry, because:"},{"line_number":920,"context_line":"                # - it is secure registry"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_10f0ccfb","line":917,"range":{"start_line":902,"start_character":0,"end_line":917,"end_character":31},"in_reply_to":"3fa7e38b_50296486","updated":"2020-01-07 18:44:49.000000000","message":"Are you sure the registry was in DockerInsecureRegistry correctly in the bug?  This block was to specifically address this case https://launchpad.net/tripleo/+bug/1833751","commit_id":"dcd0225267b170e27d57810da53b6127c60e13cd"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"42c409244db4c71773efda051353cdee5eaf6ec2","unresolved":false,"context_lines":[{"line_number":899,"context_line":"            try:"},{"line_number":900,"context_line":"                s.get(\u0027https://%s/v2\u0027 % registry_host, timeout\u003d30)"},{"line_number":901,"context_line":"            except requests.exceptions.SSLError:"},{"line_number":902,"context_line":"                # Might be just a TLS certificate validation issue"},{"line_number":903,"context_line":"                # Just retry without the verification"},{"line_number":904,"context_line":"                try:"},{"line_number":905,"context_line":"                    s.get(\u0027https://%s/v2\u0027 % registry_host, timeout\u003d30,"},{"line_number":906,"context_line":"                          verify\u003dFalse)"},{"line_number":907,"context_line":"                    cls.no_verify_registries.add(registry_host)"},{"line_number":908,"context_line":"                    # Techinically these type of registries are insecure when"},{"line_number":909,"context_line":"                    # the container engine tries to do a pull. The python"},{"line_number":910,"context_line":"                    # uploader ignores the certificate problem, but they are"},{"line_number":911,"context_line":"                    # still inscure so we return True here while we\u0027ll still"},{"line_number":912,"context_line":"                    # use https when we access the registry. LP#1833751"},{"line_number":913,"context_line":"                    return True"},{"line_number":914,"context_line":"                except requests.exceptions.SSLError:"},{"line_number":915,"context_line":"                    # So nope, it\u0027s really not a certificate verification issue"},{"line_number":916,"context_line":"                    cls.insecure_registries.add(registry_host)"},{"line_number":917,"context_line":"                    return True"},{"line_number":918,"context_line":"            except Exception:"},{"line_number":919,"context_line":"                # for any other error assume it is a secure registry, because:"},{"line_number":920,"context_line":"                # - it is secure registry"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_a55dfc48","line":917,"range":{"start_line":902,"start_character":0,"end_line":917,"end_character":31},"in_reply_to":"3fa7e38b_85e800a7","updated":"2020-01-07 18:27:06.000000000","message":"That means the error being returned is not an SSLerror (maybe it\u0027s failing because of the 401?)","commit_id":"dcd0225267b170e27d57810da53b6127c60e13cd"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"3b53ef681006e8d6c6544fc0eddd1d6f1aebcb02","unresolved":false,"context_lines":[{"line_number":899,"context_line":"            try:"},{"line_number":900,"context_line":"                s.get(\u0027https://%s/v2\u0027 % registry_host, timeout\u003d30)"},{"line_number":901,"context_line":"            except requests.exceptions.SSLError:"},{"line_number":902,"context_line":"                # Might be just a TLS certificate validation issue"},{"line_number":903,"context_line":"                # Just retry without the verification"},{"line_number":904,"context_line":"                try:"},{"line_number":905,"context_line":"                    s.get(\u0027https://%s/v2\u0027 % registry_host, timeout\u003d30,"},{"line_number":906,"context_line":"                          verify\u003dFalse)"},{"line_number":907,"context_line":"                    cls.no_verify_registries.add(registry_host)"},{"line_number":908,"context_line":"                    # Techinically these type of registries are insecure when"},{"line_number":909,"context_line":"                    # the container engine tries to do a pull. The python"},{"line_number":910,"context_line":"                    # uploader ignores the certificate problem, but they are"},{"line_number":911,"context_line":"                    # still inscure so we return True here while we\u0027ll still"},{"line_number":912,"context_line":"                    # use https when we access the registry. LP#1833751"},{"line_number":913,"context_line":"                    return True"},{"line_number":914,"context_line":"                except requests.exceptions.SSLError:"},{"line_number":915,"context_line":"                    # So nope, it\u0027s really not a certificate verification issue"},{"line_number":916,"context_line":"                    cls.insecure_registries.add(registry_host)"},{"line_number":917,"context_line":"                    return True"},{"line_number":918,"context_line":"            except Exception:"},{"line_number":919,"context_line":"                # for any other error assume it is a secure registry, because:"},{"line_number":920,"context_line":"                # - it is secure registry"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_50296486","line":917,"range":{"start_line":902,"start_character":0,"end_line":917,"end_character":31},"in_reply_to":"3fa7e38b_a55dfc48","updated":"2020-01-07 18:35:02.000000000","message":"Whoops, my bad. For this registry it exits at L913, not L917. It is an SSL error, and I confirmed the registry ends up in cls.no_verify_registries.","commit_id":"dcd0225267b170e27d57810da53b6127c60e13cd"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"8ae15c3350bfb94b50b1d41bb8c67e99c8b8317c","unresolved":false,"context_lines":[{"line_number":919,"context_line":"                # for any other error assume it is a secure registry, because:"},{"line_number":920,"context_line":"                # - it is secure registry"},{"line_number":921,"context_line":"                # - the host is not accessible"},{"line_number":922,"context_line":"                pass"},{"line_number":923,"context_line":"        cls.secure_registries.add(registry_host)"},{"line_number":924,"context_line":"        return False"},{"line_number":925,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_e5af749a","line":922,"updated":"2020-01-07 17:55:11.000000000","message":"I think you\u0027re hitting this because that registry accepts http but throws a difffernt exception","commit_id":"dcd0225267b170e27d57810da53b6127c60e13cd"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"3b53ef681006e8d6c6544fc0eddd1d6f1aebcb02","unresolved":false,"context_lines":[{"line_number":919,"context_line":"                # for any other error assume it is a secure registry, because:"},{"line_number":920,"context_line":"                # - it is secure registry"},{"line_number":921,"context_line":"                # - the host is not accessible"},{"line_number":922,"context_line":"                pass"},{"line_number":923,"context_line":"        cls.secure_registries.add(registry_host)"},{"line_number":924,"context_line":"        return False"},{"line_number":925,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_f01bb06b","line":922,"in_reply_to":"3fa7e38b_25126cb5","updated":"2020-01-07 18:35:02.000000000","message":"Correction: it exits at L913 for this registry.","commit_id":"dcd0225267b170e27d57810da53b6127c60e13cd"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"2c2e24ba626e0a7701f07b3c9bc14ced00a6871b","unresolved":false,"context_lines":[{"line_number":919,"context_line":"                # for any other error assume it is a secure registry, because:"},{"line_number":920,"context_line":"                # - it is secure registry"},{"line_number":921,"context_line":"                # - the host is not accessible"},{"line_number":922,"context_line":"                pass"},{"line_number":923,"context_line":"        cls.secure_registries.add(registry_host)"},{"line_number":924,"context_line":"        return False"},{"line_number":925,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_25126cb5","line":922,"in_reply_to":"3fa7e38b_e5af749a","updated":"2020-01-07 18:07:01.000000000","message":"The registry accepts HTTPS (albeit with an SSL error), and so we return at L917. I don\u0027t think the code reaches L922 when probing that registry.","commit_id":"dcd0225267b170e27d57810da53b6127c60e13cd"}]}