)]}'
{"workbooks/deployment.yaml":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"29cdb5a23817fbecf0fe9961bd99d5f695e87b88","unresolved":false,"context_lines":[{"line_number":370,"context_line":"      - work_dir: /var/lib/mistral"},{"line_number":371,"context_line":"      - verbosity: 0"},{"line_number":372,"context_line":"      - blacklist: []"},{"line_number":373,"context_line":"      - override_ansible_cfg: \"\""},{"line_number":374,"context_line":"      - config_download_timeout: 14400"},{"line_number":375,"context_line":"      - nodes: []"},{"line_number":376,"context_line":"      - playbook_name: deploy_steps_playbook.yaml"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_cefd5b6e","side":"PARENT","line":373,"updated":"2020-01-31 22:13:58.000000000","message":"this doesn\u0027t seem right. This option is for a user who wants to pass in a custom ansible.cfg where the options specified within will override the values from our generated ansible.cfg.","commit_id":"d39fb80e07d42b147ee971a60d1eb87a39df74b5"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"00f033bb3fbc85c94e9386ea829ce5a757602154","unresolved":false,"context_lines":[{"line_number":370,"context_line":"      - work_dir: /var/lib/mistral"},{"line_number":371,"context_line":"      - verbosity: 0"},{"line_number":372,"context_line":"      - blacklist: []"},{"line_number":373,"context_line":"      - override_ansible_cfg: \"\""},{"line_number":374,"context_line":"      - config_download_timeout: 14400"},{"line_number":375,"context_line":"      - nodes: []"},{"line_number":376,"context_line":"      - playbook_name: deploy_steps_playbook.yaml"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_d1573ac9","side":"PARENT","line":373,"in_reply_to":"3fa7e38b_b1c4fe95","updated":"2020-01-31 23:29:59.000000000","message":"in ps5 I put the input back but made it so that if the override is null it will default to our generated ansible.cfg file.","commit_id":"d39fb80e07d42b147ee971a60d1eb87a39df74b5"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"a61fc77ed28dd303c04cf41aeaca868866a5aaa3","unresolved":false,"context_lines":[{"line_number":370,"context_line":"      - work_dir: /var/lib/mistral"},{"line_number":371,"context_line":"      - verbosity: 0"},{"line_number":372,"context_line":"      - blacklist: []"},{"line_number":373,"context_line":"      - override_ansible_cfg: \"\""},{"line_number":374,"context_line":"      - config_download_timeout: 14400"},{"line_number":375,"context_line":"      - nodes: []"},{"line_number":376,"context_line":"      - playbook_name: deploy_steps_playbook.yaml"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_62720f4e","side":"PARENT","line":373,"in_reply_to":"3fa7e38b_b1c4fe95","updated":"2020-02-04 22:01:10.000000000","message":"the config specified with --override-ansible-cfg is merged with the generated config in write_default_ansible_cfg in tripleo_common/actions/ansible.py.\n\nIf there are the same keys in both, the values from the override will take precedence since it is read last with the ConfigParser object.","commit_id":"d39fb80e07d42b147ee971a60d1eb87a39df74b5"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"9c5dae8958c611d3681d07c93885d13f29035deb","unresolved":false,"context_lines":[{"line_number":370,"context_line":"      - work_dir: /var/lib/mistral"},{"line_number":371,"context_line":"      - verbosity: 0"},{"line_number":372,"context_line":"      - blacklist: []"},{"line_number":373,"context_line":"      - override_ansible_cfg: \"\""},{"line_number":374,"context_line":"      - config_download_timeout: 14400"},{"line_number":375,"context_line":"      - nodes: []"},{"line_number":376,"context_line":"      - playbook_name: deploy_steps_playbook.yaml"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_b1c4fe95","side":"PARENT","line":373,"in_reply_to":"3fa7e38b_cefd5b6e","updated":"2020-01-31 23:19:25.000000000","message":"I may be wrong here, but in reading our tripleo-common ansible code it seems that if a user provides an ansible.cfg file it will replace our generated config, not extend it, and if this happens, its likely nothing will work.\n\nI will say that we\u0027ve added the ability to set the config via the client when playbooks are executed, so users will be able to provide a config to their liking, however, giving users the ability to control the config options when we have so many configuration settings that are hard coded for our specific systems seems like a foot gun, eventually leading to a bad user experience.","commit_id":"d39fb80e07d42b147ee971a60d1eb87a39df74b5"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"29cdb5a23817fbecf0fe9961bd99d5f695e87b88","unresolved":false,"context_lines":[{"line_number":509,"context_line":"          playbook_name: \u003c% $.get(\u0027playbook_name\u0027) %\u003e"},{"line_number":510,"context_line":"          plan_name: \u003c% $.plan_name %\u003e"},{"line_number":511,"context_line":"          remote_user: tripleo-admin"},{"line_number":512,"context_line":"          ssh_private_key: \u003c% $.private_key %\u003e"},{"line_number":513,"context_line":"          use_openstack_credentials: true"},{"line_number":514,"context_line":"          verbosity: \u003c% $.get(\u0027verbosity\u0027) %\u003e"},{"line_number":515,"context_line":"          become: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_4ee96ba9","side":"PARENT","line":512,"updated":"2020-01-31 22:13:58.000000000","message":"i don\u0027t see how this can be removed either until the config_download_deploy workflow is fully migrated","commit_id":"d39fb80e07d42b147ee971a60d1eb87a39df74b5"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"9c5dae8958c611d3681d07c93885d13f29035deb","unresolved":false,"context_lines":[{"line_number":509,"context_line":"          playbook_name: \u003c% $.get(\u0027playbook_name\u0027) %\u003e"},{"line_number":510,"context_line":"          plan_name: \u003c% $.plan_name %\u003e"},{"line_number":511,"context_line":"          remote_user: tripleo-admin"},{"line_number":512,"context_line":"          ssh_private_key: \u003c% $.private_key %\u003e"},{"line_number":513,"context_line":"          use_openstack_credentials: true"},{"line_number":514,"context_line":"          verbosity: \u003c% $.get(\u0027verbosity\u0027) %\u003e"},{"line_number":515,"context_line":"          become: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_11d07252","side":"PARENT","line":512,"in_reply_to":"3fa7e38b_4ee96ba9","updated":"2020-01-31 23:19:25.000000000","message":"The key is in our generated ansible.cfg file so there\u0027s no need to provide the key here.","commit_id":"d39fb80e07d42b147ee971a60d1eb87a39df74b5"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"2c9405beca05a9e41a86859f5f07e8875074b80e","unresolved":false,"context_lines":[{"line_number":509,"context_line":"          playbook_name: \u003c% $.get(\u0027playbook_name\u0027) %\u003e"},{"line_number":510,"context_line":"          plan_name: \u003c% $.plan_name %\u003e"},{"line_number":511,"context_line":"          remote_user: tripleo-admin"},{"line_number":512,"context_line":"          ssh_private_key: \u003c% $.private_key %\u003e"},{"line_number":513,"context_line":"          use_openstack_credentials: true"},{"line_number":514,"context_line":"          verbosity: \u003c% $.get(\u0027verbosity\u0027) %\u003e"},{"line_number":515,"context_line":"          become: true"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_82e06bcd","side":"PARENT","line":512,"updated":"2020-02-04 22:07:16.000000000","message":"this won\u0027t pass CI if you don\u0027t pass a key in. I think this patch needs to wait until config_download_deploy is migrated as well.","commit_id":"d39fb80e07d42b147ee971a60d1eb87a39df74b5"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"2c9405beca05a9e41a86859f5f07e8875074b80e","unresolved":false,"context_lines":[{"line_number":497,"context_line":"          reproduce_command: true"},{"line_number":498,"context_line":"          trash_output: true"},{"line_number":499,"context_line":"          blacklisted_hostnames: \u003c% $.blacklisted_hostnames %\u003e"},{"line_number":500,"context_line":"          override_ansible_cfg: \u003c% $.override_ansible_cfg or $.get(\u0027work_dir\u0027) + \"/\" + $.get(\u0027plan_name\u0027) + \"/ansible.cfg\" %\u003e"},{"line_number":501,"context_line":"          command_timeout: \u003c% $.config_download_timeout %\u003e"},{"line_number":502,"context_line":"          execution_id: \u003c% execution().id %\u003e"},{"line_number":503,"context_line":"          limit_hosts: \u003c% $.nodes and list(task(uuids_to_names).result.instance_info.display_name).join(\u0027,\u0027) or false %\u003e"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_22a17793","line":500,"updated":"2020-02-04 22:07:16.000000000","message":"this isn\u0027t right. i don\u0027t think this line needs to be changed at all.","commit_id":"258767d15b2b4bcc3596318e033cec59d9ff12ef"}],"workbooks/swift_ring_rebalance.yaml":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"2c9405beca05a9e41a86859f5f07e8875074b80e","unresolved":false,"context_lines":[{"line_number":23,"context_line":"          remote_user: tripleo-admin"},{"line_number":24,"context_line":"          become: true"},{"line_number":25,"context_line":"          become_user: root"},{"line_number":26,"context_line":"          override_ansible_cfg: \u003c% $.get(\u0027work_dir\u0027) %\u003e/\u003c% $.get(\u0027container\u0027) %\u003e/ansible.cfg"},{"line_number":27,"context_line":"          playbook: /usr/share/tripleo-ansible/playbooks/swift_ring_rebalance.yaml"},{"line_number":28,"context_line":"          inventory: \u003c% $.get(\u0027work_dir\u0027) %\u003e/\u003c% $.get(\u0027container\u0027) %\u003e/tripleo-ansible-inventory.yaml"},{"line_number":29,"context_line":"          use_openstack_credentials: true"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_82ab8b6f","line":26,"updated":"2020-02-04 22:07:16.000000000","message":"not needed","commit_id":"258767d15b2b4bcc3596318e033cec59d9ff12ef"}]}