)]}'
{"tripleo_common/inventory.py":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"753181fc70b1e8a82e0e3162b9c1cddae4a7c389","unresolved":false,"context_lines":[{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        role_net_ip_map \u003d self.stack_outputs.get(\u0027RoleNetIpMap\u0027, {})"},{"line_number":230,"context_line":"        role_node_id_map \u003d self.stack_outputs.get(\u0027ServerIdData\u0027, {})"},{"line_number":231,"context_line":"        networks \u003d set()"},{"line_number":232,"context_line":"        role_net_hostname_map \u003d self.stack_outputs.get("},{"line_number":233,"context_line":"            \u0027RoleNetHostnameMap\u0027, {})"},{"line_number":234,"context_line":"        children \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_1fd2d460","line":231,"range":{"start_line":231,"start_character":8,"end_line":231,"end_character":24},"updated":"2020-01-30 15:42:26.000000000","message":"ah, I thought this was inside the for loop. As this is outside it\u0027s the union of all role networks, so not correct to use this below for tripleo_role_networks","commit_id":"3d01a6eb6e513e63e66c030cfd88ec357d2d1fcb"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"ae99ef85575876bbb073de62be524c74acebf921","unresolved":false,"context_lines":[{"line_number":250,"context_line":"                        hosts[name].update({"},{"line_number":251,"context_line":"                            \u0027deploy_server_id\u0027: role_node_id_map["},{"line_number":252,"context_line":"                                \u0027server_ids\u0027][role][idx]})"},{"line_number":253,"context_line":"                    # Conflicts with global var but keep for compaibility"},{"line_number":254,"context_line":"                    # Use tripleo_role_networks instead"},{"line_number":255,"context_line":"                    hosts[name].update({"},{"line_number":256,"context_line":"                        \u0027enabled_networks\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_3943336e","line":253,"range":{"start_line":253,"start_character":48,"end_line":253,"end_character":73},"updated":"2020-01-30 12:10:12.000000000","message":"I wonder if it\u0027s safe to remove it? Everything using enabled_networks in tripleo-ansible expects the global var format\n\nAlso nit: typo","commit_id":"3d01a6eb6e513e63e66c030cfd88ec357d2d1fcb"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"04738e53c4920bc7e0da9d3541e7c9044369cb56","unresolved":false,"context_lines":[{"line_number":250,"context_line":"                        hosts[name].update({"},{"line_number":251,"context_line":"                            \u0027deploy_server_id\u0027: role_node_id_map["},{"line_number":252,"context_line":"                                \u0027server_ids\u0027][role][idx]})"},{"line_number":253,"context_line":"                    # Conflicts with global var but keep for compaibility"},{"line_number":254,"context_line":"                    # Use tripleo_role_networks instead"},{"line_number":255,"context_line":"                    hosts[name].update({"},{"line_number":256,"context_line":"                        \u0027enabled_networks\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_7f2f4857","line":253,"range":{"start_line":253,"start_character":48,"end_line":253,"end_character":73},"in_reply_to":"3fa7e38b_3943336e","updated":"2020-01-30 15:44:04.000000000","message":"Removal got a +1 from slagle and cloudnull on #tripleo IRC","commit_id":"3d01a6eb6e513e63e66c030cfd88ec357d2d1fcb"}]}