)]}'
{"tripleo_common/tests/fake_config/fakes.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e1487f5657989107f03eafee038a7848f0621b57","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                     \u0027chrony_host\u0027: \u0027localhost\u0027,"},{"line_number":69,"context_line":"                     # TODO add tests for a value that won\u0027t be overriden"},{"line_number":70,"context_line":"                     # \u0027chrony_acl\u0027: \u0027none\u0027,"},{"line_number":71,"context_line":"                  },"},{"line_number":72,"context_line":"                 \u0027global_config_settings\u0027: {},"},{"line_number":73,"context_line":"                 \u0027logging_groups\u0027: [\u0027root\u0027, \u0027keystone\u0027, \u0027neutron\u0027],"},{"line_number":74,"context_line":"                 \u0027logging_sources\u0027: [{\u0027path\u0027: \u0027/var/log/keystone/keystone.log\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_a82189b6","line":71,"updated":"2020-04-03 05:13:28.000000000","message":"linters: E121 continuation line under-indented for hanging indent","commit_id":"a27c12247504fe25b99187b127b4f4c42b25204d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e1487f5657989107f03eafee038a7848f0621b57","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                     \u0027chrony_host\u0027: \u0027localhost\u0027,"},{"line_number":69,"context_line":"                     # TODO add tests for a value that won\u0027t be overriden"},{"line_number":70,"context_line":"                     # \u0027chrony_acl\u0027: \u0027none\u0027,"},{"line_number":71,"context_line":"                  },"},{"line_number":72,"context_line":"                 \u0027global_config_settings\u0027: {},"},{"line_number":73,"context_line":"                 \u0027logging_groups\u0027: [\u0027root\u0027, \u0027keystone\u0027, \u0027neutron\u0027],"},{"line_number":74,"context_line":"                 \u0027logging_sources\u0027: [{\u0027path\u0027: \u0027/var/log/keystone/keystone.log\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_082d15a7","line":71,"updated":"2020-04-03 05:13:28.000000000","message":"pep8: E121 continuation line under-indented for hanging indent","commit_id":"a27c12247504fe25b99187b127b4f4c42b25204d"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"2650e8d20a9e8896f61e1693b0bc45425892e5e0","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                     \u0027chrony_host\u0027: \u0027localhost\u0027,"},{"line_number":69,"context_line":"                     # TODO add tests for a value that won\u0027t be overriden"},{"line_number":70,"context_line":"                     # \u0027chrony_acl\u0027: \u0027none\u0027,"},{"line_number":71,"context_line":"                  },"},{"line_number":72,"context_line":"                 \u0027global_config_settings\u0027: {},"},{"line_number":73,"context_line":"                 \u0027logging_groups\u0027: [\u0027root\u0027, \u0027keystone\u0027, \u0027neutron\u0027],"},{"line_number":74,"context_line":"                 \u0027logging_sources\u0027: [{\u0027path\u0027: \u0027/var/log/keystone/keystone.log\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_fc8fd671","line":71,"in_reply_to":"df33271e_a82189b6","updated":"2020-04-03 05:35:53.000000000","message":"nice stuff from zuul:)","commit_id":"a27c12247504fe25b99187b127b4f4c42b25204d"}],"tripleo_common/utils/config.py":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"2650e8d20a9e8896f61e1693b0bc45425892e5e0","unresolved":false,"context_lines":[{"line_number":258,"context_line":"                    else:"},{"line_number":259,"context_line":"                        # NOTE(aschultz): We have role group vars so we want"},{"line_number":260,"context_line":"                        # them to be overrides to the ansible"},{"line_number":261,"context_line":"                        role[config].update(role_group_vars[role_name])"},{"line_number":262,"context_line":"                        role_group_vars[role_name] \u003d role[config]"},{"line_number":263,"context_line":"                else:"},{"line_number":264,"context_line":"                    # NOTE(emilien): Move this condition to the"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_7c7c6671","line":261,"range":{"start_line":261,"start_character":24,"end_line":261,"end_character":71},"updated":"2020-04-03 05:35:53.000000000","message":"Though this would work, should we be more explicit to keep it as \u0027service_extra_vars\u0027 key in  \u0027role_group_vars\u0027 and then allow only that to override role[\u0027config\u0027], finally deleting \u0027service_extra_vars\u0027 from \u0027role_group_vars\u0027?\n\nIgnore if it would be more confusing.","commit_id":"a27c12247504fe25b99187b127b4f4c42b25204d"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e2352f785aaf4acd04829753e967ae603b208167","unresolved":false,"context_lines":[{"line_number":258,"context_line":"                    else:"},{"line_number":259,"context_line":"                        # NOTE(aschultz): We have role group vars so we want"},{"line_number":260,"context_line":"                        # them to be overrides to the ansible"},{"line_number":261,"context_line":"                        role[config].update(role_group_vars[role_name])"},{"line_number":262,"context_line":"                        role_group_vars[role_name] \u003d role[config]"},{"line_number":263,"context_line":"                else:"},{"line_number":264,"context_line":"                    # NOTE(emilien): Move this condition to the"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_c18b03bd","line":261,"range":{"start_line":261,"start_character":24,"end_line":261,"end_character":71},"in_reply_to":"df33271e_7c7c6671","updated":"2020-04-03 12:21:45.000000000","message":"why would we do that? It would work too, but unless there is a reason, i would keep it as simple.","commit_id":"a27c12247504fe25b99187b127b4f4c42b25204d"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"bf21bf9a9f00457953c581f94ac1cb6957bf88e7","unresolved":false,"context_lines":[{"line_number":258,"context_line":"                    else:"},{"line_number":259,"context_line":"                        # NOTE(aschultz): We have role group vars so we want"},{"line_number":260,"context_line":"                        # them to be overrides to the ansible"},{"line_number":261,"context_line":"                        role[config].update(role_group_vars[role_name])"},{"line_number":262,"context_line":"                        role_group_vars[role_name] \u003d role[config]"},{"line_number":263,"context_line":"                else:"},{"line_number":264,"context_line":"                    # NOTE(emilien): Move this condition to the"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_c1e4a211","line":261,"range":{"start_line":261,"start_character":24,"end_line":261,"end_character":71},"in_reply_to":"df33271e_c18b03bd","updated":"2020-04-03 12:58:12.000000000","message":"Though not a big reason....\n\nWe\u0027re updating role[config] with everything in role_group_vars[role_name] and when we assign it to role_group_vars in the next line they refer to the same exact dict object. Though role[config] has no significance beyond this, changing one would change the other. Also, roledata would be modified as well.\n\nAFAIU, the vars in {{role.name}}ExtraGroupVars are _only_ supposed to override service specific vars, so I thought about being explicit.","commit_id":"a27c12247504fe25b99187b127b4f4c42b25204d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"9bacbd5396e1213d9e15c4341fe514af1e21d126","unresolved":false,"context_lines":[{"line_number":258,"context_line":"                    else:"},{"line_number":259,"context_line":"                        # NOTE(aschultz): We have role group vars so we want"},{"line_number":260,"context_line":"                        # them to be overrides to the ansible"},{"line_number":261,"context_line":"                        role[config].update(role_group_vars[role_name])"},{"line_number":262,"context_line":"                        role_group_vars[role_name] \u003d role[config]"},{"line_number":263,"context_line":"                else:"},{"line_number":264,"context_line":"                    # NOTE(emilien): Move this condition to the"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_159d2466","line":261,"range":{"start_line":261,"start_character":24,"end_line":261,"end_character":71},"in_reply_to":"df33271e_c1e4a211","updated":"2020-04-03 14:55:08.000000000","message":"I believe RoleExtraGroupVars should override any ansible var because of the way it\u0027s loaded.  I think this is a difference between the ansible/hiera implementation only because we\u0027re using ansible as the deployment mechanism too rather than just configs.  From an flexibility standpoint I think this makes this more useful for folks who need to tweak things on a role level.","commit_id":"a27c12247504fe25b99187b127b4f4c42b25204d"}]}