)]}'
{"tripleo_common/utils/nodes.py":[{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"189a127c7f81a9b75468a39d34645f9fc05cd9a3","unresolved":false,"context_lines":[{"line_number":713,"context_line":"            for port in baremetal_client.port.list(node\u003dbm_node.uuid):"},{"line_number":714,"context_line":"                hostmap[port.address] \u003d {\"compute_name\": node.name,"},{"line_number":715,"context_line":"                                         \"baremetal_name\": bm_node.name}"},{"line_number":716,"context_line":"        except:"},{"line_number":717,"context_line":"            # we didn\u0027t find a bm_node corresponding to the instance"},{"line_number":718,"context_line":"            # probably server is in error state with no corresponding"},{"line_number":719,"context_line":"            # ironic node assigned."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_f1ca359f","line":716,"range":{"start_line":716,"start_character":6,"end_line":716,"end_character":15},"updated":"2020-07-01 09:29:50.000000000","message":"it\u0027d be nice to catch a more specific exception here?","commit_id":"bf8730e5ac14b42fc27531293670b6fb05b433ff"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9fb9a8b718115381ef2a72a5f6ff9b01941c3f3e","unresolved":false,"context_lines":[{"line_number":713,"context_line":"            for port in baremetal_client.port.list(node\u003dbm_node.uuid):"},{"line_number":714,"context_line":"                hostmap[port.address] \u003d {\"compute_name\": node.name,"},{"line_number":715,"context_line":"                                         \"baremetal_name\": bm_node.name}"},{"line_number":716,"context_line":"        except:"},{"line_number":717,"context_line":"            # we didn\u0027t find a bm_node corresponding to the instance"},{"line_number":718,"context_line":"            # probably server is in error state with no corresponding"},{"line_number":719,"context_line":"            # ironic node assigned."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_71e58538","line":716,"updated":"2020-07-01 09:28:50.000000000","message":"let\u0027s use a specific exception (ironicclient.exc.NotFound if I\u0027m not mistaken)","commit_id":"bf8730e5ac14b42fc27531293670b6fb05b433ff"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"8b82464832a363e8f068c7dd3b20a8c4627c963f","unresolved":false,"context_lines":[{"line_number":713,"context_line":"            for port in baremetal_client.port.list(node\u003dbm_node.uuid):"},{"line_number":714,"context_line":"                hostmap[port.address] \u003d {\"compute_name\": node.name,"},{"line_number":715,"context_line":"                                         \"baremetal_name\": bm_node.name}"},{"line_number":716,"context_line":"        except:"},{"line_number":717,"context_line":"            # we didn\u0027t find a bm_node corresponding to the instance"},{"line_number":718,"context_line":"            # probably server is in error state with no corresponding"},{"line_number":719,"context_line":"            # ironic node assigned."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_51ecc1f2","line":716,"updated":"2020-07-01 09:45:11.000000000","message":"linters: E722 do not use bare \u0027except\u0027","commit_id":"bf8730e5ac14b42fc27531293670b6fb05b433ff"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"8b82464832a363e8f068c7dd3b20a8c4627c963f","unresolved":false,"context_lines":[{"line_number":713,"context_line":"            for port in baremetal_client.port.list(node\u003dbm_node.uuid):"},{"line_number":714,"context_line":"                hostmap[port.address] \u003d {\"compute_name\": node.name,"},{"line_number":715,"context_line":"                                         \"baremetal_name\": bm_node.name}"},{"line_number":716,"context_line":"        except:"},{"line_number":717,"context_line":"            # we didn\u0027t find a bm_node corresponding to the instance"},{"line_number":718,"context_line":"            # probably server is in error state with no corresponding"},{"line_number":719,"context_line":"            # ironic node assigned."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_b1ba7dde","line":716,"updated":"2020-07-01 09:45:11.000000000","message":"pep8: E722 do not use bare \u0027except\u0027","commit_id":"bf8730e5ac14b42fc27531293670b6fb05b433ff"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"189a127c7f81a9b75468a39d34645f9fc05cd9a3","unresolved":false,"context_lines":[{"line_number":716,"context_line":"        except:"},{"line_number":717,"context_line":"            # we didn\u0027t find a bm_node corresponding to the instance"},{"line_number":718,"context_line":"            # probably server is in error state with no corresponding"},{"line_number":719,"context_line":"            # ironic node assigned."},{"line_number":720,"context_line":"            return"},{"line_number":721,"context_line":""},{"line_number":722,"context_line":"    if hostmap \u003d\u003d {}:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_91d5b946","line":719,"range":{"start_line":719,"start_character":12,"end_line":719,"end_character":35},"updated":"2020-07-01 09:29:50.000000000","message":"maybe just add a warning \"node XYZ was in Error state\"?","commit_id":"bf8730e5ac14b42fc27531293670b6fb05b433ff"}]}
