)]}'
{"id":"openstack%2Ftripleo-common~739713","triplet_id":"openstack%2Ftripleo-common~stable%2Ftrain~I397f8d641504ac2ceed36fa975cf97fac5bbb81a","project":"openstack/tripleo-common","branch":"stable/train","hashtags":[],"change_id":"I397f8d641504ac2ceed36fa975cf97fac5bbb81a","subject":"Catch exception if servers are in error state with no bm_node attached","status":"MERGED","created":"2020-07-07 11:14:46.000000000","updated":"2020-07-08 20:45:37.000000000","submitted":"2020-07-08 20:43:17.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"739713-1594240997784-abf989b5","meta_rev_id":"0377a765d63923f75e17d3388485ca9cef6e33cb","_number":739713,"virtual_id_number":739713,"owner":{"_account_id":30126,"name":"Luca Miccini","email":"lmiccini@redhat.com","username":"lmiccini2"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-07-08 20:43:17.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-1,"date":"2020-07-07 12:08:57.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"date":"2020-07-08 06:38:03.000000000","_account_id":30126,"name":"Luca Miccini","email":"lmiccini@redhat.com","username":"lmiccini2"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"all":[{"value":2,"date":"2020-07-08 15:10:09.000000000","_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":30126,"name":"Luca Miccini","email":"lmiccini@redhat.com","username":"lmiccini2"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"all":[{"value":1,"date":"2020-07-08 15:10:09.000000000","_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":30126,"name":"Luca Miccini","email":"lmiccini@redhat.com","username":"lmiccini2"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"_account_id":30126,"name":"Luca Miccini","email":"lmiccini@redhat.com","username":"lmiccini2"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-07-07 12:08:57.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-07-08 15:10:09.000000000","updated_by":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"reviewer":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"state":"REVIEWER"},{"updated":"2020-07-08 20:43:17.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"a9027fb2d2489fcd12cf607e5e6d6833ab4d0f36","author":{"_account_id":30126,"name":"Luca Miccini","email":"lmiccini@redhat.com","username":"lmiccini2"},"date":"2020-07-07 11:14:46.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0dae6b4e8ca0f07dfc685cc745f56544402e1690","author":{"_account_id":30126,"name":"Luca Miccini","email":"lmiccini@redhat.com","username":"lmiccini2"},"date":"2020-07-07 11:20:19.000000000","message":"Patch Set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"91b97ce440549c5e826a078966d8b728289ff1f8","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2020-07-07 12:08:57.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- tripleo-rhel-8-buildimage-overcloud-full-train https://review.rdoproject.org/zuul/build/014aa459f98e4b4ea733f5eed8d0eb73 : RETRY_LIMIT in 5m 13s\n- tripleo-rhel-8-buildimage-ironic-python-agent-train https://review.rdoproject.org/zuul/build/6e90f3846c9c4af2adf27e3ebb8a79b1 : RETRY_LIMIT in 7m 41s (non-voting)\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001-vexxhost https://review.rdoproject.org/zuul/build/ca897f68746243b288f19d159b33af05 : RETRY_LIMIT in 9m 31s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"ed5adeee741cf19ccc640f885406e2532272045b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-07 14:24:00.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/29d963ac54954f3da1c18acaade292e2 : SUCCESS in 6m 20s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/75a6cc9af8ce4f94bd88be9c6889b6c6 : SUCCESS in 5m 02s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/33bc10c26f2443e39aa0e42acf198592 : SUCCESS in 5m 41s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/f9a845b93cd8444f8e145abd648537de : SUCCESS in 6m 21s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/bf01f98dcb0c4bd3a9d5a4405f4b291a : SUCCESS in 6m 24s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f29090ed2a9144448e103a2ce87b084e : SUCCESS in 6m 31s\n- tripleo-ci-centos-7-undercloud-containers https://zuul.opendev.org/t/openstack/build/419de843d431400abc66aee1449a0413 : SUCCESS in 2h 06m 36s\n- tripleo-ci-centos-7-containers-multinode https://zuul.opendev.org/t/openstack/build/3a42c430bbad4dbaa45bac05909a658a : SUCCESS in 2h 50m 14s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades https://zuul.opendev.org/t/openstack/build/330ee56e08664f65b99c83010e1d1936 : SUCCESS in 2h 34m 11s (non-voting)\n- tripleo-ci-centos-7-standalone https://zuul.opendev.org/t/openstack/build/cd60f663919348699e7db62155234d2d : SUCCESS in 1h 55m 40s\n- tripleo-ci-centos-7-standalone-upgrade-train https://zuul.opendev.org/t/openstack/build/297562a675974347a1c7040d3bc015bd : SUCCESS in 2h 23m 45s (non-voting)\n- tripleo-ci-centos-7-containers-undercloud-minion https://zuul.opendev.org/t/openstack/build/8472acc3291f400e9adedda78cfa6d63 : SUCCESS in 2h 12m 49s\n- tripleo-ci-centos-7-containerized-undercloud-upgrades https://zuul.opendev.org/t/openstack/build/f7574a1513464e73913c5b1fafacd73e : FAILURE in 2h 39m 26s (non-voting)\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/420a72e36da84ed8aedbe5162b3151aa : SUCCESS in 5m 04s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/304c8e4553c04b73a1d599b7ffff4870 : SUCCESS in 6m 55s","accounts_in_message":[],"_revision_number":2},{"id":"d3727b45c51d671cecad54c91b37b381878b42d6","author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"date":"2020-07-08 06:37:47.000000000","message":"Patch Set 2:\n\ncheck-rdo","accounts_in_message":[],"_revision_number":2},{"id":"a1ff6832c05581a387cb92c4e62153a75695294b","author":{"_account_id":30126,"name":"Luca Miccini","email":"lmiccini@redhat.com","username":"lmiccini2"},"date":"2020-07-08 06:38:03.000000000","message":"Patch Set 2:\n\ncheck-rdo","accounts_in_message":[],"_revision_number":2},{"id":"529c58382ec60875605e3256c47165dc749262f7","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2020-07-08 10:09:57.000000000","message":"Patch Set 2:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- tripleo-rhel-8-buildimage-overcloud-full-train https://review.rdoproject.org/zuul/build/a06bc050183f41c09abc23726de7eab8 : RETRY_LIMIT in 5m 02s\n- tripleo-rhel-8-buildimage-ironic-python-agent-train https://review.rdoproject.org/zuul/build/5b72454f58584574925055d8cdde43cf : RETRY_LIMIT in 5m 03s (non-voting)\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001-vexxhost https://review.rdoproject.org/zuul/build/f6fac028f721406eaa63989e141890a9 : SUCCESS in 3h 31m 14s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"68cb4a8228adb7b7243a041a8523fa97210dc532","author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"date":"2020-07-08 15:10:09.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"a619f69809c0604d30e40ab6e89b0f896eab640a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-08 15:10:36.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"e893057cbe356c37f97e3ab44f019e9339b7e46a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-08 20:43:17.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"5b387bf317c31c3cea1bd60870d8b629ffc35522","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-08 20:43:17.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0d1e5e99e2634c9ba17ffa5dcfb7151b : SUCCESS in 7m 41s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/7035d7ad8f5c40d087eb681d15eb22bc : SUCCESS in 8m 13s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/182887d6dd1245d09526c70955ff0392 : SUCCESS in 8m 58s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/e66991c2f78c49efbf6f8f920d1a69d6 : SUCCESS in 9m 22s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5a1ae066f18c404eab7cb5b01826feef : SUCCESS in 8m 46s\n- tripleo-ci-centos-7-containers-multinode https://zuul.opendev.org/t/openstack/build/6e58738db56e4987b546464edac30e4f : SUCCESS in 2h 36m 08s\n- tripleo-ci-centos-7-standalone https://zuul.opendev.org/t/openstack/build/296c24354878450581739d06484194fb : SUCCESS in 1h 30m 38s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates https://zuul.opendev.org/t/openstack/build/ef83019599814c9f82890c84ee552036 : SUCCESS in 2h 04m 56s\n- tripleo-ci-centos-7-standalone-upgrade-train https://zuul.opendev.org/t/openstack/build/39a4de1fd7c54da191c707cd3ee8cdda : SUCCESS in 2h 24m 08s (non-voting)\n- tripleo-ci-centos-7-undercloud-containers https://zuul.opendev.org/t/openstack/build/048ddd021e1349f7901239a421001da8 : SUCCESS in 2h 09m 38s\n- tripleo-ci-centos-7-containers-undercloud-minion https://zuul.opendev.org/t/openstack/build/da25db908a644a7795894ae62769ad6a : SUCCESS in 1h 35m 49s\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/cdc6c173096a42b996fa562369576556 : SUCCESS in 6m 03s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/5cbd5522d48b4c77bb52fe7eaf86e7dd : SUCCESS in 8m 19s","accounts_in_message":[],"_revision_number":2},{"id":"0377a765d63923f75e17d3388485ca9cef6e33cb","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-08 20:45:37.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7c288e390a754abaae7aa6f55fdf87ee : SUCCESS in 1m 52s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"8806829a6278386cae9b93b6084891830c83a2c1","revisions":{"1f99e9349ae6b114b0182fc5ad94fa6367b25239":{"kind":"REWORK","_number":1,"created":"2020-07-07 11:14:46.000000000","uploader":{"_account_id":30126,"name":"Luca Miccini","email":"lmiccini@redhat.com","username":"lmiccini2"},"ref":"refs/changes/13/739713/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tripleo-common","ref":"refs/changes/13/739713/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tripleo-common refs/changes/13/739713/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tripleo-common refs/changes/13/739713/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tripleo-common refs/changes/13/739713/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tripleo-common refs/changes/13/739713/1"}}},"commit":{"parents":[{"commit":"0651b0d931b563897529d345f473491616cf0796","subject":"Merge \"Fix the ANSIBLE_LOG_PATH value.\" into stable/train","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-common/commit/0651b0d931b563897529d345f473491616cf0796"}]}],"author":{"name":"Zuul","email":"zuul@review.opendev.org","date":"2020-07-07 10:21:19.000000000","tz":0},"committer":{"name":"Luca Miccini","email":"lmiccini@redhat.com","date":"2020-07-07 11:14:43.000000000","tz":120},"subject":"Catch exception if servers are in error state with no bm_node attached","message":"Catch exception if servers are in error state with no bm_node attached\n\nThere have been reports (rhbz#1851507) where generating the fencing\nparameters fails because of one or more servers in error state, like\nwhen a scale out operation doesn\u0027t go as planned.\n\nThis commit wraps get_by_instance_uuid in a try/except block to prevent\nthis from happening, skipping the node in error state and allowing\nusers to still get a valid fencing config for the remaining servers.\n\nNote: manually cherry picked skipping the unit tests (conflict vs the\nmistral_to_ansible patchset).\n\nChange-Id: I397f8d641504ac2ceed36fa975cf97fac5bbb81a\n(cherry picked from commit 14f72a8f775b17e13a32677c407785c3f371c811)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-common/commit/1f99e9349ae6b114b0182fc5ad94fa6367b25239"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-common/commit/1f99e9349ae6b114b0182fc5ad94fa6367b25239"}]},"branch":"refs/heads/stable/train"},"8806829a6278386cae9b93b6084891830c83a2c1":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2020-07-07 11:20:19.000000000","uploader":{"_account_id":30126,"name":"Luca Miccini","email":"lmiccini@redhat.com","username":"lmiccini2"},"ref":"refs/changes/13/739713/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tripleo-common","ref":"refs/changes/13/739713/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tripleo-common refs/changes/13/739713/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tripleo-common refs/changes/13/739713/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tripleo-common refs/changes/13/739713/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tripleo-common refs/changes/13/739713/2"}}},"commit":{"parents":[{"commit":"0651b0d931b563897529d345f473491616cf0796","subject":"Merge \"Fix the ANSIBLE_LOG_PATH value.\" into stable/train","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-common/commit/0651b0d931b563897529d345f473491616cf0796"}]}],"author":{"name":"Zuul","email":"zuul@review.opendev.org","date":"2020-07-07 10:21:19.000000000","tz":0},"committer":{"name":"Luca Miccini","email":"lmiccini@redhat.com","date":"2020-07-07 11:20:15.000000000","tz":0},"subject":"Catch exception if servers are in error state with no bm_node attached","message":"Catch exception if servers are in error state with no bm_node attached\n\nThere have been reports (rhbz#1851507) where generating the fencing\nparameters fails because of one or more servers in error state, like\nwhen a scale out operation doesn\u0027t go as planned.\n\nThis commit wraps get_by_instance_uuid in a try/except block to prevent\nthis from happening, skipping the node in error state and allowing\nusers to still get a valid fencing config for the remaining servers.\n\nNote: manually cherry picked skipping the unit tests (conflict vs the\nmistral_to_ansible patchset).\n\nChange-Id: I397f8d641504ac2ceed36fa975cf97fac5bbb81a\n(cherry picked from commit 7d2c25319b10daad3d3ef6ba2ff656b10b716beb)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-common/commit/8806829a6278386cae9b93b6084891830c83a2c1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-common/commit/8806829a6278386cae9b93b6084891830c83a2c1"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[],"submit_requirements":[]}