)]}'
{"container-images/tcib/base/frr/frr.yaml":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"bdaeeab171240e649c6c0e7556c9fc46b224ced4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tcib_actions:"},{"line_number":2,"context_line":"- run: bash /usr/local/bin/uid_gid_manage {{ tcib_user }}"},{"line_number":3,"context_line":"- run: dnf install -y {{ tcib_packages[\u0027common\u0027] | join(\u0027 \u0027) }} \u0026\u0026 dnf clean all \u0026\u0026 rm -rf /var/cache/dnf"},{"line_number":4,"context_line":"- run: ln -s /usr/share/openstack-tripleo-common/healthcheck/frr /openstack/healthcheck \u0026\u0026 chmod a+rx /openstack/healthcheck"},{"line_number":5,"context_line":"tcib_packages:"},{"line_number":6,"context_line":"  common:"},{"line_number":7,"context_line":"  - frr"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f621f24_e84377ae","line":4,"range":{"start_line":4,"start_character":49,"end_line":4,"end_character":64},"updated":"2020-11-18 10:12:56.000000000","message":"This health check file is missing.\n\nIt is tricky to check liveness since FRR is comprised of a set of daemons (e.g. zebra, bgpd, staticd, bfdd, etc), so knowing which daemons are enabled and on which port, if any, they are listening to  is relevant.\n\nI would suggest we make the assumption that the watchfrr daemon is always enabled (in fact, it is the only daemon enabled by default), and that it can respawn unresponsive daemons.\n\nWatchfrr is a watchdog program to monitor status of FRR daemons and try to restart them if they are down or unresponsive.  It determines whether a daemon is up based on whether it can connect to the daemon\u0027s vty unix stream socket. It then repeatedly sends echo commands over that socket to determine whether the daemon is responsive.  If the daemon crashes, we will receive an EOF on the socket connection and know immediately that the daemon is down.","commit_id":"c5504d5ffa5f2320280d2f05aac3f35d1b9b9484"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"672bf319f36a3c66696662b7fe6940a629172749","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tcib_actions:"},{"line_number":2,"context_line":"- run: bash /usr/local/bin/uid_gid_manage {{ tcib_user }}"},{"line_number":3,"context_line":"- run: dnf install -y {{ tcib_packages[\u0027common\u0027] | join(\u0027 \u0027) }} \u0026\u0026 dnf clean all \u0026\u0026 rm -rf /var/cache/dnf"},{"line_number":4,"context_line":"- run: ln -s /usr/share/openstack-tripleo-common/healthcheck/frr /openstack/healthcheck \u0026\u0026 chmod a+rx /openstack/healthcheck"},{"line_number":5,"context_line":"tcib_packages:"},{"line_number":6,"context_line":"  common:"},{"line_number":7,"context_line":"  - frr"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f621f24_3fa482b9","line":4,"range":{"start_line":4,"start_character":49,"end_line":4,"end_character":64},"in_reply_to":"1f621f24_9c8164c7","updated":"2020-11-18 12:24:07.000000000","message":"+1. It may not be the most reliable health check but it is a good start! ;)","commit_id":"c5504d5ffa5f2320280d2f05aac3f35d1b9b9484"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"bc4f6233c16b8c018b3e017a1f86fe8f38e1ec58","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tcib_actions:"},{"line_number":2,"context_line":"- run: bash /usr/local/bin/uid_gid_manage {{ tcib_user }}"},{"line_number":3,"context_line":"- run: dnf install -y {{ tcib_packages[\u0027common\u0027] | join(\u0027 \u0027) }} \u0026\u0026 dnf clean all \u0026\u0026 rm -rf /var/cache/dnf"},{"line_number":4,"context_line":"- run: ln -s /usr/share/openstack-tripleo-common/healthcheck/frr /openstack/healthcheck \u0026\u0026 chmod a+rx /openstack/healthcheck"},{"line_number":5,"context_line":"tcib_packages:"},{"line_number":6,"context_line":"  common:"},{"line_number":7,"context_line":"  - frr"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f621f24_9c8164c7","line":4,"range":{"start_line":4,"start_character":49,"end_line":4,"end_character":64},"in_reply_to":"1f621f24_e84377ae","updated":"2020-11-18 11:26:34.000000000","message":"Yeah I was going to look into healthcheck later on once we have a prototype container that works.\n\nShould we then just create a healthcheck that monitors for watchfrr process running and assume it is doing what it can?","commit_id":"c5504d5ffa5f2320280d2f05aac3f35d1b9b9484"}]}