)]}'
{"tripleo_common/inventories.py":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"ea5f63e64a8e6524658d6ee946ed44fc595dda0b","unresolved":true,"context_lines":[{"line_number":58,"context_line":"                inventory[\u0027Undercloud\u0027][\u0027vars\u0027][\u0027plans\u0027] \u003d []"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"            # save the plan for this stack in the plans list"},{"line_number":61,"context_line":"            plan \u003d inv[\u0027Undercloud\u0027][\u0027vars\u0027].get(\u0027plan\u0027, None)"},{"line_number":62,"context_line":"            if plan is not None:"},{"line_number":63,"context_line":"                inventory[\u0027Undercloud\u0027][\u0027vars\u0027][\u0027plans\u0027].append(plan)"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"24d8730b_eed25b25","line":61,"range":{"start_line":61,"start_character":55,"end_line":61,"end_character":61},"updated":"2021-01-19 04:03:37.000000000","message":"Default \u0027None\u0027 not required.","commit_id":"619f664e054466af0d3a1c13956e732a61f6ba71"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"ff794ef4827e2f52c1303f48b7c26ab538cc5b42","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                inventory[\u0027Undercloud\u0027][\u0027vars\u0027][\u0027plans\u0027] \u003d []"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"            # save the plan for this stack in the plans list"},{"line_number":61,"context_line":"            plan \u003d inv[\u0027Undercloud\u0027][\u0027vars\u0027].get(\u0027plan\u0027, None)"},{"line_number":62,"context_line":"            if plan is not None:"},{"line_number":63,"context_line":"                inventory[\u0027Undercloud\u0027][\u0027vars\u0027][\u0027plans\u0027].append(plan)"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"16b0013f_c9d446a2","line":61,"range":{"start_line":61,"start_character":55,"end_line":61,"end_character":61},"in_reply_to":"24d8730b_eed25b25","updated":"2021-01-19 08:18:42.000000000","message":"Done","commit_id":"619f664e054466af0d3a1c13956e732a61f6ba71"}],"tripleo_common/inventory.py":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"cedfea959444a379cd3813dc60e654ce813ff514","unresolved":true,"context_lines":[{"line_number":301,"context_line":"    def _undercloud_inventory(self, ret, dynamic):"},{"line_number":302,"context_line":"        undercloud \u003d ret.setdefault(\u0027Undercloud\u0027, {})"},{"line_number":303,"context_line":"        undercloud.setdefault(\u0027hosts\u0027, self._hosts([\u0027undercloud\u0027], dynamic))"},{"line_number":304,"context_line":"        vars \u003d undercloud.setdefault(\u0027vars\u0027, {})"},{"line_number":305,"context_line":"        vars.setdefault(\u0027ansible_host\u0027, \u0027localhost\u0027)"},{"line_number":306,"context_line":"        vars.setdefault(\u0027ansible_connection\u0027, self.undercloud_connection)"},{"line_number":307,"context_line":"        # see https://github.com/ansible/ansible/issues/41808"}],"source_content_type":"text/x-python","patch_set":4,"id":"f7dd8534_fb52ab2d","line":304,"range":{"start_line":304,"start_character":8,"end_line":304,"end_character":12},"updated":"2020-12-10 20:17:59.000000000","message":"err, this conflicts with builtin vars().","commit_id":"c46815268de44a70e47f56251060fae161113d9b"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"fd5507e5f486922c9c48abdb78dc12023aad64f4","unresolved":true,"context_lines":[{"line_number":356,"context_line":"            # details"},{"line_number":357,"context_line":"            ret.setdefault(\u0027_meta\u0027, {\u0027hostvars\u0027: self.hostvars})"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"        children \u003d set()"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"        self.stack \u003d self._get_stack()"},{"line_number":362,"context_line":"        self.stack_outputs \u003d StackOutputs(self.stack)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f4a136e_37f1c517","line":359,"range":{"start_line":359,"start_character":19,"end_line":359,"end_character":24},"updated":"2020-12-11 15:09:08.000000000","message":"note: sorted() is used where order matters so should be ok to use set instead of list","commit_id":"1ff198d03d761056835aa6b0249e297fc39ada33"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"ea5f63e64a8e6524658d6ee946ed44fc595dda0b","unresolved":true,"context_lines":[{"line_number":154,"context_line":"            stack \u003d self.hclient.stacks.get(self.plan_name)"},{"line_number":155,"context_line":"        except HTTPNotFound:"},{"line_number":156,"context_line":"            LOG.warning("},{"line_number":157,"context_line":"                \"Stack not found: %s. Only the undercloud and neutron data \""},{"line_number":158,"context_line":"                \"will be added to the inventory.\", self.plan_name)"},{"line_number":159,"context_line":"            stack \u003d None"},{"line_number":160,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"ca8f8dc2_e0312adb","line":157,"range":{"start_line":157,"start_character":58,"end_line":157,"end_character":74},"updated":"2021-01-19 04:03:37.000000000","message":"Isn\u0027t this assuming that neutron resources are already provisioned?","commit_id":"619f664e054466af0d3a1c13956e732a61f6ba71"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"ff794ef4827e2f52c1303f48b7c26ab538cc5b42","unresolved":false,"context_lines":[{"line_number":154,"context_line":"            stack \u003d self.hclient.stacks.get(self.plan_name)"},{"line_number":155,"context_line":"        except HTTPNotFound:"},{"line_number":156,"context_line":"            LOG.warning("},{"line_number":157,"context_line":"                \"Stack not found: %s. Only the undercloud and neutron data \""},{"line_number":158,"context_line":"                \"will be added to the inventory.\", self.plan_name)"},{"line_number":159,"context_line":"            stack \u003d None"},{"line_number":160,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"0325d3fc_e6a0a81b","line":157,"range":{"start_line":157,"start_character":58,"end_line":157,"end_character":74},"in_reply_to":"ca8f8dc2_e0312adb","updated":"2021-01-19 08:18:42.000000000","message":"yes, I guess the logging can be made more clear. Also mentioning neutron should not happen before the follow on patch.\nI changed this back to the initial log message here, and will do a better job with the message in the follow-on.","commit_id":"619f664e054466af0d3a1c13956e732a61f6ba71"}],"tripleo_common/tests/test_inventory.py":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"eecc518e9f33404dadf7fb33d9607d39262ca846","unresolved":true,"context_lines":[{"line_number":323,"context_line":"                    \u0027auth_url\u0027: \u0027xyz://keystone.local\u0027,"},{"line_number":324,"context_line":"                    \u0027cacert\u0027: \u0027acacert\u0027,"},{"line_number":325,"context_line":"                    \u0027project_name\u0027: \u0027admin\u0027,"},{"line_number":326,"context_line":"                    \u0027plan\u0027: None,"},{"line_number":327,"context_line":"                    \u0027undercloud_service_list\u0027: ["},{"line_number":328,"context_line":"                        \u0027tripleo_nova_compute\u0027,"},{"line_number":329,"context_line":"                        \u0027tripleo_heat_engine\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"25ae2558_80f2bf8f","side":"PARENT","line":326,"range":{"start_line":326,"start_character":20,"end_line":326,"end_character":33},"updated":"2020-12-10 20:12:48.000000000","message":"Rebased on https://review.opendev.org/c/openstack/tripleo-common/+/765524.\nI opted to only set the plan key if the stack is available instead of setting it to None.","commit_id":"29d5bf69f834e02867c343b95ea0a39a7f7e4288"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"fd5507e5f486922c9c48abdb78dc12023aad64f4","unresolved":true,"context_lines":[{"line_number":323,"context_line":"                    \u0027auth_url\u0027: \u0027xyz://keystone.local\u0027,"},{"line_number":324,"context_line":"                    \u0027cacert\u0027: \u0027acacert\u0027,"},{"line_number":325,"context_line":"                    \u0027project_name\u0027: \u0027admin\u0027,"},{"line_number":326,"context_line":"                    \u0027plan\u0027: None,"},{"line_number":327,"context_line":"                    \u0027undercloud_service_list\u0027: ["},{"line_number":328,"context_line":"                        \u0027tripleo_nova_compute\u0027,"},{"line_number":329,"context_line":"                        \u0027tripleo_heat_engine\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"e2d270ce_c49b8b7a","side":"PARENT","line":326,"range":{"start_line":326,"start_character":20,"end_line":326,"end_character":33},"in_reply_to":"25ae2558_80f2bf8f","updated":"2020-12-11 15:09:08.000000000","message":"+1","commit_id":"29d5bf69f834e02867c343b95ea0a39a7f7e4288"}]}