)]}'
{".pylintrc":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"84e95cb1f089ff04b1bb5d74e24da0880457aaec","unresolved":true,"context_lines":[{"line_number":21,"context_line":"    missing-class-docstring,"},{"line_number":22,"context_line":"    missing-function-docstring,"},{"line_number":23,"context_line":"    missing-module-docstring,"},{"line_number":24,"context_line":"    no-else-break,"},{"line_number":25,"context_line":"    no-else-continue,"},{"line_number":26,"context_line":"    no-else-raise,"},{"line_number":27,"context_line":"    no-else-return,"},{"line_number":28,"context_line":"    no-self-use,"},{"line_number":29,"context_line":"    no-value-for-parameter,"},{"line_number":30,"context_line":"    protected-access,"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"cb25197d_ca7db044","side":"PARENT","line":27,"range":{"start_line":24,"start_character":13,"end_line":27,"end_character":15},"updated":"2021-01-08 07:55:44.000000000","message":"is there any pointer to these rules that explains what they are enforcing please?","commit_id":"bd271527e14231f516c1966e193c4586eb32a142"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"5bb703600e4c9ab2ad0833cd6438a064d1363b30","unresolved":true,"context_lines":[{"line_number":21,"context_line":"    missing-class-docstring,"},{"line_number":22,"context_line":"    missing-function-docstring,"},{"line_number":23,"context_line":"    missing-module-docstring,"},{"line_number":24,"context_line":"    no-else-break,"},{"line_number":25,"context_line":"    no-else-continue,"},{"line_number":26,"context_line":"    no-else-raise,"},{"line_number":27,"context_line":"    no-else-return,"},{"line_number":28,"context_line":"    no-self-use,"},{"line_number":29,"context_line":"    no-value-for-parameter,"},{"line_number":30,"context_line":"    protected-access,"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"f9434301_3e57af83","side":"PARENT","line":27,"range":{"start_line":24,"start_character":13,"end_line":27,"end_character":15},"in_reply_to":"cb25197d_ca7db044","updated":"2021-01-08 10:52:31.000000000","message":"Let me reply with docs: http://pylint.pycqa.org/en/latest/technical_reference/features.html?highlight\u003dR1723#refactoring-checker-messages \n\nWhen it occurs pylint gives a better explanation but that is also available in docs.","commit_id":"bd271527e14231f516c1966e193c4586eb32a142"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"e1af91859f02e267dc39bab4aaf94024af9503ca","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    missing-class-docstring,"},{"line_number":22,"context_line":"    missing-function-docstring,"},{"line_number":23,"context_line":"    missing-module-docstring,"},{"line_number":24,"context_line":"    no-else-break,"},{"line_number":25,"context_line":"    no-else-continue,"},{"line_number":26,"context_line":"    no-else-raise,"},{"line_number":27,"context_line":"    no-else-return,"},{"line_number":28,"context_line":"    no-self-use,"},{"line_number":29,"context_line":"    no-value-for-parameter,"},{"line_number":30,"context_line":"    protected-access,"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"841178df_f78a8656","side":"PARENT","line":27,"range":{"start_line":24,"start_character":13,"end_line":27,"end_character":15},"in_reply_to":"f9434301_3e57af83","updated":"2021-01-14 13:06:02.000000000","message":"Done","commit_id":"bd271527e14231f516c1966e193c4586eb32a142"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c27add45aa47ef80c4c5580dc72c73032dee111f","unresolved":true,"context_lines":[{"line_number":21,"context_line":"    missing-class-docstring,"},{"line_number":22,"context_line":"    missing-function-docstring,"},{"line_number":23,"context_line":"    missing-module-docstring,"},{"line_number":24,"context_line":"    no-else-break,"},{"line_number":25,"context_line":"    no-else-continue,"},{"line_number":26,"context_line":"    no-else-raise,"},{"line_number":27,"context_line":"    no-else-return,"},{"line_number":28,"context_line":"    no-self-use,"},{"line_number":29,"context_line":"    no-value-for-parameter,"},{"line_number":30,"context_line":"    protected-access,"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"8343a828_42d3f4c6","side":"PARENT","line":27,"range":{"start_line":24,"start_character":13,"end_line":27,"end_character":15},"in_reply_to":"f9434301_3e57af83","updated":"2021-01-12 08:28:57.000000000","message":"thank you for pointer yes this is exactly what i had in mind","commit_id":"bd271527e14231f516c1966e193c4586eb32a142"}],"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"339cdfa24109f75183f2bcca41bf44f0aa12ddb0","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2021-01-06 13:44:34 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"pylint: fixed conditions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I0e6bcebca55d89bdfb59944bf91f4f9949c95562"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"8df6b9c8_a8d3578d","line":8,"updated":"2021-01-08 07:56:25.000000000","message":"cool story bro\n\nplease consider adding some words or even pointers to the rules that are being enabled here","commit_id":"7ec11fd475706ffc367ca421bb9e0fa1977d956a"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c27add45aa47ef80c4c5580dc72c73032dee111f","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Sandeep Yadav \u003csandyada@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-01-11 17:14:06 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"pylint: fixed conditions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I0e6bcebca55d89bdfb59944bf91f4f9949c95562"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"91ad003c_253cde0c","line":7,"updated":"2021-01-12 08:28:57.000000000","message":"this is still a very cool story, bro :)\n\nthanks for the link to http://pylint.pycqa.org/en/latest/technical_reference/features.html?highlight\u003dR1723#refactoring-checker-messages\nplease consider including it here and in future commit messages of this series.\nthank you!\n\nbest regards,\nmarios ;)","commit_id":"4db1e72654cf6ae275791620fcacdd94cf443bfe"}],"container-images/kolla/base/set_configs.py":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"84e95cb1f089ff04b1bb5d74e24da0880457aaec","unresolved":true,"context_lines":[{"line_number":398,"context_line":"        else:"},{"line_number":399,"context_line":"            copy_config(config)"},{"line_number":400,"context_line":"            handle_permissions(config)"},{"line_number":401,"context_line":"            os.mknod(\u0027/configured\u0027)"},{"line_number":402,"context_line":"    else:"},{"line_number":403,"context_line":"        raise InvalidConfig(\u0027KOLLA_CONFIG_STRATEGY is not set properly\u0027)"},{"line_number":404,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7d9f7596_ce792ef9","side":"PARENT","line":401,"updated":"2021-01-08 07:55:44.000000000","message":"so what was wrong with this else then i can\u0027t tell by staring","commit_id":"bd271527e14231f516c1966e193c4586eb32a142"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"0a73f2eb271cc7bde127f69220d6e5b7f3b2df21","unresolved":true,"context_lines":[{"line_number":398,"context_line":"        else:"},{"line_number":399,"context_line":"            copy_config(config)"},{"line_number":400,"context_line":"            handle_permissions(config)"},{"line_number":401,"context_line":"            os.mknod(\u0027/configured\u0027)"},{"line_number":402,"context_line":"    else:"},{"line_number":403,"context_line":"        raise InvalidConfig(\u0027KOLLA_CONFIG_STRATEGY is not set properly\u0027)"},{"line_number":404,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"d1bc2074_e642c946","side":"PARENT","line":401,"in_reply_to":"7d9f7596_ce792ef9","updated":"2021-01-09 05:37:54.000000000","message":"@marios \n\nI think else is logically correct here but not neccesary as if condition have raise.\n\ntox -re linters gives below error with unneccesary else\n~~~\ncontainer-images/kolla/base/set_configs.py:394:8: R1720: Unnecessary \"else\" after \"raise\" (no-else-raise)\n~~~","commit_id":"bd271527e14231f516c1966e193c4586eb32a142"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c27add45aa47ef80c4c5580dc72c73032dee111f","unresolved":true,"context_lines":[{"line_number":398,"context_line":"        else:"},{"line_number":399,"context_line":"            copy_config(config)"},{"line_number":400,"context_line":"            handle_permissions(config)"},{"line_number":401,"context_line":"            os.mknod(\u0027/configured\u0027)"},{"line_number":402,"context_line":"    else:"},{"line_number":403,"context_line":"        raise InvalidConfig(\u0027KOLLA_CONFIG_STRATEGY is not set properly\u0027)"},{"line_number":404,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"d4b4c7fb_723550ac","side":"PARENT","line":401,"in_reply_to":"d1bc2074_e642c946","updated":"2021-01-12 08:28:57.000000000","message":"thank you sandeep that makes sense","commit_id":"bd271527e14231f516c1966e193c4586eb32a142"}],"tripleo_common/image/image_uploader.py":[{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"6788ab0343dfc4333a627378b1d0bc6dc4a70d52","unresolved":true,"context_lines":[{"line_number":2241,"context_line":"                layer_found \u003d x"},{"line_number":2242,"context_line":"                break"},{"line_number":2243,"context_line":"            parts[\u0027digest\u0027] \u003d x[\u0027digest\u0027]"},{"line_number":2244,"context_line":"            blob_url \u003d cls._build_url("},{"line_number":2245,"context_line":"                target_url, CALL_BLOB % parts)"},{"line_number":2246,"context_line":"            if session.head(blob_url, timeout\u003d30).status_code \u003d\u003d 200:"},{"line_number":2247,"context_line":"                LOG.debug(\u0027[%s] Layer already exists: %s\u0027 %"},{"line_number":2248,"context_line":"                            (image, x[\u0027digest\u0027]))"}],"source_content_type":"text/x-python","patch_set":2,"id":"65e61b71_8e2ba688","line":2245,"range":{"start_line":2244,"start_character":0,"end_line":2245,"end_character":46},"updated":"2021-01-09 05:18:16.000000000","message":"With else condition removed, I think we can move this in one line now\n~~~\nblob_url \u003d cls._build_url(target_url, CALL_BLOB % parts)\n~~~","commit_id":"7ec11fd475706ffc367ca421bb9e0fa1977d956a"}]}