)]}'
{"tripleo_common/inventory.py":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"45bd9d35d775f98bacf0eb35da3457d95b3710c1","unresolved":true,"context_lines":[{"line_number":145,"context_line":"            dns_domain \u003d self.networks_by_id[network_id][\u0027dns_domain\u0027]"},{"line_number":146,"context_line":"            dns_nameservers \u003d self.subnets_by_id[subnet_id][\u0027dns_nameservers\u0027]"},{"line_number":147,"context_line":"            mtu \u003d self.networks_by_id[network_id][\u0027mtu\u0027]"},{"line_number":148,"context_line":"            net_name \u003d self.networks_by_id[network_id][\u0027name\u0027]"},{"line_number":149,"context_line":"            ip_address \u003d port.fixed_ips[0].get(\u0027ip_address\u0027)"},{"line_number":150,"context_line":"            gateway_ip \u003d self.subnets_by_id[subnet_id][\u0027gateway_ip\u0027]"},{"line_number":151,"context_line":"            host_routes \u003d copy.deepcopy("}],"source_content_type":"text/x-python","patch_set":7,"id":"533b6dde_2a3c167d","line":148,"range":{"start_line":148,"start_character":23,"end_line":148,"end_character":42},"updated":"2021-03-08 15:28:06.000000000","message":"maybe we can define this as an object given its used a few times.","commit_id":"7f0c4afb5c52106c6afea18ea59860bd368b7eef"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"b1c6760773abe65cab094132f945674e181bc033","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            dns_domain \u003d self.networks_by_id[network_id][\u0027dns_domain\u0027]"},{"line_number":146,"context_line":"            dns_nameservers \u003d self.subnets_by_id[subnet_id][\u0027dns_nameservers\u0027]"},{"line_number":147,"context_line":"            mtu \u003d self.networks_by_id[network_id][\u0027mtu\u0027]"},{"line_number":148,"context_line":"            net_name \u003d self.networks_by_id[network_id][\u0027name\u0027]"},{"line_number":149,"context_line":"            ip_address \u003d port.fixed_ips[0].get(\u0027ip_address\u0027)"},{"line_number":150,"context_line":"            gateway_ip \u003d self.subnets_by_id[subnet_id][\u0027gateway_ip\u0027]"},{"line_number":151,"context_line":"            host_routes \u003d copy.deepcopy("}],"source_content_type":"text/x-python","patch_set":7,"id":"ef42b255_16f8a2c3","line":148,"range":{"start_line":148,"start_character":23,"end_line":148,"end_character":42},"in_reply_to":"533b6dde_2a3c167d","updated":"2021-03-09 15:26:01.000000000","message":"Done","commit_id":"7f0c4afb5c52106c6afea18ea59860bd368b7eef"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"45bd9d35d775f98bacf0eb35da3457d95b3710c1","unresolved":true,"context_lines":[{"line_number":146,"context_line":"            dns_nameservers \u003d self.subnets_by_id[subnet_id][\u0027dns_nameservers\u0027]"},{"line_number":147,"context_line":"            mtu \u003d self.networks_by_id[network_id][\u0027mtu\u0027]"},{"line_number":148,"context_line":"            net_name \u003d self.networks_by_id[network_id][\u0027name\u0027]"},{"line_number":149,"context_line":"            ip_address \u003d port.fixed_ips[0].get(\u0027ip_address\u0027)"},{"line_number":150,"context_line":"            gateway_ip \u003d self.subnets_by_id[subnet_id][\u0027gateway_ip\u0027]"},{"line_number":151,"context_line":"            host_routes \u003d copy.deepcopy("},{"line_number":152,"context_line":"                self.subnets_by_id[subnet_id][\u0027host_routes\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"05e72c5d_e8543ecb","line":149,"range":{"start_line":149,"start_character":25,"end_line":149,"end_character":42},"updated":"2021-03-08 15:28:06.000000000","message":"maybe we can define this as an object given its used a few times.","commit_id":"7f0c4afb5c52106c6afea18ea59860bd368b7eef"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"b1c6760773abe65cab094132f945674e181bc033","unresolved":false,"context_lines":[{"line_number":146,"context_line":"            dns_nameservers \u003d self.subnets_by_id[subnet_id][\u0027dns_nameservers\u0027]"},{"line_number":147,"context_line":"            mtu \u003d self.networks_by_id[network_id][\u0027mtu\u0027]"},{"line_number":148,"context_line":"            net_name \u003d self.networks_by_id[network_id][\u0027name\u0027]"},{"line_number":149,"context_line":"            ip_address \u003d port.fixed_ips[0].get(\u0027ip_address\u0027)"},{"line_number":150,"context_line":"            gateway_ip \u003d self.subnets_by_id[subnet_id][\u0027gateway_ip\u0027]"},{"line_number":151,"context_line":"            host_routes \u003d copy.deepcopy("},{"line_number":152,"context_line":"                self.subnets_by_id[subnet_id][\u0027host_routes\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"24c660a7_7d246d52","line":149,"range":{"start_line":149,"start_character":25,"end_line":149,"end_character":42},"in_reply_to":"05e72c5d_e8543ecb","updated":"2021-03-09 15:26:01.000000000","message":"Done","commit_id":"7f0c4afb5c52106c6afea18ea59860bd368b7eef"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"45bd9d35d775f98bacf0eb35da3457d95b3710c1","unresolved":true,"context_lines":[{"line_number":148,"context_line":"            net_name \u003d self.networks_by_id[network_id][\u0027name\u0027]"},{"line_number":149,"context_line":"            ip_address \u003d port.fixed_ips[0].get(\u0027ip_address\u0027)"},{"line_number":150,"context_line":"            gateway_ip \u003d self.subnets_by_id[subnet_id][\u0027gateway_ip\u0027]"},{"line_number":151,"context_line":"            host_routes \u003d copy.deepcopy("},{"line_number":152,"context_line":"                self.subnets_by_id[subnet_id][\u0027host_routes\u0027])"},{"line_number":153,"context_line":"            # If this is the default route network, add a default route using"},{"line_number":154,"context_line":"            # gateway_ip to the host_routes unless it\u0027s already present"},{"line_number":155,"context_line":"            if tags.get(\u0027tripleo_default_route\u0027):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1d7aa3e4_55e643e4","line":152,"range":{"start_line":151,"start_character":0,"end_line":152,"end_character":61},"updated":"2021-03-08 15:28:06.000000000","message":"why the deep copy?","commit_id":"7f0c4afb5c52106c6afea18ea59860bd368b7eef"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"b1c6760773abe65cab094132f945674e181bc033","unresolved":true,"context_lines":[{"line_number":148,"context_line":"            net_name \u003d self.networks_by_id[network_id][\u0027name\u0027]"},{"line_number":149,"context_line":"            ip_address \u003d port.fixed_ips[0].get(\u0027ip_address\u0027)"},{"line_number":150,"context_line":"            gateway_ip \u003d self.subnets_by_id[subnet_id][\u0027gateway_ip\u0027]"},{"line_number":151,"context_line":"            host_routes \u003d copy.deepcopy("},{"line_number":152,"context_line":"                self.subnets_by_id[subnet_id][\u0027host_routes\u0027])"},{"line_number":153,"context_line":"            # If this is the default route network, add a default route using"},{"line_number":154,"context_line":"            # gateway_ip to the host_routes unless it\u0027s already present"},{"line_number":155,"context_line":"            if tags.get(\u0027tripleo_default_route\u0027):"}],"source_content_type":"text/x-python","patch_set":7,"id":"2b3b7d55_935ed170","line":152,"range":{"start_line":151,"start_character":0,"end_line":152,"end_character":61},"in_reply_to":"1d7aa3e4_55e643e4","updated":"2021-03-09 15:26:01.000000000","message":"If we don\u0027t copy it here, the default set at L156 would be added to self.subnets_by_id[subnet_id][\u0027host_routes\u0027]. Upon the next node which may have the default route on a different network it would end up with duplicate {\u0027default\u0027: True, \u0027nexthop\u0027: gateway_ip} entries.\n\nI added a code comment as well.","commit_id":"7f0c4afb5c52106c6afea18ea59860bd368b7eef"}]}