)]}'
{"roles/tripleo-bootstrap/tasks/main.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"41b90adc0ef4b98c52dcdc24e9b338e596962a72","unresolved":true,"context_lines":[{"line_number":11,"context_line":"    rpm -q {{ item }}"},{"line_number":12,"context_line":"  with_items: \"{{ packages_bootstrap }}\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- name: Populate service facts"},{"line_number":15,"context_line":"  service_facts:"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- name: Stop NetworkManager from updating resolv.conf"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"44d80f3e_16bea721","line":14,"updated":"2021-02-17 06:32:58.000000000","message":"this one a nit?\n\ni don\u0027t see it in any of the other branches https://review.opendev.org/q/6881079d12a9fb2cf752a5f56116c1b4d3a7b75d \n\n\nwhy are we setting service_facts:  (null?)","commit_id":"b7885f0dd6c85823559d8b3000bb7cb7546813aa"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"253560a009545372bfebbcc166c69ef78d14f1b0","unresolved":true,"context_lines":[{"line_number":11,"context_line":"    rpm -q {{ item }}"},{"line_number":12,"context_line":"  with_items: \"{{ packages_bootstrap }}\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- name: Populate service facts"},{"line_number":15,"context_line":"  service_facts:"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- name: Stop NetworkManager from updating resolv.conf"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"af2c6bdf_e1d1bbe6","line":14,"in_reply_to":"2ac55e17_06a47a44","updated":"2021-02-17 06:45:41.000000000","message":"thanks for checking\n\n08:42 \u003c ramishra\u003e marios: replied, some rdo jobs with centos7, there is no NetworkManager, so we need to do the \n                  additional check..\n08:42 \u003c ramishra\u003e and that\u0027s how we collect those facts...not a nit...\n08:43 \u003c ramishra\u003e https://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/playbooks/rotate-keys.yaml#L26-L27\n08:44 \u003c marios\u003e ramishra: hmm thanks haven\u0027t seen that before but it is a thing apparently \"needed to make yaml \n                happy\" \nhttps://opendev.org/openstack/tripleo-heat-templates/src/commit/8d612ea015c0fc60b0756c5d395aa4a1653e6130/deployment/nova/nova-compute-container-puppet.yaml#L1423 :/\n08:44 \u003c marios\u003e weird\n08:44 \u003c marios\u003e https://opendev.org/openstack/tripleo-heat-templates/src/commit/8d612ea015c0fc60b0756c5d395aa4a1653e6130/deployment/timesync/chrony-baremetal-ansible.yaml#L107\n08:44 \u003c marios\u003e https://opendev.org/openstack/tripleo-heat-templates/src/commit/8d612ea015c0fc60b0756c5d395aa4a1653e6130/common/deploy-steps-tasks-step-0.j2.yaml#L11 \n08:44 \u003c marios\u003e k","commit_id":"b7885f0dd6c85823559d8b3000bb7cb7546813aa"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"4b0cc803ec54de21d969b5b3b33cda3e50b40e31","unresolved":true,"context_lines":[{"line_number":11,"context_line":"    rpm -q {{ item }}"},{"line_number":12,"context_line":"  with_items: \"{{ packages_bootstrap }}\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- name: Populate service facts"},{"line_number":15,"context_line":"  service_facts:"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- name: Stop NetworkManager from updating resolv.conf"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"2ac55e17_06a47a44","line":14,"in_reply_to":"44d80f3e_16bea721","updated":"2021-02-17 06:41:10.000000000","message":"Nope we just collect the service_facts with that.\n\nIt was not required in other branches as we don\u0027t need to check if the service exists or not. It was failing in the gate[1] so I added it for this branch.\n\n\"Could not find the requested service NetworkManager\"\n\n[1] https://logserver.rdoproject.org/55/775555/2/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001/82292ad/logs/undercloud/home/zuul/overcloud_deploy.log.txt.gz","commit_id":"b7885f0dd6c85823559d8b3000bb7cb7546813aa"}]}