)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"bfb5a7a783ce912b1e0792d081f512c2242c33dc","unresolved":true,"context_lines":[{"line_number":11,"context_line":"sysfsutils and systool shoudl nolonger be used in nova directly"},{"line_number":12,"context_line":"as a result this depency shoudl nolonger be required."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"sysfsutils is going away in centos 9 which will be the basis of"},{"line_number":15,"context_line":"so we should remove it from the package list in the"},{"line_number":16,"context_line":"nova-compute container."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"a8b194c6_50819f96","line":14,"range":{"start_line":14,"start_character":28,"end_line":14,"end_character":36},"updated":"2022-08-01 07:41:26.000000000","message":"but what about centos 8 - do we still need this there?\n\nthere is no c8 container build running in this review","commit_id":"9229811de0f938d5835583d95599cf1ea329224d"},{"author":{"_account_id":15895,"name":"Adriano Petrich","email":"apetrich@redhat.com","username":"apetrich"},"change_message_id":"d65f93b658218f5c863c3e5f2f5715d1320b00f4","unresolved":false,"context_lines":[{"line_number":11,"context_line":"sysfsutils and systool shoudl nolonger be used in nova directly"},{"line_number":12,"context_line":"as a result this depency shoudl nolonger be required."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"sysfsutils is going away in centos 9 which will be the basis of"},{"line_number":15,"context_line":"so we should remove it from the package list in the"},{"line_number":16,"context_line":"nova-compute container."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"2d1c9def_7a08c3ef","line":14,"range":{"start_line":14,"start_character":28,"end_line":14,"end_character":36},"in_reply_to":"a8b194c6_50819f96","updated":"2022-08-10 11:04:01.000000000","message":"Done, used Cedrics idea.","commit_id":"9229811de0f938d5835583d95599cf1ea329224d"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"9cf822941ed6f89700a4c1b46ec38590167c98d3","unresolved":true,"context_lines":[{"line_number":11,"context_line":"sysfsutils and systool shoudl nolonger be used in nova directly"},{"line_number":12,"context_line":"as a result this depency shoudl nolonger be required."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"sysfsutils is going away in centos 9 which will be the basis of"},{"line_number":15,"context_line":"so we should remove it from the package list in the"},{"line_number":16,"context_line":"nova-compute container."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"direct usage of sysfsutils/systool was removed a while ago but it is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a369d25_32bb0923","line":15,"range":{"start_line":14,"start_character":43,"end_line":15,"end_character":2},"updated":"2022-08-01 01:06:36.000000000","message":"basis of ?  Did you mean base OS?","commit_id":"9229811de0f938d5835583d95599cf1ea329224d"},{"author":{"_account_id":15895,"name":"Adriano Petrich","email":"apetrich@redhat.com","username":"apetrich"},"change_message_id":"d65f93b658218f5c863c3e5f2f5715d1320b00f4","unresolved":false,"context_lines":[{"line_number":11,"context_line":"sysfsutils and systool shoudl nolonger be used in nova directly"},{"line_number":12,"context_line":"as a result this depency shoudl nolonger be required."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"sysfsutils is going away in centos 9 which will be the basis of"},{"line_number":15,"context_line":"so we should remove it from the package list in the"},{"line_number":16,"context_line":"nova-compute container."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"direct usage of sysfsutils/systool was removed a while ago but it is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"2aa7ef76_e0e22a3d","line":15,"range":{"start_line":14,"start_character":43,"end_line":15,"end_character":2},"in_reply_to":"7a369d25_32bb0923","updated":"2022-08-10 11:04:01.000000000","message":"Done","commit_id":"9229811de0f938d5835583d95599cf1ea329224d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16282,"name":"YaZug","email":"jschluet@redhat.com","username":"yazug"},"change_message_id":"fd2ad9af8c379161d6c338d697df8dd6faa12d22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3f93c4c1_d5843b8b","updated":"2022-06-23 21:33:30.000000000","message":"This patch should be able to be merged because usage in os-brick already brings it in with a Requires there.  It should not be required to be blocked on os-brick change getting through.","commit_id":"68bbedae86a7c676d7e553cfd074620858dea832"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"9cf822941ed6f89700a4c1b46ec38590167c98d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"045907f3_8a33ecad","updated":"2022-08-01 01:06:36.000000000","message":"Thanks, just clarifying your commit message. But looks good otherwise.","commit_id":"9229811de0f938d5835583d95599cf1ea329224d"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"bb20c1f0ff989212870d9d0ab84d4e8f9fb887fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9bfea4ac_0beae455","updated":"2022-07-01 12:55:49.000000000","message":"it seems like the rhel team decided not to remove it.","commit_id":"9229811de0f938d5835583d95599cf1ea329224d"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"bd91c22a02ce9a72c67b09b71d4407979eb64271","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0be331aa_40c03d31","updated":"2022-08-09 21:47:21.000000000","message":"let\u0027s -1 this. too many concerns. we need a response from Adriano.","commit_id":"9229811de0f938d5835583d95599cf1ea329224d"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"a61329beec7e7f1eeb1e2891581cb64bfc252342","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1c910854_e5752365","updated":"2022-08-03 12:52:36.000000000","message":"ok, it seems that multi-os versions support (cs8 and cs9 builds in master branch) makes this change not so obvious to implement","commit_id":"9229811de0f938d5835583d95599cf1ea329224d"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"bfb5a7a783ce912b1e0792d081f512c2242c33dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c120c1d6_aff3ab49","updated":"2022-08-01 07:41:26.000000000","message":"sanity check please would be good to test this with c8 build if we don\u0027t already know for sure we don\u0027t need it","commit_id":"9229811de0f938d5835583d95599cf1ea329224d"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"7f4db59fb2c576c8e6d7d13f0226d65af7da7ea2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"472ac6f4_0fad14cc","updated":"2022-08-03 12:56:51.000000000","message":"see also ongoing discussions there https://review.opendev.org/c/openstack/tripleo-heat-templates/+/848208","commit_id":"9229811de0f938d5835583d95599cf1ea329224d"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"0a96420f8d2f8a51f9c48b3822bf0469018fa058","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"673dc647_f2568f1f","updated":"2022-08-10 11:33:41.000000000","message":"Wondering how we get cs9 containers if that package is removed... Is it still provided by delorean?","commit_id":"def937575a0f46a9195bf01246ba3383bd41e138"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"880de0f042ea8908946ac76887145158c6fa0e2d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"78bc1478_242ac65d","updated":"2022-08-16 14:48:53.000000000","message":"recheck\n\n\n2022-08-16 13:32:15.866668 | fa163ef0-10c9-335b-659a-000000001cb7 |      FATAL | Pre-fetch all the containers | standalone | item\u003d173.231.255.104:5001/tripleomastercentos9/openstack-horizon:120b06809f1abde369d06cef81ded6ab | error\u003d{\"ansible_loop_var\": \"prefetch_image\", \"attempts\": 5, \"changed\": false, \"msg\": \"Failed to pull image 173.231.255.104:5001/tripleomastercentos9/openstack-horizon:120b06809f1abde369d06cef81ded6ab\", \"prefetch_image\": \"173.231.255.104:5001/tripleomastercentos9/openstack-horizon:120b06809f1abde369d06cef81ded6ab\"}","commit_id":"def937575a0f46a9195bf01246ba3383bd41e138"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"8a59beb3b91665716c46e0677a46240daced6352","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2947998a_e009d558","updated":"2022-08-12 13:59:58.000000000","message":"recheck fips","commit_id":"def937575a0f46a9195bf01246ba3383bd41e138"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2353a3921ccc62de08dc879beeae7596e84867f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"71421255_16663cd5","in_reply_to":"673dc647_f2568f1f","updated":"2022-08-11 08:05:18.000000000","message":"we have c9 containers built in this patch via the content provider \n\nhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_10e/790070/3/check/tripleo-ci-centos-9-content-provider/10e8374/logs/container-builds/9bf62bff-4439-4739-8943-f0318fd23038/base/os/nova-base/nova-compute/nova-compute-build.log","commit_id":"def937575a0f46a9195bf01246ba3383bd41e138"}],"container-images/tcib/base/os/nova-base/nova-compute/nova-compute.yaml":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"090bf06a31e306493aa66c10727d182b22770e0e","unresolved":true,"context_lines":[{"line_number":24,"context_line":"  - python3-libguestfs"},{"line_number":25,"context_line":"  - python3-oslo-vmware"},{"line_number":26,"context_line":"  - python3-rtslib"},{"line_number":27,"context_line":"  - sysfsutils"},{"line_number":28,"context_line":"  - swtpm"},{"line_number":29,"context_line":"  - swtpm-tools"},{"line_number":30,"context_line":"  - targetcli"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"4a194414_28562400","side":"PARENT","line":27,"updated":"2022-08-10 07:47:25.000000000","message":"I\u0027d move this to the \"el8\" section bellow so that we don\u0027t risk anything with older releases. WDYT?\n\nThat would also address Marios\u0027 concern.","commit_id":"8a5555d7fc0e91cc531134bbd55fb15816ec3fcd"},{"author":{"_account_id":15895,"name":"Adriano Petrich","email":"apetrich@redhat.com","username":"apetrich"},"change_message_id":"d65f93b658218f5c863c3e5f2f5715d1320b00f4","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  - python3-libguestfs"},{"line_number":25,"context_line":"  - python3-oslo-vmware"},{"line_number":26,"context_line":"  - python3-rtslib"},{"line_number":27,"context_line":"  - sysfsutils"},{"line_number":28,"context_line":"  - swtpm"},{"line_number":29,"context_line":"  - swtpm-tools"},{"line_number":30,"context_line":"  - targetcli"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fba288b7_fa6c1dd0","side":"PARENT","line":27,"in_reply_to":"4a194414_28562400","updated":"2022-08-10 11:04:01.000000000","message":"Done. Great catch.","commit_id":"8a5555d7fc0e91cc531134bbd55fb15816ec3fcd"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2353a3921ccc62de08dc879beeae7596e84867f5","unresolved":true,"context_lines":[{"line_number":27,"context_line":"  - swtpm"},{"line_number":28,"context_line":"  - swtpm-tools"},{"line_number":29,"context_line":"  - targetcli"},{"line_number":30,"context_line":"  - xfsprogs"},{"line_number":31,"context_line":"  x86_64:"},{"line_number":32,"context_line":"  - daxio"},{"line_number":33,"context_line":"  el8:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"0ef5b49b_454a4bc7","line":30,"updated":"2022-08-11 08:05:18.000000000","message":"resulting dockerfile looks OK@ \n\nhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_10e/790070/3/check/tripleo-ci-centos-9-content-provider/10e8374/logs/container-builds/9bf62bff-4439-4739-8943-f0318fd23038/base/os/nova-base/nova-compute/Dockerfile\n\n\nRUN if [ \u00279\u0027 \u003d\u003d \u00278\u0027 ]; then dnf -y install sysfsutils trousers; fi\n\nRUN dnf -y install ceph-common device-mapper-multipath e2fsprogs xorriso iscsi-initiator-utils ndctl nfs-utils nvme-cli openssh-server openstack-nova-compute openstack-nova-migration openvswitch parted python3-libguestfs python3-oslo-vmware python3-rtslib swtpm swtpm-tools targetcli xfsprogs \u0026\u0026 dnf clean all \u0026\u0026 rm -rf /var/cache/dnf","commit_id":"def937575a0f46a9195bf01246ba3383bd41e138"}]}