)]}'
{"tripleo_common/inventory.py":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"a64be10b37619706d99add522ad6f2839e08dc42","unresolved":true,"context_lines":[{"line_number":133,"context_line":"        ports_by_role_and_host \u003d {}"},{"line_number":134,"context_line":"        for port in self.ports:"},{"line_number":135,"context_line":"            # Ignore ports in networks we ignore, i.e the OVN Bridge MAC net"},{"line_number":136,"context_line":"            if port.network_id not in self.networks_by_id:"},{"line_number":137,"context_line":"                continue"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"            tags \u003d self._tags_to_dict(port.tags)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5bfdfce4_6d033041","line":136,"range":{"start_line":136,"start_character":12,"end_line":136,"end_character":58},"updated":"2021-05-18 03:37:25.000000000","message":"same here, if we set the mandatory tags for the neutron resources when creating, we could avoid this.","commit_id":"14441478f944d0e07d107191d59fbb9024ced512"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"c5c54b965521fd207ba0301790ac3243a18305a9","unresolved":true,"context_lines":[{"line_number":133,"context_line":"        ports_by_role_and_host \u003d {}"},{"line_number":134,"context_line":"        for port in self.ports:"},{"line_number":135,"context_line":"            # Ignore ports in networks we ignore, i.e the OVN Bridge MAC net"},{"line_number":136,"context_line":"            if port.network_id not in self.networks_by_id:"},{"line_number":137,"context_line":"                continue"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"            tags \u003d self._tags_to_dict(port.tags)"}],"source_content_type":"text/x-python","patch_set":6,"id":"b64fc0a3_6fd4bad5","line":136,"range":{"start_line":136,"start_character":12,"end_line":136,"end_character":58},"in_reply_to":"5bfdfce4_6d033041","updated":"2021-05-18 06:03:12.000000000","message":"And then we would index error at L148 instead, since the ports in the OVN Bridge MAC net does not have an IP allocation.\nWe need something here to special case this network and it\u0027s ports.","commit_id":"14441478f944d0e07d107191d59fbb9024ced512"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"5307259fac6630bb04fc67257dc94ba17e22f1ce","unresolved":true,"context_lines":[{"line_number":133,"context_line":"        ports_by_role_and_host \u003d {}"},{"line_number":134,"context_line":"        for port in self.ports:"},{"line_number":135,"context_line":"            # Ignore ports in networks we ignore, i.e the OVN Bridge MAC net"},{"line_number":136,"context_line":"            if port.network_id not in self.networks_by_id:"},{"line_number":137,"context_line":"                continue"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"            tags \u003d self._tags_to_dict(port.tags)"}],"source_content_type":"text/x-python","patch_set":6,"id":"c3bde5f6_0b747b16","line":136,"range":{"start_line":136,"start_character":12,"end_line":136,"end_character":58},"in_reply_to":"b64fc0a3_6fd4bad5","updated":"2021-05-18 06:22:14.000000000","message":"I thought inventory should have details of all neutron resources and we could change L148. But anyway.","commit_id":"14441478f944d0e07d107191d59fbb9024ced512"}]}
