)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a1d36c93a791c568bffbf1ca60627e2a1c622fc0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"2da7ba2c_1b912240","updated":"2021-11-01 14:37:29.000000000","message":"recheck","commit_id":"aff83d34c620b68a51510f36cefcabd0fc88245a"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"f711c5482e56e7cae4a8f2162a7b2f5f7db7c19d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"dc5bf0da_0aee7afb","updated":"2021-11-12 11:50:22.000000000","message":"Thanks!","commit_id":"a9a5f43e29fb684d39f13ef29ad6897374f9226d"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"74933f0205438dbfb05789fac7c16ae35b870397","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"66bd7f8b_4c4d8348","updated":"2021-11-17 07:37:59.000000000","message":"directord_server[1] seems empty. May be the patch dependencies are not proper?\n\n[1] \nhttps://logserver.rdoproject.org/21/798721/21/openstack-check/tripleo-ci-centos-8-ovb-3ctlr_1comp-featureset001/0f64cdc/logs/undercloud/home/zuul/config-download/overcloud/task_core/directord-inventory.yaml.txt.gz","commit_id":"a9a5f43e29fb684d39f13ef29ad6897374f9226d"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"658dfd48201b0662004869513aa8c8bd2ebfbfad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"a86154cc_1cf6e181","updated":"2021-11-15 08:08:39.000000000","message":"thanks, minor diff since my last vote (https://review.opendev.org/c/openstack/tripleo-common/+/798721/21..22) - re-adding vote and upgrading it ","commit_id":"a9a5f43e29fb684d39f13ef29ad6897374f9226d"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"76e7cdc38e4e455a65bfe9db59c1223f94dca607","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"54c35733_b73f4fc5","in_reply_to":"4338296d_cbd94d91","updated":"2021-11-19 03:46:28.000000000","message":"Yeah, I\u0027m sure I know the dependency issues:) As we\u0027re building tripleoclient/tripleo-common from source in CI it\u0027s better to have the dependencies correct (atleast for reviewers if we care). I was looking around to find out where \u0027DeployHost\u0027 parameter is coming from.","commit_id":"a9a5f43e29fb684d39f13ef29ad6897374f9226d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"25d4ee3796288b16531d81886a9700fd9cfdc32c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"fa69873a_59b70a48","in_reply_to":"66bd7f8b_4c4d8348","updated":"2021-11-17 14:46:07.000000000","message":"It\u0027s empty until the dependent tripleoclient patch that provides this information","commit_id":"a9a5f43e29fb684d39f13ef29ad6897374f9226d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"4f8d8ff0fef37a555fdf35a98cd60a6faa34b288","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"4338296d_cbd94d91","in_reply_to":"7bb114ec_a7688771","updated":"2021-11-18 14:50:13.000000000","message":"because the tripleo-common/client relationship is difficult. And this is just file generation. While I could flip the depends on, it doesn\u0027t rellay matter because this output is not leveraged until the client items land which need the files to be generated first.  We need to rev tripleo-common and release it before landing the client code.","commit_id":"a9a5f43e29fb684d39f13ef29ad6897374f9226d"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"4a20bd19bff09b67e3207fce88d2556fc53c091d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"7bb114ec_a7688771","in_reply_to":"c6bb89b1_7e8f5f43","updated":"2021-11-18 04:05:23.000000000","message":"Yeah I was asking exactly that. Why this one does not have a Depends-On for https://review.opendev.org/c/openstack/python-tripleoclient/+/814492?","commit_id":"a9a5f43e29fb684d39f13ef29ad6897374f9226d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"b9f8a9e00c689710036dccd8705fedeb05ce3f96","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"c6bb89b1_7e8f5f43","in_reply_to":"fa69873a_59b70a48","updated":"2021-11-17 14:46:30.000000000","message":"specifically https://review.opendev.org/c/openstack/python-tripleoclient/+/814492","commit_id":"a9a5f43e29fb684d39f13ef29ad6897374f9226d"}],"tripleo_common/inventory.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"6ec353bb84790d83787c35dc47f7bf6f63eaee83","unresolved":true,"context_lines":[{"line_number":840,"context_line":"        shortnames \u003d [n.split(\".%s.\" % host_network)[0].lower()"},{"line_number":841,"context_line":"                      for n in names]"},{"line_number":842,"context_line":"        for name in shortnames:"},{"line_number":843,"context_line":"            if inv[\u0027hosts\u0027].get(\u0027name\u0027):"},{"line_number":844,"context_line":"                LOG.warning(\"task-core inventory already containers %s, \""},{"line_number":845,"context_line":"                            \"overriding it\", inv[\u0027hosts\u0027].get(\u0027name\u0027))"},{"line_number":846,"context_line":"            inv[\u0027hosts\u0027][name] \u003d {\u0027role\u0027: role_name.lower()}"}],"source_content_type":"text/x-python","patch_set":21,"id":"480af265_cef2554d","line":843,"range":{"start_line":843,"start_character":31,"end_line":843,"end_character":39},"updated":"2021-11-08 18:51:23.000000000","message":"shouldn\u0027t be inv[\u0027hosts\u0027].get(name)?","commit_id":"aff83d34c620b68a51510f36cefcabd0fc88245a"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"1926f31165cbaaf842f02ec05bdc46c3741c53b6","unresolved":true,"context_lines":[{"line_number":840,"context_line":"        shortnames \u003d [n.split(\".%s.\" % host_network)[0].lower()"},{"line_number":841,"context_line":"                      for n in names]"},{"line_number":842,"context_line":"        for name in shortnames:"},{"line_number":843,"context_line":"            if inv[\u0027hosts\u0027].get(\u0027name\u0027):"},{"line_number":844,"context_line":"                LOG.warning(\"task-core inventory already containers %s, \""},{"line_number":845,"context_line":"                            \"overriding it\", inv[\u0027hosts\u0027].get(\u0027name\u0027))"},{"line_number":846,"context_line":"            inv[\u0027hosts\u0027][name] \u003d {\u0027role\u0027: role_name.lower()}"}],"source_content_type":"text/x-python","patch_set":21,"id":"698181bc_2555ad1a","line":843,"range":{"start_line":843,"start_character":31,"end_line":843,"end_character":39},"in_reply_to":"480af265_cef2554d","updated":"2021-11-08 19:16:09.000000000","message":"likely","commit_id":"aff83d34c620b68a51510f36cefcabd0fc88245a"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a5e1bf2a0df5ad71cc100afde528df4dd47df0f6","unresolved":false,"context_lines":[{"line_number":840,"context_line":"        shortnames \u003d [n.split(\".%s.\" % host_network)[0].lower()"},{"line_number":841,"context_line":"                      for n in names]"},{"line_number":842,"context_line":"        for name in shortnames:"},{"line_number":843,"context_line":"            if inv[\u0027hosts\u0027].get(\u0027name\u0027):"},{"line_number":844,"context_line":"                LOG.warning(\"task-core inventory already containers %s, \""},{"line_number":845,"context_line":"                            \"overriding it\", inv[\u0027hosts\u0027].get(\u0027name\u0027))"},{"line_number":846,"context_line":"            inv[\u0027hosts\u0027][name] \u003d {\u0027role\u0027: role_name.lower()}"}],"source_content_type":"text/x-python","patch_set":21,"id":"e10cabcf_67bb0e73","line":843,"range":{"start_line":843,"start_character":31,"end_line":843,"end_character":39},"in_reply_to":"698181bc_2555ad1a","updated":"2021-11-11 23:23:37.000000000","message":"Done","commit_id":"aff83d34c620b68a51510f36cefcabd0fc88245a"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"74933f0205438dbfb05789fac7c16ae35b870397","unresolved":true,"context_lines":[{"line_number":841,"context_line":"                      for n in names]"},{"line_number":842,"context_line":"        for name in shortnames:"},{"line_number":843,"context_line":"            if inv[\u0027hosts\u0027].get(name):"},{"line_number":844,"context_line":"                LOG.warning(\"task-core inventory already containers %s, \""},{"line_number":845,"context_line":"                            \"overriding it\", inv[\u0027hosts\u0027].get(name))"},{"line_number":846,"context_line":"            inv[\u0027hosts\u0027][name] \u003d {\u0027role\u0027: role_name.lower()}"},{"line_number":847,"context_line":"    return inv"}],"source_content_type":"text/x-python","patch_set":22,"id":"5968e911_0b121e90","line":844,"range":{"start_line":844,"start_character":57,"end_line":844,"end_character":67},"updated":"2021-11-17 07:37:59.000000000","message":"contains","commit_id":"a9a5f43e29fb684d39f13ef29ad6897374f9226d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"07bd29fe6e5c66ef3908b7587121f433440e068d","unresolved":false,"context_lines":[{"line_number":841,"context_line":"                      for n in names]"},{"line_number":842,"context_line":"        for name in shortnames:"},{"line_number":843,"context_line":"            if inv[\u0027hosts\u0027].get(name):"},{"line_number":844,"context_line":"                LOG.warning(\"task-core inventory already containers %s, \""},{"line_number":845,"context_line":"                            \"overriding it\", inv[\u0027hosts\u0027].get(name))"},{"line_number":846,"context_line":"            inv[\u0027hosts\u0027][name] \u003d {\u0027role\u0027: role_name.lower()}"},{"line_number":847,"context_line":"    return inv"}],"source_content_type":"text/x-python","patch_set":22,"id":"d700c05a_9f98031f","line":844,"range":{"start_line":844,"start_character":57,"end_line":844,"end_character":67},"in_reply_to":"5968e911_0b121e90","updated":"2021-11-17 15:00:52.000000000","message":"Done","commit_id":"a9a5f43e29fb684d39f13ef29ad6897374f9226d"}],"tripleo_common/utils/config.py":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3416864f793465d9b4f2ed177c71a59fdd68e821","unresolved":true,"context_lines":[{"line_number":220,"context_line":"            os.makedirs(os.path.join(config_dir, d), mode\u003d0o700,"},{"line_number":221,"context_line":"                        exist_ok\u003dTrue)"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"        os.makedirs(os.path.join(config_dir, \u0027task_core\u0027), mode\u003d0o755,"},{"line_number":224,"context_line":"                    exist_ok\u003dTrue)"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"    def fetch_config(self, name):"}],"source_content_type":"text/x-python","patch_set":21,"id":"bb004e0b_7933cf0f","line":223,"range":{"start_line":223,"start_character":67,"end_line":223,"end_character":69},"updated":"2021-11-08 08:47:13.000000000","message":"why does it need to be different from the rest of the directories (I see 0o700 just above this ^^^) ?","commit_id":"aff83d34c620b68a51510f36cefcabd0fc88245a"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"d79d8c58c15d04a64711830ef687c8175d2492b0","unresolved":true,"context_lines":[{"line_number":220,"context_line":"            os.makedirs(os.path.join(config_dir, d), mode\u003d0o700,"},{"line_number":221,"context_line":"                        exist_ok\u003dTrue)"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"        os.makedirs(os.path.join(config_dir, \u0027task_core\u0027), mode\u003d0o755,"},{"line_number":224,"context_line":"                    exist_ok\u003dTrue)"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"    def fetch_config(self, name):"}],"source_content_type":"text/x-python","patch_set":21,"id":"ef100a2b_fc602456","line":223,"range":{"start_line":223,"start_character":67,"end_line":223,"end_character":69},"in_reply_to":"bb004e0b_7933cf0f","updated":"2021-11-08 14:52:09.000000000","message":"doesn\u0027t really matter.  it can be either. there\u0027s nothing sensitive in the task-core stuff as passwords and things come from the ansible vars files","commit_id":"aff83d34c620b68a51510f36cefcabd0fc88245a"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a5e1bf2a0df5ad71cc100afde528df4dd47df0f6","unresolved":false,"context_lines":[{"line_number":220,"context_line":"            os.makedirs(os.path.join(config_dir, d), mode\u003d0o700,"},{"line_number":221,"context_line":"                        exist_ok\u003dTrue)"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"        os.makedirs(os.path.join(config_dir, \u0027task_core\u0027), mode\u003d0o755,"},{"line_number":224,"context_line":"                    exist_ok\u003dTrue)"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"    def fetch_config(self, name):"}],"source_content_type":"text/x-python","patch_set":21,"id":"1536ac66_a6d94917","line":223,"range":{"start_line":223,"start_character":67,"end_line":223,"end_character":69},"in_reply_to":"ef100a2b_fc602456","updated":"2021-11-11 23:23:37.000000000","message":"Done","commit_id":"aff83d34c620b68a51510f36cefcabd0fc88245a"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3416864f793465d9b4f2ed177c71a59fdd68e821","unresolved":true,"context_lines":[{"line_number":630,"context_line":"                yaml.safe_dump(role_group_vars[role], group_vars_file,"},{"line_number":631,"context_line":"                               default_flow_style\u003dFalse)"},{"line_number":632,"context_line":""},{"line_number":633,"context_line":"        self.render_task_core(name, config_dir, role_data, server_roles,"},{"line_number":634,"context_line":"                              role_group_vars, role_config)"},{"line_number":635,"context_line":""},{"line_number":636,"context_line":"        # Render host_vars"}],"source_content_type":"text/x-python","patch_set":21,"id":"a38251f9_93cdcc3b","line":633,"range":{"start_line":633,"start_character":30,"end_line":633,"end_character":34},"updated":"2021-11-08 08:47:13.000000000","message":"does it need to be server_name now?\n[EDIT]: no there is a \u0027name\u0027 passed into the write_config function args","commit_id":"aff83d34c620b68a51510f36cefcabd0fc88245a"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"d79d8c58c15d04a64711830ef687c8175d2492b0","unresolved":true,"context_lines":[{"line_number":630,"context_line":"                yaml.safe_dump(role_group_vars[role], group_vars_file,"},{"line_number":631,"context_line":"                               default_flow_style\u003dFalse)"},{"line_number":632,"context_line":""},{"line_number":633,"context_line":"        self.render_task_core(name, config_dir, role_data, server_roles,"},{"line_number":634,"context_line":"                              role_group_vars, role_config)"},{"line_number":635,"context_line":""},{"line_number":636,"context_line":"        # Render host_vars"}],"source_content_type":"text/x-python","patch_set":21,"id":"a5026c80_a2b9fcaf","line":633,"range":{"start_line":633,"start_character":30,"end_line":633,"end_character":34},"in_reply_to":"a38251f9_93cdcc3b","updated":"2021-11-08 14:52:09.000000000","message":"no this is stack name","commit_id":"aff83d34c620b68a51510f36cefcabd0fc88245a"}]}