)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"a95782eeee84b7290433cd4f455b8ef021d15432","unresolved":true,"context_lines":[{"line_number":22,"context_line":"[1]. https://review.opendev.org/c/openstack/tripleo-common/+/807577"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Depends-On: https://review.opendev.org/c/openstack/tripleo-quickstart-extras/+/808056"},{"line_number":25,"context_line":"Depends-On: https://review.opendev.org/c/openstack/tripleo-quickstart/+/811438"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Signed-off-by: Ronelle Landy \u003crlandy@redhat.com\u003e"},{"line_number":28,"context_line":"Co-authored-by: Chandan Kumar (raukadah) \u003cchkumar@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":49,"id":"c9bc7a0c_3ac952f2","line":25,"updated":"2021-10-06 20:26:05.000000000","message":"Both merged","commit_id":"69e0effd62e25fa310b5dc2415b8c1f373264aa7"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"d2127ce934388743cdc39a590ef532795d70daff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":52,"id":"da24fa8f_2ad373f1","updated":"2021-10-11 06:42:14.000000000","message":"recheck","commit_id":"7aa79b11cdcbcb6170ca9425965062b807ed9061"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"80e22e1e05a70bd997319627cda04d5ed5958157","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":54,"id":"b77c945c_005a5659","updated":"2021-10-11 10:59:37.000000000","message":"Note my comment with ironic container, this patch is re-introducing tftp-server","commit_id":"965bba2ceb0a64ec3a8cc98b16e86cc3327032fc"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"9dc7ae9db5c557bf97e17594d4965d76b8639972","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":54,"id":"0777e0c8_d87ec2fa","updated":"2021-10-11 12:39:35.000000000","message":"Will update rest of the stuff.","commit_id":"965bba2ceb0a64ec3a8cc98b16e86cc3327032fc"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"3d5c4d040d9eef83c340e4e0729aa3db7d8892c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":56,"id":"84073167_f0ac3a2c","updated":"2021-10-11 15:50:52.000000000","message":"I took the liberty to add the \u0027- which\u0027 one-liner to base.yaml in the common packages, hope that is okay","commit_id":"d064bfa38f4b4af72d501edf9eb75b1e22970384"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"a4b2a30d180dafc46685b2dd99ffcb820bc08245","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":56,"id":"9005e049_33b0daef","updated":"2021-10-12 06:43:29.000000000","message":"inline question about the \u0027latest\u0027 for container tools and does this need to depends-on the tripleo-ci patch I think?","commit_id":"d064bfa38f4b4af72d501edf9eb75b1e22970384"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"132923fc8494c8f9c93466b138b320b216d02488","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":58,"id":"0a011b4a_c034d38a","updated":"2021-10-12 13:36:17.000000000","message":"We can improvements to this patch in a later review","commit_id":"3200c19d1388460b57e4d75d7f5b543a845bddcb"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"7ec52aae906f3d6b9b205d4db36b9448a0a3e301","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":63,"id":"0bfc33dc_91db649b","updated":"2021-10-12 21:05:40.000000000","message":"build passes on testproject now: https://review.rdoproject.org/zuul/build/9379f769be41416aa3d4904230cada2e","commit_id":"a3b984bc91d335f5e712d32ad6c84332fba50647"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"740e7815170a201145a143fd4b9bcdbd21144369","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":68,"id":"00edd432_789c95d4","updated":"2021-10-13 14:49:23.000000000","message":"[chandankumar@fedora base]$ podman images\nREPOSITORY                                                         TAG                               IMAGE ID      CREATED         SIZE\ntrunk.registry.rdoproject.org/tripleomastercentos9/openstack-base  d119ee536038f5ee65b5fc9e71221f5a  0838c2fa8197  30 minutes ago  339 MB\nquay.io/centos/centos                                              stream9-development               db9e6dc9e1d9  12 hours ago    150 MB\nregistry.fedoraproject.org/fedora-toolbox                          35                                9adeab321ffa  4 weeks ago     503 MB\nquay.io/centos/centos                                              latest                            300e315adb2f  10 months ago   217 MB\n[chandankumar@fedora base]$ podman run -it 0838c2fa8197 bash\n[root@3f16a6f64590 /]# cd /usr/share/\n[root@3f16a6f64590 share]# ls | grep zone\nzoneinfo\n[root@3f16a6f64590 share]# ","commit_id":"f558eaa75a12cc2f1c3147f61c57510e51859c99"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"7ca63f8f23b8e977b439aea77af8ec4423db73fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":68,"id":"b8f898e1_c299b5ac","updated":"2021-10-14 05:35:38.000000000","message":"recheck","commit_id":"f558eaa75a12cc2f1c3147f61c57510e51859c99"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f42ed23b63524b8977747aea67c9f3413e4b738a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":68,"id":"9a4a9962_6d3dad44","updated":"2021-10-14 06:54:34.000000000","message":"thanks for the update lgtm","commit_id":"f558eaa75a12cc2f1c3147f61c57510e51859c99"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"1a9c2d63d7bbc053bc872b1e83b6ecc8a5a44d14","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":68,"id":"c44fae46_74ccc5ac","updated":"2021-10-14 07:27:37.000000000","message":"we are planning to work on the missing packages over the next sprint. ","commit_id":"f558eaa75a12cc2f1c3147f61c57510e51859c99"}],"container-images/tcib/base/base.yaml":[{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"4949530cf747d22911f20bce81e16ba89b83a220","unresolved":true,"context_lines":[{"line_number":61,"context_line":"  - sudo"},{"line_number":62,"context_line":"  - tar"},{"line_number":63,"context_line":"  - util-linux-user"},{"line_number":64,"context_line":"  - rubygem-rexml"},{"line_number":65,"context_line":"  modules:"},{"line_number":66,"context_line":"  - disable: container-tools:rhel8"},{"line_number":67,"context_line":"  - disable: virt:rhel"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"010c5ec5_e9583a56","line":64,"range":{"start_line":64,"start_character":0,"end_line":64,"end_character":17},"updated":"2021-09-02 07:31:06.000000000","message":"This would need to be conditionalized on the rhel/centos version as it does not exist on centos8? https://review.rdoproject.org/r/c/openstack/tripleo-common-distgit/+/35242/ is an alternative approach","commit_id":"bc3d8ce016eee8832dfefe651d7b6ecf71961575"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"505926d27479be63ca1f6d6200adb21fbe7142bd","unresolved":true,"context_lines":[{"line_number":61,"context_line":"  - sudo"},{"line_number":62,"context_line":"  - tar"},{"line_number":63,"context_line":"  - util-linux-user"},{"line_number":64,"context_line":"  - rubygem-rexml"},{"line_number":65,"context_line":"  modules:"},{"line_number":66,"context_line":"  - disable: container-tools:rhel8"},{"line_number":67,"context_line":"  - disable: virt:rhel"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"e7f1c3fe_151969dc","line":64,"range":{"start_line":64,"start_character":0,"end_line":64,"end_character":17},"in_reply_to":"010c5ec5_e9583a56","updated":"2021-09-02 07:31:36.000000000","message":"But yeah for now to test things, this is perfect ;)","commit_id":"bc3d8ce016eee8832dfefe651d7b6ecf71961575"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"79bd59d6cb5a20c5a9118199ce7afbf883809aaf","unresolved":true,"context_lines":[{"line_number":28,"context_line":"- run: cp /usr/share/openstack-tripleo-common-containers/container-images/kolla/base/sudoers /etc/sudoers"},{"line_number":29,"context_line":"- run: chmod 440 /etc/sudoers"},{"line_number":30,"context_line":"- run: \u003e-"},{"line_number":31,"context_line":"    if [ \u0027{{ tcib_release }}\u0027 \u003d\u003d \u00278\u0027 ];then"},{"line_number":32,"context_line":"    sed -ri \u0027/-session(\\s+)optional(\\s+)pam_systemd.so/d\u0027 /etc/pam.d/system-auth; fi"},{"line_number":33,"context_line":"- run: sed -ri \u0027/^(passwd:|group:)/ s/systemd//g\u0027 /etc/nsswitch.conf"},{"line_number":34,"context_line":"- run: dnf install -y {{ tcib_packages[\u0027common\u0027] | join(\u0027 \u0027) }}"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"7e08473b_ddef2d32","line":31,"updated":"2021-09-03 05:54:35.000000000","message":"oh, this is corrected? yay!","commit_id":"4f11e99132792f97ee1ae4d00c3980e298b613d9"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"a7b94561beddadceee07a679b211ce40cc521236","unresolved":true,"context_lines":[{"line_number":37,"context_line":"    dnf -y reinstall tzdata; fi"},{"line_number":38,"context_line":"- run: mkdir -p /openstack"},{"line_number":39,"context_line":"- run: \u003e-"},{"line_number":40,"context_line":"    if [ \u0027{{ tcib_distro }}\u0027 \u003d\u003d \u0027centos\u0027 ];then dnf -y install dnf-plugins-core \u0026\u0026"},{"line_number":41,"context_line":"    dnf download centos*release \u0026\u0026"},{"line_number":42,"context_line":"    rpm -ivh --nodeps --replacepkgs --replacefiles *.rpm \u0026\u0026"},{"line_number":43,"context_line":"    if [ \u0027{{ tcib_release }}\u0027 \u003d\u003d \u00278\u0027 ];then rpm -e --nodeps redhat-release; fi \u0026\u0026"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"f352c95d_59e958d1","line":40,"range":{"start_line":40,"start_character":63,"end_line":40,"end_character":79},"updated":"2021-09-29 06:41:00.000000000","message":"this is new and not previously needed for 8? but seems needed on 9?","commit_id":"69e0effd62e25fa310b5dc2415b8c1f373264aa7"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"56ca3cd59a72b2b4f62870dd5ff60a09c6793e5e","unresolved":true,"context_lines":[{"line_number":37,"context_line":"    dnf -y reinstall tzdata; fi"},{"line_number":38,"context_line":"- run: mkdir -p /openstack"},{"line_number":39,"context_line":"- run: \u003e-"},{"line_number":40,"context_line":"    if [ \u0027{{ tcib_distro }}\u0027 \u003d\u003d \u0027centos\u0027 ];then dnf -y install dnf-plugins-core \u0026\u0026"},{"line_number":41,"context_line":"    dnf download centos*release \u0026\u0026"},{"line_number":42,"context_line":"    rpm -ivh --nodeps --replacepkgs --replacefiles *.rpm \u0026\u0026"},{"line_number":43,"context_line":"    if [ \u0027{{ tcib_release }}\u0027 \u003d\u003d \u00278\u0027 ];then rpm -e --nodeps redhat-release; fi \u0026\u0026"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"1522bb94_e77477a8","line":40,"range":{"start_line":40,"start_character":63,"end_line":40,"end_character":79},"in_reply_to":"f352c95d_59e958d1","updated":"2021-10-08 10:29:31.000000000","message":"It is needed for dnf-download command.","commit_id":"69e0effd62e25fa310b5dc2415b8c1f373264aa7"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"a7b94561beddadceee07a679b211ce40cc521236","unresolved":true,"context_lines":[{"line_number":40,"context_line":"    if [ \u0027{{ tcib_distro }}\u0027 \u003d\u003d \u0027centos\u0027 ];then dnf -y install dnf-plugins-core \u0026\u0026"},{"line_number":41,"context_line":"    dnf download centos*release \u0026\u0026"},{"line_number":42,"context_line":"    rpm -ivh --nodeps --replacepkgs --replacefiles *.rpm \u0026\u0026"},{"line_number":43,"context_line":"    if [ \u0027{{ tcib_release }}\u0027 \u003d\u003d \u00278\u0027 ];then rpm -e --nodeps redhat-release; fi \u0026\u0026"},{"line_number":44,"context_line":"    rm -rf *.rpm; fi"},{"line_number":45,"context_line":"- run: dnf update --excludepkgs redhat-release -y \u0026\u0026 dnf clean all \u0026\u0026 rm -rf /var/cache/dnf"},{"line_number":46,"context_line":"tcib_cmd: kolla_start"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"9e10b83a_322a4cdc","line":43,"range":{"start_line":43,"start_character":60,"end_line":43,"end_character":74},"updated":"2021-09-29 06:41:00.000000000","message":"seems a bit messy why we doing that one for 8?","commit_id":"69e0effd62e25fa310b5dc2415b8c1f373264aa7"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"56ca3cd59a72b2b4f62870dd5ff60a09c6793e5e","unresolved":true,"context_lines":[{"line_number":40,"context_line":"    if [ \u0027{{ tcib_distro }}\u0027 \u003d\u003d \u0027centos\u0027 ];then dnf -y install dnf-plugins-core \u0026\u0026"},{"line_number":41,"context_line":"    dnf download centos*release \u0026\u0026"},{"line_number":42,"context_line":"    rpm -ivh --nodeps --replacepkgs --replacefiles *.rpm \u0026\u0026"},{"line_number":43,"context_line":"    if [ \u0027{{ tcib_release }}\u0027 \u003d\u003d \u00278\u0027 ];then rpm -e --nodeps redhat-release; fi \u0026\u0026"},{"line_number":44,"context_line":"    rm -rf *.rpm; fi"},{"line_number":45,"context_line":"- run: dnf update --excludepkgs redhat-release -y \u0026\u0026 dnf clean all \u0026\u0026 rm -rf /var/cache/dnf"},{"line_number":46,"context_line":"tcib_cmd: kolla_start"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"3dc2e7ca_6fbebe05","line":43,"range":{"start_line":43,"start_character":60,"end_line":43,"end_character":74},"in_reply_to":"6fe8b571_2efbfc21","updated":"2021-10-08 10:29:31.000000000","message":"redhat-release utility comes as a part of centos-stream-release package for cs9 and for cs8 it is a seperate package. that\u0027s why we have added the workaround.\n\nI grepped the codebase in tripleo-common there is no reference of redhat-release. Will i Remove the above hack?","commit_id":"69e0effd62e25fa310b5dc2415b8c1f373264aa7"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"c0711f6b20ef371b5a1cb8e581b5e4e6f7389978","unresolved":true,"context_lines":[{"line_number":40,"context_line":"    if [ \u0027{{ tcib_distro }}\u0027 \u003d\u003d \u0027centos\u0027 ];then dnf -y install dnf-plugins-core \u0026\u0026"},{"line_number":41,"context_line":"    dnf download centos*release \u0026\u0026"},{"line_number":42,"context_line":"    rpm -ivh --nodeps --replacepkgs --replacefiles *.rpm \u0026\u0026"},{"line_number":43,"context_line":"    if [ \u0027{{ tcib_release }}\u0027 \u003d\u003d \u00278\u0027 ];then rpm -e --nodeps redhat-release; fi \u0026\u0026"},{"line_number":44,"context_line":"    rm -rf *.rpm; fi"},{"line_number":45,"context_line":"- run: dnf update --excludepkgs redhat-release -y \u0026\u0026 dnf clean all \u0026\u0026 rm -rf /var/cache/dnf"},{"line_number":46,"context_line":"tcib_cmd: kolla_start"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"967ac5ac_65a7a77e","line":43,"range":{"start_line":43,"start_character":60,"end_line":43,"end_character":74},"in_reply_to":"6fe8b571_2efbfc21","updated":"2021-10-11 10:36:14.000000000","message":"yes, it\u0027s from:\nhttps://bugzilla.redhat.com/show_bug.cgi?id\u003d1987752\nhttps://bugzilla.redhat.com/show_bug.cgi?id\u003d1993209\n\nwas it solved?","commit_id":"69e0effd62e25fa310b5dc2415b8c1f373264aa7"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"da4c73bfa528197484fccc61e64864f694621627","unresolved":true,"context_lines":[{"line_number":40,"context_line":"    if [ \u0027{{ tcib_distro }}\u0027 \u003d\u003d \u0027centos\u0027 ];then dnf -y install dnf-plugins-core \u0026\u0026"},{"line_number":41,"context_line":"    dnf download centos*release \u0026\u0026"},{"line_number":42,"context_line":"    rpm -ivh --nodeps --replacepkgs --replacefiles *.rpm \u0026\u0026"},{"line_number":43,"context_line":"    if [ \u0027{{ tcib_release }}\u0027 \u003d\u003d \u00278\u0027 ];then rpm -e --nodeps redhat-release; fi \u0026\u0026"},{"line_number":44,"context_line":"    rm -rf *.rpm; fi"},{"line_number":45,"context_line":"- run: dnf update --excludepkgs redhat-release -y \u0026\u0026 dnf clean all \u0026\u0026 rm -rf /var/cache/dnf"},{"line_number":46,"context_line":"tcib_cmd: kolla_start"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"6fe8b571_2efbfc21","line":43,"range":{"start_line":43,"start_character":60,"end_line":43,"end_character":74},"in_reply_to":"9e10b83a_322a4cdc","updated":"2021-09-30 21:12:51.000000000","message":"Was this to workaround the contrainers-common/redhat-release conflicts? I don\u0027t think we should do this.","commit_id":"69e0effd62e25fa310b5dc2415b8c1f373264aa7"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"a7b94561beddadceee07a679b211ce40cc521236","unresolved":true,"context_lines":[{"line_number":68,"context_line":"  - sudo"},{"line_number":69,"context_line":"  - tar"},{"line_number":70,"context_line":"  - util-linux-user"},{"line_number":71,"context_line":"  el9:"},{"line_number":72,"context_line":"  - rubygem-rexml"},{"line_number":73,"context_line":"  - which"},{"line_number":74,"context_line":"  modules:"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"5e6bc0ca_6700bec9","line":71,"updated":"2021-09-29 06:41:00.000000000","message":"do we have a bug for those will they show up eventually or we will need to carry that?\nif we have something to point to like a bug consider adding a comment here for removal when it is possible","commit_id":"69e0effd62e25fa310b5dc2415b8c1f373264aa7"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"1033ec5fea970b219ec5536c0ca12ed998499a2e","unresolved":true,"context_lines":[{"line_number":68,"context_line":"  - sudo"},{"line_number":69,"context_line":"  - tar"},{"line_number":70,"context_line":"  - util-linux-user"},{"line_number":71,"context_line":"  el9:"},{"line_number":72,"context_line":"  - rubygem-rexml"},{"line_number":73,"context_line":"  - which"},{"line_number":74,"context_line":"  modules:"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"a38bd295_6f90f617","line":71,"in_reply_to":"5e6bc0ca_6700bec9","updated":"2021-10-06 06:26:20.000000000","message":"rubygem-xml could be removed if we merged https://review.rdoproject.org/r/c/openstack/tripleo-common-distgit/+/35242\nwhich has a BZ here https://bugzilla.redhat.com/show_bug.cgi?id\u003d2011142","commit_id":"69e0effd62e25fa310b5dc2415b8c1f373264aa7"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"56ca3cd59a72b2b4f62870dd5ff60a09c6793e5e","unresolved":true,"context_lines":[{"line_number":68,"context_line":"  - sudo"},{"line_number":69,"context_line":"  - tar"},{"line_number":70,"context_line":"  - util-linux-user"},{"line_number":71,"context_line":"  el9:"},{"line_number":72,"context_line":"  - rubygem-rexml"},{"line_number":73,"context_line":"  - which"},{"line_number":74,"context_line":"  modules:"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"815fd732_ba080d1a","line":71,"in_reply_to":"a38bd295_6f90f617","updated":"2021-10-08 10:29:31.000000000","message":"Awesome, I will move which package as a part of base package as which is not available for EL9 in the base image.","commit_id":"69e0effd62e25fa310b5dc2415b8c1f373264aa7"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"87db67769e776aa3026e9f9f8bea1b65d1d42d38","unresolved":true,"context_lines":[{"line_number":65,"context_line":"  - socat"},{"line_number":66,"context_line":"  - sudo"},{"line_number":67,"context_line":"  - tar"},{"line_number":68,"context_line":"  - util-linux-user"},{"line_number":69,"context_line":"  modules:"},{"line_number":70,"context_line":"  - disable: container-tools:rhel8"},{"line_number":71,"context_line":"  - disable: virt:rhel"}],"source_content_type":"text/x-yaml","patch_set":55,"id":"4af6ee56_03949160","line":68,"range":{"start_line":68,"start_character":1,"end_line":68,"end_character":19},"updated":"2021-10-11 15:28:05.000000000","message":"we need to readd \u0027- which\u0027 here. We can add it unconditionalized (i.e. without an el9 section) since it exists on rhel8 as well:\n# cat /etc/redhat-release\nRed Hat Enterprise Linux release 8.4 (Ootpa)\n# rpm -qf /usr/bin/which\nwhich-2.21-12.el8.x86_64\n\nOtherwise we will hit issue 15 again: https://docs.google.com/document/d/1uOlItDNP-WX6F786uZZu1Dgzj54b1q_9W5b-qWQekIc/edit#heading\u003dh.lesxntpspxma","commit_id":"a617678263ea4ab78da5e3c8ea787035ec791700"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"a4b2a30d180dafc46685b2dd99ffcb820bc08245","unresolved":true,"context_lines":[{"line_number":70,"context_line":"  modules:"},{"line_number":71,"context_line":"  - disable: container-tools:rhel8"},{"line_number":72,"context_line":"  - disable: virt:rhel"},{"line_number":73,"context_line":"  - enable: container-tools:{{ tcib_rhel_modules[\u0027container-tools\u0027] | default(\u0027latest\u0027) }}"},{"line_number":74,"context_line":"  - enable: mariadb:{{ tcib_rhel_modules[\u0027mariadb\u0027] | default(\u002710.3\u0027) }}"},{"line_number":75,"context_line":"  - enable: virt:{{ tcib_rhel_modules[\u0027virt\u0027] | default(\u0027av\u0027) }}"},{"line_number":76,"context_line":"  - enable: redis:{{ tcib_rhel_modules[\u0027redis\u0027] | default(\u00275\u0027) }}"}],"source_content_type":"text/x-yaml","patch_set":56,"id":"54baae88_d822d2e3","line":73,"range":{"start_line":73,"start_character":79,"end_line":73,"end_character":85},"updated":"2021-10-12 06:43:29.000000000","message":"we need latest for C9 but will that work OK for C8? I think we explicitly needed 3.0 for 8 which is why we had it hard-coded here.","commit_id":"d064bfa38f4b4af72d501edf9eb75b1e22970384"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"d96feaaa1cbf78201897267c2273fb92996cd2dc","unresolved":true,"context_lines":[{"line_number":70,"context_line":"  modules:"},{"line_number":71,"context_line":"  - disable: container-tools:rhel8"},{"line_number":72,"context_line":"  - disable: virt:rhel"},{"line_number":73,"context_line":"  - enable: container-tools:{{ tcib_rhel_modules[\u0027container-tools\u0027] | default(\u0027latest\u0027) }}"},{"line_number":74,"context_line":"  - enable: mariadb:{{ tcib_rhel_modules[\u0027mariadb\u0027] | default(\u002710.3\u0027) }}"},{"line_number":75,"context_line":"  - enable: virt:{{ tcib_rhel_modules[\u0027virt\u0027] | default(\u0027av\u0027) }}"},{"line_number":76,"context_line":"  - enable: redis:{{ tcib_rhel_modules[\u0027redis\u0027] | default(\u00275\u0027) }}"}],"source_content_type":"text/x-yaml","patch_set":56,"id":"229c2279_4fa8ea8c","line":73,"range":{"start_line":73,"start_character":79,"end_line":73,"end_character":85},"in_reply_to":"54baae88_d822d2e3","updated":"2021-10-12 13:35:54.000000000","message":"Yes, we need to make it conditional for cs9","commit_id":"d064bfa38f4b4af72d501edf9eb75b1e22970384"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"98ecdc1d21f8b8c45ce76809bfffcc01fd563e1a","unresolved":true,"context_lines":[{"line_number":16,"context_line":"- run: if [ \u0027{{ tcib_distro }}\u0027 \u003d\u003d \u0027rhel\u0027 ]; then {% for item in tcib_packages.modules %}{% set key, value \u003d (item.items() | list).0 %}dnf module -y {{ key }} {{ value }}; {% endfor %}fi"},{"line_number":17,"context_line":"- run: \u003e-"},{"line_number":18,"context_line":"    if [ \u0027{{ tcib_release }}\u0027 \u003d\u003d \u00279\u0027 ];then"},{"line_number":19,"context_line":"    dnf module switch-to container-tools:latest -y; fi"},{"line_number":20,"context_line":"- run: dnf install -y openstack-tripleo-common-containers"},{"line_number":21,"context_line":"- run: cp /usr/share/openstack-tripleo-common-containers/container-images/kolla/base/uid_gid_manage.sh /usr/local/bin/uid_gid_manage"},{"line_number":22,"context_line":"- run: chmod 755 /usr/local/bin/uid_gid_manage"}],"source_content_type":"text/x-yaml","patch_set":58,"id":"ca0b1b97_63f3ba80","line":19,"updated":"2021-10-12 13:45:13.000000000","message":"Can we not use the modules definition in tcib/base.yaml for this?","commit_id":"3200c19d1388460b57e4d75d7f5b543a845bddcb"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"67d0556ea4f3ca88d31f8068d672b7b169eb8f33","unresolved":false,"context_lines":[{"line_number":16,"context_line":"- run: if [ \u0027{{ tcib_distro }}\u0027 \u003d\u003d \u0027rhel\u0027 ]; then {% for item in tcib_packages.modules %}{% set key, value \u003d (item.items() | list).0 %}dnf module -y {{ key }} {{ value }}; {% endfor %}fi"},{"line_number":17,"context_line":"- run: \u003e-"},{"line_number":18,"context_line":"    if [ \u0027{{ tcib_release }}\u0027 \u003d\u003d \u00279\u0027 ];then"},{"line_number":19,"context_line":"    dnf module switch-to container-tools:latest -y; fi"},{"line_number":20,"context_line":"- run: dnf install -y openstack-tripleo-common-containers"},{"line_number":21,"context_line":"- run: cp /usr/share/openstack-tripleo-common-containers/container-images/kolla/base/uid_gid_manage.sh /usr/local/bin/uid_gid_manage"},{"line_number":22,"context_line":"- run: chmod 755 /usr/local/bin/uid_gid_manage"}],"source_content_type":"text/x-yaml","patch_set":58,"id":"e9c5be8d_1089bcc4","line":19,"in_reply_to":"ca0b1b97_63f3ba80","updated":"2021-10-12 14:30:36.000000000","message":"Done","commit_id":"3200c19d1388460b57e4d75d7f5b543a845bddcb"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ac75d84a2176a4ea52960f590b7787ea3241314c","unresolved":true,"context_lines":[{"line_number":73,"context_line":"  modules:"},{"line_number":74,"context_line":"  - disable: container-tools:rhel8"},{"line_number":75,"context_line":"  - disable: virt:rhel"},{"line_number":76,"context_line":"  - enable: container-tools:{{ tcib_rhel_modules[\u0027container-tools\u0027] | default(\u00273.0\u0027) }}"},{"line_number":77,"context_line":"  - enable: mariadb:{{ tcib_rhel_modules[\u0027mariadb\u0027] | default(\u002710.3\u0027) }}"},{"line_number":78,"context_line":"  - enable: virt:{{ tcib_rhel_modules[\u0027virt\u0027] | default(\u0027av\u0027) }}"},{"line_number":79,"context_line":"  - enable: redis:{{ tcib_rhel_modules[\u0027redis\u0027] | default(\u00275\u0027) }}"}],"source_content_type":"text/x-yaml","patch_set":58,"id":"f99c892a_1b46abc9","line":76,"range":{"start_line":76,"start_character":6,"end_line":76,"end_character":7},"updated":"2021-10-12 13:50:45.000000000","message":"Specifically i mean this. does this not work correctly for 9? if so this needs to get fixed","commit_id":"3200c19d1388460b57e4d75d7f5b543a845bddcb"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"67d0556ea4f3ca88d31f8068d672b7b169eb8f33","unresolved":false,"context_lines":[{"line_number":73,"context_line":"  modules:"},{"line_number":74,"context_line":"  - disable: container-tools:rhel8"},{"line_number":75,"context_line":"  - disable: virt:rhel"},{"line_number":76,"context_line":"  - enable: container-tools:{{ tcib_rhel_modules[\u0027container-tools\u0027] | default(\u00273.0\u0027) }}"},{"line_number":77,"context_line":"  - enable: mariadb:{{ tcib_rhel_modules[\u0027mariadb\u0027] | default(\u002710.3\u0027) }}"},{"line_number":78,"context_line":"  - enable: virt:{{ tcib_rhel_modules[\u0027virt\u0027] | default(\u0027av\u0027) }}"},{"line_number":79,"context_line":"  - enable: redis:{{ tcib_rhel_modules[\u0027redis\u0027] | default(\u00275\u0027) }}"}],"source_content_type":"text/x-yaml","patch_set":58,"id":"e5bd3ff0_b7da06eb","line":76,"range":{"start_line":76,"start_character":6,"end_line":76,"end_character":7},"in_reply_to":"a9ba5e5d_84a03dbb","updated":"2021-10-12 14:30:36.000000000","message":"Done","commit_id":"3200c19d1388460b57e4d75d7f5b543a845bddcb"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"678ee9cb3da6cd165e7e7d78dc8f9f73be0c9df8","unresolved":true,"context_lines":[{"line_number":73,"context_line":"  modules:"},{"line_number":74,"context_line":"  - disable: container-tools:rhel8"},{"line_number":75,"context_line":"  - disable: virt:rhel"},{"line_number":76,"context_line":"  - enable: container-tools:{{ tcib_rhel_modules[\u0027container-tools\u0027] | default(\u00273.0\u0027) }}"},{"line_number":77,"context_line":"  - enable: mariadb:{{ tcib_rhel_modules[\u0027mariadb\u0027] | default(\u002710.3\u0027) }}"},{"line_number":78,"context_line":"  - enable: virt:{{ tcib_rhel_modules[\u0027virt\u0027] | default(\u0027av\u0027) }}"},{"line_number":79,"context_line":"  - enable: redis:{{ tcib_rhel_modules[\u0027redis\u0027] | default(\u00275\u0027) }}"}],"source_content_type":"text/x-yaml","patch_set":58,"id":"a9ba5e5d_84a03dbb","line":76,"range":{"start_line":76,"start_character":6,"end_line":76,"end_character":7},"in_reply_to":"f99c892a_1b46abc9","updated":"2021-10-12 13:56:26.000000000","message":"If I set\n- enable: container-tools:{{ tcib_rhel_modules[\u0027container-tools\u0027] | default(\u0027latest\u0027) }}, It works fine for el9 but we also need to set 3.0 for el8. I am not sure how to add support for both the distros. Need help here.","commit_id":"3200c19d1388460b57e4d75d7f5b543a845bddcb"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b8e69a790a73fe932cd092dca436e10f4e58a0fb","unresolved":true,"context_lines":[{"line_number":70,"context_line":"  modules:"},{"line_number":71,"context_line":"  - disable: container-tools:rhel8"},{"line_number":72,"context_line":"  - disable: virt:rhel"},{"line_number":73,"context_line":"  - enable: container-tools:{{ tcib_rhel_modules[\u0027container-tools\u0027] | default(\u0027latest\u0027 if tcib_release \u003d\u003d \u00279\u0027 else \u00273.0\u0027) }}"},{"line_number":74,"context_line":"  - enable: mariadb:{{ tcib_rhel_modules[\u0027mariadb\u0027] | default(\u002710.3\u0027) }}"},{"line_number":75,"context_line":"  - enable: virt:{{ tcib_rhel_modules[\u0027virt\u0027] | default(\u0027av\u0027) }}"},{"line_number":76,"context_line":"  - enable: redis:{{ tcib_rhel_modules[\u0027redis\u0027] | default(\u00275\u0027) }}"}],"source_content_type":"text/x-yaml","patch_set":65,"id":"a9f894b3_4fcafadd","line":73,"range":{"start_line":73,"start_character":78,"end_line":73,"end_character":120},"updated":"2021-10-13 06:30:31.000000000","message":"not seen this syntax before are you sure it is OK?\n\n[EDIT]: ok it works but you should use is version to guard against 9 vs \u00279\u0027\n\n  5   vars:                                                                        \n  6     - tcib_release: 9                                                          \n  7   tasks:                                                                       \n  8     - debug:                                                                   \n  9         msg: \"with tcib_release {{ tcib_release }} result is {{ tcib_rhel_modules[\u0027container-tools\u0027] | default(\u0027latest\u0027 if tcib_release \u003d\u003d \u00279\u0027 else \u00273.0\u0027) }}\"\n\n\nTASK [debug] *******************************************************************************************************************************************************************************************************\nok: [localhost] \u003d\u003e {\n    \"msg\": \"with tcib_release 9 result is 3.0\"\n}\n\n\n\n\nif you do instaed\n\n  7   tasks:                                                                       \n  8     - debug:                                                                   \n  9         msg: \"with tcib_release {{ tcib_release }} result is {{ tcib_rhel_modules[\u0027container-tools\u0027] | default(\u0027latest\u0027 if tcib_release is version(\u00279\u0027, \u0027\u003d\u003d\u0027) else \u00273.0\u0027) }}\"\n\n\nthen it is OK\n\nTASK [debug] *******************************************************************************************************************************************************************************************************\nok: [localhost] \u003d\u003e {\n    \"msg\": \"with tcib_release 9 result is latest\"\n}","commit_id":"fa20028cf52cdf7052d9c5cc36639907cab33bf5"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"1ad6cc56156bb2aade1cc1420dadf7428cce6f1d","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  modules:"},{"line_number":71,"context_line":"  - disable: container-tools:rhel8"},{"line_number":72,"context_line":"  - disable: virt:rhel"},{"line_number":73,"context_line":"  - enable: container-tools:{{ tcib_rhel_modules[\u0027container-tools\u0027] | default(\u0027latest\u0027 if tcib_release \u003d\u003d \u00279\u0027 else \u00273.0\u0027) }}"},{"line_number":74,"context_line":"  - enable: mariadb:{{ tcib_rhel_modules[\u0027mariadb\u0027] | default(\u002710.3\u0027) }}"},{"line_number":75,"context_line":"  - enable: virt:{{ tcib_rhel_modules[\u0027virt\u0027] | default(\u0027av\u0027) }}"},{"line_number":76,"context_line":"  - enable: redis:{{ tcib_rhel_modules[\u0027redis\u0027] | default(\u00275\u0027) }}"}],"source_content_type":"text/x-yaml","patch_set":65,"id":"63c6fcfd_35e98662","line":73,"range":{"start_line":73,"start_character":78,"end_line":73,"end_character":120},"in_reply_to":"02ab1e45_8f6a7881","updated":"2021-10-13 07:25:53.000000000","message":"Done","commit_id":"fa20028cf52cdf7052d9c5cc36639907cab33bf5"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"1c7eebf03c56e2fddd45c098818420f8d38606ff","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  modules:"},{"line_number":71,"context_line":"  - disable: container-tools:rhel8"},{"line_number":72,"context_line":"  - disable: virt:rhel"},{"line_number":73,"context_line":"  - enable: container-tools:{{ tcib_rhel_modules[\u0027container-tools\u0027] | default(\u0027latest\u0027 if tcib_release \u003d\u003d \u00279\u0027 else \u00273.0\u0027) }}"},{"line_number":74,"context_line":"  - enable: mariadb:{{ tcib_rhel_modules[\u0027mariadb\u0027] | default(\u002710.3\u0027) }}"},{"line_number":75,"context_line":"  - enable: virt:{{ tcib_rhel_modules[\u0027virt\u0027] | default(\u0027av\u0027) }}"},{"line_number":76,"context_line":"  - enable: redis:{{ tcib_rhel_modules[\u0027redis\u0027] | default(\u00275\u0027) }}"}],"source_content_type":"text/x-yaml","patch_set":65,"id":"ebfd236e_71fdaff4","line":73,"range":{"start_line":73,"start_character":78,"end_line":73,"end_character":120},"in_reply_to":"63c6fcfd_35e98662","updated":"2021-10-13 07:34:46.000000000","message":"And it works: https://review.rdoproject.org/zuul/build/14cd2c21ab564097bd3163d8486e20ff and https://logserver.rdoproject.org/53/18953/106/check/tripleo-build-containers-stream9-development/14cd2c2/logs/container-builds/9ccf1fcb-e724-4aa9-b0f0-bbca17ec1e91/base/base-build.log\n\nEnabling module streams:\n container-tools                                   latest","commit_id":"fa20028cf52cdf7052d9c5cc36639907cab33bf5"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"323cade59c49922c768c128ac00587488f1e250c","unresolved":true,"context_lines":[{"line_number":70,"context_line":"  modules:"},{"line_number":71,"context_line":"  - disable: container-tools:rhel8"},{"line_number":72,"context_line":"  - disable: virt:rhel"},{"line_number":73,"context_line":"  - enable: container-tools:{{ tcib_rhel_modules[\u0027container-tools\u0027] | default(\u0027latest\u0027 if tcib_release \u003d\u003d \u00279\u0027 else \u00273.0\u0027) }}"},{"line_number":74,"context_line":"  - enable: mariadb:{{ tcib_rhel_modules[\u0027mariadb\u0027] | default(\u002710.3\u0027) }}"},{"line_number":75,"context_line":"  - enable: virt:{{ tcib_rhel_modules[\u0027virt\u0027] | default(\u0027av\u0027) }}"},{"line_number":76,"context_line":"  - enable: redis:{{ tcib_rhel_modules[\u0027redis\u0027] | default(\u00275\u0027) }}"}],"source_content_type":"text/x-yaml","patch_set":65,"id":"02ab1e45_8f6a7881","line":73,"range":{"start_line":73,"start_character":78,"end_line":73,"end_character":120},"in_reply_to":"a9f894b3_4fcafadd","updated":"2021-10-13 06:41:40.000000000","message":"Above syntax is working let me try the above suggestion, Thanks for pointing it out.","commit_id":"fa20028cf52cdf7052d9c5cc36639907cab33bf5"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"270ef0e44226cda80ab3b8c03664129d31d5c57f","unresolved":true,"context_lines":[{"line_number":34,"context_line":"- run: dnf install -y {{ tcib_packages[\u0027common\u0027] | join(\u0027 \u0027) }}"},{"line_number":35,"context_line":"- run: \u003e-"},{"line_number":36,"context_line":"    if [ \u0027{{ tcib_release }}\u0027 \u003d\u003d \u00279\u0027 ];then"},{"line_number":37,"context_line":"    dnf -y reinstall which \u0026\u0026"},{"line_number":38,"context_line":"    rpm -e --nodeps tzdata \u0026\u0026"},{"line_number":39,"context_line":"    dnf -y install tzdata; fi"},{"line_number":40,"context_line":"- run: mkdir -p /openstack"}],"source_content_type":"text/x-yaml","patch_set":68,"id":"c525dd3e_30cfdc1f","line":37,"range":{"start_line":37,"start_character":4,"end_line":37,"end_character":29},"updated":"2021-10-13 17:02:44.000000000","message":"this needs a bugzilla if they\u0027ve killed which in the base container","commit_id":"f558eaa75a12cc2f1c3147f61c57510e51859c99"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f42ed23b63524b8977747aea67c9f3413e4b738a","unresolved":true,"context_lines":[{"line_number":36,"context_line":"    if [ \u0027{{ tcib_release }}\u0027 \u003d\u003d \u00279\u0027 ];then"},{"line_number":37,"context_line":"    dnf -y reinstall which \u0026\u0026"},{"line_number":38,"context_line":"    rpm -e --nodeps tzdata \u0026\u0026"},{"line_number":39,"context_line":"    dnf -y install tzdata; fi"},{"line_number":40,"context_line":"- run: mkdir -p /openstack"},{"line_number":41,"context_line":"- run: \u003e-"},{"line_number":42,"context_line":"    if [ \u0027{{ tcib_distro }}\u0027 \u003d\u003d \u0027centos\u0027 ];then dnf -y install dnf-plugins-core \u0026\u0026"}],"source_content_type":"text/x-yaml","patch_set":68,"id":"bda9b0f0_70562bf4","line":39,"range":{"start_line":39,"start_character":19,"end_line":39,"end_character":25},"updated":"2021-10-14 06:54:34.000000000","message":"thank you for the added explanation in the message about this\nagree with Alex about the bug perhaps you can have one to the tzdata workaround  I guess this can be removed if we get tzdata missing directory fixed from base if possible","commit_id":"f558eaa75a12cc2f1c3147f61c57510e51859c99"}],"container-images/tcib/base/collectd/collectd.yaml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"b30c671df3456c0831695f684354f789e03be896","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":49,"id":"5922c4e1_d95d95ac","line":61,"range":{"start_line":54,"start_character":0,"end_line":61,"end_character":0},"updated":"2021-09-30 22:33:05.000000000","message":"is there an el9 equivalent for this package set?","commit_id":"69e0effd62e25fa310b5dc2415b8c1f373264aa7"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"117d5bb5a1bb411ed46016e98982651d6e09b769","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":49,"id":"bf3a075d_dee1e73a","line":61,"range":{"start_line":54,"start_character":0,"end_line":61,"end_character":0},"in_reply_to":"5922c4e1_d95d95ac","updated":"2021-10-01 06:24:05.000000000","message":"I\u0027ve added them to the next sprint. Some of them are planned for inclusion; the fate of iptables is unclear.","commit_id":"69e0effd62e25fa310b5dc2415b8c1f373264aa7"}],"container-images/tcib/base/mariadb/mariadb.yaml":[{"author":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"change_message_id":"5e3343d7f99c8d205474c5cf5bccd98f667a9cf2","unresolved":true,"context_lines":[{"line_number":1,"context_line":"tcib_actions:"},{"line_number":2,"context_line":"- run: bash /usr/local/bin/uid_gid_manage {{ tcib_user }}"},{"line_number":3,"context_line":"- run: \u003e-"},{"line_number":4,"context_line":"    if [ \u0027{{ tcib_release }}\u0027 \u003d\u003d \u00279\u0027 ];then"},{"line_number":5,"context_line":"    dnf -y install which;"},{"line_number":6,"context_line":"    fi"},{"line_number":7,"context_line":"- run: dnf -y install {{ tcib_packages[\u0027common\u0027] | join(\u0027 \u0027) }} \u0026\u0026 dnf clean all \u0026\u0026 rm -rf /var/cache/dnf"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"e4bb22f3_e00797d6","line":4,"updated":"2021-09-03 08:01:11.000000000","message":"nit: not sure if this is being run in bash, but POSIX string comparison is done with \u0027\u003d\u0027, \u0027\u003d\u003d\u0027 is a ksh/bash thing.","commit_id":"4f11e99132792f97ee1ae4d00c3980e298b613d9"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"690e35ab445433167612c0f918eb6bdf5171a854","unresolved":true,"context_lines":[{"line_number":1,"context_line":"tcib_actions:"},{"line_number":2,"context_line":"- run: bash /usr/local/bin/uid_gid_manage {{ tcib_user }}"},{"line_number":3,"context_line":"- run: \u003e-"},{"line_number":4,"context_line":"    if [ \u0027{{ tcib_release }}\u0027 \u003d\u003d \u00279\u0027 ];then"},{"line_number":5,"context_line":"    dnf -y install which;"},{"line_number":6,"context_line":"    fi"},{"line_number":7,"context_line":"- run: dnf -y install {{ tcib_packages[\u0027common\u0027] | join(\u0027 \u0027) }} \u0026\u0026 dnf clean all \u0026\u0026 rm -rf /var/cache/dnf"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"2605ab6e_7ba0e5f8","line":4,"in_reply_to":"e4bb22f3_e00797d6","updated":"2021-09-03 08:12:46.000000000","message":"It is kind of tricky, https://logserver.rdoproject.org/53/18953/102/check/tripleo-build-containers-stream9-development/a06b19b/logs/container-builds/ff30c13b-d8b8-4050-ac3b-eebd8f2e9eae/base/base-build.log and https://review.opendev.org/c/openstack/tripleo-common/+/807241/1/container-images/tcib/base/base.yaml#35","commit_id":"4f11e99132792f97ee1ae4d00c3980e298b613d9"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"79bd59d6cb5a20c5a9118199ce7afbf883809aaf","unresolved":true,"context_lines":[{"line_number":2,"context_line":"- run: bash /usr/local/bin/uid_gid_manage {{ tcib_user }}"},{"line_number":3,"context_line":"- run: \u003e-"},{"line_number":4,"context_line":"    if [ \u0027{{ tcib_release }}\u0027 \u003d\u003d \u00279\u0027 ];then"},{"line_number":5,"context_line":"    dnf -y install which;"},{"line_number":6,"context_line":"    fi"},{"line_number":7,"context_line":"- run: dnf -y install {{ tcib_packages[\u0027common\u0027] | join(\u0027 \u0027) }} \u0026\u0026 dnf clean all \u0026\u0026 rm -rf /var/cache/dnf"},{"line_number":8,"context_line":"- run: cp /usr/share/openstack-tripleo-common-containers/container-images/kolla/mariadb/extend_start.sh /usr/local/bin/kolla_extend_start"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"872e9b7e_ef240936","line":5,"updated":"2021-09-03 05:54:35.000000000","message":"Seriously? Not installed by default? Are they following Debian \"yay deprecate which, use «command -v» that doesn\u0027t do the same but hey, don\u0027t care?\" way?!","commit_id":"4f11e99132792f97ee1ae4d00c3980e298b613d9"},{"author":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"change_message_id":"5e3343d7f99c8d205474c5cf5bccd98f667a9cf2","unresolved":true,"context_lines":[{"line_number":7,"context_line":"- run: dnf -y install {{ tcib_packages[\u0027common\u0027] | join(\u0027 \u0027) }} \u0026\u0026 dnf clean all \u0026\u0026 rm -rf /var/cache/dnf"},{"line_number":8,"context_line":"- run: cp /usr/share/openstack-tripleo-common-containers/container-images/kolla/mariadb/extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":9,"context_line":"- run: chmod 755 /usr/local/bin/kolla_extend_start"},{"line_number":10,"context_line":"- run: cp /usr/share/openstack-tripleo-common-containers/container-images/kolla/mariadb/security_reset.expect /usr/local/bin/kolla_security_reset"},{"line_number":11,"context_line":"- run: chmod 755 /usr/local/bin/kolla_security_reset"},{"line_number":12,"context_line":"- run: rm -rf /var/lib/mysql/* /etc/my.cnf.d/mariadb-server.cnf /etc/my.cnf.d/auth_gssapi.cnf"},{"line_number":13,"context_line":"- run: mkdir -p /etc/libqb"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"318f3d02_4d90fb75","line":10,"updated":"2021-09-03 08:01:11.000000000","message":"this line only works for mariadb \u003c 10.5.\nTo fix it we need to import another kolla file [1] in tripleo common:\nand make a conditional install like so:\n\n- run: \u003e-\n    if [ \u0027{{ tcib_release }}\u0027 \u003d\u003d \u00279\u0027 ];then\n    cp /usr/share/openstack-tripleo-common-containers/container-images/kolla/mariadb/security_reset.expect.debian /usr/local/bin/kolla_security_reset\n    else\n    cp /usr/share/openstack-tripleo-common-containers/container-images/kolla/mariadb/security_reset.expect /usr/local/bin/kolla_security_reset\n    fi\n\n\n\n[1] https://github.com/openstack/kolla/blob/master/docker/mariadb/mariadb-server/security_reset.expect.debian","commit_id":"4f11e99132792f97ee1ae4d00c3980e298b613d9"}],"container-images/tcib/base/os/cinder-base/cinder-base.yaml":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"79bd59d6cb5a20c5a9118199ce7afbf883809aaf","unresolved":true,"context_lines":[{"line_number":3,"context_line":"- run: dnf -y install {{ tcib_packages.common | join(\u0027 \u0027) }} \u0026\u0026 dnf clean all \u0026\u0026 rm -rf /var/cache/dnf"},{"line_number":4,"context_line":"tcib_packages:"},{"line_number":5,"context_line":"  common:"},{"line_number":6,"context_line":"  - ceph-common"},{"line_number":7,"context_line":"  - openstack-cinder"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"759bc266_e3d7d7c2","side":"PARENT","line":6,"updated":"2021-09-03 05:54:35.000000000","message":"maybe better to ensure it\u0027s installed for CS8? or is it also useless for that release?","commit_id":"bf443f9708e05fb04869ecbd3237cd324cb70348"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"b30c671df3456c0831695f684354f789e03be896","unresolved":true,"context_lines":[{"line_number":3,"context_line":"- run: dnf -y install {{ tcib_packages.common | join(\u0027 \u0027) }} \u0026\u0026 dnf clean all \u0026\u0026 rm -rf /var/cache/dnf"},{"line_number":4,"context_line":"tcib_packages:"},{"line_number":5,"context_line":"  common:"},{"line_number":6,"context_line":"  - ceph-common"},{"line_number":7,"context_line":"  - openstack-cinder"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"0303efda_ffd79cd5","side":"PARENT","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":15},"updated":"2021-09-30 22:33:05.000000000","message":"why are we removing this? should this go into an el8 specific package set?","commit_id":"1b1ef04b3e9ba203b3e7f06b74c46b0393b4b857"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"a95782eeee84b7290433cd4f455b8ef021d15432","unresolved":true,"context_lines":[{"line_number":3,"context_line":"- run: dnf -y install {{ tcib_packages.common | join(\u0027 \u0027) }} \u0026\u0026 dnf clean all \u0026\u0026 rm -rf /var/cache/dnf"},{"line_number":4,"context_line":"tcib_packages:"},{"line_number":5,"context_line":"  common:"},{"line_number":6,"context_line":"  - ceph-common"},{"line_number":7,"context_line":"  - openstack-cinder"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"c94cb206_4b3f5ead","side":"PARENT","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":15},"in_reply_to":"0303efda_ffd79cd5","updated":"2021-10-06 20:26:05.000000000","message":"It included in line 3 on the modified file.","commit_id":"1b1ef04b3e9ba203b3e7f06b74c46b0393b4b857"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"56ca3cd59a72b2b4f62870dd5ff60a09c6793e5e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"- run: dnf -y install {{ tcib_packages.common | join(\u0027 \u0027) }} \u0026\u0026 dnf clean all \u0026\u0026 rm -rf /var/cache/dnf"},{"line_number":4,"context_line":"tcib_packages:"},{"line_number":5,"context_line":"  common:"},{"line_number":6,"context_line":"  - ceph-common"},{"line_number":7,"context_line":"  - openstack-cinder"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"26cdcea0_d7ea0729","side":"PARENT","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":15},"in_reply_to":"c94cb206_4b3f5ead","updated":"2021-10-08 10:29:31.000000000","message":"Done","commit_id":"1b1ef04b3e9ba203b3e7f06b74c46b0393b4b857"}],"container-images/tcib/base/os/glance-api/glance-api.yaml":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"79bd59d6cb5a20c5a9118199ce7afbf883809aaf","unresolved":true,"context_lines":[{"line_number":11,"context_line":"  - mod_ssl"},{"line_number":12,"context_line":"  - openstack-glance"},{"line_number":13,"context_line":"  - python3-oslo-vmware"},{"line_number":14,"context_line":"  - python3-rados"},{"line_number":15,"context_line":"  - python3-rbd"},{"line_number":16,"context_line":"  - qemu-img"},{"line_number":17,"context_line":"tcib_user: glance"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"820d9d86_34f101d6","side":"PARENT","line":14,"updated":"2021-09-03 05:54:35.000000000","message":"ditto - CS8 doesn\u0027t need them?","commit_id":"bf443f9708e05fb04869ecbd3237cd324cb70348"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"82c13957c16c53c5e597b339023c7f432f893de3","unresolved":true,"context_lines":[{"line_number":12,"context_line":"  - mod_ssl"},{"line_number":13,"context_line":"  - openstack-glance"},{"line_number":14,"context_line":"  - python3-oslo-vmware"},{"line_number":15,"context_line":"  - qemu-img"},{"line_number":16,"context_line":"tcib_user: glance"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"2a8952d1_d35c583b","line":15,"updated":"2021-09-03 14:08:35.000000000","message":"It would be better to create a new group and here rather than moving them up into L3.  Also are these packages not going to be used in 9?\n\n\npreferred example (we do something similar for horizon+localization):\n\nL3: - run: if [ \u0027{{ tcib_release }}\u0027 \u003d\u003d \u00278\u0027]; then dnf -y install \"{{ tcib_packages.with_ceph | join(\u0027 \u0027) }}\"; fi\n\ntcib_packages:\n  common:\n    ...\n  with_ceph:\n    - python3-rados\n    - python3-rbd","commit_id":"37afa22c008e7d7c6d295a081510354e90a9d5ad"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"42a461589b8fdbfa9eb7926d66d9278285da2f86","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  - mod_ssl"},{"line_number":13,"context_line":"  - openstack-glance"},{"line_number":14,"context_line":"  - python3-oslo-vmware"},{"line_number":15,"context_line":"  - qemu-img"},{"line_number":16,"context_line":"tcib_user: glance"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"b93d48e3_996e757c","line":15,"in_reply_to":"2a8952d1_d35c583b","updated":"2021-09-08 10:46:56.000000000","message":"Done","commit_id":"37afa22c008e7d7c6d295a081510354e90a9d5ad"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"a7b94561beddadceee07a679b211ce40cc521236","unresolved":true,"context_lines":[{"line_number":1,"context_line":"tcib_actions:"},{"line_number":2,"context_line":"- run: bash /usr/local/bin/uid_gid_manage {{ tcib_user }}"},{"line_number":3,"context_line":"- run: if [ \u0027{{ tcib_release }}\u0027 \u003d\u003d \u00278\u0027 ];then dnf -y install {{ tcib_packages.with_ceph | join(\u0027 \u0027) }}; fi"},{"line_number":4,"context_line":"- run: dnf -y install {{ tcib_packages[\u0027common\u0027] | join(\u0027 \u0027) }} \u0026\u0026 dnf clean all \u0026\u0026 rm -rf /var/cache/dnf"},{"line_number":5,"context_line":"- run: cp /usr/share/openstack-tripleo-common-containers/container-images/kolla/glance-api/extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":6,"context_line":"- run: chmod 755 /usr/local/bin/kolla_extend_start"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"dd53cc2e_372b22dc","line":3,"range":{"start_line":3,"start_character":65,"end_line":3,"end_character":88},"updated":"2021-09-29 06:41:00.000000000","message":"same for these workarounds we will need to undo them once we get the packages on 9\n\nmaybe worth a tracker lp if we don\u0027t have one or perhaps something else you have to point to but adding a comment about this in the code would be helpful i think","commit_id":"69e0effd62e25fa310b5dc2415b8c1f373264aa7"}],"container-images/tcib/base/os/gnocchi-base/gnocchi-base.yaml":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"79bd59d6cb5a20c5a9118199ce7afbf883809aaf","unresolved":true,"context_lines":[{"line_number":4,"context_line":"tcib_packages:"},{"line_number":5,"context_line":"  common:"},{"line_number":6,"context_line":"  - gnocchi-common"},{"line_number":7,"context_line":"  - python3-rados"},{"line_number":8,"context_line":"  - python3-eventlet"},{"line_number":9,"context_line":"  - httpd"},{"line_number":10,"context_line":"  - librados2"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"ef7afbc2_ff340e34","side":"PARENT","line":7,"updated":"2021-09-03 05:54:35.000000000","message":"ditto - CS8?","commit_id":"bf443f9708e05fb04869ecbd3237cd324cb70348"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"82c13957c16c53c5e597b339023c7f432f893de3","unresolved":true,"context_lines":[{"line_number":7,"context_line":"  - gnocchi-common"},{"line_number":8,"context_line":"  - python3-eventlet"},{"line_number":9,"context_line":"  - httpd"},{"line_number":10,"context_line":"  - librados2"},{"line_number":11,"context_line":"  - mod_ssl"},{"line_number":12,"context_line":"  - python3-boto3"},{"line_number":13,"context_line":"  - python3-ldappool"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"e604ae09_556fe136","line":10,"updated":"2021-09-03 14:08:35.000000000","message":"see previous comment about different package section","commit_id":"37afa22c008e7d7c6d295a081510354e90a9d5ad"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"42a461589b8fdbfa9eb7926d66d9278285da2f86","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  - gnocchi-common"},{"line_number":8,"context_line":"  - python3-eventlet"},{"line_number":9,"context_line":"  - httpd"},{"line_number":10,"context_line":"  - librados2"},{"line_number":11,"context_line":"  - mod_ssl"},{"line_number":12,"context_line":"  - python3-boto3"},{"line_number":13,"context_line":"  - python3-ldappool"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"5715b49c_18452562","line":10,"in_reply_to":"e604ae09_556fe136","updated":"2021-09-08 10:46:56.000000000","message":"Done","commit_id":"37afa22c008e7d7c6d295a081510354e90a9d5ad"}],"container-images/tcib/base/os/horizon/horizon.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"82c13957c16c53c5e597b339023c7f432f893de3","unresolved":true,"context_lines":[{"line_number":2,"context_line":"- run: mv /etc/rpm/macros.image-language-conf /tmp \u0026\u0026 dnf -y install  {{ tcib_packages.with_localization | join(\u0027 \u0027) }}  \u0026\u0026 mv /tmp/macros.image-language-conf /etc/rpm \u0026\u0026 dnf -y install {{ tcib_packages.common | join(\u0027 \u0027) }} \u0026\u0026 dnf clean all \u0026\u0026 rm -rf /var/cache/dnf"},{"line_number":3,"context_line":"- run: cp /usr/share/openstack-tripleo-common-containers/container-images/kolla/horizon/extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":4,"context_line":"- run: chmod 755 /usr/local/bin/kolla_extend_start"},{"line_number":5,"context_line":"- run: \u0027sed -i -r \u0027\u0027s,^(Listen 80),#\\1,\u0027\u0027 /etc/httpd/conf/httpd.conf \u0026\u0026 sed -i -r \u0027\u0027s,^(Listen 443),#\\1,\u0027\u0027 /etc/httpd/conf.d/ssl.conf \u0026\u0026 ln -s /usr/share/openstack-dashboard/openstack_dashboard /usr/lib/python{{ tcib_python_version }}/site-packages/openstack_dashboard \u0026\u0026 ln -s /usr/share/openstack-dashboard/static /usr/lib/python{{ tcib_python_version }}/site-packages/static \u0026\u0026 chown -R apache /etc/openstack-dashboard /usr/share/openstack-dashboard \u0026\u0026 chown -R apache /usr/share/openstack-dashboard/static \u0026\u0026 sed -i \"s|WEBROOT \u003d \u0027\u0027/dashboard/\u0027\u0027|WEBROOT \u003d \u0027\u0027/\u0027\u0027|\" /etc/openstack-dashboard/local_settings \u0026\u0026 cp /usr/share/openstack-dashboard/manage.py /usr/bin/manage.py \u0026\u0026 rm -f /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/?[^_]*.py* \u0026\u0026 rm -f /usr/lib/python{{ tcib_python_version }}/site-packages/openstack_dashboard/local/enabled/?[^_]*.py* \u0026\u0026 for locale in /usr/lib/python{{ tcib_python_version }}/site-packages/*/locale; do (cd ${locale%/*} \u0026\u0026 /usr/bin/django-admin compilemessages) done\u0027"},{"line_number":6,"context_line":"- run: ln -s /usr/share/openstack-tripleo-common/healthcheck/horizon /openstack/healthcheck \u0026\u0026 chmod a+rx /openstack/healthcheck"},{"line_number":7,"context_line":"tcib_packages:"},{"line_number":8,"context_line":"  common:"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"70b9b8b5_c55d6762","line":5,"updated":"2021-09-03 14:08:35.000000000","message":"ah now i see the reason behind the python version.  though we could probably make the version lookup dynamic based on where the file actually exists.","commit_id":"37afa22c008e7d7c6d295a081510354e90a9d5ad"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"a7b94561beddadceee07a679b211ce40cc521236","unresolved":true,"context_lines":[{"line_number":2,"context_line":"- run: mv /etc/rpm/macros.image-language-conf /tmp \u0026\u0026 dnf -y install  {{ tcib_packages.with_localization | join(\u0027 \u0027) }}  \u0026\u0026 mv /tmp/macros.image-language-conf /etc/rpm \u0026\u0026 dnf -y install {{ tcib_packages.common | join(\u0027 \u0027) }} \u0026\u0026 dnf clean all \u0026\u0026 rm -rf /var/cache/dnf"},{"line_number":3,"context_line":"- run: cp /usr/share/openstack-tripleo-common-containers/container-images/kolla/horizon/extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":4,"context_line":"- run: chmod 755 /usr/local/bin/kolla_extend_start"},{"line_number":5,"context_line":"- run: \u0027sed -i -r \u0027\u0027s,^(Listen 80),#\\1,\u0027\u0027 /etc/httpd/conf/httpd.conf \u0026\u0026 sed -i -r \u0027\u0027s,^(Listen 443),#\\1,\u0027\u0027 /etc/httpd/conf.d/ssl.conf \u0026\u0026 ln -s /usr/share/openstack-dashboard/openstack_dashboard /usr/lib/python{{ tcib_python_version }}/site-packages/openstack_dashboard \u0026\u0026 ln -s /usr/share/openstack-dashboard/static /usr/lib/python{{ tcib_python_version }}/site-packages/static \u0026\u0026 chown -R apache /etc/openstack-dashboard /usr/share/openstack-dashboard \u0026\u0026 chown -R apache /usr/share/openstack-dashboard/static \u0026\u0026 sed -i \"s|WEBROOT \u003d \u0027\u0027/dashboard/\u0027\u0027|WEBROOT \u003d \u0027\u0027/\u0027\u0027|\" /etc/openstack-dashboard/local_settings \u0026\u0026 cp /usr/share/openstack-dashboard/manage.py /usr/bin/manage.py \u0026\u0026 rm -f /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/?[^_]*.py* \u0026\u0026 rm -f /usr/lib/python{{ tcib_python_version }}/site-packages/openstack_dashboard/local/enabled/?[^_]*.py* \u0026\u0026 for locale in /usr/lib/python{{ tcib_python_version }}/site-packages/*/locale; do (cd ${locale%/*} \u0026\u0026 /usr/bin/django-admin compilemessages) done\u0027"},{"line_number":6,"context_line":"- run: ln -s /usr/share/openstack-tripleo-common/healthcheck/horizon /openstack/healthcheck \u0026\u0026 chmod a+rx /openstack/healthcheck"},{"line_number":7,"context_line":"tcib_packages:"},{"line_number":8,"context_line":"  common:"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"fe06f30f_9168fbbd","line":5,"range":{"start_line":5,"start_character":212,"end_line":5,"end_character":231},"updated":"2021-09-29 06:41:00.000000000","message":"ok and this is passed via the depends-on https://review.opendev.org/c/openstack/tripleo-quickstart-extras/+/808056/4/roles/container-build/tasks/main.yaml\n\nBUT wont that break container build for train/ussuri/victoria where we aren\u0027t passing those things based on your conditional in that review ?\n\nEDIT: no because this is a branchful repo tripleo-common/master so we can just backport this to where we want (wallaby if we want 9 there i think we will eventually)","commit_id":"69e0effd62e25fa310b5dc2415b8c1f373264aa7"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"da4c73bfa528197484fccc61e64864f694621627","unresolved":true,"context_lines":[{"line_number":2,"context_line":"- run: mv /etc/rpm/macros.image-language-conf /tmp \u0026\u0026 dnf -y install  {{ tcib_packages.with_localization | join(\u0027 \u0027) }}  \u0026\u0026 mv /tmp/macros.image-language-conf /etc/rpm \u0026\u0026 dnf -y install {{ tcib_packages.common | join(\u0027 \u0027) }} \u0026\u0026 dnf clean all \u0026\u0026 rm -rf /var/cache/dnf"},{"line_number":3,"context_line":"- run: cp /usr/share/openstack-tripleo-common-containers/container-images/kolla/horizon/extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":4,"context_line":"- run: chmod 755 /usr/local/bin/kolla_extend_start"},{"line_number":5,"context_line":"- run: \u0027sed -i -r \u0027\u0027s,^(Listen 80),#\\1,\u0027\u0027 /etc/httpd/conf/httpd.conf \u0026\u0026 sed -i -r \u0027\u0027s,^(Listen 443),#\\1,\u0027\u0027 /etc/httpd/conf.d/ssl.conf \u0026\u0026 ln -s /usr/share/openstack-dashboard/openstack_dashboard /usr/lib/python{{ tcib_python_version }}/site-packages/openstack_dashboard \u0026\u0026 ln -s /usr/share/openstack-dashboard/static /usr/lib/python{{ tcib_python_version }}/site-packages/static \u0026\u0026 chown -R apache /etc/openstack-dashboard /usr/share/openstack-dashboard \u0026\u0026 chown -R apache /usr/share/openstack-dashboard/static \u0026\u0026 sed -i \"s|WEBROOT \u003d \u0027\u0027/dashboard/\u0027\u0027|WEBROOT \u003d \u0027\u0027/\u0027\u0027|\" /etc/openstack-dashboard/local_settings \u0026\u0026 cp /usr/share/openstack-dashboard/manage.py /usr/bin/manage.py \u0026\u0026 rm -f /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/?[^_]*.py* \u0026\u0026 rm -f /usr/lib/python{{ tcib_python_version }}/site-packages/openstack_dashboard/local/enabled/?[^_]*.py* \u0026\u0026 for locale in /usr/lib/python{{ tcib_python_version }}/site-packages/*/locale; do (cd ${locale%/*} \u0026\u0026 /usr/bin/django-admin compilemessages) done\u0027"},{"line_number":6,"context_line":"- run: ln -s /usr/share/openstack-tripleo-common/healthcheck/horizon /openstack/healthcheck \u0026\u0026 chmod a+rx /openstack/healthcheck"},{"line_number":7,"context_line":"tcib_packages:"},{"line_number":8,"context_line":"  common:"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"839f2ae8_1dd184f9","line":5,"range":{"start_line":5,"start_character":212,"end_line":5,"end_character":231},"in_reply_to":"fe06f30f_9168fbbd","updated":"2021-09-30 21:12:51.000000000","message":"I really wish this could be handled smarter than relying on a tcib variable because that\u0027s not really portable.  Alternatively was python* tried for these commands?","commit_id":"69e0effd62e25fa310b5dc2415b8c1f373264aa7"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"a4b2a30d180dafc46685b2dd99ffcb820bc08245","unresolved":true,"context_lines":[{"line_number":2,"context_line":"- run: mv /etc/rpm/macros.image-language-conf /tmp \u0026\u0026 dnf -y install  {{ tcib_packages.with_localization | join(\u0027 \u0027) }}  \u0026\u0026 mv /tmp/macros.image-language-conf /etc/rpm \u0026\u0026 dnf -y install {{ tcib_packages.common | join(\u0027 \u0027) }} \u0026\u0026 dnf clean all \u0026\u0026 rm -rf /var/cache/dnf"},{"line_number":3,"context_line":"- run: cp /usr/share/openstack-tripleo-common-containers/container-images/kolla/horizon/extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":4,"context_line":"- run: chmod 755 /usr/local/bin/kolla_extend_start"},{"line_number":5,"context_line":"- run: \u0027sed -i -r \u0027\u0027s,^(Listen 80),#\\1,\u0027\u0027 /etc/httpd/conf/httpd.conf \u0026\u0026 sed -i -r \u0027\u0027s,^(Listen 443),#\\1,\u0027\u0027 /etc/httpd/conf.d/ssl.conf \u0026\u0026 ln -s /usr/share/openstack-dashboard/openstack_dashboard /usr/lib/python{{ tcib_python_version }}/site-packages/openstack_dashboard \u0026\u0026 ln -s /usr/share/openstack-dashboard/static /usr/lib/python{{ tcib_python_version }}/site-packages/static \u0026\u0026 chown -R apache /etc/openstack-dashboard /usr/share/openstack-dashboard \u0026\u0026 chown -R apache /usr/share/openstack-dashboard/static \u0026\u0026 sed -i \"s|WEBROOT \u003d \u0027\u0027/dashboard/\u0027\u0027|WEBROOT \u003d \u0027\u0027/\u0027\u0027|\" /etc/openstack-dashboard/local_settings \u0026\u0026 cp /usr/share/openstack-dashboard/manage.py /usr/bin/manage.py \u0026\u0026 rm -f /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/?[^_]*.py* \u0026\u0026 rm -f /usr/lib/python{{ tcib_python_version }}/site-packages/openstack_dashboard/local/enabled/?[^_]*.py* \u0026\u0026 for locale in /usr/lib/python{{ tcib_python_version }}/site-packages/*/locale; do (cd ${locale%/*} \u0026\u0026 /usr/bin/django-admin compilemessages) done\u0027"},{"line_number":6,"context_line":"- run: ln -s /usr/share/openstack-tripleo-common/healthcheck/horizon /openstack/healthcheck \u0026\u0026 chmod a+rx /openstack/healthcheck"},{"line_number":7,"context_line":"tcib_packages:"},{"line_number":8,"context_line":"  common:"}],"source_content_type":"text/x-yaml","patch_set":56,"id":"b86462a9_2e1152a9","line":5,"range":{"start_line":5,"start_character":212,"end_line":5,"end_character":231},"updated":"2021-10-12 06:43:29.000000000","message":"i understand this is passed with tcib_extras, but how are we getting it here \n\n[EDIT]: ok from the tripleo-ci patch? https://review.opendev.org/c/openstack/tripleo-ci/+/800577/58/roles/build-containers/templates/tripleo-build.sh.j2\n\nso then this patch depends-on the tripleo-ci?","commit_id":"d064bfa38f4b4af72d501edf9eb75b1e22970384"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"d96feaaa1cbf78201897267c2273fb92996cd2dc","unresolved":true,"context_lines":[{"line_number":2,"context_line":"- run: mv /etc/rpm/macros.image-language-conf /tmp \u0026\u0026 dnf -y install  {{ tcib_packages.with_localization | join(\u0027 \u0027) }}  \u0026\u0026 mv /tmp/macros.image-language-conf /etc/rpm \u0026\u0026 dnf -y install {{ tcib_packages.common | join(\u0027 \u0027) }} \u0026\u0026 dnf clean all \u0026\u0026 rm -rf /var/cache/dnf"},{"line_number":3,"context_line":"- run: cp /usr/share/openstack-tripleo-common-containers/container-images/kolla/horizon/extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":4,"context_line":"- run: chmod 755 /usr/local/bin/kolla_extend_start"},{"line_number":5,"context_line":"- run: \u0027sed -i -r \u0027\u0027s,^(Listen 80),#\\1,\u0027\u0027 /etc/httpd/conf/httpd.conf \u0026\u0026 sed -i -r \u0027\u0027s,^(Listen 443),#\\1,\u0027\u0027 /etc/httpd/conf.d/ssl.conf \u0026\u0026 ln -s /usr/share/openstack-dashboard/openstack_dashboard /usr/lib/python{{ tcib_python_version }}/site-packages/openstack_dashboard \u0026\u0026 ln -s /usr/share/openstack-dashboard/static /usr/lib/python{{ tcib_python_version }}/site-packages/static \u0026\u0026 chown -R apache /etc/openstack-dashboard /usr/share/openstack-dashboard \u0026\u0026 chown -R apache /usr/share/openstack-dashboard/static \u0026\u0026 sed -i \"s|WEBROOT \u003d \u0027\u0027/dashboard/\u0027\u0027|WEBROOT \u003d \u0027\u0027/\u0027\u0027|\" /etc/openstack-dashboard/local_settings \u0026\u0026 cp /usr/share/openstack-dashboard/manage.py /usr/bin/manage.py \u0026\u0026 rm -f /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/?[^_]*.py* \u0026\u0026 rm -f /usr/lib/python{{ tcib_python_version }}/site-packages/openstack_dashboard/local/enabled/?[^_]*.py* \u0026\u0026 for locale in /usr/lib/python{{ tcib_python_version }}/site-packages/*/locale; do (cd ${locale%/*} \u0026\u0026 /usr/bin/django-admin compilemessages) done\u0027"},{"line_number":6,"context_line":"- run: ln -s /usr/share/openstack-tripleo-common/healthcheck/horizon /openstack/healthcheck \u0026\u0026 chmod a+rx /openstack/healthcheck"},{"line_number":7,"context_line":"tcib_packages:"},{"line_number":8,"context_line":"  common:"}],"source_content_type":"text/x-yaml","patch_set":56,"id":"09b6fd54_5e153501","line":5,"range":{"start_line":5,"start_character":212,"end_line":5,"end_character":231},"in_reply_to":"b86462a9_2e1152a9","updated":"2021-10-12 13:35:54.000000000","message":"yes","commit_id":"d064bfa38f4b4af72d501edf9eb75b1e22970384"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"12533bc91eff01bbc687bed16ff5249215cddd92","unresolved":true,"context_lines":[{"line_number":2,"context_line":"- run: mv /etc/rpm/macros.image-language-conf /tmp \u0026\u0026 dnf -y install  {{ tcib_packages.with_localization | join(\u0027 \u0027) }}  \u0026\u0026 mv /tmp/macros.image-language-conf /etc/rpm \u0026\u0026 dnf -y install {{ tcib_packages.common | join(\u0027 \u0027) }} \u0026\u0026 dnf clean all \u0026\u0026 rm -rf /var/cache/dnf"},{"line_number":3,"context_line":"- run: cp /usr/share/openstack-tripleo-common-containers/container-images/kolla/horizon/extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":4,"context_line":"- run: chmod 755 /usr/local/bin/kolla_extend_start"},{"line_number":5,"context_line":"- run: \u0027sed -i -r \u0027\u0027s,^(Listen 80),#\\1,\u0027\u0027 /etc/httpd/conf/httpd.conf \u0026\u0026 sed -i -r \u0027\u0027s,^(Listen 443),#\\1,\u0027\u0027 /etc/httpd/conf.d/ssl.conf \u0026\u0026 ln -s /usr/share/openstack-dashboard/openstack_dashboard /usr/lib/python{{ tcib_python_version | default(\u00273.9\u0027 if tcib_release \u003d\u003d \u00279\u0027 else \u00273.6\u0027) }}/site-packages/openstack_dashboard \u0026\u0026 ln -s /usr/share/openstack-dashboard/static /usr/lib/python{{ tcib_python_version | default(\u00273.9\u0027 if tcib_release \u003d\u003d \u00279\u0027 else \u00273.6\u0027) }}/site-packages/static \u0026\u0026 chown -R apache /etc/openstack-dashboard /usr/share/openstack-dashboard \u0026\u0026 chown -R apache /usr/share/openstack-dashboard/static \u0026\u0026 sed -i \"s|WEBROOT \u003d \u0027\u0027/dashboard/\u0027\u0027|WEBROOT \u003d \u0027\u0027/\u0027\u0027|\" /etc/openstack-dashboard/local_settings \u0026\u0026 cp /usr/share/openstack-dashboard/manage.py /usr/bin/manage.py \u0026\u0026 rm -f /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/?[^_]*.py* \u0026\u0026 rm -f /usr/lib/python{{ tcib_python_version | default(\u00273.9\u0027 if tcib_release \u003d\u003d \u00279\u0027 else \u00273.6\u0027) }}/site-packages/openstack_dashboard/local/enabled/?[^_]*.py* \u0026\u0026 for locale in /usr/lib/python{{ tcib_python_version | default(\u00273.9\u0027 if tcib_release \u003d\u003d \u00279\u0027 else \u00273.6\u0027) }}/site-packages/*/locale; do (cd ${locale%/*} \u0026\u0026 /usr/bin/django-admin compilemessages) done\u0027"},{"line_number":6,"context_line":"- run: ln -s /usr/share/openstack-tripleo-common/healthcheck/horizon /openstack/healthcheck \u0026\u0026 chmod a+rx /openstack/healthcheck"},{"line_number":7,"context_line":"tcib_packages:"},{"line_number":8,"context_line":"  common:"}],"source_content_type":"text/x-yaml","patch_set":64,"id":"4bcf8aff_a8d86816","line":5,"range":{"start_line":5,"start_character":212,"end_line":5,"end_character":282},"updated":"2021-10-13 05:12:40.000000000","message":"Updated this part if someone misses to set tcib_python_version","commit_id":"a679d7ea76843eab90c2a93b49993de2704b790d"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"e1be60449abe71be97df4f76fbbf72b66f2e6af1","unresolved":true,"context_lines":[{"line_number":2,"context_line":"- run: mv /etc/rpm/macros.image-language-conf /tmp \u0026\u0026 dnf -y install  {{ tcib_packages.with_localization | join(\u0027 \u0027) }}  \u0026\u0026 mv /tmp/macros.image-language-conf /etc/rpm \u0026\u0026 dnf -y install {{ tcib_packages.common | join(\u0027 \u0027) }} \u0026\u0026 dnf clean all \u0026\u0026 rm -rf /var/cache/dnf"},{"line_number":3,"context_line":"- run: cp /usr/share/openstack-tripleo-common-containers/container-images/kolla/horizon/extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":4,"context_line":"- run: chmod 755 /usr/local/bin/kolla_extend_start"},{"line_number":5,"context_line":"- run: \u0027sed -i -r \u0027\u0027s,^(Listen 80),#\\1,\u0027\u0027 /etc/httpd/conf/httpd.conf \u0026\u0026 sed -i -r \u0027\u0027s,^(Listen 443),#\\1,\u0027\u0027 /etc/httpd/conf.d/ssl.conf \u0026\u0026 ln -s /usr/share/openstack-dashboard/openstack_dashboard /usr/lib/python{{ tcib_python_version | default(\u00273.9\u0027 if tcib_release \u003d\u003d \u00279\u0027 else \u00273.6\u0027) }}/site-packages/openstack_dashboard \u0026\u0026 ln -s /usr/share/openstack-dashboard/static /usr/lib/python{{ tcib_python_version | default(\u00273.9\u0027 if tcib_release \u003d\u003d \u00279\u0027 else \u00273.6\u0027) }}/site-packages/static \u0026\u0026 chown -R apache /etc/openstack-dashboard /usr/share/openstack-dashboard \u0026\u0026 chown -R apache /usr/share/openstack-dashboard/static \u0026\u0026 sed -i \"s|WEBROOT \u003d \u0027\u0027/dashboard/\u0027\u0027|WEBROOT \u003d \u0027\u0027/\u0027\u0027|\" /etc/openstack-dashboard/local_settings \u0026\u0026 cp /usr/share/openstack-dashboard/manage.py /usr/bin/manage.py \u0026\u0026 rm -f /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/?[^_]*.py* \u0026\u0026 rm -f /usr/lib/python{{ tcib_python_version | default(\u00273.9\u0027 if tcib_release \u003d\u003d \u00279\u0027 else \u00273.6\u0027) }}/site-packages/openstack_dashboard/local/enabled/?[^_]*.py* \u0026\u0026 for locale in /usr/lib/python{{ tcib_python_version | default(\u00273.9\u0027 if tcib_release \u003d\u003d \u00279\u0027 else \u00273.6\u0027) }}/site-packages/*/locale; do (cd ${locale%/*} \u0026\u0026 /usr/bin/django-admin compilemessages) done\u0027"},{"line_number":6,"context_line":"- run: ln -s /usr/share/openstack-tripleo-common/healthcheck/horizon /openstack/healthcheck \u0026\u0026 chmod a+rx /openstack/healthcheck"},{"line_number":7,"context_line":"tcib_packages:"},{"line_number":8,"context_line":"  common:"}],"source_content_type":"text/x-yaml","patch_set":64,"id":"5d5600d7_e61159fa","line":5,"range":{"start_line":5,"start_character":212,"end_line":5,"end_character":282},"in_reply_to":"4bcf8aff_a8d86816","updated":"2021-10-13 06:37:27.000000000","message":"same as my other comment lets use is version to guard again int vs string here","commit_id":"a679d7ea76843eab90c2a93b49993de2704b790d"}],"container-images/tcib/base/os/ironic-base/ironic-pxe/ironic-pxe.yaml":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"79bd59d6cb5a20c5a9118199ce7afbf883809aaf","unresolved":true,"context_lines":[{"line_number":2,"context_line":"- run: dnf -y install {{ tcib_packages[\u0027common\u0027] | join(\u0027 \u0027) }} \u0026\u0026 dnf clean all \u0026\u0026 rm -rf /var/cache/dnf"},{"line_number":3,"context_line":"- run: \u003e-"},{"line_number":4,"context_line":"    if [ \u0027{{ tcib_release }}\u0027 \u003d\u003d \u00278\u0027 ];then"},{"line_number":5,"context_line":"    dnf -y install tftp-server;"},{"line_number":6,"context_line":"    fi"},{"line_number":7,"context_line":"- run: sed -i -r \u0027s,^(Listen 80),#\\1,\u0027 /etc/httpd/conf/httpd.conf  \u0026\u0026 sed -i -r \u0027s,^(Listen 443),#\\1,\u0027 /etc/httpd/conf.d/ssl.conf"},{"line_number":8,"context_line":"- run: echo -e \"re ^(/tftpboot/) /tftpboot/\\2\\nre ^/tftpboot/ /tftpboot/\\nre ^(^/) /tftpboot/\\1\\nre ^([^/]) /tftpboot/\\1\" \u003e /map-file"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"ea75ec12_1bbfe6cd","line":5,"updated":"2021-09-03 05:54:35.000000000","message":"why isn\u0027t it installed at this point? Isn\u0027t it some dependency on ironic?","commit_id":"4f11e99132792f97ee1ae4d00c3980e298b613d9"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"82c13957c16c53c5e597b339023c7f432f893de3","unresolved":true,"context_lines":[{"line_number":3,"context_line":"- run: \u003e-"},{"line_number":4,"context_line":"    if [ \u0027{{ tcib_release }}\u0027 \u003d\u003d \u00278\u0027 ];then"},{"line_number":5,"context_line":"    dnf -y install tftp-server;"},{"line_number":6,"context_line":"    fi"},{"line_number":7,"context_line":"- run: sed -i -r \u0027s,^(Listen 80),#\\1,\u0027 /etc/httpd/conf/httpd.conf  \u0026\u0026 sed -i -r \u0027s,^(Listen 443),#\\1,\u0027 /etc/httpd/conf.d/ssl.conf"},{"line_number":8,"context_line":"- run: echo -e \"re ^(/tftpboot/) /tftpboot/\\2\\nre ^/tftpboot/ /tftpboot/\\nre ^(^/) /tftpboot/\\1\\nre ^([^/]) /tftpboot/\\1\" \u003e /map-file"},{"line_number":9,"context_line":"- run: echo \". /usr/local/bin/kolla_httpd_setup\"\u003e /usr/local/bin/kolla_extend_start \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"2cf540c8_81463b11","line":6,"updated":"2021-09-03 14:08:35.000000000","message":"see comment in glance","commit_id":"37afa22c008e7d7c6d295a081510354e90a9d5ad"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"42a461589b8fdbfa9eb7926d66d9278285da2f86","unresolved":false,"context_lines":[{"line_number":3,"context_line":"- run: \u003e-"},{"line_number":4,"context_line":"    if [ \u0027{{ tcib_release }}\u0027 \u003d\u003d \u00278\u0027 ];then"},{"line_number":5,"context_line":"    dnf -y install tftp-server;"},{"line_number":6,"context_line":"    fi"},{"line_number":7,"context_line":"- run: sed -i -r \u0027s,^(Listen 80),#\\1,\u0027 /etc/httpd/conf/httpd.conf  \u0026\u0026 sed -i -r \u0027s,^(Listen 443),#\\1,\u0027 /etc/httpd/conf.d/ssl.conf"},{"line_number":8,"context_line":"- run: echo -e \"re ^(/tftpboot/) /tftpboot/\\2\\nre ^/tftpboot/ /tftpboot/\\nre ^(^/) /tftpboot/\\1\\nre ^([^/]) /tftpboot/\\1\" \u003e /map-file"},{"line_number":9,"context_line":"- run: echo \". /usr/local/bin/kolla_httpd_setup\"\u003e /usr/local/bin/kolla_extend_start \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"c0c5a64b_13bb9dd6","line":6,"in_reply_to":"2cf540c8_81463b11","updated":"2021-09-08 10:46:56.000000000","message":"Done","commit_id":"37afa22c008e7d7c6d295a081510354e90a9d5ad"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"80e22e1e05a70bd997319627cda04d5ed5958157","unresolved":true,"context_lines":[{"line_number":14,"context_line":"  - syslinux-tftpboot"},{"line_number":15,"context_line":"  - dnsmasq"},{"line_number":16,"context_line":"  el8:"},{"line_number":17,"context_line":"  - tftp-server"}],"source_content_type":"text/x-yaml","patch_set":54,"id":"9f23b7be_35088a84","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":2},"updated":"2021-10-11 10:59:37.000000000","message":"tftp-server was removed from the container in https://review.opendev.org/q/I01f90814e0a2574ba0bb6526ded63c0e886495f4 so i guess it\u0027s not longer needed even for el8.","commit_id":"965bba2ceb0a64ec3a8cc98b16e86cc3327032fc"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"d96feaaa1cbf78201897267c2273fb92996cd2dc","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  - syslinux-tftpboot"},{"line_number":15,"context_line":"  - dnsmasq"},{"line_number":16,"context_line":"  el8:"},{"line_number":17,"context_line":"  - tftp-server"}],"source_content_type":"text/x-yaml","patch_set":54,"id":"0bb1390a_7a69a925","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":2},"in_reply_to":"9f23b7be_35088a84","updated":"2021-10-12 13:35:54.000000000","message":"Done","commit_id":"965bba2ceb0a64ec3a8cc98b16e86cc3327032fc"}],"container-images/tcib/base/os/keystone/keystone.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"a4b2a30d180dafc46685b2dd99ffcb820bc08245","unresolved":true,"context_lines":[{"line_number":1,"context_line":"tcib_actions:"},{"line_number":2,"context_line":"- run: bash /usr/local/bin/uid_gid_manage keystone"},{"line_number":3,"context_line":"- run: \u003e-"},{"line_number":4,"context_line":"    if [ \u0027{{ tcib_release }}\u0027 \u003d\u003d \u00278\u0027 ];then"},{"line_number":5,"context_line":"    dnf module -y enable mod_auth_openidc; fi"},{"line_number":6,"context_line":"- run: dnf -y install {{ tcib_packages[\u0027common\u0027] | join(\u0027 \u0027) }} \u0026\u0026 dnf clean all \u0026\u0026 rm -rf /var/cache/dnf"},{"line_number":7,"context_line":"- run: mkdir -p /var/www/cgi-bin/keystone \u0026\u0026 chown -R keystone /var/www/cgi-bin/keystone"}],"source_content_type":"text/x-yaml","patch_set":56,"id":"2fa5212e_d456dfa3","line":4,"range":{"start_line":4,"start_character":13,"end_line":4,"end_character":25},"updated":"2021-10-12 06:43:29.000000000","message":"so this depends-on https://review.opendev.org/c/openstack/tripleo-ci/+/800577/58/roles/build-containers/templates/tripleo-build.sh.j2 ?","commit_id":"d064bfa38f4b4af72d501edf9eb75b1e22970384"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"d96feaaa1cbf78201897267c2273fb92996cd2dc","unresolved":true,"context_lines":[{"line_number":1,"context_line":"tcib_actions:"},{"line_number":2,"context_line":"- run: bash /usr/local/bin/uid_gid_manage keystone"},{"line_number":3,"context_line":"- run: \u003e-"},{"line_number":4,"context_line":"    if [ \u0027{{ tcib_release }}\u0027 \u003d\u003d \u00278\u0027 ];then"},{"line_number":5,"context_line":"    dnf module -y enable mod_auth_openidc; fi"},{"line_number":6,"context_line":"- run: dnf -y install {{ tcib_packages[\u0027common\u0027] | join(\u0027 \u0027) }} \u0026\u0026 dnf clean all \u0026\u0026 rm -rf /var/cache/dnf"},{"line_number":7,"context_line":"- run: mkdir -p /var/www/cgi-bin/keystone \u0026\u0026 chown -R keystone /var/www/cgi-bin/keystone"}],"source_content_type":"text/x-yaml","patch_set":56,"id":"e5f67502_45cb7354","line":4,"range":{"start_line":4,"start_character":13,"end_line":4,"end_character":25},"in_reply_to":"2fa5212e_d456dfa3","updated":"2021-10-12 13:35:54.000000000","message":"Yes","commit_id":"d064bfa38f4b4af72d501edf9eb75b1e22970384"}],"container-images/tcib/base/os/manila-base/manila-share/manila-share.yaml":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"79bd59d6cb5a20c5a9118199ce7afbf883809aaf","unresolved":true,"context_lines":[{"line_number":3,"context_line":"- run: mkdir -p /etc/libqb"},{"line_number":4,"context_line":"tcib_packages:"},{"line_number":5,"context_line":"  common:"},{"line_number":6,"context_line":"  - ceph-common"},{"line_number":7,"context_line":"  - libqb"},{"line_number":8,"context_line":"  - openstack-manila-share"},{"line_number":9,"context_line":"  - pacemaker"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"557ca14f_7ad04389","side":"PARENT","line":6,"updated":"2021-09-03 05:54:35.000000000","message":"ditto - CS8?","commit_id":"bf443f9708e05fb04869ecbd3237cd324cb70348"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"b30c671df3456c0831695f684354f789e03be896","unresolved":true,"context_lines":[{"line_number":3,"context_line":"- run: mkdir -p /etc/libqb"},{"line_number":4,"context_line":"tcib_packages:"},{"line_number":5,"context_line":"  common:"},{"line_number":6,"context_line":"  - ceph-common"},{"line_number":7,"context_line":"  - libqb"},{"line_number":8,"context_line":"  - openstack-manila-share"},{"line_number":9,"context_line":"  - pacemaker"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"8aed76a7_c73a24f1","side":"PARENT","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":15},"updated":"2021-09-30 22:33:05.000000000","message":"should this be moved into an el8 specific package set?","commit_id":"1b1ef04b3e9ba203b3e7f06b74c46b0393b4b857"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"56ca3cd59a72b2b4f62870dd5ff60a09c6793e5e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"- run: mkdir -p /etc/libqb"},{"line_number":4,"context_line":"tcib_packages:"},{"line_number":5,"context_line":"  common:"},{"line_number":6,"context_line":"  - ceph-common"},{"line_number":7,"context_line":"  - libqb"},{"line_number":8,"context_line":"  - openstack-manila-share"},{"line_number":9,"context_line":"  - pacemaker"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"675769fd_219fb71e","side":"PARENT","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":15},"in_reply_to":"8aed76a7_c73a24f1","updated":"2021-10-08 10:29:31.000000000","message":"Done","commit_id":"1b1ef04b3e9ba203b3e7f06b74c46b0393b4b857"}],"container-images/tcib/base/os/nova-base/nova-compute/nova-compute.yaml":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"79bd59d6cb5a20c5a9118199ce7afbf883809aaf","unresolved":true,"context_lines":[{"line_number":7,"context_line":"- run: ln -s /usr/share/openstack-tripleo-common/healthcheck/nova-compute /openstack/healthcheck \u0026\u0026  chmod a+rx /openstack/healthcheck"},{"line_number":8,"context_line":"tcib_packages:"},{"line_number":9,"context_line":"  common:"},{"line_number":10,"context_line":"  - ceph-common"},{"line_number":11,"context_line":"  - device-mapper-multipath"},{"line_number":12,"context_line":"  - e2fsprogs"},{"line_number":13,"context_line":"  - genisoimage"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"e98baf56_b64ff6f1","side":"PARENT","line":10,"updated":"2021-09-03 05:54:35.000000000","message":"ditto - CS8?","commit_id":"bf443f9708e05fb04869ecbd3237cd324cb70348"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"b30c671df3456c0831695f684354f789e03be896","unresolved":true,"context_lines":[{"line_number":7,"context_line":"- run: ln -s /usr/share/openstack-tripleo-common/healthcheck/nova-compute /openstack/healthcheck \u0026\u0026  chmod a+rx /openstack/healthcheck"},{"line_number":8,"context_line":"tcib_packages:"},{"line_number":9,"context_line":"  common:"},{"line_number":10,"context_line":"  - ceph-common"},{"line_number":11,"context_line":"  - device-mapper-multipath"},{"line_number":12,"context_line":"  - e2fsprogs"},{"line_number":13,"context_line":"  - genisoimage"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"f1cedc31_47e76eda","side":"PARENT","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":15},"updated":"2021-09-30 22:33:05.000000000","message":"should this be moved into an el8 specific package set?","commit_id":"1b1ef04b3e9ba203b3e7f06b74c46b0393b4b857"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"56ca3cd59a72b2b4f62870dd5ff60a09c6793e5e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"- run: ln -s /usr/share/openstack-tripleo-common/healthcheck/nova-compute /openstack/healthcheck \u0026\u0026  chmod a+rx /openstack/healthcheck"},{"line_number":8,"context_line":"tcib_packages:"},{"line_number":9,"context_line":"  common:"},{"line_number":10,"context_line":"  - ceph-common"},{"line_number":11,"context_line":"  - device-mapper-multipath"},{"line_number":12,"context_line":"  - e2fsprogs"},{"line_number":13,"context_line":"  - genisoimage"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"c51811b8_eb4593bc","side":"PARENT","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":15},"in_reply_to":"f1cedc31_47e76eda","updated":"2021-10-08 10:29:31.000000000","message":"Done","commit_id":"1b1ef04b3e9ba203b3e7f06b74c46b0393b4b857"}],"container-images/tcib/base/os/nova-base/nova-libvirt/nova-libvirt.yaml":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"79bd59d6cb5a20c5a9118199ce7afbf883809aaf","unresolved":true,"context_lines":[{"line_number":4,"context_line":"- run: ln -s /usr/share/openstack-tripleo-common/healthcheck/nova-libvirt /openstack/healthcheck \u0026\u0026 chmod a+rx /openstack/healthcheck"},{"line_number":5,"context_line":"tcib_packages:"},{"line_number":6,"context_line":"  common:"},{"line_number":7,"context_line":"  - ceph-common"},{"line_number":8,"context_line":"  - cyrus-sasl-scram"},{"line_number":9,"context_line":"  - libguestfs"},{"line_number":10,"context_line":"  - libseccomp"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"675033c6_c0f4db9f","side":"PARENT","line":7,"updated":"2021-09-03 05:54:35.000000000","message":"ditto - CS8?","commit_id":"bf443f9708e05fb04869ecbd3237cd324cb70348"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"b30c671df3456c0831695f684354f789e03be896","unresolved":true,"context_lines":[{"line_number":4,"context_line":"- run: ln -s /usr/share/openstack-tripleo-common/healthcheck/nova-libvirt /openstack/healthcheck \u0026\u0026 chmod a+rx /openstack/healthcheck"},{"line_number":5,"context_line":"tcib_packages:"},{"line_number":6,"context_line":"  common:"},{"line_number":7,"context_line":"  - ceph-common"},{"line_number":8,"context_line":"  - cyrus-sasl-scram"},{"line_number":9,"context_line":"  - libguestfs"},{"line_number":10,"context_line":"  - libseccomp"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"a1d005f4_75cfba4c","side":"PARENT","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":15},"updated":"2021-09-30 22:33:05.000000000","message":"should this be moved into an el8 specific package set?","commit_id":"1b1ef04b3e9ba203b3e7f06b74c46b0393b4b857"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"56ca3cd59a72b2b4f62870dd5ff60a09c6793e5e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"- run: ln -s /usr/share/openstack-tripleo-common/healthcheck/nova-libvirt /openstack/healthcheck \u0026\u0026 chmod a+rx /openstack/healthcheck"},{"line_number":5,"context_line":"tcib_packages:"},{"line_number":6,"context_line":"  common:"},{"line_number":7,"context_line":"  - ceph-common"},{"line_number":8,"context_line":"  - cyrus-sasl-scram"},{"line_number":9,"context_line":"  - libguestfs"},{"line_number":10,"context_line":"  - libseccomp"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"811a2d00_4d62b58c","side":"PARENT","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":15},"in_reply_to":"a1d005f4_75cfba4c","updated":"2021-10-08 10:29:31.000000000","message":"Done","commit_id":"1b1ef04b3e9ba203b3e7f06b74c46b0393b4b857"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"b30c671df3456c0831695f684354f789e03be896","unresolved":true,"context_lines":[{"line_number":19,"context_line":"  - podman"},{"line_number":20,"context_line":"  - qemu-kvm"},{"line_number":21,"context_line":"  - swtpm"},{"line_number":22,"context_line":"  - trousers"},{"line_number":23,"context_line":"  x86_64:"},{"line_number":24,"context_line":"  - edk2-ovmf"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"06aeffee_777f2491","side":"PARENT","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":12},"updated":"2021-09-30 22:33:05.000000000","message":"should this be moved into an el8 specific package set?","commit_id":"1b1ef04b3e9ba203b3e7f06b74c46b0393b4b857"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"56ca3cd59a72b2b4f62870dd5ff60a09c6793e5e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  - podman"},{"line_number":20,"context_line":"  - qemu-kvm"},{"line_number":21,"context_line":"  - swtpm"},{"line_number":22,"context_line":"  - trousers"},{"line_number":23,"context_line":"  x86_64:"},{"line_number":24,"context_line":"  - edk2-ovmf"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"126ca688_55d4df53","side":"PARENT","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":12},"in_reply_to":"06aeffee_777f2491","updated":"2021-10-08 10:29:31.000000000","message":"Done","commit_id":"1b1ef04b3e9ba203b3e7f06b74c46b0393b4b857"}],"container-images/tcib/base/qdrouterd/qdrouterd.yaml":[{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"80e22e1e05a70bd997319627cda04d5ed5958157","unresolved":true,"context_lines":[{"line_number":5,"context_line":"- run: ln -s /usr/share/openstack-tripleo-common/healthcheck/qdrouterd /openstack/healthcheck \u0026\u0026 chmod a+rx /openstack/healthcheck"},{"line_number":6,"context_line":"tcib_packages:"},{"line_number":7,"context_line":"  common:"},{"line_number":8,"context_line":"  - cyrus-sasl-lib"},{"line_number":9,"context_line":"  - cyrus-sasl-plain"},{"line_number":10,"context_line":"  el8:"},{"line_number":11,"context_line":"  - qpid-dispatch-router"}],"source_content_type":"text/x-yaml","patch_set":54,"id":"cdc0104d_55ca030d","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":1},"updated":"2021-10-11 10:59:37.000000000","message":"given that qrouterd container without qrouterd install will not be useful at all, wouldn\u0027t it be better to skip this container when building in el9?","commit_id":"965bba2ceb0a64ec3a8cc98b16e86cc3327032fc"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"9dc7ae9db5c557bf97e17594d4965d76b8639972","unresolved":true,"context_lines":[{"line_number":5,"context_line":"- run: ln -s /usr/share/openstack-tripleo-common/healthcheck/qdrouterd /openstack/healthcheck \u0026\u0026 chmod a+rx /openstack/healthcheck"},{"line_number":6,"context_line":"tcib_packages:"},{"line_number":7,"context_line":"  common:"},{"line_number":8,"context_line":"  - cyrus-sasl-lib"},{"line_number":9,"context_line":"  - cyrus-sasl-plain"},{"line_number":10,"context_line":"  el8:"},{"line_number":11,"context_line":"  - qpid-dispatch-router"}],"source_content_type":"text/x-yaml","patch_set":54,"id":"622bc7f7_651085c5","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":1},"in_reply_to":"cdc0104d_55ca030d","updated":"2021-10-11 12:39:35.000000000","message":"We will skip this container for el9 in a separate patch on tripleo-ci side. As it requires some work in design changes there.","commit_id":"965bba2ceb0a64ec3a8cc98b16e86cc3327032fc"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"46e056ef64f91d8fa275b89b377c620cd62dda21","unresolved":true,"context_lines":[{"line_number":7,"context_line":"  common:"},{"line_number":8,"context_line":"  - cyrus-sasl-lib"},{"line_number":9,"context_line":"  - cyrus-sasl-plain"},{"line_number":10,"context_line":"  el8:"},{"line_number":11,"context_line":"  - qpid-dispatch-router"},{"line_number":12,"context_line":"  - qpid-dispatch-tools"},{"line_number":13,"context_line":"tcib_user: qdrouterd"}],"source_content_type":"text/x-yaml","patch_set":68,"id":"15ceeabd_9d21efc1","line":10,"updated":"2021-10-14 07:19:39.000000000","message":"these tools are incredibly useful and should not be dropped.","commit_id":"f558eaa75a12cc2f1c3147f61c57510e51859c99"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"e888c47db0162625377d18ab0f2ca7a112564762","unresolved":true,"context_lines":[{"line_number":7,"context_line":"  common:"},{"line_number":8,"context_line":"  - cyrus-sasl-lib"},{"line_number":9,"context_line":"  - cyrus-sasl-plain"},{"line_number":10,"context_line":"  el8:"},{"line_number":11,"context_line":"  - qpid-dispatch-router"},{"line_number":12,"context_line":"  - qpid-dispatch-tools"},{"line_number":13,"context_line":"tcib_user: qdrouterd"}],"source_content_type":"text/x-yaml","patch_set":68,"id":"38a0e4ba_ef0be587","line":10,"in_reply_to":"15ceeabd_9d21efc1","updated":"2021-10-14 07:22:12.000000000","message":"Since these packages are not yet available for cs9, so we are restricting it to EL8 (not dropping it.) Once the packages will be available, we will remove this condition.","commit_id":"f558eaa75a12cc2f1c3147f61c57510e51859c99"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"daaf8b42c82f2de511a844f61c520e18ae2dc4b9","unresolved":true,"context_lines":[{"line_number":7,"context_line":"  common:"},{"line_number":8,"context_line":"  - cyrus-sasl-lib"},{"line_number":9,"context_line":"  - cyrus-sasl-plain"},{"line_number":10,"context_line":"  el8:"},{"line_number":11,"context_line":"  - qpid-dispatch-router"},{"line_number":12,"context_line":"  - qpid-dispatch-tools"},{"line_number":13,"context_line":"tcib_user: qdrouterd"}],"source_content_type":"text/x-yaml","patch_set":68,"id":"80c34736_df1f088d","line":10,"in_reply_to":"38a0e4ba_ef0be587","updated":"2021-10-14 07:29:58.000000000","message":"Not installing the packages on a given condition is the same as removing them (to me). This creates technical debt and a regression. It would be easier and better IMHO to just build the packages and go on with our lives.","commit_id":"f558eaa75a12cc2f1c3147f61c57510e51859c99"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"28c76327cf416a8302a1a2d5e305173228cfe849","unresolved":true,"context_lines":[{"line_number":7,"context_line":"  common:"},{"line_number":8,"context_line":"  - cyrus-sasl-lib"},{"line_number":9,"context_line":"  - cyrus-sasl-plain"},{"line_number":10,"context_line":"  el8:"},{"line_number":11,"context_line":"  - qpid-dispatch-router"},{"line_number":12,"context_line":"  - qpid-dispatch-tools"},{"line_number":13,"context_line":"tcib_user: qdrouterd"}],"source_content_type":"text/x-yaml","patch_set":68,"id":"c0fd91c9_90510d5f","line":10,"in_reply_to":"58a02eda_9e7656bc","updated":"2021-10-15 08:49:12.000000000","message":"https://cbs.centos.org/koji/buildinfo?buildID\u003d35542","commit_id":"f558eaa75a12cc2f1c3147f61c57510e51859c99"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"5e0759d4e4f8f2dbe3b4705f3df80e0c613c250d","unresolved":true,"context_lines":[{"line_number":7,"context_line":"  common:"},{"line_number":8,"context_line":"  - cyrus-sasl-lib"},{"line_number":9,"context_line":"  - cyrus-sasl-plain"},{"line_number":10,"context_line":"  el8:"},{"line_number":11,"context_line":"  - qpid-dispatch-router"},{"line_number":12,"context_line":"  - qpid-dispatch-tools"},{"line_number":13,"context_line":"tcib_user: qdrouterd"}],"source_content_type":"text/x-yaml","patch_set":68,"id":"898e291f_7531e2e2","line":10,"in_reply_to":"80c34736_df1f088d","updated":"2021-10-15 06:45:46.000000000","message":"qpid-dispatch-router and qpid-dispatch-tools come from http://mirror.centos.org/centos-8/8/cloud/x86_64/openstack-victoria/Packages/q/\n\nAre you intending to build them for centos 9?","commit_id":"f558eaa75a12cc2f1c3147f61c57510e51859c99"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"1700abca5ee647adc8a8f831daae520f0effc3d9","unresolved":true,"context_lines":[{"line_number":7,"context_line":"  common:"},{"line_number":8,"context_line":"  - cyrus-sasl-lib"},{"line_number":9,"context_line":"  - cyrus-sasl-plain"},{"line_number":10,"context_line":"  el8:"},{"line_number":11,"context_line":"  - qpid-dispatch-router"},{"line_number":12,"context_line":"  - qpid-dispatch-tools"},{"line_number":13,"context_line":"tcib_user: qdrouterd"}],"source_content_type":"text/x-yaml","patch_set":68,"id":"58a02eda_9e7656bc","line":10,"in_reply_to":"898e291f_7531e2e2","updated":"2021-10-15 07:21:09.000000000","message":"My plan is to wait for messaging SIG to deliver it and crosstag it when done. I may rebuild the latest fedora build (i already scratch built it for testing) but i think messaging sig should be maintaining it.\n\nAlthough i agree that not installing it is creating technical debt, not testing openstack/tripleo in CS9 has the same effect for all openstack, so i\u0027d move ahead with this exception and remove it once we have qpid-dispatch ready.","commit_id":"f558eaa75a12cc2f1c3147f61c57510e51859c99"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"cc5ab71e9c3f636e3ecd9ed09213db4a875a2aed","unresolved":true,"context_lines":[{"line_number":7,"context_line":"  common:"},{"line_number":8,"context_line":"  - cyrus-sasl-lib"},{"line_number":9,"context_line":"  - cyrus-sasl-plain"},{"line_number":10,"context_line":"  el8:"},{"line_number":11,"context_line":"  - qpid-dispatch-router"},{"line_number":12,"context_line":"  - qpid-dispatch-tools"},{"line_number":13,"context_line":"tcib_user: qdrouterd"}],"source_content_type":"text/x-yaml","patch_set":68,"id":"c269567b_267c4e9a","line":10,"in_reply_to":"c0fd91c9_90510d5f","updated":"2021-10-15 09:24:55.000000000","message":"Thanks a bunch!","commit_id":"f558eaa75a12cc2f1c3147f61c57510e51859c99"}],"container-images/tcib/base/tripleoclient/tripleoclient.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"82c13957c16c53c5e597b339023c7f432f893de3","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    dnf -y install ceph-ansible;"},{"line_number":6,"context_line":"    else"},{"line_number":7,"context_line":"    dnf -y install cephadm;"},{"line_number":8,"context_line":"    fi"},{"line_number":9,"context_line":"- run: dnf -y install {{ tcib_packages[\u0027common\u0027] | join(\u0027 \u0027) }} \u0026\u0026 dnf clean all \u0026\u0026 rm -rf /var/cache/dnf"},{"line_number":10,"context_line":"- run: openstack complete | tee /etc/bash_completion.d/osc.bash_completion \u003e /dev/null"},{"line_number":11,"context_line":"- run: cp /usr/share/openstack-tripleo-common-containers/container-images/kolla/tripleoclient/create_super_user.sh /usr/local/bin/create_super_user.sh"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"f8c46cb5_cfdb83a1","line":8,"updated":"2021-09-03 14:08:35.000000000","message":"actually this should just be cephadm now. you don\u0027t need to continue with ceph-ansible","commit_id":"37afa22c008e7d7c6d295a081510354e90a9d5ad"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"42a461589b8fdbfa9eb7926d66d9278285da2f86","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    dnf -y install ceph-ansible;"},{"line_number":6,"context_line":"    else"},{"line_number":7,"context_line":"    dnf -y install cephadm;"},{"line_number":8,"context_line":"    fi"},{"line_number":9,"context_line":"- run: dnf -y install {{ tcib_packages[\u0027common\u0027] | join(\u0027 \u0027) }} \u0026\u0026 dnf clean all \u0026\u0026 rm -rf /var/cache/dnf"},{"line_number":10,"context_line":"- run: openstack complete | tee /etc/bash_completion.d/osc.bash_completion \u003e /dev/null"},{"line_number":11,"context_line":"- run: cp /usr/share/openstack-tripleo-common-containers/container-images/kolla/tripleoclient/create_super_user.sh /usr/local/bin/create_super_user.sh"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"3059e44b_d1b14d28","line":8,"in_reply_to":"f8c46cb5_cfdb83a1","updated":"2021-09-08 10:46:56.000000000","message":"Done","commit_id":"37afa22c008e7d7c6d295a081510354e90a9d5ad"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"b30c671df3456c0831695f684354f789e03be896","unresolved":true,"context_lines":[{"line_number":19,"context_line":"  - xfsprogs"},{"line_number":20,"context_line":"  - python3-osc-placement"},{"line_number":21,"context_line":"  - bash-completion"},{"line_number":22,"context_line":"  - ceph-ansible"},{"line_number":23,"context_line":"tcib_user: cloud-admin"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"1fbb8bf7_1253ae19","side":"PARENT","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":16},"updated":"2021-09-30 22:33:05.000000000","message":"should this be moved into an el8 specific package set?","commit_id":"1b1ef04b3e9ba203b3e7f06b74c46b0393b4b857"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"56ca3cd59a72b2b4f62870dd5ff60a09c6793e5e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  - xfsprogs"},{"line_number":20,"context_line":"  - python3-osc-placement"},{"line_number":21,"context_line":"  - bash-completion"},{"line_number":22,"context_line":"  - ceph-ansible"},{"line_number":23,"context_line":"tcib_user: cloud-admin"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"6c4c3bdd_2655c60d","side":"PARENT","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":16},"in_reply_to":"1fbb8bf7_1253ae19","updated":"2021-10-08 10:29:31.000000000","message":"Done","commit_id":"1b1ef04b3e9ba203b3e7f06b74c46b0393b4b857"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"98ecdc1d21f8b8c45ce76809bfffcc01fd563e1a","unresolved":true,"context_lines":[{"line_number":2,"context_line":"- run: bash /usr/local/bin/uid_gid_manage {{ tcib_user }}"},{"line_number":3,"context_line":"- run: \u003e-"},{"line_number":4,"context_line":"    if [ \u0027{{ tcib_release }}\u0027 \u003d\u003d \u00278\u0027 ];then"},{"line_number":5,"context_line":"    dnf -y install {{ tcib_packages[\u0027el8\u0027] | join(\u0027 \u0027) }};"},{"line_number":6,"context_line":"    else"},{"line_number":7,"context_line":"    dnf -y install {{ tcib_packages[\u0027el9\u0027] | join(\u0027 \u0027) }}; fi"},{"line_number":8,"context_line":"- run: dnf -y install {{ tcib_packages[\u0027common\u0027] | join(\u0027 \u0027) }} \u0026\u0026 dnf clean all \u0026\u0026 rm -rf /var/cache/dnf"}],"source_content_type":"text/x-yaml","patch_set":58,"id":"e06f9ab0_067a47da","line":5,"range":{"start_line":5,"start_character":36,"end_line":5,"end_character":41},"updated":"2021-10-12 13:45:13.000000000","message":"You coiuld do \u0027el\u0027 ~ tcib_release and not bother with an if condition","commit_id":"3200c19d1388460b57e4d75d7f5b543a845bddcb"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"67d0556ea4f3ca88d31f8068d672b7b169eb8f33","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- run: bash /usr/local/bin/uid_gid_manage {{ tcib_user }}"},{"line_number":3,"context_line":"- run: \u003e-"},{"line_number":4,"context_line":"    if [ \u0027{{ tcib_release }}\u0027 \u003d\u003d \u00278\u0027 ];then"},{"line_number":5,"context_line":"    dnf -y install {{ tcib_packages[\u0027el8\u0027] | join(\u0027 \u0027) }};"},{"line_number":6,"context_line":"    else"},{"line_number":7,"context_line":"    dnf -y install {{ tcib_packages[\u0027el9\u0027] | join(\u0027 \u0027) }}; fi"},{"line_number":8,"context_line":"- run: dnf -y install {{ tcib_packages[\u0027common\u0027] | join(\u0027 \u0027) }} \u0026\u0026 dnf clean all \u0026\u0026 rm -rf /var/cache/dnf"}],"source_content_type":"text/x-yaml","patch_set":58,"id":"919674fa_5912498a","line":5,"range":{"start_line":5,"start_character":36,"end_line":5,"end_character":41},"in_reply_to":"e06f9ab0_067a47da","updated":"2021-10-12 14:30:36.000000000","message":"Done","commit_id":"3200c19d1388460b57e4d75d7f5b543a845bddcb"}],"scripts/containerfile-converter.py":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"da4c73bfa528197484fccc61e64864f694621627","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":49,"id":"efcbcfcd_56f257e1","updated":"2021-09-30 21:12:51.000000000","message":"why is this file mode 644 now?","commit_id":"69e0effd62e25fa310b5dc2415b8c1f373264aa7"}]}