)]}'
{"scripts/tripleo-mount-image":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2c97d426b25d62a6f9445f0281fa23e4e608c04b","unresolved":true,"context_lines":[{"line_number":28,"context_line":"fi"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# supported LVM devices and mount points for whole-disk overcloud images"},{"line_number":31,"context_line":"MOUNTS\u003d\"/dev/mapper/vg-lv_var:/var \\"},{"line_number":32,"context_line":"        /dev/mapper/vg-lv_log:/var/log \\"},{"line_number":33,"context_line":"        /dev/mapper/vg-lv_audit:/var/log/audit \\"},{"line_number":34,"context_line":"        /dev/mapper/vg-lv_home:/home \\"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"631a039b_b46ff942","line":31,"updated":"2021-09-07 07:07:01.000000000","message":"nice... you don\u0027t need a \u0027proper\u0027 bash array as you\u0027re always only feeding this into for x in $MOUNTS and not trying to access ${MOUNTS[1]} for example.","commit_id":"5f55ee2bd1bd03f911500f5eb2e1005df851a792"}],"scripts/tripleo-unmount-image":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"217c546248bd3c59ac848fb85ddb5bf29364acc2","unresolved":true,"context_lines":[{"line_number":70,"context_line":"set -x"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"if mountpoint \"$MOUNT_DIR\"; then"},{"line_number":73,"context_line":"    unmount_volume $MOUNT_DIR/var/log/audit"},{"line_number":74,"context_line":"    unmount_volume $MOUNT_DIR/var/log"},{"line_number":75,"context_line":"    unmount_volume $MOUNT_DIR/var"},{"line_number":76,"context_line":"    unmount_volume $MOUNT_DIR/home"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"85d7c623_26501f84","line":73,"range":{"start_line":73,"start_character":27,"end_line":73,"end_character":42},"updated":"2021-09-01 07:32:49.000000000","message":"trying to think of how to make it less repetitive, this list appears in both the mount-image and unmount-image scripts.\n\nEven if you don\u0027t have them defined in a common location it would be nicer to have this in a bash array (\"this\" I mean \u0027var/log\u0027, \u0027var\u0027 \u0027home\u0027 etc) and then loop through calling unmount_volume\n\nIdeally the list would be shared by both of the scripts but you may not want to have yet another file for \u0027common\u0027 stuff...","commit_id":"50616b13244d2b57b89af293c3f822b3cbc87354"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"0a961e78c87bf78ece140924726b47255a852ee8","unresolved":false,"context_lines":[{"line_number":70,"context_line":"set -x"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"if mountpoint \"$MOUNT_DIR\"; then"},{"line_number":73,"context_line":"    unmount_volume $MOUNT_DIR/var/log/audit"},{"line_number":74,"context_line":"    unmount_volume $MOUNT_DIR/var/log"},{"line_number":75,"context_line":"    unmount_volume $MOUNT_DIR/var"},{"line_number":76,"context_line":"    unmount_volume $MOUNT_DIR/home"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"b016afb5_92e22990","line":73,"range":{"start_line":73,"start_character":27,"end_line":73,"end_character":42},"in_reply_to":"3340bed9_0c432eae","updated":"2021-09-06 23:13:38.000000000","message":"Done","commit_id":"50616b13244d2b57b89af293c3f822b3cbc87354"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"8dd5034bb14d3f46df9cc03a87e05fccdc27e4ee","unresolved":true,"context_lines":[{"line_number":70,"context_line":"set -x"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"if mountpoint \"$MOUNT_DIR\"; then"},{"line_number":73,"context_line":"    unmount_volume $MOUNT_DIR/var/log/audit"},{"line_number":74,"context_line":"    unmount_volume $MOUNT_DIR/var/log"},{"line_number":75,"context_line":"    unmount_volume $MOUNT_DIR/var"},{"line_number":76,"context_line":"    unmount_volume $MOUNT_DIR/home"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3340bed9_0c432eae","line":73,"range":{"start_line":73,"start_character":27,"end_line":73,"end_character":42},"in_reply_to":"85d7c623_26501f84","updated":"2021-09-01 21:50:28.000000000","message":"I could make tripleo-unmount-image a symlink to tripleo-mount-image. Then the one file can have the data structures required to do this.","commit_id":"50616b13244d2b57b89af293c3f822b3cbc87354"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"217c546248bd3c59ac848fb85ddb5bf29364acc2","unresolved":true,"context_lines":[{"line_number":82,"context_line":"qemu-nbd --disconnect $NBD_DEVICE"},{"line_number":83,"context_line":"vgchange --refresh vg || true"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"remove_device vg-lv_root"},{"line_number":86,"context_line":"remove_device vg-lv_var"},{"line_number":87,"context_line":"remove_device vg-lv_log"},{"line_number":88,"context_line":"remove_device vg-lv_audit"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"cbcc2a83_f40b06ef","line":85,"range":{"start_line":85,"start_character":15,"end_line":85,"end_character":22},"updated":"2021-09-01 07:32:49.000000000","message":"same with these i.e. loop through some variable that holds these and call remove_device","commit_id":"50616b13244d2b57b89af293c3f822b3cbc87354"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2c97d426b25d62a6f9445f0281fa23e4e608c04b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"tripleo-mount-image"}],"source_content_type":"x-git/symlink","patch_set":3,"id":"7b48f2fb_2cccc987","line":1,"updated":"2021-09-07 07:07:01.000000000","message":"nice :)","commit_id":"5f55ee2bd1bd03f911500f5eb2e1005df851a792"}]}