)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"3eaf70731848dc960d5ad8b0b158e1098a03e6ca","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"We need to remove this dependency from TCIB."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: https://review.opendev.org/c/openstack/nova/+/808921/"},{"line_number":14,"context_line":"Related: https://bugzilla.redhat.com/show_bug.cgi?id\u003d2002949"},{"line_number":15,"context_line":"Change-Id: I6c3798c40b7f5c241a7eb13d2ae01cd23fd943b5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"96169daa_4f62a96f","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":65},"updated":"2021-09-15 19:34:57.000000000","message":"As discussed on the call today we aren\u0027t going to go ahead with this change of the in-code default in Nova until Yoga so in the short term we will need TripleO/THT/puppet-nova to default the mkisofs_cmd [1] configurable to mkisofs (currently genisoimage) when using el9.\n\n[1] https://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.mkisofs_cmd","commit_id":"2732aeb3e3a39fe796f36482bcfe59bb6fa17193"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"d07f3d216dc33f64fc17dad2f208eae7cc4b947a","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"We need to remove this dependency from TCIB."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: https://review.opendev.org/c/openstack/nova/+/808921/"},{"line_number":14,"context_line":"Related: https://bugzilla.redhat.com/show_bug.cgi?id\u003d2002949"},{"line_number":15,"context_line":"Change-Id: I6c3798c40b7f5c241a7eb13d2ae01cd23fd943b5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a9fe0586_e04514f9","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":65},"in_reply_to":"0ca607c5_67b511d0","updated":"2021-09-16 08:36:02.000000000","message":"yes we need the puppet-nova change. that\u0027s not what I wanted to say. But we could set mkisofs as the default in puppet-nova if other distributions also set a link for mkisofs to genisoimage for the current genisoimage package, makes sense?","commit_id":"2732aeb3e3a39fe796f36482bcfe59bb6fa17193"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"b56f2e50ec6835f3d7a99654f202ce6651f86d9e","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"We need to remove this dependency from TCIB."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: https://review.opendev.org/c/openstack/nova/+/808921/"},{"line_number":14,"context_line":"Related: https://bugzilla.redhat.com/show_bug.cgi?id\u003d2002949"},{"line_number":15,"context_line":"Change-Id: I6c3798c40b7f5c241a7eb13d2ae01cd23fd943b5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"513098d4_2f9e6407","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":65},"in_reply_to":"294373c1_6b16b3fb","updated":"2021-09-16 07:58:14.000000000","message":"Ah cool, if xorriso does the same between /usr/bin/genisoimage and /etc/alternatives/mkisofs then we can just switch the package for now without puppet-nova or THT changes.","commit_id":"2732aeb3e3a39fe796f36482bcfe59bb6fa17193"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"729ac5b741b7709dc94777b238571f57e440e424","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"We need to remove this dependency from TCIB."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: https://review.opendev.org/c/openstack/nova/+/808921/"},{"line_number":14,"context_line":"Related: https://bugzilla.redhat.com/show_bug.cgi?id\u003d2002949"},{"line_number":15,"context_line":"Change-Id: I6c3798c40b7f5c241a7eb13d2ae01cd23fd943b5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"294373c1_6b16b3fb","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":65},"in_reply_to":"2c07ecfb_82a58317","updated":"2021-09-16 06:22:36.000000000","message":"xorriso seems to be available from rhel-8-for-x86_64-appstream-rpms","commit_id":"2732aeb3e3a39fe796f36482bcfe59bb6fa17193"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"35d734b0e57ea4649c3e9965f12197daf4439009","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"We need to remove this dependency from TCIB."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: https://review.opendev.org/c/openstack/nova/+/808921/"},{"line_number":14,"context_line":"Related: https://bugzilla.redhat.com/show_bug.cgi?id\u003d2002949"},{"line_number":15,"context_line":"Change-Id: I6c3798c40b7f5c241a7eb13d2ae01cd23fd943b5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a48a7ac_3398e2e9","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":65},"in_reply_to":"3df2f69f_8d31fdf3","updated":"2021-09-16 12:14:28.000000000","message":"\u003e in el8 with genisoimage, mkisofs is a link to genisoimage, so mkisofs is availability with either package and could be used as the default in puppet-nova if other distributions do the same?\n\u003e \n\u003e # ll /usr/bin/mkisofs\n\u003e lrwxrwxrwx. 1 root root 25 Dec 11  2020 /usr/bin/mkisofs -\u003e /etc/alternatives/mkisofs\n\u003e # ll /etc/alternatives/mkisofs\n\u003e lrwxrwxrwx. 1 root root 20 Dec 11  2020 /etc/alternatives/mkisofs -\u003e /usr/bin/genisoimage\n\nso we should keep genisoimage package then, to keep that link around and to no break c8 based backports","commit_id":"2732aeb3e3a39fe796f36482bcfe59bb6fa17193"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"46885b8c3e4310f120cc10ce6348fdb15be4a6f7","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"We need to remove this dependency from TCIB."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: https://review.opendev.org/c/openstack/nova/+/808921/"},{"line_number":14,"context_line":"Related: https://bugzilla.redhat.com/show_bug.cgi?id\u003d2002949"},{"line_number":15,"context_line":"Change-Id: I6c3798c40b7f5c241a7eb13d2ae01cd23fd943b5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"0ca607c5_67b511d0","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":65},"in_reply_to":"513098d4_2f9e6407","updated":"2021-09-16 08:03:47.000000000","message":"It doesn\u0027t AFAICT so my -1 here still applies, I think we need to..\n\n- Add xorriso to the containers alongside genisoimage \n- Update puppet-nova and THT to switch the mkisofs_cmd configurable over to mkisofs (dependent on the above change)\n- Remove genisoimage from the container (dependent on the above change)\n- Backport the above series back to stable/wallaby\n\nThoughts?","commit_id":"2732aeb3e3a39fe796f36482bcfe59bb6fa17193"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"e9508a261f680c3db9a889410025734090f884ba","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"We need to remove this dependency from TCIB."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: https://review.opendev.org/c/openstack/nova/+/808921/"},{"line_number":14,"context_line":"Related: https://bugzilla.redhat.com/show_bug.cgi?id\u003d2002949"},{"line_number":15,"context_line":"Change-Id: I6c3798c40b7f5c241a7eb13d2ae01cd23fd943b5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ac1ceb2f_ae0c7768","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":65},"in_reply_to":"5a48a7ac_3398e2e9","updated":"2021-09-25 22:01:03.000000000","message":"\u003e so we should keep genisoimage package then, to keep that link around and to no break c8 based backports\n\nI\u0027m not sure we can keep genisoimage package in TCIB as it will fail to build the containers in el9:\n\n\u003e run: dnf -y install {{ tcib_packages[\u0027common\u0027] | join(\u0027 \u0027) }} \u0026\u0026 dnf clean all \u0026\u0026 rm -rf /var/cache/dnf\n\nI believe that we should just leave xorriso in the containers since it\u0027s available in both el8 and el9, and maybe have puppet-nova either install or remove genisoimage/xorriso depending on major release and define mkisofs_cmd based on that as well?\n\nIn Ubuntu, mkisofs is not part of alternatives, but symlinks directly to genisoimages, as opposed to CentOS that goes through alternatives, so we need to keep that in mind if we symlink.\n\nIf the dependent change goes through, we don\u0027t need to change mkisofs_cmd in tht as it will work by default on all distros.\n\nLet me know if I\u0027m missing something.","commit_id":"2732aeb3e3a39fe796f36482bcfe59bb6fa17193"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"1ad3985a44c322048c8639d75c59aa9646728a4f","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"We need to remove this dependency from TCIB."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: https://review.opendev.org/c/openstack/nova/+/808921/"},{"line_number":14,"context_line":"Related: https://bugzilla.redhat.com/show_bug.cgi?id\u003d2002949"},{"line_number":15,"context_line":"Change-Id: I6c3798c40b7f5c241a7eb13d2ae01cd23fd943b5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"949057fb_b04b1c96","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":65},"in_reply_to":"5fe9d030_c71d0705","updated":"2021-09-15 23:21:57.000000000","message":"Sorry my understanding is that W, X and Y are going to be under C9/RHEL9, so that would be necessary on all these branches. Let\u0027s sync up later about this.","commit_id":"2732aeb3e3a39fe796f36482bcfe59bb6fa17193"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"f35f31a2516a72ecf373b67671ed64ce41761e0e","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"We need to remove this dependency from TCIB."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: https://review.opendev.org/c/openstack/nova/+/808921/"},{"line_number":14,"context_line":"Related: https://bugzilla.redhat.com/show_bug.cgi?id\u003d2002949"},{"line_number":15,"context_line":"Change-Id: I6c3798c40b7f5c241a7eb13d2ae01cd23fd943b5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"2c07ecfb_82a58317","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":65},"in_reply_to":"949057fb_b04b1c96","updated":"2021-09-16 06:19:38.000000000","message":"yes, that\u0027s what I suggested in the call, if xorriso is available for el8 and el9, lets switch per default to use the new package for both versions starting W, so that we do not have to add a condition to differentiate which package needs to be available for el8/9 and just make puppet-nova to configure mkisofs_cmd which we set via ooo tht to mkisofs.\n\nBTW, I don\u0027t know about other distributions, but in el8 with genisoimage, mkisofs is a link to genisoimage, so mkisofs is availability with either package and could be used as the default in puppet-nova if other distributions do the same?\n\n# ll /usr/bin/mkisofs\nlrwxrwxrwx. 1 root root 25 Dec 11  2020 /usr/bin/mkisofs -\u003e /etc/alternatives/mkisofs\n# ll /etc/alternatives/mkisofs\nlrwxrwxrwx. 1 root root 20 Dec 11  2020 /etc/alternatives/mkisofs -\u003e /usr/bin/genisoimage","commit_id":"2732aeb3e3a39fe796f36482bcfe59bb6fa17193"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"ff2db77bc84cd6a425d62e801697c1471e5a09ed","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"We need to remove this dependency from TCIB."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: https://review.opendev.org/c/openstack/nova/+/808921/"},{"line_number":14,"context_line":"Related: https://bugzilla.redhat.com/show_bug.cgi?id\u003d2002949"},{"line_number":15,"context_line":"Change-Id: I6c3798c40b7f5c241a7eb13d2ae01cd23fd943b5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fe9d030_c71d0705","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":65},"in_reply_to":"96169daa_4f62a96f","updated":"2021-09-15 19:38:40.000000000","message":"\u003e when using el9.\n\nSorry I missed that this change was actually working when building centos 8 containers, as a result we can just switch straight over to mkisofs by default across both el8 and el9 while also backporting that to stable/wallaby for 17.","commit_id":"2732aeb3e3a39fe796f36482bcfe59bb6fa17193"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"8a58ab1df5a4feab74da4ca55736eb8f1513b644","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"We need to remove this dependency from TCIB."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: https://review.opendev.org/c/openstack/nova/+/808921/"},{"line_number":14,"context_line":"Related: https://bugzilla.redhat.com/show_bug.cgi?id\u003d2002949"},{"line_number":15,"context_line":"Change-Id: I6c3798c40b7f5c241a7eb13d2ae01cd23fd943b5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3df2f69f_8d31fdf3","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":65},"in_reply_to":"a9fe0586_e04514f9","updated":"2021-09-16 08:43:13.000000000","message":"Yup that works.","commit_id":"2732aeb3e3a39fe796f36482bcfe59bb6fa17193"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"99fa98bb0cfaa2580d6e7b90138568dffde43745","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"63207863_0144a1fa","updated":"2021-10-11 23:36:56.000000000","message":"recheck","commit_id":"b6df8024229b95d3abf5fae0672176bf657d8a45"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"1178b2779cba290169b3ffe1fba6c2daf2af1009","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b01a620c_b6adc088","updated":"2021-10-12 05:42:14.000000000","message":"recheck","commit_id":"b6df8024229b95d3abf5fae0672176bf657d8a45"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"3832cb6a81bc25e9520a9dd053260ccf58d00862","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e8c9bd0b_1efc56bb","updated":"2021-10-12 11:46:51.000000000","message":"recheck","commit_id":"b6df8024229b95d3abf5fae0672176bf657d8a45"}]}