)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"9a52c5f6cc3922f1a592c8fed31c7c6deb3b1dc0","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix permissions for deployments"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If you run the deployment with a global become, the permissions on the"},{"line_number":10,"context_line":"deployment output folder is root which causes it to fail."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"2021-10-25 17:21:12.735097 | 5254006a-0342-081e-9547-00000000043e |"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"4aef5f9e_3dcf046a","line":9,"range":{"start_line":9,"start_character":26,"end_line":9,"end_character":30},"updated":"2021-10-25 22:25:19.000000000","message":"should be without, will fix later","commit_id":"b56790d8833b5c7db44cc84cc3f4280f7d9d4bfe"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"e0c3e78399723dbf7947e860490fbe2b96b1adcc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"126d2921_8f673a0e","updated":"2021-11-04 10:39:51.000000000","message":"recheck","commit_id":"f9377d062bb4c9fe11c1e9698dcae614540dfb81"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"6e4685683512a5ccb97d4521fd4a20c0f8517c4e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1c2b0d9b_4317334b","updated":"2021-10-27 15:38:19.000000000","message":"recheck","commit_id":"f9377d062bb4c9fe11c1e9698dcae614540dfb81"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"41bb82753a80cee3a1aabafdeed3b13d9e2b03d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cdf58e21_44173e00","updated":"2021-11-07 22:14:43.000000000","message":"recheck","commit_id":"f9377d062bb4c9fe11c1e9698dcae614540dfb81"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"b68f08cd09ce495c512200ff212fd6ad2759e0f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d0df6828_45cc16e4","updated":"2021-11-07 22:14:27.000000000","message":"recheck","commit_id":"f9377d062bb4c9fe11c1e9698dcae614540dfb81"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"979fcabff2762e858856506bbb0d16b01daad7a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f604b75d_e23ae0a0","updated":"2021-11-01 14:37:37.000000000","message":"recheck","commit_id":"f9377d062bb4c9fe11c1e9698dcae614540dfb81"}],"tripleo_common/templates/deployments.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"7e50505f6f8e2f09d2a293c52df404657a771f38","unresolved":true,"context_lines":[{"line_number":13,"context_line":"    deployment_group: \"{{ lookup(\u0027file\u0027, tripleo_role_name ~ \u0027/\u0027 ~ ansible_facts[\u0027hostname\u0027] | lower ~ \u0027/\u0027 ~ item) | from_yaml | json_query(item_group) }}\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- name: Hiera check and diff mode"},{"line_number":16,"context_line":"  become: true"},{"line_number":17,"context_line":"  block:"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    - name: Create hiera check-mode directory"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"2af917ee_d9a6c5fa","line":16,"updated":"2021-10-26 12:37:31.000000000","message":"wouldn\u0027t that make files created with become no longer accessible for regular (sudo-less) deployments afterwards?","commit_id":"b56790d8833b5c7db44cc84cc3f4280f7d9d4bfe"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"8cee805e1f59417238c7d8512c7823d2169e827e","unresolved":true,"context_lines":[{"line_number":13,"context_line":"    deployment_group: \"{{ lookup(\u0027file\u0027, tripleo_role_name ~ \u0027/\u0027 ~ ansible_facts[\u0027hostname\u0027] | lower ~ \u0027/\u0027 ~ item) | from_yaml | json_query(item_group) }}\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- name: Hiera check and diff mode"},{"line_number":16,"context_line":"  become: true"},{"line_number":17,"context_line":"  block:"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    - name: Create hiera check-mode directory"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a2221c12_6d6f66d9","line":16,"in_reply_to":"2af917ee_d9a6c5fa","updated":"2021-10-26 13:53:24.000000000","message":"all the file creation/modification is already done as root.  The reason we don\u0027t hit this is because we run the main playbook with become.  I hit this because in my test I wasn\u0027t running the main deployment playbook with become and had one of these in it.","commit_id":"b56790d8833b5c7db44cc84cc3f4280f7d9d4bfe"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"6d84b541d6014af0c01066005a2186523588c5cb","unresolved":true,"context_lines":[{"line_number":13,"context_line":"    deployment_group: \"{{ lookup(\u0027file\u0027, tripleo_role_name ~ \u0027/\u0027 ~ ansible_facts[\u0027hostname\u0027] | lower ~ \u0027/\u0027 ~ item) | from_yaml | json_query(item_group) }}\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- name: Hiera check and diff mode"},{"line_number":16,"context_line":"  block:"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    - name: Create hiera check-mode directory"},{"line_number":19,"context_line":"      become: true"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"23419e3a_7b8a187b","line":16,"range":{"start_line":16,"start_character":1,"end_line":16,"end_character":8},"updated":"2021-11-03 13:38:02.000000000","message":"nit: would be easier just to have \"become: true\" here in block","commit_id":"f9377d062bb4c9fe11c1e9698dcae614540dfb81"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"eb5bb605e7f60583259308a45443d06cd58c48b2","unresolved":true,"context_lines":[{"line_number":13,"context_line":"    deployment_group: \"{{ lookup(\u0027file\u0027, tripleo_role_name ~ \u0027/\u0027 ~ ansible_facts[\u0027hostname\u0027] | lower ~ \u0027/\u0027 ~ item) | from_yaml | json_query(item_group) }}\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- name: Hiera check and diff mode"},{"line_number":16,"context_line":"  block:"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    - name: Create hiera check-mode directory"},{"line_number":19,"context_line":"      become: true"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"67a4123c_34309740","line":16,"range":{"start_line":16,"start_character":1,"end_line":16,"end_character":8},"in_reply_to":"23419e3a_7b8a187b","updated":"2021-11-03 13:59:07.000000000","message":"True, but there are some things that don\u0027t need become in this block so I opted to just apply it to the commands that needed it. My original patch had it here but i noticed that we already have it in the block","commit_id":"f9377d062bb4c9fe11c1e9698dcae614540dfb81"}]}