)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"0a060ba670123e7bbcb59bfe135f2495bf17e6f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1311619d_00647583","updated":"2021-11-10 17:01:26.000000000","message":"I tested manually on a not hardened undercloud as follow:\n- Download the overcloud-hardened as user stack\n- Create temporary directory\n- Use the tripleo-mount-image to mount the image\n- Use the tripleo-unmount-image to unmount\n- Try to mount it again and fail.\n-- reboot the undercloud to start again\n- Modify the tripleo-unmount-image with the patch\n- Mount, umount and mount again (this time it worked)\n\nBTW, nothing related to this patch\n-----------------------------------\nI realized that the scripts:\n-rwxr-xr-x. 1 root root  6096 Nov 10 16:47 /usr/bin/tripleo-mount-image\n-rwxr-xr-x. 1 root root  6096 Nov 10 16:50 /usr/bin/tripleo-unmount-image\n\nThey are two separate scripts.\nShould we keep them as one or should we split them?\n","commit_id":"02941066880241c14865589473bd471f8b37cd62"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"37b74f6ff76431bc64dc61e4ef063f5eb69b5fa5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3c9b8f07_cc249f94","updated":"2021-11-10 23:28:47.000000000","message":"modify-image worked on https://logserver.rdoproject.org/65/31165/55/check/tripleo-ci-centos-8-ovb-3ctlr_1comp-featureset001/a927187/job-output.txt","commit_id":"02941066880241c14865589473bd471f8b37cd62"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"7a983e3343c29ece025a3b1693609cbf54daa6f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"df284df7_8baabaa5","updated":"2021-11-11 12:39:55.000000000","message":"OK, seems like worked fine","commit_id":"cc2a64572ddf90401476b1f1ce52b7c62b3b24ad"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"a3ccf13127e3f79ce28388546e27a2fa13dde9d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"74afea09_7953b036","updated":"2021-11-15 04:14:13.000000000","message":"Thanks for this fix, I\u0027ve proposed a backport to wallaby https://review.opendev.org/c/openstack/tripleo-common/+/817889","commit_id":"cc2a64572ddf90401476b1f1ce52b7c62b3b24ad"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"bcbfc85cdeaa1bcd1d8719f98ab48ed374106f43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c8cd125f_4076c496","updated":"2021-11-11 10:28:32.000000000","message":"This should be tested in the job that actually runs the code with modifying image, better in a few branches. The job that runs on this patch doesn\u0027t test it.\nI run the test in testproject: https://review.rdoproject.org/r/c/testproject/+/36699","commit_id":"cc2a64572ddf90401476b1f1ce52b7c62b3b24ad"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"bb326b42e8b48c094827dc1000fd315b3064f03b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d0fd921d_33d8e3c1","in_reply_to":"9490aeba_db228b40","updated":"2021-11-11 12:28:53.000000000","message":"Great, now I\u0027m testing it for other branches as well.","commit_id":"cc2a64572ddf90401476b1f1ce52b7c62b3b24ad"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"cd693707fd1652cb0be56a4e09b2804cd604a4bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9490aeba_db228b40","in_reply_to":"c8cd125f_4076c496","updated":"2021-11-11 11:11:47.000000000","message":"This was tested here https://review.rdoproject.org/r/c/testproject/+/31165 by Ronelle.","commit_id":"cc2a64572ddf90401476b1f1ce52b7c62b3b24ad"}],"scripts/tripleo-mount-image":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3195bd0ddc0db794569395b505a822d0d0249d2c","unresolved":true,"context_lines":[{"line_number":159,"context_line":"    # `--activate n` makes LVs inactive, they must be set"},{"line_number":160,"context_line":"    # inactive so that the nbd device can be disconnected."},{"line_number":161,"context_line":"    # Ref bug: https://bugs.launchpad.net/tripleo/+bug/1950137"},{"line_number":162,"context_line":"    vgchange --activate n vg || true"},{"line_number":163,"context_line":"    qemu-nbd --disconnect $NBD_DEVICE"},{"line_number":164,"context_line":"    vgchange --refresh vg || true"},{"line_number":165,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"b2b68f80_44d97bc9","line":162,"range":{"start_line":162,"start_character":14,"end_line":162,"end_character":26},"updated":"2021-11-11 08:20:10.000000000","message":"seems counterintuitive but man page confirmed it ;)\n\n       -a|--activate y|n|ay\n              Change the active state of LVs.  An active LV can be used\n              through a block device, allowing data on the LV to be\n              accessed.  y makes LVs active, or available.  n makes LVs\n              inactive, or unavailable.  The block device for the LV is\n\n\nhttps://www.man7.org/linux/man-pages/man8/vgchange.8.html","commit_id":"02941066880241c14865589473bd471f8b37cd62"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3195bd0ddc0db794569395b505a822d0d0249d2c","unresolved":true,"context_lines":[{"line_number":215,"context_line":"        mount_show_options 1"},{"line_number":216,"context_line":"    fi"},{"line_number":217,"context_line":"    mount_image"},{"line_number":218,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"13d29731_7906041e","line":218,"updated":"2021-11-11 08:20:10.000000000","message":"that one needed?","commit_id":"02941066880241c14865589473bd471f8b37cd62"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"8fb8b6650aa9007c4409ad3668c69f143ed2bd83","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        mount_show_options 1"},{"line_number":216,"context_line":"    fi"},{"line_number":217,"context_line":"    mount_image"},{"line_number":218,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"e1739600_79561212","line":218,"in_reply_to":"13d29731_7906041e","updated":"2021-11-11 10:25:46.000000000","message":"Not really, not sure why it got added.\nI will push a new revision.","commit_id":"02941066880241c14865589473bd471f8b37cd62"}]}