)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"1acbfe1892c72b526b47568f89975d60a2b06098","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"54dee04f_3064625d","updated":"2022-01-12 07:02:50.000000000","message":"Thanks, and this is also the first step of the \"ansible extraction\". This change will give us the ability to #include this library on both tripleoclient and ansible. ","commit_id":"c09ef2c9a1da567612d7d6242e05925523b9fb06"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3f6925f9ed9bc17a08b0237fd418fdccb3cbf0fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ee18025c_f279f789","updated":"2022-01-12 08:09:48.000000000","message":"looks ok should be straight copy but i see a small diff - inline question ","commit_id":"c09ef2c9a1da567612d7d6242e05925523b9fb06"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"4ffdcd4698e2bf7ec3488f360477cd6cfac509ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"08985082_9f035f2b","updated":"2022-01-12 15:01:01.000000000","message":"thanks for checking","commit_id":"c09ef2c9a1da567612d7d6242e05925523b9fb06"}],"tripleo_common/utils/ceph_spec.py":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3f6925f9ed9bc17a08b0237fd418fdccb3cbf0fa","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":"# Copyright (c) 2021 OpenStack Foundation"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"a43ccbce_69836c96","line":2,"range":{"start_line":2,"start_character":19,"end_line":2,"end_character":20},"updated":"2022-01-12 08:09:48.000000000","message":"2 😄","commit_id":"c09ef2c9a1da567612d7d6242e05925523b9fb06"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"bea121e37d7ed43fc9c400811ee0093023f9ea9e","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":"# Copyright (c) 2021 OpenStack Foundation"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"6eae5670_df07cd02","line":2,"range":{"start_line":2,"start_character":19,"end_line":2,"end_character":20},"in_reply_to":"a43ccbce_69836c96","updated":"2022-01-12 14:59:51.000000000","message":"When this lib was originally committed to tripleo-ansible it was (c) 2021. I guess since it\u0027s going into the repo as something new in 2022 I assume you\u0027re saying it should be 2022.","commit_id":"c09ef2c9a1da567612d7d6242e05925523b9fb06"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3f6925f9ed9bc17a08b0237fd418fdccb3cbf0fa","unresolved":true,"context_lines":[{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import ipaddress"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"ALLOWED_DAEMONS \u003d [\u0027host\u0027, \u0027mon\u0027, \u0027mgr\u0027, \u0027mds\u0027, \u0027nfs\u0027, \u0027osd\u0027, \u0027rgw\u0027, \u0027grafana\u0027,"},{"line_number":20,"context_line":"                   \u0027crash\u0027, \u0027prometheus\u0027, \u0027alertmanager\u0027, \u0027node-exporter\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"935e4eac_e60699c5","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":2},"updated":"2022-01-12 08:09:48.000000000","message":"should be straight copy from https://review.opendev.org/c/openstack/tripleo-ansible/+/822829/4/tripleo_ansible/ansible_plugins/module_utils/ceph_spec.py\n\nbut i noticed the diff on the imports here is that OK? \nbut i also can\u0027t see either json or sys used here so... must be ;)","commit_id":"c09ef2c9a1da567612d7d6242e05925523b9fb06"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"bea121e37d7ed43fc9c400811ee0093023f9ea9e","unresolved":true,"context_lines":[{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import ipaddress"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"ALLOWED_DAEMONS \u003d [\u0027host\u0027, \u0027mon\u0027, \u0027mgr\u0027, \u0027mds\u0027, \u0027nfs\u0027, \u0027osd\u0027, \u0027rgw\u0027, \u0027grafana\u0027,"},{"line_number":20,"context_line":"                   \u0027crash\u0027, \u0027prometheus\u0027, \u0027alertmanager\u0027, \u0027node-exporter\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"46b1e3fc_0e7eff03","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":2},"in_reply_to":"935e4eac_e60699c5","updated":"2022-01-12 14:59:51.000000000","message":"I made a small style change since pep8 wasn\u0027t happy with the original.","commit_id":"c09ef2c9a1da567612d7d6242e05925523b9fb06"}]}
