)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"41d42169085fb684d2cf0096eaaf87513737bfc5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"8a01ee4a_94ca0e0a","updated":"2022-01-31 09:56:04.000000000","message":"I missed the ping here - thanks for the heads-up!","commit_id":"a055503fd7faa1b204ad8118423968ccf3f6ffbe"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"60a32e09d0227d654d0586724e6edb462b552e06","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"0521950b_83ea34b2","updated":"2022-02-03 08:26:10.000000000","message":"@Marios, this change could be interesting for quickstart and some CI jobs where ceph is not required (see releasenotes)","commit_id":"331d3103a6ad67f894fc3d92cde19b80de2367bc"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"16b3fa1572b064701618f1f1492545ca9dfa9eae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"815fa3b9_fe12afe3","updated":"2022-02-10 12:24:59.000000000","message":"It seems good. But some more reviewers might be good, just to be sure :).","commit_id":"08a8118f1b26a170219c63feb8bb5f0b929028c3"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"393f45062e38e4cb3449866b19d7c55f71ed9183","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"b56225de_5aa6b2b3","updated":"2022-02-09 09:29:03.000000000","message":"check-rdo","commit_id":"08a8118f1b26a170219c63feb8bb5f0b929028c3"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"133e0e75d95ac70155eff0084d2bdc72b32130ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"eaff4266_0b23c9a9","updated":"2022-02-10 07:47:34.000000000","message":"k stared at it some more\n\ncan\u0027t spot the nits ;)","commit_id":"08a8118f1b26a170219c63feb8bb5f0b929028c3"}],"container-images/ceph.j2":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"133e0e75d95ac70155eff0084d2bdc72b32130ef","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"e10fb40a_1a7f3223","updated":"2022-02-10 07:47:34.000000000","message":"I was going to comment on ceph.j2 vs ceph.yaml.j2\n\nI think it should also work as ceph.yaml.j2 but what you have is technically correct because this won\u0027t be rendered directly itself.\nInstead you are doing an include https://review.opendev.org/c/openstack/tripleo-common/+/824431/12/container-images/tripleo_containers.yaml.j2 so this should just be jinja :)","commit_id":"08a8118f1b26a170219c63feb8bb5f0b929028c3"}],"container-images/container_image_prepare_defaults.yaml":[{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"a589977eba55f32ed0dd88aad67272db8cbcc7d0","unresolved":true,"context_lines":[{"line_number":48,"context_line":"      ceph_grafana_image: grafana"},{"line_number":49,"context_line":"      ceph_grafana_tag: 6.7.4"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"      ceph_haproxy_namespace: docker.io/library"},{"line_number":52,"context_line":"      ceph_haproxy_image: haproxy"},{"line_number":53,"context_line":"      ceph_haproxy_tag: 2.3"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"      ceph_keepalived_namespace: docker.io/arcts"},{"line_number":56,"context_line":"      ceph_keepalived_image: keepalived"},{"line_number":57,"context_line":"      ceph_keepalived_tag: latest"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"22f6e281_a32e0729","line":57,"range":{"start_line":51,"start_character":0,"end_line":57,"end_character":33},"updated":"2022-01-12 13:07:21.000000000","message":"This default pointing to docker.io can be a problem due to rate limits, still investigating the quay.io replacement with the cephadm team.","commit_id":"fb0e0449853491804198b73b2632025c3697dadd"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"8ef4991c228ec4f233c621520b1a4e4c90fa0f9e","unresolved":false,"context_lines":[{"line_number":48,"context_line":"      ceph_grafana_image: grafana"},{"line_number":49,"context_line":"      ceph_grafana_tag: 6.7.4"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"      ceph_haproxy_namespace: docker.io/library"},{"line_number":52,"context_line":"      ceph_haproxy_image: haproxy"},{"line_number":53,"context_line":"      ceph_haproxy_tag: 2.3"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"      ceph_keepalived_namespace: docker.io/arcts"},{"line_number":56,"context_line":"      ceph_keepalived_image: keepalived"},{"line_number":57,"context_line":"      ceph_keepalived_tag: latest"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"2d61a3e9_cf38ff5a","line":57,"range":{"start_line":51,"start_character":0,"end_line":57,"end_character":33},"in_reply_to":"22f6e281_a32e0729","updated":"2022-02-03 13:34:39.000000000","message":"Done","commit_id":"fb0e0449853491804198b73b2632025c3697dadd"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"2b2ff0bdcacf9d88e4e4fd8d1c22edcc502afb15","unresolved":true,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"      # Container image name components for Ceph images."},{"line_number":28,"context_line":"      # Only used if Ceph is deployed."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"      # Pass ceph_images: false to avoid pulling the Ceph related images"},{"line_number":31,"context_line":"      ceph_namespace: quay.io/ceph"},{"line_number":32,"context_line":"      ceph_image: daemon"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"51662216_e9b83f92","line":29,"updated":"2022-01-13 16:49:24.000000000","message":"@cedric, here we update the Ceph container defaults (images and tags). We still need to solve the docker.io issue (rate limits) by mirroring keepalived and haproxy, but these containers have schemaVersion \u003d\u003d 2","commit_id":"8d4784294242893c82c68ab50d0e1ae73eeef102"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"41d42169085fb684d2cf0096eaaf87513737bfc5","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"      # Container image name components for Ceph images."},{"line_number":28,"context_line":"      # Only used if Ceph is deployed."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"      # Pass ceph_images: false to avoid pulling the Ceph related images"},{"line_number":31,"context_line":"      ceph_namespace: quay.io/ceph"},{"line_number":32,"context_line":"      ceph_image: daemon"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1214f8e2_8fa6d201","line":29,"in_reply_to":"51662216_e9b83f92","updated":"2022-01-31 09:56:04.000000000","message":"Ack","commit_id":"8d4784294242893c82c68ab50d0e1ae73eeef102"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"04ee8b9d84c42e0a3e880c331d9359eea134a26d","unresolved":true,"context_lines":[{"line_number":52,"context_line":"      ceph_haproxy_image: haproxy"},{"line_number":53,"context_line":"      ceph_haproxy_tag: 2.3"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"      ceph_keepalived_namespace: quay.io/ceph"},{"line_number":56,"context_line":"      ceph_keepalived_image: keepalived"},{"line_number":57,"context_line":"      ceph_keepalived_tag: 2.1.5"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"6f7041a8_8109387f","line":55,"range":{"start_line":55,"start_character":33,"end_line":55,"end_character":45},"updated":"2022-02-03 14:22:22.000000000","message":"goodbye docker.io. Hello quay.io. Yay for quay.","commit_id":"08a8118f1b26a170219c63feb8bb5f0b929028c3"}],"container-images/tripleo_containers.yaml":[{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"a589977eba55f32ed0dd88aad67272db8cbcc7d0","unresolved":true,"context_lines":[{"line_number":175,"context_line":"  image_source: prom"},{"line_number":176,"context_line":"- imagename: quay.ceph.io/app-sre/grafana:6.7.4"},{"line_number":177,"context_line":"  image_source: grafana"},{"line_number":178,"context_line":"- imagename: docker.io/arcts/keepalived:latest"},{"line_number":179,"context_line":"  image_source: keepalived"},{"line_number":180,"context_line":"- imagename: docker.io/library/haproxy:2.3"},{"line_number":181,"context_line":"  image_source: haproxy"},{"line_number":182,"context_line":"- imagename: quay.io/tripleomaster/openstack-rsyslog:current-tripleo"},{"line_number":183,"context_line":"  image_source: tripleo"},{"line_number":184,"context_line":"- imagename: quay.io/tripleomaster/openstack-unbound:current-tripleo"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"419830ff_703b3d5c","line":181,"range":{"start_line":178,"start_character":1,"end_line":181,"end_character":23},"updated":"2022-01-12 13:07:21.000000000","message":"This default pointing to docker.io can be a problem due to rate limits, still investigating the quay.io replacement with the cephadm team.","commit_id":"fb0e0449853491804198b73b2632025c3697dadd"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"1080280d0d290f7adb560bac66573a9ee665d8ca","unresolved":true,"context_lines":[{"line_number":175,"context_line":"  image_source: prom"},{"line_number":176,"context_line":"- imagename: quay.io/ceph/ceph-grafana:6.7.4"},{"line_number":177,"context_line":"  image_source: grafana"},{"line_number":178,"context_line":"- imagename: docker.io/arcts/keepalived:latest"},{"line_number":179,"context_line":"  image_source: keepalived"},{"line_number":180,"context_line":"- imagename: docker.io/library/haproxy:2.3"},{"line_number":181,"context_line":"  image_source: haproxy"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"aa008609_8344dd50","line":178,"range":{"start_line":178,"start_character":13,"end_line":178,"end_character":22},"updated":"2022-01-13 17:46:15.000000000","message":"I assume we\u0027ll work on finding a compatible container from quay instead before this merges.","commit_id":"8d4784294242893c82c68ab50d0e1ae73eeef102"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"9a837ff8fdf221777b0effa4edceae25d642cd6e","unresolved":false,"context_lines":[{"line_number":175,"context_line":"  image_source: prom"},{"line_number":176,"context_line":"- imagename: quay.io/ceph/ceph-grafana:6.7.4"},{"line_number":177,"context_line":"  image_source: grafana"},{"line_number":178,"context_line":"- imagename: docker.io/arcts/keepalived:latest"},{"line_number":179,"context_line":"  image_source: keepalived"},{"line_number":180,"context_line":"- imagename: docker.io/library/haproxy:2.3"},{"line_number":181,"context_line":"  image_source: haproxy"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"441feb51_e43e29d7","line":178,"range":{"start_line":178,"start_character":13,"end_line":178,"end_character":22},"in_reply_to":"5b990d9b_5aabe553","updated":"2022-02-03 13:35:01.000000000","message":"Done","commit_id":"8d4784294242893c82c68ab50d0e1ae73eeef102"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"c813cc762a5b591fea6f3c54d7f7bbb691d4f37e","unresolved":true,"context_lines":[{"line_number":175,"context_line":"  image_source: prom"},{"line_number":176,"context_line":"- imagename: quay.io/ceph/ceph-grafana:6.7.4"},{"line_number":177,"context_line":"  image_source: grafana"},{"line_number":178,"context_line":"- imagename: docker.io/arcts/keepalived:latest"},{"line_number":179,"context_line":"  image_source: keepalived"},{"line_number":180,"context_line":"- imagename: docker.io/library/haproxy:2.3"},{"line_number":181,"context_line":"  image_source: haproxy"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5b990d9b_5aabe553","line":178,"range":{"start_line":178,"start_character":13,"end_line":178,"end_character":22},"in_reply_to":"aa008609_8344dd50","updated":"2022-01-14 08:01:15.000000000","message":"Yeah, that\u0027s the idea and we already have a tracker on Ceph [1]\n\n[1] https://tracker.ceph.com/issues/53871","commit_id":"8d4784294242893c82c68ab50d0e1ae73eeef102"}],"container-images/tripleo_containers.yaml.j2":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"1080280d0d290f7adb560bac66573a9ee665d8ca","unresolved":true,"context_lines":[{"line_number":721,"context_line":"  - OS::TripleO::Services::SwiftStorage"},{"line_number":722,"context_line":""},{"line_number":723,"context_line":"{% if ceph_images | default(true) %}"},{"line_number":724,"context_line":"{% include \u0027ceph.j2\u0027 %}"},{"line_number":725,"context_line":"{% endif %}"},{"line_number":726,"context_line":""},{"line_number":727,"context_line":"- imagename: \"{{namespace}}/{{name_prefix}}rsyslog{{name_suffix}}:{{tag}}\""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"1f0835df_87ef337a","line":724,"updated":"2022-01-13 17:46:15.000000000","message":"yay!","commit_id":"8d4784294242893c82c68ab50d0e1ae73eeef102"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c2a1946cc22c581c111f8f185e9c2a3aa23a5b8c","unresolved":true,"context_lines":[{"line_number":721,"context_line":"  - OS::TripleO::Services::SwiftStorage"},{"line_number":722,"context_line":""},{"line_number":723,"context_line":"{% if ceph_images | default(true) %}"},{"line_number":724,"context_line":"{% include \u0027ceph.j2\u0027 %}"},{"line_number":725,"context_line":"{% endif %}"},{"line_number":726,"context_line":""},{"line_number":727,"context_line":"- imagename: \"{{namespace}}/{{name_prefix}}rsyslog{{name_suffix}}:{{tag}}\""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"dc864c90_9a4d41c2","line":724,"in_reply_to":"1f0835df_87ef337a","updated":"2022-01-13 17:48:32.000000000","message":"This might also benefit from being a directory and loaded in rather than doing an include here. The include is less extensible than taking a dir and iterating through all the files and merging.","commit_id":"8d4784294242893c82c68ab50d0e1ae73eeef102"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"c813cc762a5b591fea6f3c54d7f7bbb691d4f37e","unresolved":true,"context_lines":[{"line_number":721,"context_line":"  - OS::TripleO::Services::SwiftStorage"},{"line_number":722,"context_line":""},{"line_number":723,"context_line":"{% if ceph_images | default(true) %}"},{"line_number":724,"context_line":"{% include \u0027ceph.j2\u0027 %}"},{"line_number":725,"context_line":"{% endif %}"},{"line_number":726,"context_line":""},{"line_number":727,"context_line":"- imagename: \"{{namespace}}/{{name_prefix}}rsyslog{{name_suffix}}:{{tag}}\""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"c2ef65c0_31502d77","line":724,"in_reply_to":"dc864c90_9a4d41c2","updated":"2022-01-14 08:01:15.000000000","message":"+1, for ceph purposes I think this is just enough as we\u0027re not planning to split the container space anymore, but yeah, having a template_dir means you can iterate over the *.j2 files and include them w/o the need of touching this template anymore.\nMaybe we can address/improve this in a follow up patch.","commit_id":"8d4784294242893c82c68ab50d0e1ae73eeef102"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"ec3d8b07c1be8341c1219ec69fd8701cd1b4ef33","unresolved":true,"context_lines":[{"line_number":720,"context_line":"  - OS::TripleO::Services::SwiftRingBuilder"},{"line_number":721,"context_line":"  - OS::TripleO::Services::SwiftStorage"},{"line_number":722,"context_line":""},{"line_number":723,"context_line":"{% if ceph_images | default(true) %}"},{"line_number":724,"context_line":"{% include \u0027ceph.j2\u0027 %}"},{"line_number":725,"context_line":"{% endif %}"},{"line_number":726,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"2157f147_ddcf8fe3","line":723,"range":{"start_line":723,"start_character":34,"end_line":723,"end_character":36},"updated":"2022-02-09 08:21:36.000000000","message":"Should we add |bool here for safety? i reviewed [1] recently so it came to mind i wonder if the same can apply here i.e. if if ceph_images is the string \u0027false\u0027 \n\nceph_images|default(true)|bool\n\n[1] https://review.opendev.org/c/openstack/tripleo-ansible/+/828058/1#message-6892796e13afe2b259205a06c7271efe8202d52a","commit_id":"08a8118f1b26a170219c63feb8bb5f0b929028c3"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"393f45062e38e4cb3449866b19d7c55f71ed9183","unresolved":true,"context_lines":[{"line_number":720,"context_line":"  - OS::TripleO::Services::SwiftRingBuilder"},{"line_number":721,"context_line":"  - OS::TripleO::Services::SwiftStorage"},{"line_number":722,"context_line":""},{"line_number":723,"context_line":"{% if ceph_images | default(true) %}"},{"line_number":724,"context_line":"{% include \u0027ceph.j2\u0027 %}"},{"line_number":725,"context_line":"{% endif %}"},{"line_number":726,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"49914930_ba26d9ca","line":723,"range":{"start_line":723,"start_character":34,"end_line":723,"end_character":36},"in_reply_to":"2157f147_ddcf8fe3","updated":"2022-02-09 09:29:03.000000000","message":"Hey Marios, thanks for your comment: I think here is a different situation, and I\u0027m not sure at this stage jinja is able to work w/ filters.\n\nWhen the following line is called:\n\ntemplate \u003d jinja2.Environment(loader\u003djinja2.FileSystemLoader(template_dir)).from_string(cf.read())\n\nusing \"| bool\" it fails with:\n\n```\n2022-02-09 08:58:10.166495 | 2442014a-c7ca-fd0e-19f8-00000000000e |      FATAL | Prepare container images, check logs in /home/stack/container_image_prepare.log | localhost | error\u003d{\"changed\": false, \"error\": \"no filter named \u0027bool\u0027\", \"msg\": \"Error runn\ning container image prepare: no filter named \u0027bool\u0027\", \"params\": {}, \"success\": false}\n```\n\nThe review you mentioned is a tripleo-ansible role which is run from a separated (ad-hoc) playbook, and the |bool filter is an ansible functionality rather then jinja2 [1] (instead |default() is a built-in provided by the jinja library).\nHere we rely on what is imported by \"jinja2.Environment\" and I\u0027d avoid messing up w/ filters unless there\u0027s a clean pattern to add them w/o rewriting the way kolla builder works.\n\nwdyt?\n\n[1] https://jinja2docs.readthedocs.io/en/stable/templates.html?highlight\u003dfilters#filters","commit_id":"08a8118f1b26a170219c63feb8bb5f0b929028c3"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"03665f15912fdd87e71398989056d634b7a222e9","unresolved":true,"context_lines":[{"line_number":720,"context_line":"  - OS::TripleO::Services::SwiftRingBuilder"},{"line_number":721,"context_line":"  - OS::TripleO::Services::SwiftStorage"},{"line_number":722,"context_line":""},{"line_number":723,"context_line":"{% if ceph_images | default(true) %}"},{"line_number":724,"context_line":"{% include \u0027ceph.j2\u0027 %}"},{"line_number":725,"context_line":"{% endif %}"},{"line_number":726,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"bcaab9dc_36d1fc1a","line":723,"range":{"start_line":723,"start_character":34,"end_line":723,"end_character":36},"in_reply_to":"49914930_ba26d9ca","updated":"2022-02-09 09:39:53.000000000","message":"thanks for checking sorry for the extra work :/","commit_id":"08a8118f1b26a170219c63feb8bb5f0b929028c3"}],"releasenotes/notes/split_off_ceph_containers-e1a66fa39076c2cf.yaml":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"1080280d0d290f7adb560bac66573a9ee665d8ca","unresolved":true,"context_lines":[{"line_number":35,"context_line":"    the Ceph Ingress daemon are added, and they are supposed to match"},{"line_number":36,"context_line":"    the tripleo-heat-templates \u0027OS::TripleO::Services::CephIngress\u0027"},{"line_number":37,"context_line":"    service."},{"line_number":38,"context_line":"    The Ingress daemon won’t be baked into the Ceph daemon container,"},{"line_number":39,"context_line":"    hence `tripleo container image prepare` should be executed to pull"},{"line_number":40,"context_line":"    the new container images/tags in the undercloud as made for the"},{"line_number":41,"context_line":"    Ceph Dashboard and the regular Ceph image."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ac09ed0b_f4bd6fa5","line":38,"range":{"start_line":38,"start_character":23,"end_line":38,"end_character":42},"updated":"2022-01-13 17:46:15.000000000","message":"doesn\u0027t use","commit_id":"8d4784294242893c82c68ab50d0e1ae73eeef102"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"c813cc762a5b591fea6f3c54d7f7bbb691d4f37e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    the Ceph Ingress daemon are added, and they are supposed to match"},{"line_number":36,"context_line":"    the tripleo-heat-templates \u0027OS::TripleO::Services::CephIngress\u0027"},{"line_number":37,"context_line":"    service."},{"line_number":38,"context_line":"    The Ingress daemon won’t be baked into the Ceph daemon container,"},{"line_number":39,"context_line":"    hence `tripleo container image prepare` should be executed to pull"},{"line_number":40,"context_line":"    the new container images/tags in the undercloud as made for the"},{"line_number":41,"context_line":"    Ceph Dashboard and the regular Ceph image."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9431e843_6bfdef6f","line":38,"range":{"start_line":38,"start_character":23,"end_line":38,"end_character":42},"in_reply_to":"ac09ed0b_f4bd6fa5","updated":"2022-01-14 08:01:15.000000000","message":"Done","commit_id":"8d4784294242893c82c68ab50d0e1ae73eeef102"}],"releasenotes/source/unreleased.rst":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"1080280d0d290f7adb560bac66573a9ee665d8ca","unresolved":true,"context_lines":[{"line_number":2,"context_line":" Current Series Release Notes"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":" .. release-notes::"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff9d9085_8618e3b2","side":"PARENT","line":5,"updated":"2022-01-13 17:46:15.000000000","message":"why modify this file?","commit_id":"80cf7111073e7ec8eb9c02f538b3be9206ef04ea"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"818b64b63a618c321b7e5682e879b75bc053476b","unresolved":false,"context_lines":[{"line_number":2,"context_line":" Current Series Release Notes"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":" .. release-notes::"}],"source_content_type":"text/x-rst","patch_set":6,"id":"e7075824_66c468c5","side":"PARENT","line":5,"in_reply_to":"ff9d9085_8618e3b2","updated":"2022-01-14 08:21:49.000000000","message":"by mistake, fixed.","commit_id":"80cf7111073e7ec8eb9c02f538b3be9206ef04ea"}],"tripleo_common/image/kolla_builder.py":[{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"4ef038205a2457db2e7b5e90c97a9c49285c3caa","unresolved":true,"context_lines":[{"line_number":518,"context_line":"        if len(self.config_files) !\u003d 1:"},{"line_number":519,"context_line":"            raise ValueError(\u0027A single config file must be specified\u0027)"},{"line_number":520,"context_line":"        config_file \u003d self.config_files[0]"},{"line_number":521,"context_line":"        template_dir \u003d self.template_dir"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"        with open(config_file) as cf:"},{"line_number":524,"context_line":"            if template_dir is not None:"}],"source_content_type":"text/x-python","patch_set":6,"id":"e53c9811_dfd0c3a6","line":521,"range":{"start_line":521,"start_character":8,"end_line":521,"end_character":20},"updated":"2022-01-13 16:46:58.000000000","message":"@Alex, regardless of Ceph,this could be a generic approach to split 3rd parties containers into separated j2","commit_id":"8d4784294242893c82c68ab50d0e1ae73eeef102"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"83d5782cd1363e90c0cb62b9aa7e938af40d30b6","unresolved":true,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"DEFAULT_PREPARE_FILE \u003d os.path.join(sys.prefix, \u0027share\u0027, \u0027tripleo-common\u0027,"},{"line_number":61,"context_line":"                                    \u0027container-images\u0027,"},{"line_number":62,"context_line":"                                    \u0027container_image_prepare_defaults.yaml\u0027)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"if os.path.isfile(DEFAULT_PREPARE_FILE):"},{"line_number":65,"context_line":"    init_prepare_defaults(DEFAULT_PREPARE_FILE)"}],"source_content_type":"text/x-python","patch_set":10,"id":"effa6147_d21695a4","line":62,"updated":"2022-02-02 23:02:16.000000000","message":"should we simplify these to use DEFAULT_TEMPLATE_DIR now?","commit_id":"a055503fd7faa1b204ad8118423968ccf3f6ffbe"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"b73c60c6a808896facd81381df026d18ae6aade4","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"DEFAULT_PREPARE_FILE \u003d os.path.join(sys.prefix, \u0027share\u0027, \u0027tripleo-common\u0027,"},{"line_number":61,"context_line":"                                    \u0027container-images\u0027,"},{"line_number":62,"context_line":"                                    \u0027container_image_prepare_defaults.yaml\u0027)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"if os.path.isfile(DEFAULT_PREPARE_FILE):"},{"line_number":65,"context_line":"    init_prepare_defaults(DEFAULT_PREPARE_FILE)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1d4fad6d_af36fcfe","line":62,"in_reply_to":"effa6147_d21695a4","updated":"2022-02-03 08:17:28.000000000","message":"Done","commit_id":"a055503fd7faa1b204ad8118423968ccf3f6ffbe"}]}