)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"b47bee9f598ee18a393d15433cf051bb874d2377","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4a74497e_fcac3ce1","updated":"2022-08-11 13:06:16.000000000","message":"LGTM but some deduplication of templates?","commit_id":"e33b791dee119cb07774a62940c71e9ce1bffbfa"}],"container-images/tripleo_containers.yaml.j2":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"b47bee9f598ee18a393d15433cf051bb874d2377","unresolved":true,"context_lines":[{"line_number":299,"context_line":"{% endfor %}"},{"line_number":300,"context_line":"{% else %}"},{"line_number":301,"context_line":"- imagename: \"{{namespace}}/{{name_prefix}}haproxy{{name_suffix}}:{{tag}}\""},{"line_number":302,"context_line":"  image_source: tripleo"},{"line_number":303,"context_line":"  params:"},{"line_number":304,"context_line":"  - ContainerHAProxyConfigImage"},{"line_number":305,"context_line":"  - ContainerHAProxyImage"},{"line_number":306,"context_line":"  services:"},{"line_number":307,"context_line":"  - OS::TripleO::Services::HAproxy"},{"line_number":308,"context_line":"  - OS::TripleO::Services::HAproxyEdge"},{"line_number":309,"context_line":"  - OS::TripleO::Services::UndercloudHAProxy"},{"line_number":310,"context_line":"{% endif %}"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"{% if os_dependant %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"d4fcb2c7_cc0b7981","line":309,"range":{"start_line":302,"start_character":0,"end_line":309,"end_character":44},"updated":"2022-08-11 13:06:16.000000000","message":"this repeated twice, perhaps the if else section could be done for imagename and operating_system values only?","commit_id":"e33b791dee119cb07774a62940c71e9ce1bffbfa"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"98a44e6577ffab2378d1958f5118b893cdcb8ef7","unresolved":true,"context_lines":[{"line_number":299,"context_line":"{% endfor %}"},{"line_number":300,"context_line":"{% else %}"},{"line_number":301,"context_line":"- imagename: \"{{namespace}}/{{name_prefix}}haproxy{{name_suffix}}:{{tag}}\""},{"line_number":302,"context_line":"  image_source: tripleo"},{"line_number":303,"context_line":"  params:"},{"line_number":304,"context_line":"  - ContainerHAProxyConfigImage"},{"line_number":305,"context_line":"  - ContainerHAProxyImage"},{"line_number":306,"context_line":"  services:"},{"line_number":307,"context_line":"  - OS::TripleO::Services::HAproxy"},{"line_number":308,"context_line":"  - OS::TripleO::Services::HAproxyEdge"},{"line_number":309,"context_line":"  - OS::TripleO::Services::UndercloudHAProxy"},{"line_number":310,"context_line":"{% endif %}"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"{% if os_dependant %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"e1546e56_5246b081","line":309,"range":{"start_line":302,"start_character":0,"end_line":309,"end_character":44},"in_reply_to":"d4fcb2c7_cc0b7981","updated":"2022-08-11 14:02:18.000000000","message":"I wonder if we even need to do it for HAProxy at all? I\u0027m sure the ubi9 container would run fine on el8. \n\nSame for the Heat ones below. We definitely don\u0027t need them to be OS dependent.","commit_id":"e33b791dee119cb07774a62940c71e9ce1bffbfa"},{"author":{"_account_id":11166,"name":"Lukas Bezdicka","email":"social@v3.sk","username":"xbezdick"},"change_message_id":"eba540ab5d24a87dca8ee6e9406e8fd61a8eca80","unresolved":true,"context_lines":[{"line_number":299,"context_line":"{% endfor %}"},{"line_number":300,"context_line":"{% else %}"},{"line_number":301,"context_line":"- imagename: \"{{namespace}}/{{name_prefix}}haproxy{{name_suffix}}:{{tag}}\""},{"line_number":302,"context_line":"  image_source: tripleo"},{"line_number":303,"context_line":"  params:"},{"line_number":304,"context_line":"  - ContainerHAProxyConfigImage"},{"line_number":305,"context_line":"  - ContainerHAProxyImage"},{"line_number":306,"context_line":"  services:"},{"line_number":307,"context_line":"  - OS::TripleO::Services::HAproxy"},{"line_number":308,"context_line":"  - OS::TripleO::Services::HAproxyEdge"},{"line_number":309,"context_line":"  - OS::TripleO::Services::UndercloudHAProxy"},{"line_number":310,"context_line":"{% endif %}"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"{% if os_dependant %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"898df367_1ef7e5f9","line":309,"range":{"start_line":302,"start_character":0,"end_line":309,"end_character":44},"in_reply_to":"e1546e56_5246b081","updated":"2022-08-11 16:53:12.000000000","message":"Right now they are for testing + there are unrelated blockers. Take them as example not as final list of images. \n\nTLDR heat image with rhel9 ubi fails because it runs on UC in pod but RHEL8.4 podman pods don\u0027t support rhel9 atm.","commit_id":"e33b791dee119cb07774a62940c71e9ce1bffbfa"}]}