)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"070e1ee7b03479d6f70e1f2968118277cc8c177b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"94569eb6_fe7caad7","updated":"2022-09-19 07:40:06.000000000","message":"btw, there\u0027s an issue when running tests locally - in order to run the script, it needs some galaxy dependencies that are, then, installed by the script... There\u0027s a bit of ordering/cleaning to do imho.\n\nBut that one seems OK.","commit_id":"9ee029074d50d35c8dd659d6016d8536cdb92855"}],"container-images/kolla/tripleo-ansible-ee/requirements.yaml":[{"author":{"_account_id":31581,"name":"Miguel Garcia","display_name":"Miguel Garcia","email":"migarcia@redhat.com","username":"mgarciac"},"change_message_id":"da00c4c9ea71745fb444b1b947b6bbea00df85af","unresolved":true,"context_lines":[{"line_number":14,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# Custom Roles and collections not shipped as a part of tripleo-ansible"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9735b495_174e6e32","line":17,"updated":"2022-09-16 09:13:49.000000000","message":"The way the ansible-galaxy commands are set up in tcib/tripleo-ansible-ee[1], they\u0027ll run if this requirements file exists at all.\n\nRunning \u0027ansible-galaxy role install -r $TRIPLEO_ANSIBLE_REQ\u0027 where $TRIPLEO_ANSIBLE_REQ is a file that doesn\u0027t actually contain any role definitions returns error code 1 with this output:\n\u003e ERROR! No requirements found in file \u0027requirements.yaml\u0027\nWhich I believe would break builds of the tripleo-ansible-ee container if this were to merge as is.\n\nI can think of two ways to avoid that:\n1) Delete this file entirely, so that the \"if [ -f \"$TRIPLEO_ANSIBLE_REQ\" ]\" checks[1] don\u0027t pass and ansible-galaxy never runs (unless the user created it for the express purpose of installing stuff via ansible-galaxy)\n2) Keep the file and alter those checks to further verify whether any roles/collections are actually defined in it.\n\n\n[1] https://opendev.org/openstack/tripleo-common/src/commit/54a6bac5d557aa84c21986e96db0e0911792fe1b/container-images/tcib/tripleo-ansible-ee/tripleo-ansible-ee.yaml#L18","commit_id":"f16b0ebf71674092712449434702d60e83ab7343"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"ccf5a56d5c4eee8a8ce42996279fa9f6e4f8faf2","unresolved":true,"context_lines":[{"line_number":14,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# Custom Roles and collections not shipped as a part of tripleo-ansible"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d31eaec8_513218b4","line":17,"in_reply_to":"9735b495_174e6e32","updated":"2022-09-16 10:09:35.000000000","message":"Thank you Miguel for the review.\nI have setted \n```\ncollections: []\nroles: []\n```\nand tested it here: https://paste.centos.org/view/raw/23903530\nIt works fine without breaking the build.","commit_id":"f16b0ebf71674092712449434702d60e83ab7343"},{"author":{"_account_id":31581,"name":"Miguel Garcia","display_name":"Miguel Garcia","email":"migarcia@redhat.com","username":"mgarciac"},"change_message_id":"0fe3947b5cf01af6dac94058709cc86e0d4e701d","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# Custom Roles and collections not shipped as a part of tripleo-ansible"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c7b50a6e_2852bd6b","line":17,"in_reply_to":"d31eaec8_513218b4","updated":"2022-09-16 10:43:27.000000000","message":"That\u0027s great! Even works without network access as ansible-galaxy doesn\u0027t try to connect anywhere.","commit_id":"f16b0ebf71674092712449434702d60e83ab7343"}]}