)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"e6235a41be09e3fbf577d4110e2983d4bdbbdfa4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4b45e4fc_3623da7d","updated":"2023-02-10 16:32:04.000000000","message":"I am not confident it fixes the issue","commit_id":"66345b09b21181fcaef86b9409f8212842c4c3ff"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"bbbb67783eb827e5e5f43dc6369469bb50f72b3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fe3db3e9_0ee7754a","updated":"2023-02-09 14:51:56.000000000","message":"I\u0027d also use https://review.opendev.org/c/openstack/tripleo-ansible/+/873039/2","commit_id":"66345b09b21181fcaef86b9409f8212842c4c3ff"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"6931da0172ce82120c4443cbf00e7095bd504bb3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ac5991e0_4efa216d","updated":"2023-03-27 18:41:32.000000000","message":"recheck","commit_id":"5abcd59625413ff97dfe852ee135e1a817fedffe"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"a86ff42ca0efe5cd6e3dc79ddd65d34ea4e45265","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d258e985_a97edd39","updated":"2023-03-25 16:03:45.000000000","message":"recheck","commit_id":"5abcd59625413ff97dfe852ee135e1a817fedffe"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"804f6eaa7e181d9cb0c91d40fbe2ef45fcf49ab0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"edc96658_d1f3f446","updated":"2023-03-25 10:18:48.000000000","message":"recheck","commit_id":"5abcd59625413ff97dfe852ee135e1a817fedffe"}],"tripleo_common/image/image_uploader.py":[{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"620c33fb75d0365db562c4eddf345fa766eeb984","unresolved":true,"context_lines":[{"line_number":232,"context_line":"                # for 403 and 404 but provide an error string. Other registries"},{"line_number":233,"context_line":"                # like registry.redhat.io and quay.io do not do this. So if"},{"line_number":234,"context_line":"                # we find an error string, check to see if we should reauth."},{"line_number":235,"context_line":"                do_reauth \u003d allow_reauth"},{"line_number":236,"context_line":"                if \u0027error\u003d\u0027 in www_auth:"},{"line_number":237,"context_line":"                    error \u003d re.search(\u0027error\u003d\"(.*?)\"\u0027, www_auth).group(1)"},{"line_number":238,"context_line":"                    LOG.warning("}],"source_content_type":"text/x-python","patch_set":1,"id":"89025a99_c2a829ab","line":235,"updated":"2023-01-31 09:09:22.000000000","message":"Dont we nee to modify this as well?","commit_id":"ac69eab8095a3aa15f26e806380e971be77143df"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"e839c67cf68a2e9bcd2f7f13c31fa538b792334b","unresolved":true,"context_lines":[{"line_number":1875,"context_line":"        jobs_count \u003d 0"},{"line_number":1876,"context_line":"        jobs_finished \u003d 0"},{"line_number":1877,"context_line":"        # force single thread rhbz#2165527"},{"line_number":1878,"context_line":"        with futures.ThreadPoolExecutor(max_workers\u003d1) as p:"},{"line_number":1879,"context_line":"            if source_layers:"},{"line_number":1880,"context_line":"                for layer in source_layers:"},{"line_number":1881,"context_line":"                    copy_jobs.append(p.submit("}],"source_content_type":"text/x-python","patch_set":2,"id":"06965df9_dca45232","line":1878,"updated":"2023-02-07 13:21:46.000000000","message":"This doesn\u0027t work as it\u0027s applied but job is still failing on the same point.\n\n2023-02-07 04:10:41 | 2023-02-07 04:10:41.135 257843 INFO tripleoclient.utils.utils [-] Temporary directory [ /tmp/tripleo1otzrauu ] cleaned up\u001b[00m\n2023-02-07 04:10:41 | 2023-02-07 04:10:41.135 257843 ERROR tripleoclient.utils.utils [-] Ansible execution failed. playbook: /home/stack/overcloud-deploy/qe-Cloud-0/config-download/tripleo-multi-playbook.yaml, Run Status: failed, Return Code: 2, To rerun the failed command manually execute the following script: /home/stack/overcloud-deploy/qe-Cloud-0/config-download/ansible-playbook-command.sh\u001b[00m\n2023-02-07 04:10:41 | 2023-02-07 04:10:41.136 257843 ERROR tripleoclient.v1.overcloud_external_upgrade.ExternalUpgradeRun [-] Exception occured while running the command: RuntimeError: Ansible execution failed. playbook: /home/stack/overcloud-deploy/qe-Cloud-0/config-download/tripleo-multi-playbook.yaml, Run Status: failed, Return Code: 2, To rerun the failed command manually execute the following script: /home/stack/overcloud-deploy/qe-Cloud-0/config-download/ansible-playbook-command.sh\n2023-02-07 04:10:41 | 2023-02-07 04:10:41.136 257843 ERROR tripleoclient.v1.overcloud_external_upgrade.ExternalUpgradeRun Traceback (most recent call last):\n2023-02-07 04:10:41 | 2023-02-07 04:10:41.136 257843 ERROR tripleoclient.v1.overcloud_external_upgrade.ExternalUpgradeRun   File \"/usr/lib/python3.6/site-packages/tripleoclient/command.py\", line 32, in run\n2023-02-07 04:10:41 | 2023-02-07 04:10:41.136 257843 ERROR tripleoclient.v1.overcloud_external_upgrade.ExternalUpgradeRun     super(Command, self).run(parsed_args)\n2023-02-07 04:10:41 | 2023-02-07 04:10:41.136 257843 ERROR tripleoclient.v1.overcloud_external_upgrade.ExternalUpgradeRun   File \"/usr/lib/python3.6/site-packages/osc_lib/command/command.py\", line 39, in run\n2023-02-07 04:10:41 | 2023-02-07 04:10:41.136 257843 ERROR tripleoclient.v1.overcloud_external_upgrade.ExternalUpgradeRun     return super(Command, self).run(parsed_args)\n2023-02-07 04:10:41 | 2023-02-07 04:10:41.136 257843 ERROR tripleoclient.v1.overcloud_external_upgrade.ExternalUpgradeRun   File \"/usr/lib/python3.6/site-packages/cliff/command.py\", line 186, in run\n2023-02-07 04:10:41 | 2023-02-07 04:10:41.136 257843 ERROR tripleoclient.v1.overcloud_external_upgrade.ExternalUpgradeRun     return_code \u003d self.take_action(parsed_args) or 0\n2023-02-07 04:10:41 | 2023-02-07 04:10:41.136 257843 ERROR tripleoclient.v1.overcloud_external_upgrade.ExternalUpgradeRun   File \"/usr/lib/python3.6/site-packages/tripleoclient/v1/overcloud_external_upgrade.py\", line 146, in take_action\n2023-02-07 04:10:41 | 2023-02-07 04:10:41.136 257843 ERROR tripleoclient.v1.overcloud_external_upgrade.ExternalUpgradeRun     reproduce_command\u003dTrue\n2023-02-07 04:10:41 | 2023-02-07 04:10:41.136 257843 ERROR tripleoclient.v1.overcloud_external_upgrade.ExternalUpgradeRun   File \"/usr/lib/python3.6/site-packages/tripleoclient/utils.py\", line 741, in run_ansible_playbook\n2023-02-07 04:10:41 | 2023-02-07 04:10:41.136 257843 ERROR tripleoclient.v1.overcloud_external_upgrade.ExternalUpgradeRun     raise RuntimeError(err_msg)\n2023-02-07 04:10:41 | 2023-02-07 04:10:41.136 257843 ERROR tripleoclient.v1.overcloud_external_upgrade.ExternalUpgradeRun RuntimeError: Ansible execution failed. playbook: /home/stack/overcloud-deploy/qe-Cloud-0/config-download/tripleo-multi-playbook.yaml, Run Status: failed, Return Code: 2, To rerun the failed command manually execute the following script: /home/stack/overcloud-deploy/qe-Cloud-0/config-download/ansible-playbook-command.sh\n2023-02-07 04:10:41 | 2023-02-07 04:10:41.136 257843 ERROR tripleoclient.v1.overcloud_external_upgrade.ExternalUpgradeRun \u001b[00m\n2023-02-07 04:10:41 | 2023-02-07 04:10:41.138 257843 ERROR openstack [-] Ansible execution failed. playbook: /home/stack/overcloud-deploy/qe-Cloud-0/config-download/tripleo-multi-playbook.yaml, Run Status: failed, Return Code: 2, To rerun the failed command manually execute the following script: /home/stack/overcloud-deploy/qe-Cloud-0/config-download/ansible-playbook-command.sh: RuntimeError: Ansible execution failed. playbook: /home/stack/overcloud-deploy/qe-Cloud-0/config-download/tripleo-multi-playbook.yaml, Run Status: failed, Return Code: 2, To rerun the failed command manually execute the following script: /home/stack/overcloud-deploy/qe-Cloud-0/config-download/ansible-playbook-command.sh\u001b[00m\n2023-02-07 04:10:41 | 2023-02-07 04:10:41.138 257843 INFO osc_lib.shell [-] END return value: 1\u001b[00m\n2023-02-07 04:10:41 | /usr/lib/python3.6/site-packages/barbicancl","commit_id":"091a69fbc438652984464438494ccfc09a2e249d"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"bb15fc9789834505295db5ee2922c29fe2b41873","unresolved":true,"context_lines":[{"line_number":1875,"context_line":"        jobs_count \u003d 0"},{"line_number":1876,"context_line":"        jobs_finished \u003d 0"},{"line_number":1877,"context_line":"        # force single thread rhbz#2165527"},{"line_number":1878,"context_line":"        with futures.ThreadPoolExecutor(max_workers\u003d1) as p:"},{"line_number":1879,"context_line":"            if source_layers:"},{"line_number":1880,"context_line":"                for layer in source_layers:"},{"line_number":1881,"context_line":"                    copy_jobs.append(p.submit("}],"source_content_type":"text/x-python","patch_set":2,"id":"5d76cd4c_3fa7e316","line":1878,"in_reply_to":"06965df9_dca45232","updated":"2023-02-07 19:43:15.000000000","message":"Line #2401 is where you would want to set max_workers\u003d1 to try without per-image concurrency.\n\nAlso a bunch of complexity could be removed if we revert https://opendev.org/openstack/tripleo-common/commit/60afc0eec44f698dd95d9d6ec80dad94a4b07329 now that python2 and mistral are not required.","commit_id":"091a69fbc438652984464438494ccfc09a2e249d"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"cfddabff36521ee12b98a73e0fabbbd8dca7d0f4","unresolved":true,"context_lines":[{"line_number":1875,"context_line":"        jobs_count \u003d 0"},{"line_number":1876,"context_line":"        jobs_finished \u003d 0"},{"line_number":1877,"context_line":"        # force single thread rhbz#2165527"},{"line_number":1878,"context_line":"        with futures.ThreadPoolExecutor(max_workers\u003d1) as p:"},{"line_number":1879,"context_line":"            if source_layers:"},{"line_number":1880,"context_line":"                for layer in source_layers:"},{"line_number":1881,"context_line":"                    copy_jobs.append(p.submit("}],"source_content_type":"text/x-python","patch_set":2,"id":"9a04b067_1ca9006b","line":1878,"in_reply_to":"5d76cd4c_3fa7e316","updated":"2023-02-07 20:20:10.000000000","message":"If this is being triggered by the tripleo_container_image_prepare ansible module, it is using the ProcessLock[1], which results in a ProcessPoolExecutor. Process based concurrency was only added to support python2 and Mistral[2] so it would be worth checking with Rabi to see if there is a requirement that ansible use it.\n\nIt might be worth trying removing the line in [1] to use the default thread based lock.\n\n[1] https://opendev.org/openstack/tripleo-ansible/src/branch/stable/wallaby/tripleo_ansible/ansible_plugins/modules/tripleo_container_image_prepare.py#L147\n[2] https://opendev.org/openstack/tripleo-common/commit/60afc0eec44f698dd95d9d6ec80dad94a4b07329","commit_id":"091a69fbc438652984464438494ccfc09a2e249d"}]}
