)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"c4f50668ddad2b7946a61944e2a1a4206443d97a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d88f8321_9f0d46ab","updated":"2023-05-27 07:20:51.000000000","message":"Master is unmaintained, can you propose this for Wallaby?","commit_id":"ecb5fc730d86dd1b6f89a68e2179dfad062881bf"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"241053f0427d03c9c69dd2cbefc16adc9b1ebdb5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4aa4e804_90305080","in_reply_to":"d88f8321_9f0d46ab","updated":"2023-05-27 13:19:24.000000000","message":"I can but let\u0027s finish this conversation first.","commit_id":"ecb5fc730d86dd1b6f89a68e2179dfad062881bf"}],"tripleo_common/utils/passwords.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"cc41a47b103662c2ff26467931ec1d8b727bf863","unresolved":true,"context_lines":[{"line_number":51,"context_line":"        stack_env \u003d {}"},{"line_number":52,"context_line":"    passwords \u003d {}"},{"line_number":53,"context_line":"    use_complex_passwords \u003d stack_env.get(\u0027parameter_defaults\u0027, {}) \\"},{"line_number":54,"context_line":"                                     .get(\u0027UseComplexPasswords\u0027, False)"},{"line_number":55,"context_line":"    db_ed25519 \u003d stack_env.get(\u0027parameter_defaults\u0027, {}) \\"},{"line_number":56,"context_line":"                          .get(\u0027EnableMysqlAuthEd25519\u0027, False)"},{"line_number":57,"context_line":"    if use_complex_passwords:"}],"source_content_type":"text/x-python","patch_set":5,"id":"cbe6f13b_e232bf13","line":54,"range":{"start_line":54,"start_character":43,"end_line":54,"end_character":62},"updated":"2023-05-29 02:19:12.000000000","message":"this is not a tht parameter. Probably we have to add an argument to CLI instead.","commit_id":"ecb5fc730d86dd1b6f89a68e2179dfad062881bf"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"4b753694c8cc66dbbca5e3b988d1c7d788d98c65","unresolved":true,"context_lines":[{"line_number":51,"context_line":"        stack_env \u003d {}"},{"line_number":52,"context_line":"    passwords \u003d {}"},{"line_number":53,"context_line":"    use_complex_passwords \u003d stack_env.get(\u0027parameter_defaults\u0027, {}) \\"},{"line_number":54,"context_line":"                                     .get(\u0027UseComplexPasswords\u0027, False)"},{"line_number":55,"context_line":"    db_ed25519 \u003d stack_env.get(\u0027parameter_defaults\u0027, {}) \\"},{"line_number":56,"context_line":"                          .get(\u0027EnableMysqlAuthEd25519\u0027, False)"},{"line_number":57,"context_line":"    if use_complex_passwords:"}],"source_content_type":"text/x-python","patch_set":5,"id":"4d8f64e9_fecf920a","line":54,"range":{"start_line":54,"start_character":43,"end_line":54,"end_character":62},"in_reply_to":"cbe6f13b_e232bf13","updated":"2023-05-30 17:51:47.000000000","message":"It\u0027s a paraemeter that will exist in THT 😊","commit_id":"ecb5fc730d86dd1b6f89a68e2179dfad062881bf"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"c4f50668ddad2b7946a61944e2a1a4206443d97a","unresolved":true,"context_lines":[{"line_number":131,"context_line":"            passwords[name] \u003d create_rndc_key_secret()"},{"line_number":132,"context_line":"        else:"},{"line_number":133,"context_line":"            passwords[name] \u003d passlib.pwd.genword(length\u003d_MIN_PASSWORD_SIZE,"},{"line_number":134,"context_line":"                                                  charset\u003dpassword_charset)"},{"line_number":135,"context_line":"    return passwords"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"8f80acfe_a66e5f46","line":134,"updated":"2023-05-27 07:20:51.000000000","message":"Why not just use ascii_72 here as default and drop all of the other complex_password logic? Is there ever a situation where we wouldn\u0027t want ascii_72?","commit_id":"ecb5fc730d86dd1b6f89a68e2179dfad062881bf"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"4cb522886a782c768f8019f2f47f6a946ea7cb00","unresolved":true,"context_lines":[{"line_number":131,"context_line":"            passwords[name] \u003d create_rndc_key_secret()"},{"line_number":132,"context_line":"        else:"},{"line_number":133,"context_line":"            passwords[name] \u003d passlib.pwd.genword(length\u003d_MIN_PASSWORD_SIZE,"},{"line_number":134,"context_line":"                                                  charset\u003dpassword_charset)"},{"line_number":135,"context_line":"    return passwords"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"97c48993_979f47b6","line":134,"in_reply_to":"0caecd52_1ffb7e64","updated":"2023-06-05 14:45:09.000000000","message":"Would be nice to have this automated still... up to you, we can abandon it if we validate the passwords matches the regex provided by the user .","commit_id":"ecb5fc730d86dd1b6f89a68e2179dfad062881bf"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"249da586e2f11f162f6aaa1955b63cd958b3922d","unresolved":true,"context_lines":[{"line_number":131,"context_line":"            passwords[name] \u003d create_rndc_key_secret()"},{"line_number":132,"context_line":"        else:"},{"line_number":133,"context_line":"            passwords[name] \u003d passlib.pwd.genword(length\u003d_MIN_PASSWORD_SIZE,"},{"line_number":134,"context_line":"                                                  charset\u003dpassword_charset)"},{"line_number":135,"context_line":"    return passwords"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"0caecd52_1ffb7e64","line":134,"in_reply_to":"29926d6d_20ea9064","updated":"2023-06-05 11:06:25.000000000","message":"I don\u0027t think we need this change. The password can already be provided in any format.","commit_id":"ecb5fc730d86dd1b6f89a68e2179dfad062881bf"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"4b753694c8cc66dbbca5e3b988d1c7d788d98c65","unresolved":true,"context_lines":[{"line_number":131,"context_line":"            passwords[name] \u003d create_rndc_key_secret()"},{"line_number":132,"context_line":"        else:"},{"line_number":133,"context_line":"            passwords[name] \u003d passlib.pwd.genword(length\u003d_MIN_PASSWORD_SIZE,"},{"line_number":134,"context_line":"                                                  charset\u003dpassword_charset)"},{"line_number":135,"context_line":"    return passwords"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"29926d6d_20ea9064","line":134,"in_reply_to":"7172522a_447653b7","updated":"2023-05-30 17:51:47.000000000","message":"That or that.   We\u0027re received a few case about this and thought it would be a nice to have.","commit_id":"ecb5fc730d86dd1b6f89a68e2179dfad062881bf"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"54c222dd395ee7f8d74779d19877a7b8db8cabad","unresolved":true,"context_lines":[{"line_number":131,"context_line":"            passwords[name] \u003d create_rndc_key_secret()"},{"line_number":132,"context_line":"        else:"},{"line_number":133,"context_line":"            passwords[name] \u003d passlib.pwd.genword(length\u003d_MIN_PASSWORD_SIZE,"},{"line_number":134,"context_line":"                                                  charset\u003dpassword_charset)"},{"line_number":135,"context_line":"    return passwords"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"d8cd9918_8510eb89","line":134,"in_reply_to":"733c2a41_58325fd2","updated":"2023-05-27 22:28:15.000000000","message":"Is there a change we could get issues with those passwords ?   Also, I\u0027d rather have this as a new setting rather than changing the default type of password back to train because we\u0027ll need this in train as well.\n\n[dhill@knox git]$ python\nPython 3.11.3 (main, Apr  5 2023, 00:00:00) [GCC 13.0.1 20230404 (Red Hat 13.0.1-0)] on linux\nType \"help\", \"copyright\", \"credits\" or \"license\" for more information.\n\u003e\u003e\u003e import passlib.pwd\n\u003e\u003e\u003e passlib.pwd.genword(length\u003d25,charset\u003d\u0027ascii_72\u0027)\n\u0027XP4\u0026xWjui?^A#PSQbM?Im9Lb!\u0027\n\u003e\u003e\u003e passlib.pwd.genword(length\u003d25,charset\u003d\u0027ascii_72\u0027)\n\u00270WZ13iGr*JNVtP#kDcfmC!2i\u0026\u0027\n\u003e\u003e\u003e passlib.pwd.genword(length\u003d25,charset\u003d\u0027ascii_72\u0027)\n\u0027t67xwrmE22H410JoW^WXAq5sN\u0027\n\u003e\u003e\u003e passlib.pwd.genword(length\u003d25,charset\u003d\u0027ascii_72\u0027)\n\u0027^au*vHIyFDzumRNk$FO0GKdso\u0027\n\u003e\u003e\u003e passlib.pwd.genword(length\u003d25,charset\u003d\u0027ascii_72\u0027)\n\u0027^3QMQCMyl5^5*\u00261$BuyjcJgR!\u0027","commit_id":"ecb5fc730d86dd1b6f89a68e2179dfad062881bf"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"241053f0427d03c9c69dd2cbefc16adc9b1ebdb5","unresolved":true,"context_lines":[{"line_number":131,"context_line":"            passwords[name] \u003d create_rndc_key_secret()"},{"line_number":132,"context_line":"        else:"},{"line_number":133,"context_line":"            passwords[name] \u003d passlib.pwd.genword(length\u003d_MIN_PASSWORD_SIZE,"},{"line_number":134,"context_line":"                                                  charset\u003dpassword_charset)"},{"line_number":135,"context_line":"    return passwords"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"733c2a41_58325fd2","line":134,"in_reply_to":"8f80acfe_a66e5f46","updated":"2023-05-27 13:19:24.000000000","message":"We could do that as well... do we think we should switch to ascii_72 altogether ?  Also, it only changes the charset for the keystone services that are handled by the \"else\" part , perhaps we would want to generate complex passwords for all services ?","commit_id":"ecb5fc730d86dd1b6f89a68e2179dfad062881bf"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"cc41a47b103662c2ff26467931ec1d8b727bf863","unresolved":true,"context_lines":[{"line_number":131,"context_line":"            passwords[name] \u003d create_rndc_key_secret()"},{"line_number":132,"context_line":"        else:"},{"line_number":133,"context_line":"            passwords[name] \u003d passlib.pwd.genword(length\u003d_MIN_PASSWORD_SIZE,"},{"line_number":134,"context_line":"                                                  charset\u003dpassword_charset)"},{"line_number":135,"context_line":"    return passwords"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7172522a_447653b7","line":134,"in_reply_to":"d8cd9918_8510eb89","updated":"2023-05-29 02:19:12.000000000","message":"I\u0027d avoid changing the default behavior at this stage. So I kind of agree with this approach.\n\nI\u0027m still not sure if we really need this, if the requirement is not much popular. In case a user needs a specific requirement for passwords then they can pre-generate the password file (in ~/overcloud-deploy/overcloud-passwords.yaml)","commit_id":"ecb5fc730d86dd1b6f89a68e2179dfad062881bf"}]}