)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"db11b40ee3d155abf23fb4f4f3176e8191259c4b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cd0827fe_09a9b8fa","updated":"2023-05-30 06:00:58.000000000","message":"This removes the excluded_overcloud group completely when BlacklistedHostnme is empty but can it break references to the group in tht ?\n\neg. https://github.com/openstack/tripleo-heat-templates/blob/stable/train/deployment/aodh/aodh-api-container-puppet.yaml#L275","commit_id":"e1a2e58cd862ce672e96b2c4a7d5b84f09defcbd"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"8598043a06a94dd3fa85d2138a022049cafc563c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2a8b14cb_bdc6c442","in_reply_to":"cbd7558c_8bf5a09c","updated":"2023-05-31 03:59:21.000000000","message":"We should ideally use defaults for non-existing groups in THT, but I think the updated patch should work.","commit_id":"e1a2e58cd862ce672e96b2c4a7d5b84f09defcbd"},{"author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"change_message_id":"d3e2683ab035acb7ede516dffd73efa4c20ecd22","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cbd7558c_8bf5a09c","in_reply_to":"cd0827fe_09a9b8fa","updated":"2023-05-30 07:13:30.000000000","message":"I do believe you may be onto something. The filter would definitely fail in that case.","commit_id":"e1a2e58cd862ce672e96b2c4a7d5b84f09defcbd"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"cb52b88f89e95707052d766241e429bf59093b77","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"845ce74e_1a8d572c","updated":"2023-05-31 07:50:46.000000000","message":"https://opendev.org/openstack/tripleo-upgrade/src/branch/stable/train/filter_plugins/tripleo_upgrade.py#L26 filter with some own way of handling groups fails now.","commit_id":"e090fb9f719ed65325593a54e52c1b9110b6ac7c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"276dbd1f06b15fd1962552b8094dbcb927f83224","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bdca1c72_b7e690de","updated":"2023-05-31 07:51:02.000000000","message":"The previous version caused the failure below.\n\n```\n2023-05-31 06:22:15.442186 | primary | TASK [tripleo-upgrade : set inventory facts] ***********************************\n2023-05-31 06:22:15.442278 | primary | Wednesday 31 May 2023  06:22:15 +0000 (0:00:02.361)       0:01:24.859 *********\n2023-05-31 06:22:15.678144 | primary | An exception occurred during task execution. To see the full traceback, use -vvv. The error was: KeyError: \u0027overcloud_excluded_overcloud\u0027\n2023-05-31 06:22:15.678867 | primary | fatal: [undercloud]: FAILED! \u003d\u003e {\"changed\": false}\n2023-05-31 06:22:15.681887 | primary |\n```","commit_id":"49fedd76a7b335a5ff186e1f2733e3785dfccc40"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"4f75d6ebd6f9cd0b46c7e131010af3b9a2108057","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9ca2c034_6ca6880e","updated":"2023-09-19 02:14:37.000000000","message":"Let\u0027s merge this to close the BZ.","commit_id":"73cb863d66557ee0eb0558af30792c39299d48eb"}],"tripleo_common/inventory.py":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"c78dc063f4e6da656aae0a7d7ba3d62b357faa88","unresolved":true,"context_lines":[{"line_number":375,"context_line":"            for hostname in excluded_hosts:"},{"line_number":376,"context_line":"                if hostname:"},{"line_number":377,"context_line":"                    exclude[hostname] \u003d {}"},{"line_number":378,"context_line":"        else:"},{"line_number":379,"context_line":"            excluded_overcloud.setdefault(\u0027hosts\u0027, [])"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"        return ret"},{"line_number":382,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"6cbd4f29_7883f469","line":379,"range":{"start_line":378,"start_character":0,"end_line":379,"end_character":54},"updated":"2023-05-31 07:53:37.000000000","message":"Hmm.. I did not want to do this actually. I think we should use defaults in THT rather than cater for all not non-standard parsing.","commit_id":"49fedd76a7b335a5ff186e1f2733e3785dfccc40"}]}