)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2ff01f576bf2dc0cae9e72903bbf76bec7bc5b10","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Use nova-libvirt image for LibvirtConfig"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change moves the ContainerNovaLibvirtConfigImage param to use the"},{"line_number":10,"context_line":"nova-libvirt image instead of the nova-compute image."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Resolves: rhbz#2186553"},{"line_number":13,"context_line":"Signed-off-by: Brendan Shephard \u003cbshephar@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5981c108_f880e72d","line":10,"updated":"2023-07-04 10:50:22.000000000","message":"i think the intent of this patch is correct i cant comment on the implemation of it since i do not understand this part of tripleo at all.","commit_id":"2d5ae80c34b2d20382324639983bd6d7e88ecd85"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"75cecf838102c889fb46e2c88cf0c92d9b161538","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use nova-libvirt image for LibvirtConfig"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change moves the ContainerNovaLibvirtConfigImage param to use the"},{"line_number":10,"context_line":"nova-libvirt image instead of the nova-compute image."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Resolves: rhbz#2186553"},{"line_number":13,"context_line":"Signed-off-by: Brendan Shephard \u003cbshephar@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"093fa3ca_36115d92","line":10,"in_reply_to":"5981c108_f880e72d","updated":"2023-07-05 11:56:24.000000000","message":"Ack","commit_id":"2d5ae80c34b2d20382324639983bd6d7e88ecd85"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"8fb20aab683b47efdb3a8e353738d2bed59b168a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5d36cd6c_3cdb2a72","updated":"2023-07-04 06:16:37.000000000","message":"recheck","commit_id":"2d5ae80c34b2d20382324639983bd6d7e88ecd85"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"f53b20bbf88212ae3c76240db31dc3ddaf8b0899","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2188cda0_f1aa7592","updated":"2023-07-05 09:46:37.000000000","message":"This worked on the FFU process","commit_id":"4c109097e02ff9a7be217a2e6f053487b06cc950"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"4463d1b0b1fabbde171a13a9144cb0e4d67104d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"15dab09b_55dbad18","updated":"2023-07-07 07:48:44.000000000","message":"recheck","commit_id":"4c109097e02ff9a7be217a2e6f053487b06cc950"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"70205a1bbcd3a1f07df04efbfc55ba7c212ea526","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c3298a60_5afd24f7","updated":"2023-07-07 14:08:11.000000000","message":"recheck","commit_id":"4c109097e02ff9a7be217a2e6f053487b06cc950"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"222a6156fb9d498596d41aa0d7c7fe402d676afb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d3f49d7b_c785d644","updated":"2023-07-05 10:54:01.000000000","message":"recheck","commit_id":"4c109097e02ff9a7be217a2e6f053487b06cc950"}],"container-images/tripleo_containers.yaml.j2":[{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"95a7342c600af7831a0ad017eb8fc9133e9c3aba","unresolved":true,"context_lines":[{"line_number":545,"context_line":"  - ContainerNovaComputeImage"},{"line_number":546,"context_line":"  services:"},{"line_number":547,"context_line":"  - OS::TripleO::Services::NovaCompute"},{"line_number":548,"context_line":"  - OS::TripleO::Services::NovaLibvirt"},{"line_number":549,"context_line":"  - OS::TripleO::Services::NovaLibvirtLegacy"},{"line_number":550,"context_line":"  - OS::TripleO::Services::NovaMigrationTarget"},{"line_number":551,"context_line":""},{"line_number":552,"context_line":"- imagename: \"{{namespace}}/{{name_prefix}}nova-conductor{{name_suffix}}:{{tag}}\""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"2f211464_32b469e1","line":549,"range":{"start_line":548,"start_character":0,"end_line":549,"end_character":44},"updated":"2023-07-03 12:35:25.000000000","message":"shouldn\u0027t these lines be removed?","commit_id":"2d5ae80c34b2d20382324639983bd6d7e88ecd85"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1571d31b5fac2ebed86b08877c761c03a4fd54b1","unresolved":true,"context_lines":[{"line_number":545,"context_line":"  - ContainerNovaComputeImage"},{"line_number":546,"context_line":"  services:"},{"line_number":547,"context_line":"  - OS::TripleO::Services::NovaCompute"},{"line_number":548,"context_line":"  - OS::TripleO::Services::NovaLibvirt"},{"line_number":549,"context_line":"  - OS::TripleO::Services::NovaLibvirtLegacy"},{"line_number":550,"context_line":"  - OS::TripleO::Services::NovaMigrationTarget"},{"line_number":551,"context_line":""},{"line_number":552,"context_line":"- imagename: \"{{namespace}}/{{name_prefix}}nova-conductor{{name_suffix}}:{{tag}}\""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"58f456be_bb5c7983","line":549,"range":{"start_line":548,"start_character":0,"end_line":549,"end_character":44},"in_reply_to":"0996e951_8251e318","updated":"2023-07-04 11:15:48.000000000","message":"These can be removed now. Previously we had ContainerNovaLibvirtConfigImage which is used by all these nova services. However now we have only ContainerNovaComputeImage which is used by NovaCompute and NovaMigrationTarget.","commit_id":"2d5ae80c34b2d20382324639983bd6d7e88ecd85"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2ff01f576bf2dc0cae9e72903bbf76bec7bc5b10","unresolved":true,"context_lines":[{"line_number":545,"context_line":"  - ContainerNovaComputeImage"},{"line_number":546,"context_line":"  services:"},{"line_number":547,"context_line":"  - OS::TripleO::Services::NovaCompute"},{"line_number":548,"context_line":"  - OS::TripleO::Services::NovaLibvirt"},{"line_number":549,"context_line":"  - OS::TripleO::Services::NovaLibvirtLegacy"},{"line_number":550,"context_line":"  - OS::TripleO::Services::NovaMigrationTarget"},{"line_number":551,"context_line":""},{"line_number":552,"context_line":"- imagename: \"{{namespace}}/{{name_prefix}}nova-conductor{{name_suffix}}:{{tag}}\""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"0996e951_8251e318","line":549,"range":{"start_line":548,"start_character":0,"end_line":549,"end_character":44},"in_reply_to":"2f211464_32b469e1","updated":"2023-07-04 10:50:22.000000000","message":"you are probaly correct that theses should be removed but i dont know currely why this is duplciated \n\nif we were to list the services under only one of the containers the nova-libvirt contaienr makes the most sense.","commit_id":"2d5ae80c34b2d20382324639983bd6d7e88ecd85"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7d3eaec3204001bba899f5a0cceb991889aee2b6","unresolved":false,"context_lines":[{"line_number":545,"context_line":"  - ContainerNovaComputeImage"},{"line_number":546,"context_line":"  services:"},{"line_number":547,"context_line":"  - OS::TripleO::Services::NovaCompute"},{"line_number":548,"context_line":"  - OS::TripleO::Services::NovaLibvirt"},{"line_number":549,"context_line":"  - OS::TripleO::Services::NovaLibvirtLegacy"},{"line_number":550,"context_line":"  - OS::TripleO::Services::NovaMigrationTarget"},{"line_number":551,"context_line":""},{"line_number":552,"context_line":"- imagename: \"{{namespace}}/{{name_prefix}}nova-conductor{{name_suffix}}:{{tag}}\""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"c476b125_beab495f","line":549,"range":{"start_line":548,"start_character":0,"end_line":549,"end_character":44},"in_reply_to":"58f456be_bb5c7983","updated":"2023-07-05 05:03:34.000000000","message":"Done","commit_id":"2d5ae80c34b2d20382324639983bd6d7e88ecd85"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1571d31b5fac2ebed86b08877c761c03a4fd54b1","unresolved":true,"context_lines":[{"line_number":561,"context_line":"  params:"},{"line_number":562,"context_line":"  - ContainerNovaLibvirtImage"},{"line_number":563,"context_line":"  - ContainerNovaLibvirtConfigImage"},{"line_number":564,"context_line":"  services:"},{"line_number":565,"context_line":"  - OS::TripleO::Services::NovaLibvirt"},{"line_number":566,"context_line":"  - OS::TripleO::Services::NovaLibvirtLegacy"},{"line_number":567,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"1ce9c86e_4c5c25aa","line":564,"updated":"2023-07-04 11:15:48.000000000","message":"we have to add the following two services.\n\n```\n- OS::TripleO::Services::NovaCompute\n- OS::TripleO::Services::NovaMigrationTarget\n```\n\nAlso I noticed `OS::TripleO::Services::NovaLibvirtGuests` is using ContaonerNovaLibvirtConfigImage but is missing from these mappings. We can probably add it now.","commit_id":"2d5ae80c34b2d20382324639983bd6d7e88ecd85"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7d3eaec3204001bba899f5a0cceb991889aee2b6","unresolved":false,"context_lines":[{"line_number":561,"context_line":"  params:"},{"line_number":562,"context_line":"  - ContainerNovaLibvirtImage"},{"line_number":563,"context_line":"  - ContainerNovaLibvirtConfigImage"},{"line_number":564,"context_line":"  services:"},{"line_number":565,"context_line":"  - OS::TripleO::Services::NovaLibvirt"},{"line_number":566,"context_line":"  - OS::TripleO::Services::NovaLibvirtLegacy"},{"line_number":567,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"6774a820_bb5702c6","line":564,"in_reply_to":"1ce9c86e_4c5c25aa","updated":"2023-07-05 05:03:34.000000000","message":"Done","commit_id":"2d5ae80c34b2d20382324639983bd6d7e88ecd85"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"788945d70890c6dee1313de01e42e8634908fbf8","unresolved":true,"context_lines":[{"line_number":562,"context_line":"  services:"},{"line_number":563,"context_line":"  - OS::TripleO::Services::NovaCompute"},{"line_number":564,"context_line":"  - OS::TripleO::Services::NovaLibvirt"},{"line_number":565,"context_line":"  - OS::TripleO::Services::NovaLibvirtGuests"},{"line_number":566,"context_line":"  - OS::TripleO::Services::NovaLibvirtLegacy"},{"line_number":567,"context_line":"  - OS::TripleO::Services::NovaMigrationTarget"},{"line_number":568,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"abd151f7_111aa476","line":565,"range":{"start_line":565,"start_character":4,"end_line":565,"end_character":44},"updated":"2023-07-05 11:10:36.000000000","message":"this is correct I believe though, requires libvirt-client which is in the nova-libvirt image and not the nova-compute image","commit_id":"4c109097e02ff9a7be217a2e6f053487b06cc950"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"5f14ee693634f57465f91eb4ed027ddcc9b68126","unresolved":false,"context_lines":[{"line_number":562,"context_line":"  services:"},{"line_number":563,"context_line":"  - OS::TripleO::Services::NovaCompute"},{"line_number":564,"context_line":"  - OS::TripleO::Services::NovaLibvirt"},{"line_number":565,"context_line":"  - OS::TripleO::Services::NovaLibvirtGuests"},{"line_number":566,"context_line":"  - OS::TripleO::Services::NovaLibvirtLegacy"},{"line_number":567,"context_line":"  - OS::TripleO::Services::NovaMigrationTarget"},{"line_number":568,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"9c313d1f_4a37ef8f","line":565,"range":{"start_line":565,"start_character":4,"end_line":565,"end_character":44},"in_reply_to":"abd151f7_111aa476","updated":"2023-07-05 12:00:16.000000000","message":"Done","commit_id":"4c109097e02ff9a7be217a2e6f053487b06cc950"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"d760a2d308d456cba4cfc25e0c3c568510616935","unresolved":true,"context_lines":[{"line_number":564,"context_line":"  - OS::TripleO::Services::NovaLibvirt"},{"line_number":565,"context_line":"  - OS::TripleO::Services::NovaLibvirtGuests"},{"line_number":566,"context_line":"  - OS::TripleO::Services::NovaLibvirtLegacy"},{"line_number":567,"context_line":"  - OS::TripleO::Services::NovaMigrationTarget"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":"- imagename: \"{{namespace}}/{{name_prefix}}nova-novncproxy{{name_suffix}}:{{tag}}\""},{"line_number":570,"context_line":"  image_source: tripleo"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"6f251cb9_915b99ed","line":567,"range":{"start_line":567,"start_character":4,"end_line":567,"end_character":46},"updated":"2023-07-05 11:04:56.000000000","message":"this needs to be nova-compute as it includes openssh-server while nova-libvirt does not","commit_id":"4c109097e02ff9a7be217a2e6f053487b06cc950"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"e435c6c7a008fe507605b144d087c6d389bde365","unresolved":false,"context_lines":[{"line_number":564,"context_line":"  - OS::TripleO::Services::NovaLibvirt"},{"line_number":565,"context_line":"  - OS::TripleO::Services::NovaLibvirtGuests"},{"line_number":566,"context_line":"  - OS::TripleO::Services::NovaLibvirtLegacy"},{"line_number":567,"context_line":"  - OS::TripleO::Services::NovaMigrationTarget"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":"- imagename: \"{{namespace}}/{{name_prefix}}nova-novncproxy{{name_suffix}}:{{tag}}\""},{"line_number":570,"context_line":"  image_source: tripleo"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"59bf80cf_48e25241","line":567,"range":{"start_line":567,"start_character":4,"end_line":567,"end_character":46},"in_reply_to":"6f251cb9_915b99ed","updated":"2023-07-05 11:34:11.000000000","message":"Looking at the service in t-h-t, it\u0027s still using nova-libvirt image to generate config - that should have been updated nova-compute when they were split. In practice I doubt it matters (it\u0027s just generating sshd config). The image the service uses to run the container is nova-compute, that\u0027s the significant one. I think it\u0027s correct the leave the service listed here for both images until/unless that is resolved.","commit_id":"4c109097e02ff9a7be217a2e6f053487b06cc950"}]}