)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b3769cb2fa7e3b3fe99942115c0b3f25877183ad","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Composable roles walkthrough"},{"line_number":10,"context_line":"This is a documentation update to add a some guidelines and references for THT"},{"line_number":11,"context_line":"and composable services within roles."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ic8f0ddde3f19d41ffe13abb97f5e38d5d63df2a8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"bab6814e_c1575e58","line":11,"range":{"start_line":11,"start_character":36,"end_line":11,"end_character":37},"updated":"2016-05-26 08:25:50.000000000","message":"might be nice to point to the blueprints here https://blueprints.launchpad.net/tripleo/+spec/composable-services-within-roles I\u0027d say this doc is a part of that work","commit_id":"450e2fbb2c050339fceda5e76b74ec46f52ecd0f"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"71b7b21687bea364480b009af0c0c75bcf7eeaed","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Composable roles walkthrough"},{"line_number":10,"context_line":"This is a documentation update to add a some guidelines and references for THT"},{"line_number":11,"context_line":"and composable services within roles."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ic8f0ddde3f19d41ffe13abb97f5e38d5d63df2a8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"bab6814e_67d68250","line":11,"range":{"start_line":11,"start_character":36,"end_line":11,"end_character":37},"in_reply_to":"bab6814e_c1575e58","updated":"2016-05-26 08:48:07.000000000","message":"Done","commit_id":"450e2fbb2c050339fceda5e76b74ec46f52ecd0f"}],"doc/source/advanced_deployment/advanced_deployment.rst":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b0d99ee0328794a087e92255df5bc5416a90972a","unresolved":false,"context_lines":[{"line_number":24,"context_line":"   # relevant to regular users."},{"line_number":25,"context_line":"   tripleo.sh"},{"line_number":26,"context_line":"   in_progress_review"},{"line_number":27,"context_line":"   tht_walkthrough"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_10ca6b1a","line":27,"updated":"2016-05-15 10:12:26.000000000","message":"please move it to \"contributions\" section","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"}],"doc/source/advanced_deployment/tht_walkthrough.rst":[{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"0976c2f27265de2d64db6e4658f677ff8582099e","unresolved":false,"context_lines":[{"line_number":417,"context_line":""},{"line_number":418,"context_line":""},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"Sumary"},{"line_number":421,"context_line":"------"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"References:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"dab17558_7d59395a","line":420,"range":{"start_line":420,"start_character":0,"end_line":420,"end_character":6},"updated":"2016-05-09 06:43:34.000000000","message":"s/Sumary/Summary","commit_id":"56f4c68564ba7937086af7afc8aa06c5f0f6ab4e"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"3358167d6bf27aab54e09e04d6400673ee06a0fc","unresolved":false,"context_lines":[{"line_number":417,"context_line":""},{"line_number":418,"context_line":""},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"Sumary"},{"line_number":421,"context_line":"------"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"References:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"dab17558_eb99df6f","line":420,"range":{"start_line":420,"start_character":0,"end_line":420,"end_character":6},"in_reply_to":"dab17558_7d59395a","updated":"2016-05-09 07:50:31.000000000","message":"Done","commit_id":"56f4c68564ba7937086af7afc8aa06c5f0f6ab4e"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"45cc48ee786ee54ff5a2dc7dd9225d029fef9989","unresolved":false,"context_lines":[{"line_number":54,"context_line":"Gerrit patches used in this example"},{"line_number":55,"context_line":"-----------------------------------"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"The gerrit patches are going to be used to describe this walkthrough are:"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"- https://review.openstack.org/#/c/310421/ (Tripleo-Heat-Templates)"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"dab17558_cb017b6c","line":57,"updated":"2016-05-09 08:08:47.000000000","message":"that","commit_id":"7f982ba8347f4c307e5c9b93fadb64bc85cfb0f6"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"5183f944c42c941d8683e836070df7f0da22e6ce","unresolved":false,"context_lines":[{"line_number":54,"context_line":"Gerrit patches used in this example"},{"line_number":55,"context_line":"-----------------------------------"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"The gerrit patches are going to be used to describe this walkthrough are:"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"- https://review.openstack.org/#/c/310421/ (Tripleo-Heat-Templates)"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"dab17558_0b21c3b4","line":57,"in_reply_to":"dab17558_cb017b6c","updated":"2016-05-09 08:13:36.000000000","message":"Done","commit_id":"7f982ba8347f4c307e5c9b93fadb64bc85cfb0f6"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"45cc48ee786ee54ff5a2dc7dd9225d029fef9989","unresolved":false,"context_lines":[{"line_number":95,"context_line":"Changes in tripleo-heat-templates"},{"line_number":96,"context_line":"---------------------------------"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"The list of changes that need to be done in THT are:"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"- Remove all the puppet logic from THT (Will be added to PT)."},{"line_number":101,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"dab17558_8b15b39c","line":98,"range":{"start_line":98,"start_character":20,"end_line":98,"end_character":36},"updated":"2016-05-09 08:08:47.000000000","message":"remove: that need to be done","commit_id":"7f982ba8347f4c307e5c9b93fadb64bc85cfb0f6"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"5183f944c42c941d8683e836070df7f0da22e6ce","unresolved":false,"context_lines":[{"line_number":95,"context_line":"Changes in tripleo-heat-templates"},{"line_number":96,"context_line":"---------------------------------"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"The list of changes that need to be done in THT are:"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"- Remove all the puppet logic from THT (Will be added to PT)."},{"line_number":101,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"dab17558_2b0da73e","line":98,"range":{"start_line":98,"start_character":20,"end_line":98,"end_character":36},"in_reply_to":"dab17558_8b15b39c","updated":"2016-05-09 08:13:36.000000000","message":"Done","commit_id":"7f982ba8347f4c307e5c9b93fadb64bc85cfb0f6"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"45cc48ee786ee54ff5a2dc7dd9225d029fef9989","unresolved":false,"context_lines":[{"line_number":308,"context_line":""},{"line_number":309,"context_line":"This step will reference how the puppet logic should be organized in PT."},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"In the file:"},{"line_number":312,"context_line":"::"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"  class tripleo::services::time::ntp ("}],"source_content_type":"text/x-rst","patch_set":9,"id":"dab17558_8bf1336d","line":311,"range":{"start_line":311,"start_character":0,"end_line":311,"end_character":12},"updated":"2016-05-09 08:08:47.000000000","message":"Change: Inside the manifests folder, add the service manifest following the folder structure (manifests/services/time/ntp.pp)","commit_id":"7f982ba8347f4c307e5c9b93fadb64bc85cfb0f6"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"5183f944c42c941d8683e836070df7f0da22e6ce","unresolved":false,"context_lines":[{"line_number":308,"context_line":""},{"line_number":309,"context_line":"This step will reference how the puppet logic should be organized in PT."},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"In the file:"},{"line_number":312,"context_line":"::"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"  class tripleo::services::time::ntp ("}],"source_content_type":"text/x-rst","patch_set":9,"id":"dab17558_cb15fb49","line":311,"range":{"start_line":311,"start_character":0,"end_line":311,"end_character":12},"in_reply_to":"dab17558_8bf1336d","updated":"2016-05-09 08:13:36.000000000","message":"Done","commit_id":"7f982ba8347f4c307e5c9b93fadb64bc85cfb0f6"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"45cc48ee786ee54ff5a2dc7dd9225d029fef9989","unresolved":false,"context_lines":[{"line_number":352,"context_line":"In order to make quick changes to the overcloud image for testing purposes, you can:"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"Or recreating the overcloud image by following (:doc:`in_progress_review`) :"},{"line_number":356,"context_line":"::"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"  export DIB_INSTALLTYPE_puppet_tripleo\u003dsource"}],"source_content_type":"text/x-rst","patch_set":9,"id":"dab17558_0bfee337","line":355,"range":{"start_line":355,"start_character":0,"end_line":355,"end_character":14},"updated":"2016-05-09 08:08:47.000000000","message":"Change: Create","commit_id":"7f982ba8347f4c307e5c9b93fadb64bc85cfb0f6"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"5183f944c42c941d8683e836070df7f0da22e6ce","unresolved":false,"context_lines":[{"line_number":352,"context_line":"In order to make quick changes to the overcloud image for testing purposes, you can:"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"Or recreating the overcloud image by following (:doc:`in_progress_review`) :"},{"line_number":356,"context_line":"::"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"  export DIB_INSTALLTYPE_puppet_tripleo\u003dsource"}],"source_content_type":"text/x-rst","patch_set":9,"id":"dab17558_8b1bf37f","line":355,"range":{"start_line":355,"start_character":0,"end_line":355,"end_character":14},"in_reply_to":"dab17558_0bfee337","updated":"2016-05-09 08:13:36.000000000","message":"Done","commit_id":"7f982ba8347f4c307e5c9b93fadb64bc85cfb0f6"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"45cc48ee786ee54ff5a2dc7dd9225d029fef9989","unresolved":false,"context_lines":[{"line_number":363,"context_line":""},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"Also, in order to not create"},{"line_number":366,"context_line":"noise in IRC, clone the repository and apply the changes from your github account."},{"line_number":367,"context_line":"In some cases this is particular useful as there is no need to update the patchset number."},{"line_number":368,"context_line":"::"},{"line_number":369,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"dab17558_6bfdef39","line":366,"updated":"2016-05-09 08:08:47.000000000","message":"is possible to","commit_id":"7f982ba8347f4c307e5c9b93fadb64bc85cfb0f6"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"5183f944c42c941d8683e836070df7f0da22e6ce","unresolved":false,"context_lines":[{"line_number":363,"context_line":""},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"Also, in order to not create"},{"line_number":366,"context_line":"noise in IRC, clone the repository and apply the changes from your github account."},{"line_number":367,"context_line":"In some cases this is particular useful as there is no need to update the patchset number."},{"line_number":368,"context_line":"::"},{"line_number":369,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"dab17558_4b2bcb94","line":366,"in_reply_to":"dab17558_6bfdef39","updated":"2016-05-09 08:13:36.000000000","message":"Done","commit_id":"7f982ba8347f4c307e5c9b93fadb64bc85cfb0f6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b0d99ee0328794a087e92255df5bc5416a90972a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Composable roles within services integrator tutorial"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Introduction"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_70d137cd","line":1,"updated":"2016-05-15 10:12:26.000000000","message":"Lets shorten it to \"Composable roles tutorial\". Will look nicer, and I anyway have no clues what you mean by \"services integrator\" here :)","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"04ce7e57e78d7697fec7e07f059a880096fce43b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Composable roles within services integrator tutorial"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Introduction"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_3b1a997d","line":1,"in_reply_to":"dab17558_70d137cd","updated":"2016-05-17 11:52:42.000000000","message":"Done","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b0d99ee0328794a087e92255df5bc5416a90972a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"This guide will be a walkthrough related to how to add new services"},{"line_number":8,"context_line":"to TripleO main repository (tripleo-heat-templates) from now on THT, using the"},{"line_number":9,"context_line":"composable services with in roles guidelines."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The first step will be to identify and isolate a functionality or feature"},{"line_number":12,"context_line":"that needs to be aligned with the composable roles approach."}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_50d4f3bb","line":9,"updated":"2016-05-15 10:12:26.000000000","message":"link to guidelines?","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"04ce7e57e78d7697fec7e07f059a880096fce43b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"This guide will be a walkthrough related to how to add new services"},{"line_number":8,"context_line":"to TripleO main repository (tripleo-heat-templates) from now on THT, using the"},{"line_number":9,"context_line":"composable services with in roles guidelines."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The first step will be to identify and isolate a functionality or feature"},{"line_number":12,"context_line":"that needs to be aligned with the composable roles approach."}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_162b2c83","line":9,"in_reply_to":"dab17558_50d4f3bb","updated":"2016-05-17 11:52:42.000000000","message":"Done","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b0d99ee0328794a087e92255df5bc5416a90972a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"composable services with in roles guidelines."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The first step will be to identify and isolate a functionality or feature"},{"line_number":12,"context_line":"that needs to be aligned with the composable roles approach."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"All the puppet manifests are called in THT folder: puppet/manifests. In order"},{"line_number":15,"context_line":"to properly organize and  structure the code, all manifests will be re-defined in"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_b0db9fec","line":12,"updated":"2016-05-15 10:12:26.000000000","message":"If you say that, you have to explain how to identify such features.","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"04ce7e57e78d7697fec7e07f059a880096fce43b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"composable services with in roles guidelines."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The first step will be to identify and isolate a functionality or feature"},{"line_number":12,"context_line":"that needs to be aligned with the composable roles approach."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"All the puppet manifests are called in THT folder: puppet/manifests. In order"},{"line_number":15,"context_line":"to properly organize and  structure the code, all manifests will be re-defined in"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_56b5b4ea","line":12,"in_reply_to":"dab17558_b0db9fec","updated":"2016-05-17 11:52:42.000000000","message":"Done","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b0d99ee0328794a087e92255df5bc5416a90972a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"The first step will be to identify and isolate a functionality or feature"},{"line_number":12,"context_line":"that needs to be aligned with the composable roles approach."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"All the puppet manifests are called in THT folder: puppet/manifests. In order"},{"line_number":15,"context_line":"to properly organize and  structure the code, all manifests will be re-defined in"},{"line_number":16,"context_line":"the puppet-tripleo repository from now on PT, and adapted to the composable"},{"line_number":17,"context_line":"services within roles guidelines."}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_90d65bc1","line":14,"updated":"2016-05-15 10:12:26.000000000","message":"files and directories are better decorated in double ticks: ``puppet/manifests``","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"04ce7e57e78d7697fec7e07f059a880096fce43b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"The first step will be to identify and isolate a functionality or feature"},{"line_number":12,"context_line":"that needs to be aligned with the composable roles approach."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"All the puppet manifests are called in THT folder: puppet/manifests. In order"},{"line_number":15,"context_line":"to properly organize and  structure the code, all manifests will be re-defined in"},{"line_number":16,"context_line":"the puppet-tripleo repository from now on PT, and adapted to the composable"},{"line_number":17,"context_line":"services within roles guidelines."}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_96a0bc91","line":14,"in_reply_to":"dab17558_90d65bc1","updated":"2016-05-17 11:52:42.000000000","message":"Done","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b0d99ee0328794a087e92255df5bc5416a90972a","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"All the puppet manifests are called in THT folder: puppet/manifests. In order"},{"line_number":15,"context_line":"to properly organize and  structure the code, all manifests will be re-defined in"},{"line_number":16,"context_line":"the puppet-tripleo repository from now on PT, and adapted to the composable"},{"line_number":17,"context_line":"services within roles guidelines."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"The use case for this example uses NTP as a service"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_f0e527a8","line":16,"updated":"2016-05-15 10:12:26.000000000","message":"what is PT here?","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"04ce7e57e78d7697fec7e07f059a880096fce43b","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"All the puppet manifests are called in THT folder: puppet/manifests. In order"},{"line_number":15,"context_line":"to properly organize and  structure the code, all manifests will be re-defined in"},{"line_number":16,"context_line":"the puppet-tripleo repository from now on PT, and adapted to the composable"},{"line_number":17,"context_line":"services within roles guidelines."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"The use case for this example uses NTP as a service"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_36063086","line":16,"in_reply_to":"dab17558_f0e527a8","updated":"2016-05-17 11:52:42.000000000","message":"Done","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b0d99ee0328794a087e92255df5bc5416a90972a","unresolved":false,"context_lines":[{"line_number":14,"context_line":"All the puppet manifests are called in THT folder: puppet/manifests. In order"},{"line_number":15,"context_line":"to properly organize and  structure the code, all manifests will be re-defined in"},{"line_number":16,"context_line":"the puppet-tripleo repository from now on PT, and adapted to the composable"},{"line_number":17,"context_line":"services within roles guidelines."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"The use case for this example uses NTP as a service"},{"line_number":20,"context_line":"installed by default among the OpenStack deployment."}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_d0e0e398","line":17,"updated":"2016-05-15 10:12:26.000000000","message":"ditto about referring to unknown guidelines","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"04ce7e57e78d7697fec7e07f059a880096fce43b","unresolved":false,"context_lines":[{"line_number":14,"context_line":"All the puppet manifests are called in THT folder: puppet/manifests. In order"},{"line_number":15,"context_line":"to properly organize and  structure the code, all manifests will be re-defined in"},{"line_number":16,"context_line":"the puppet-tripleo repository from now on PT, and adapted to the composable"},{"line_number":17,"context_line":"services within roles guidelines."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"The use case for this example uses NTP as a service"},{"line_number":20,"context_line":"installed by default among the OpenStack deployment."}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_f6f02893","line":17,"in_reply_to":"dab17558_d0e0e398","updated":"2016-05-17 11:52:42.000000000","message":"Done","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b0d99ee0328794a087e92255df5bc5416a90972a","unresolved":false,"context_lines":[{"line_number":19,"context_line":"The use case for this example uses NTP as a service"},{"line_number":20,"context_line":"installed by default among the OpenStack deployment."},{"line_number":21,"context_line":"In this particular case, NTP is installed and configured, so no need to add additional"},{"line_number":22,"context_line":"puppet modules to tripleo-puppet-elements. In the case of the need of adding"},{"line_number":23,"context_line":"a new third-party puppet manifest, should be added in tripleo-puppet-elements"},{"line_number":24,"context_line":"(Installed by default in al nodes) and called from puppet-tripleo."},{"line_number":25,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_30ee8f8b","line":22,"updated":"2016-05-15 10:12:26.000000000","message":"I don\u0027t quite get this. You mean that there is a puppet module already? or that the OS default configuration is enough?","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"04ce7e57e78d7697fec7e07f059a880096fce43b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"The use case for this example uses NTP as a service"},{"line_number":20,"context_line":"installed by default among the OpenStack deployment."},{"line_number":21,"context_line":"In this particular case, NTP is installed and configured, so no need to add additional"},{"line_number":22,"context_line":"puppet modules to tripleo-puppet-elements. In the case of the need of adding"},{"line_number":23,"context_line":"a new third-party puppet manifest, should be added in tripleo-puppet-elements"},{"line_number":24,"context_line":"(Installed by default in al nodes) and called from puppet-tripleo."},{"line_number":25,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_e11340ff","line":22,"in_reply_to":"dab17558_30ee8f8b","updated":"2016-05-17 11:52:42.000000000","message":"Done","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b0d99ee0328794a087e92255df5bc5416a90972a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"installed by default among the OpenStack deployment."},{"line_number":21,"context_line":"In this particular case, NTP is installed and configured, so no need to add additional"},{"line_number":22,"context_line":"puppet modules to tripleo-puppet-elements. In the case of the need of adding"},{"line_number":23,"context_line":"a new third-party puppet manifest, should be added in tripleo-puppet-elements"},{"line_number":24,"context_line":"(Installed by default in al nodes) and called from puppet-tripleo."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"The initial scope of this tutorial is"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_10f1cb6a","line":23,"updated":"2016-05-15 10:12:26.000000000","message":"rephrase: If needed, a new puppet manifest should be added to tripleo-puppet-elements and should be used from puppet-tripleo. In case of NTP it\u0027s not required, because \u003cstate reason\u003e.","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"04ce7e57e78d7697fec7e07f059a880096fce43b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"installed by default among the OpenStack deployment."},{"line_number":21,"context_line":"In this particular case, NTP is installed and configured, so no need to add additional"},{"line_number":22,"context_line":"puppet modules to tripleo-puppet-elements. In the case of the need of adding"},{"line_number":23,"context_line":"a new third-party puppet manifest, should be added in tripleo-puppet-elements"},{"line_number":24,"context_line":"(Installed by default in al nodes) and called from puppet-tripleo."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"The initial scope of this tutorial is"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_81db544e","line":23,"in_reply_to":"dab17558_10f1cb6a","updated":"2016-05-17 11:52:42.000000000","message":"Done","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b0d99ee0328794a087e92255df5bc5416a90972a","unresolved":false,"context_lines":[{"line_number":21,"context_line":"In this particular case, NTP is installed and configured, so no need to add additional"},{"line_number":22,"context_line":"puppet modules to tripleo-puppet-elements. In the case of the need of adding"},{"line_number":23,"context_line":"a new third-party puppet manifest, should be added in tripleo-puppet-elements"},{"line_number":24,"context_line":"(Installed by default in al nodes) and called from puppet-tripleo."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"The initial scope of this tutorial is"},{"line_number":27,"context_line":"to create a brief walkthrough with some guidelines and naming conventions"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_70e8177d","line":24,"updated":"2016-05-15 10:12:26.000000000","message":"typo: all, also no need for upper case in brackets","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"04ce7e57e78d7697fec7e07f059a880096fce43b","unresolved":false,"context_lines":[{"line_number":21,"context_line":"In this particular case, NTP is installed and configured, so no need to add additional"},{"line_number":22,"context_line":"puppet modules to tripleo-puppet-elements. In the case of the need of adding"},{"line_number":23,"context_line":"a new third-party puppet manifest, should be added in tripleo-puppet-elements"},{"line_number":24,"context_line":"(Installed by default in al nodes) and called from puppet-tripleo."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"The initial scope of this tutorial is"},{"line_number":27,"context_line":"to create a brief walkthrough with some guidelines and naming conventions"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_816b54f0","line":24,"in_reply_to":"dab17558_70e8177d","updated":"2016-05-17 11:52:42.000000000","message":"Done","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b0d99ee0328794a087e92255df5bc5416a90972a","unresolved":false,"context_lines":[{"line_number":26,"context_line":"The initial scope of this tutorial is"},{"line_number":27,"context_line":"to create a brief walkthrough with some guidelines and naming conventions"},{"line_number":28,"context_line":"for future modules and features aligned with the composable"},{"line_number":29,"context_line":"roles architecture."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"In order to achieve this we will use part of the architecture already defined"},{"line_number":32,"context_line":"in https://blueprints.launchpad.net/tripleo/+spec/composable-services-within-roles"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_50eb5378","line":29,"updated":"2016-05-15 10:12:26.000000000","message":"this should be a part of the very 1st paragraph","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"04ce7e57e78d7697fec7e07f059a880096fce43b","unresolved":false,"context_lines":[{"line_number":26,"context_line":"The initial scope of this tutorial is"},{"line_number":27,"context_line":"to create a brief walkthrough with some guidelines and naming conventions"},{"line_number":28,"context_line":"for future modules and features aligned with the composable"},{"line_number":29,"context_line":"roles architecture."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"In order to achieve this we will use part of the architecture already defined"},{"line_number":32,"context_line":"in https://blueprints.launchpad.net/tripleo/+spec/composable-services-within-roles"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_616e3001","line":29,"in_reply_to":"dab17558_50eb5378","updated":"2016-05-17 11:52:42.000000000","message":"Done","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b0d99ee0328794a087e92255df5bc5416a90972a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"roles architecture."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"In order to achieve this we will use part of the architecture already defined"},{"line_number":32,"context_line":"in https://blueprints.launchpad.net/tripleo/+spec/composable-services-within-roles"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"The controller services are defined and configured via resource chains."},{"line_number":35,"context_line":"In the proposed patch (#/c/259568) it will be wired a new Heat feature"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_b0027f3c","line":32,"updated":"2016-05-15 10:12:26.000000000","message":"so it this the guidelines? then please convert all mentions of guidelines to this link","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"04ce7e57e78d7697fec7e07f059a880096fce43b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"roles architecture."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"In order to achieve this we will use part of the architecture already defined"},{"line_number":32,"context_line":"in https://blueprints.launchpad.net/tripleo/+spec/composable-services-within-roles"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"The controller services are defined and configured via resource chains."},{"line_number":35,"context_line":"In the proposed patch (#/c/259568) it will be wired a new Heat feature"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_fc32c7f0","line":32,"in_reply_to":"dab17558_b0027f3c","updated":"2016-05-17 11:52:42.000000000","message":"Done","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b0d99ee0328794a087e92255df5bc5416a90972a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"In order to achieve this we will use part of the architecture already defined"},{"line_number":32,"context_line":"in https://blueprints.launchpad.net/tripleo/+spec/composable-services-within-roles"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"The controller services are defined and configured via resource chains."},{"line_number":35,"context_line":"In the proposed patch (#/c/259568) it will be wired a new Heat feature"},{"line_number":36,"context_line":"that allows to dynamically include a set of nested"},{"line_number":37,"context_line":"stacks representing individual services via a Heat resource chain."}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_90fdbb3d","line":34,"updated":"2016-05-15 10:12:26.000000000","message":"is it a Heat feature? then please call it Heat resource chains.","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"04ce7e57e78d7697fec7e07f059a880096fce43b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"In order to achieve this we will use part of the architecture already defined"},{"line_number":32,"context_line":"in https://blueprints.launchpad.net/tripleo/+spec/composable-services-within-roles"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"The controller services are defined and configured via resource chains."},{"line_number":35,"context_line":"In the proposed patch (#/c/259568) it will be wired a new Heat feature"},{"line_number":36,"context_line":"that allows to dynamically include a set of nested"},{"line_number":37,"context_line":"stacks representing individual services via a Heat resource chain."}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_5c84b3d1","line":34,"in_reply_to":"dab17558_90fdbb3d","updated":"2016-05-17 11:52:42.000000000","message":"Done","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b0d99ee0328794a087e92255df5bc5416a90972a","unresolved":false,"context_lines":[{"line_number":32,"context_line":"in https://blueprints.launchpad.net/tripleo/+spec/composable-services-within-roles"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"The controller services are defined and configured via resource chains."},{"line_number":35,"context_line":"In the proposed patch (#/c/259568) it will be wired a new Heat feature"},{"line_number":36,"context_line":"that allows to dynamically include a set of nested"},{"line_number":37,"context_line":"stacks representing individual services via a Heat resource chain."},{"line_number":38,"context_line":"Follow on patches (The current example) will use this interface to decompose"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_f0fc0740","line":35,"updated":"2016-05-15 10:12:26.000000000","message":"malformed link. also what is \"it\" here? Both services and chains are plural.","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"04ce7e57e78d7697fec7e07f059a880096fce43b","unresolved":false,"context_lines":[{"line_number":32,"context_line":"in https://blueprints.launchpad.net/tripleo/+spec/composable-services-within-roles"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"The controller services are defined and configured via resource chains."},{"line_number":35,"context_line":"In the proposed patch (#/c/259568) it will be wired a new Heat feature"},{"line_number":36,"context_line":"that allows to dynamically include a set of nested"},{"line_number":37,"context_line":"stacks representing individual services via a Heat resource chain."},{"line_number":38,"context_line":"Follow on patches (The current example) will use this interface to decompose"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_dcff0300","line":35,"in_reply_to":"dab17558_f0fc0740","updated":"2016-05-17 11:52:42.000000000","message":"Done","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b0d99ee0328794a087e92255df5bc5416a90972a","unresolved":false,"context_lines":[{"line_number":35,"context_line":"In the proposed patch (#/c/259568) it will be wired a new Heat feature"},{"line_number":36,"context_line":"that allows to dynamically include a set of nested"},{"line_number":37,"context_line":"stacks representing individual services via a Heat resource chain."},{"line_number":38,"context_line":"Follow on patches (The current example) will use this interface to decompose"},{"line_number":39,"context_line":"the controller role into isolated services."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"This tutorial is divided in several steps, according different changes that needs to be added"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_d0f74357","line":38,"updated":"2016-05-15 10:12:26.000000000","message":"As you don\u0027t link the patches, it\u0027s no use mentioning them, so just \"The current example will use...\"","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"04ce7e57e78d7697fec7e07f059a880096fce43b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"In the proposed patch (#/c/259568) it will be wired a new Heat feature"},{"line_number":36,"context_line":"that allows to dynamically include a set of nested"},{"line_number":37,"context_line":"stacks representing individual services via a Heat resource chain."},{"line_number":38,"context_line":"Follow on patches (The current example) will use this interface to decompose"},{"line_number":39,"context_line":"the controller role into isolated services."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"This tutorial is divided in several steps, according different changes that needs to be added"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_7c109759","line":38,"in_reply_to":"dab17558_d0f74357","updated":"2016-05-17 11:52:42.000000000","message":"Done","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b0d99ee0328794a087e92255df5bc5416a90972a","unresolved":false,"context_lines":[{"line_number":38,"context_line":"Follow on patches (The current example) will use this interface to decompose"},{"line_number":39,"context_line":"the controller role into isolated services."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"This tutorial is divided in several steps, according different changes that needs to be added"},{"line_number":42,"context_line":"to the structure of THT and PT."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Repositories referenced in this guide"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_3095efe3","line":41,"updated":"2016-05-15 10:12:26.000000000","message":"please wrap this string.","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"04ce7e57e78d7697fec7e07f059a880096fce43b","unresolved":false,"context_lines":[{"line_number":38,"context_line":"Follow on patches (The current example) will use this interface to decompose"},{"line_number":39,"context_line":"the controller role into isolated services."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"This tutorial is divided in several steps, according different changes that needs to be added"},{"line_number":42,"context_line":"to the structure of THT and PT."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Repositories referenced in this guide"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_1c8d0b31","line":41,"in_reply_to":"dab17558_3095efe3","updated":"2016-05-17 11:52:42.000000000","message":"Done","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b0d99ee0328794a087e92255df5bc5416a90972a","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"- puppet-tripleo: Custom TripleO puppet manifests to deploy the overcloud."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- tripleo-puppet-elements: Importing third-party puppet modules (Not used in this tutorial,"},{"line_number":52,"context_line":"  but needs to be used for adding additional puppet modules)."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Gerrit patches used in this example"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_1098ab1a","line":51,"updated":"2016-05-15 10:12:26.000000000","message":"1. s/Importing//","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b0d99ee0328794a087e92255df5bc5416a90972a","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"- puppet-tripleo: Custom TripleO puppet manifests to deploy the overcloud."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- tripleo-puppet-elements: Importing third-party puppet modules (Not used in this tutorial,"},{"line_number":52,"context_line":"  but needs to be used for adding additional puppet modules)."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Gerrit patches used in this example"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_709f7703","line":51,"updated":"2016-05-15 10:12:26.000000000","message":"2. please convert these to links to github or git.o.o","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"04ce7e57e78d7697fec7e07f059a880096fce43b","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"- puppet-tripleo: Custom TripleO puppet manifests to deploy the overcloud."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- tripleo-puppet-elements: Importing third-party puppet modules (Not used in this tutorial,"},{"line_number":52,"context_line":"  but needs to be used for adding additional puppet modules)."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Gerrit patches used in this example"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_fcef67e6","line":51,"in_reply_to":"dab17558_1098ab1a","updated":"2016-05-17 11:52:42.000000000","message":"Done","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b0d99ee0328794a087e92255df5bc5416a90972a","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"- https://review.openstack.org/#/c/310725/ (Puppet-Tripleo)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Folder structure convention for PT"},{"line_number":64,"context_line":"-----------------------------------"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Services should be defined in the services folder, depending on the service purpose."}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_50a2334c","line":63,"updated":"2016-05-15 10:12:26.000000000","message":"+1 and please do not shorted puppet-tripleo","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"48516ad49352aa62bd1aaa7c0f98d5707b857931","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"- https://review.openstack.org/#/c/310725/ (Puppet-Tripleo)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Folder structure convention for PT"},{"line_number":64,"context_line":"-----------------------------------"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Services should be defined in the services folder, depending on the service purpose."}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_fce64742","line":63,"range":{"start_line":63,"start_character":32,"end_line":63,"end_character":34},"updated":"2016-05-11 13:12:29.000000000","message":"THT not PT","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"04ce7e57e78d7697fec7e07f059a880096fce43b","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"- https://review.openstack.org/#/c/310725/ (Puppet-Tripleo)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Folder structure convention for PT"},{"line_number":64,"context_line":"-----------------------------------"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Services should be defined in the services folder, depending on the service purpose."}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_dc1383ff","line":63,"in_reply_to":"dab17558_50a2334c","updated":"2016-05-17 11:52:42.000000000","message":"Done","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b0d99ee0328794a087e92255df5bc5416a90972a","unresolved":false,"context_lines":[{"line_number":75,"context_line":".. note::"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"  No templates or puppet manifests must be defined in this repository,"},{"line_number":78,"context_line":"  this will be addressed in the PT repository."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Folder structure convention for PT"},{"line_number":81,"context_line":"-----------------------------------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_b089dfcc","line":78,"updated":"2016-05-15 10:12:26.000000000","message":"rephrase: they should go to the puppet-tripleo repository instead.","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"04ce7e57e78d7697fec7e07f059a880096fce43b","unresolved":false,"context_lines":[{"line_number":75,"context_line":".. note::"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"  No templates or puppet manifests must be defined in this repository,"},{"line_number":78,"context_line":"  this will be addressed in the PT repository."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Folder structure convention for PT"},{"line_number":81,"context_line":"-----------------------------------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_bce95fe8","line":78,"in_reply_to":"dab17558_b089dfcc","updated":"2016-05-17 11:52:42.000000000","message":"Done","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b0d99ee0328794a087e92255df5bc5416a90972a","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":".. note::"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"  Follow the same folder naming convention if needed to add files to the templates folder."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Changes in tripleo-heat-templates"},{"line_number":96,"context_line":"---------------------------------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_90849bb1","line":93,"updated":"2016-05-15 10:12:26.000000000","message":"rephrase: The same naming convention is used in the ``templates`` directory.","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"04ce7e57e78d7697fec7e07f059a880096fce43b","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":".. note::"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"  Follow the same folder naming convention if needed to add files to the templates folder."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Changes in tripleo-heat-templates"},{"line_number":96,"context_line":"---------------------------------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_1c098b95","line":93,"in_reply_to":"dab17558_90849bb1","updated":"2016-05-17 11:52:42.000000000","message":"Done","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b0d99ee0328794a087e92255df5bc5416a90972a","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"The list of changes in THT are:"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"- Remove all the puppet logic from THT (Will be added to PT)."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"- Create a service type specific folder in the root services folder"},{"line_number":103,"context_line":"  (puppet/services/time)."}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_f09367f8","line":100,"updated":"2016-05-15 10:12:26.000000000","message":"I don\u0027t think it should be in the example. Or rephrase like:\n\n If existing puppet modules for the added feature are present in THT, remove them, as they\u0027ll be reintroduced in puppet-tripleo.","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"04ce7e57e78d7697fec7e07f059a880096fce43b","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"The list of changes in THT are:"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"- Remove all the puppet logic from THT (Will be added to PT)."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"- Create a service type specific folder in the root services folder"},{"line_number":103,"context_line":"  (puppet/services/time)."}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_306113d4","line":100,"in_reply_to":"dab17558_f09367f8","updated":"2016-05-17 11:52:42.000000000","message":"Done","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b0d99ee0328794a087e92255df5bc5416a90972a","unresolved":false,"context_lines":[{"line_number":100,"context_line":"- Remove all the puppet logic from THT (Will be added to PT)."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"- Create a service type specific folder in the root services folder"},{"line_number":103,"context_line":"  (puppet/services/time)."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"- Create a main service file inside the puppet/services folder"},{"line_number":106,"context_line":"  (puppet/services/time/ntp.yaml)."}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_d08e23cf","line":103,"updated":"2016-05-15 10:12:26.000000000","message":"``puppet/services/time``","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"04ce7e57e78d7697fec7e07f059a880096fce43b","unresolved":false,"context_lines":[{"line_number":100,"context_line":"- Remove all the puppet logic from THT (Will be added to PT)."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"- Create a service type specific folder in the root services folder"},{"line_number":103,"context_line":"  (puppet/services/time)."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"- Create a main service file inside the puppet/services folder"},{"line_number":106,"context_line":"  (puppet/services/time/ntp.yaml)."}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_f0b14b48","line":103,"in_reply_to":"dab17558_d08e23cf","updated":"2016-05-17 11:52:42.000000000","message":"Done","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b0d99ee0328794a087e92255df5bc5416a90972a","unresolved":false,"context_lines":[{"line_number":103,"context_line":"  (puppet/services/time)."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"- Create a main service file inside the puppet/services folder"},{"line_number":106,"context_line":"  (puppet/services/time/ntp.yaml)."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"- Create a main configuration file linked to the main service file in the"},{"line_number":109,"context_line":"  same folder (puppet/services/time/ntp-base.yaml)."}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_30bccf6b","line":106,"updated":"2016-05-15 10:12:26.000000000","message":"ditto about ticks","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"04ce7e57e78d7697fec7e07f059a880096fce43b","unresolved":false,"context_lines":[{"line_number":103,"context_line":"  (puppet/services/time)."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"- Create a main service file inside the puppet/services folder"},{"line_number":106,"context_line":"  (puppet/services/time/ntp.yaml)."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"- Create a main configuration file linked to the main service file in the"},{"line_number":109,"context_line":"  same folder (puppet/services/time/ntp-base.yaml)."}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_d0ac07ef","line":106,"in_reply_to":"dab17558_30bccf6b","updated":"2016-05-17 11:52:42.000000000","message":"Done","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b0d99ee0328794a087e92255df5bc5416a90972a","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Step 1 - remove all puppet references for the composable service from the current manifests (*.pp)"},{"line_number":113,"context_line":"--------------------------------------------------------------------------------------------------"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"All the puppet logic will live in the PT repository based on a configuration step, so forth is mandatory"},{"line_number":116,"context_line":"to remove all the references from THT."}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_10bf0b61","line":113,"updated":"2016-05-15 10:12:26.000000000","message":"line is way too long","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"04ce7e57e78d7697fec7e07f059a880096fce43b","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Step 1 - remove all puppet references for the composable service from the current manifests (*.pp)"},{"line_number":113,"context_line":"--------------------------------------------------------------------------------------------------"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"All the puppet logic will live in the PT repository based on a configuration step, so forth is mandatory"},{"line_number":116,"context_line":"to remove all the references from THT."}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_b0c863a9","line":113,"in_reply_to":"dab17558_10bf0b61","updated":"2016-05-17 11:52:42.000000000","message":"Done","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b0d99ee0328794a087e92255df5bc5416a90972a","unresolved":false,"context_lines":[{"line_number":112,"context_line":"Step 1 - remove all puppet references for the composable service from the current manifests (*.pp)"},{"line_number":113,"context_line":"--------------------------------------------------------------------------------------------------"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"All the puppet logic will live in the PT repository based on a configuration step, so forth is mandatory"},{"line_number":116,"context_line":"to remove all the references from THT."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"The updated .pp files for the NTP example were:"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_70b6578b","line":115,"updated":"2016-05-15 10:12:26.000000000","message":"wrapping","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"04ce7e57e78d7697fec7e07f059a880096fce43b","unresolved":false,"context_lines":[{"line_number":112,"context_line":"Step 1 - remove all puppet references for the composable service from the current manifests (*.pp)"},{"line_number":113,"context_line":"--------------------------------------------------------------------------------------------------"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"All the puppet logic will live in the PT repository based on a configuration step, so forth is mandatory"},{"line_number":116,"context_line":"to remove all the references from THT."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"The updated .pp files for the NTP example were:"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_f0c66b98","line":115,"in_reply_to":"dab17558_70b6578b","updated":"2016-05-17 11:52:42.000000000","message":"Done","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b0d99ee0328794a087e92255df5bc5416a90972a","unresolved":false,"context_lines":[{"line_number":113,"context_line":"--------------------------------------------------------------------------------------------------"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"All the puppet logic will live in the PT repository based on a configuration step, so forth is mandatory"},{"line_number":116,"context_line":"to remove all the references from THT."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"The updated .pp files for the NTP example were:"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_50b99378","line":116,"updated":"2016-05-15 10:12:26.000000000","message":"How do we maintain backward compatibility when removing these modules?","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"04ce7e57e78d7697fec7e07f059a880096fce43b","unresolved":false,"context_lines":[{"line_number":113,"context_line":"--------------------------------------------------------------------------------------------------"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"All the puppet logic will live in the PT repository based on a configuration step, so forth is mandatory"},{"line_number":116,"context_line":"to remove all the references from THT."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"The updated .pp files for the NTP example were:"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_10eb2fdd","line":116,"in_reply_to":"dab17558_50b99378","updated":"2016-05-17 11:52:42.000000000","message":"Need to discuss this on IRC :)","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b0d99ee0328794a087e92255df5bc5416a90972a","unresolved":false,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"By updating the resource registry we are forcing to use a nested template to configure our resources."},{"line_number":153,"context_line":"In the example case the created resource (OS::TripleO::Services::Ntp),"},{"line_number":154,"context_line":"will point to the corresponding service yaml file (puppet/services/time/ntp.yaml)."},{"line_number":155,"context_line":""},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Step 3 - overcloud.yaml initial changes"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_b0b0bf8c","line":154,"updated":"2016-05-15 10:12:26.000000000","message":"ditto about ticks","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"04ce7e57e78d7697fec7e07f059a880096fce43b","unresolved":false,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"By updating the resource registry we are forcing to use a nested template to configure our resources."},{"line_number":153,"context_line":"In the example case the created resource (OS::TripleO::Services::Ntp),"},{"line_number":154,"context_line":"will point to the corresponding service yaml file (puppet/services/time/ntp.yaml)."},{"line_number":155,"context_line":""},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Step 3 - overcloud.yaml initial changes"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_d0924756","line":154,"in_reply_to":"dab17558_b0b0bf8c","updated":"2016-05-17 11:52:42.000000000","message":"Done","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"c88c80c2f7961de2330697dfd00a755e738cac88","unresolved":false,"context_lines":[{"line_number":169,"context_line":"      - OS::TripleO::Services::Keystone"},{"line_number":170,"context_line":"      - OS::TripleO::Services::GlanceApi"},{"line_number":171,"context_line":"      - OS::TripleO::Services::GlanceRegistry"},{"line_number":172,"context_line":"      - OS::TripleO::Services::NTP              ---\u003e New service deployed in the controller overcloud"},{"line_number":173,"context_line":"    description: A list of service resources (configured in the Heat"},{"line_number":174,"context_line":"                 resource_registry) which represent nested stacks"},{"line_number":175,"context_line":"                 for each service that should get installed on the Controllers."}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_f0230b54","line":172,"range":{"start_line":172,"start_character":31,"end_line":172,"end_character":34},"updated":"2016-05-13 09:32:46.000000000","message":"Ntp","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"04ce7e57e78d7697fec7e07f059a880096fce43b","unresolved":false,"context_lines":[{"line_number":169,"context_line":"      - OS::TripleO::Services::Keystone"},{"line_number":170,"context_line":"      - OS::TripleO::Services::GlanceApi"},{"line_number":171,"context_line":"      - OS::TripleO::Services::GlanceRegistry"},{"line_number":172,"context_line":"      - OS::TripleO::Services::NTP              ---\u003e New service deployed in the controller overcloud"},{"line_number":173,"context_line":"    description: A list of service resources (configured in the Heat"},{"line_number":174,"context_line":"                 resource_registry) which represent nested stacks"},{"line_number":175,"context_line":"                 for each service that should get installed on the Controllers."}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_7091db46","line":172,"range":{"start_line":172,"start_character":31,"end_line":172,"end_character":34},"in_reply_to":"dab17558_f0230b54","updated":"2016-05-17 11:52:42.000000000","message":"Done","commit_id":"4710fdf89f46a5a760f87e07afe6bbd96559af0d"},{"author":{"_account_id":19472,"name":"Gerard Braad","email":"me@gbraad.nl","username":"gbraad"},"change_message_id":"10354ecfd5ec78263639658c09de835bc3057e26","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    services          ---\u003e To host all services."},{"line_number":82,"context_line":"      time            ---\u003e Specific folder for time services (NTP, timezone, Chrony among others)."},{"line_number":83,"context_line":"        ntp.yaml      ---\u003e Main service manifest."},{"line_number":84,"context_line":"        ntp-base.yaml ---\u003e Main service configuration file."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":".. note::"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"bab6814e_5fc59759","line":84,"updated":"2016-05-18 05:31:52.000000000","message":"Why do we need two files (ntp and ntp-base) for this functionality?","commit_id":"6da669fd9547af981b256f899e6ee465ae1497e1"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"b5a8f8224ad0538f34f17e64095f190bc610ff62","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    services          ---\u003e To host all services."},{"line_number":82,"context_line":"      time            ---\u003e Specific folder for time services (NTP, timezone, Chrony among others)."},{"line_number":83,"context_line":"        ntp.yaml      ---\u003e Main service manifest."},{"line_number":84,"context_line":"        ntp-base.yaml ---\u003e Main service configuration file."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":".. note::"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"bab6814e_3620ae9b","line":84,"in_reply_to":"bab6814e_5fc59759","updated":"2016-05-18 10:30:05.000000000","message":"I have added a section with a design pattern explaining this situation. I will add also a description here about the base file.","commit_id":"6da669fd9547af981b256f899e6ee465ae1497e1"},{"author":{"_account_id":19472,"name":"Gerard Braad","email":"me@gbraad.nl","username":"gbraad"},"change_message_id":"5ae086a07cdb07e9b315375655073b46935bdab0","unresolved":false,"context_lines":[{"line_number":191,"context_line":"------------------------------"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"It is mandatory to link our new feature to the ControllerServices"},{"line_number":194,"context_line":"parameter, which define all the services enabled by default in"},{"line_number":195,"context_line":"the controller(s)."},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"From overcloud.yaml in the parameters section find:"}],"source_content_type":"text/x-rst","patch_set":12,"id":"bab6814e_b9302309","line":194,"updated":"2016-05-18 04:15:55.000000000","message":"nit: defines","commit_id":"6da669fd9547af981b256f899e6ee465ae1497e1"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"b5a8f8224ad0538f34f17e64095f190bc610ff62","unresolved":false,"context_lines":[{"line_number":191,"context_line":"------------------------------"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"It is mandatory to link our new feature to the ControllerServices"},{"line_number":194,"context_line":"parameter, which define all the services enabled by default in"},{"line_number":195,"context_line":"the controller(s)."},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"From overcloud.yaml in the parameters section find:"}],"source_content_type":"text/x-rst","patch_set":12,"id":"bab6814e_366eeec9","line":194,"in_reply_to":"bab6814e_b9302309","updated":"2016-05-18 10:30:05.000000000","message":"Done","commit_id":"6da669fd9547af981b256f899e6ee465ae1497e1"},{"author":{"_account_id":19472,"name":"Gerard Braad","email":"me@gbraad.nl","username":"gbraad"},"change_message_id":"5ae086a07cdb07e9b315375655073b46935bdab0","unresolved":false,"context_lines":[{"line_number":222,"context_line":"      MysqlVirtualIPUri: {get_attr: [VipMap, net_ip_uri_map, {get_param: [ServiceNetMap, MysqlNetwork]}]}"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"ASK HOW TO INSTALL SERVICES IN:"},{"line_number":226,"context_line":"  - COMPUTE NODES"},{"line_number":227,"context_line":"  - STORAGE NODES"},{"line_number":228,"context_line":"  - ALL NODES"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"Step 4 - Create the services yaml files"}],"source_content_type":"text/x-rst","patch_set":12,"id":"bab6814e_390c3342","line":228,"range":{"start_line":225,"start_character":0,"end_line":228,"end_character":13},"updated":"2016-05-18 04:15:55.000000000","message":"Todo ?","commit_id":"6da669fd9547af981b256f899e6ee465ae1497e1"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"b5a8f8224ad0538f34f17e64095f190bc610ff62","unresolved":false,"context_lines":[{"line_number":222,"context_line":"      MysqlVirtualIPUri: {get_attr: [VipMap, net_ip_uri_map, {get_param: [ServiceNetMap, MysqlNetwork]}]}"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"ASK HOW TO INSTALL SERVICES IN:"},{"line_number":226,"context_line":"  - COMPUTE NODES"},{"line_number":227,"context_line":"  - STORAGE NODES"},{"line_number":228,"context_line":"  - ALL NODES"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"Step 4 - Create the services yaml files"}],"source_content_type":"text/x-rst","patch_set":12,"id":"bab6814e_0b18e783","line":228,"range":{"start_line":225,"start_character":0,"end_line":228,"end_character":13},"in_reply_to":"bab6814e_390c3342","updated":"2016-05-18 10:30:05.000000000","message":"Done","commit_id":"6da669fd9547af981b256f899e6ee465ae1497e1"},{"author":{"_account_id":19472,"name":"Gerard Braad","email":"me@gbraad.nl","username":"gbraad"},"change_message_id":"5ae086a07cdb07e9b315375655073b46935bdab0","unresolved":false,"context_lines":[{"line_number":396,"context_line":"  export DIB_REPOREF_puppet_tripleo\u003drefs/changes/25/310725/14"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"Also, is possible in order to not create"},{"line_number":400,"context_line":"noise in IRC, cloning PT and apply the changes from your github account."},{"line_number":401,"context_line":"In some cases this is particular useful as there is no need to update the patchset number."},{"line_number":402,"context_line":"::"},{"line_number":403,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"bab6814e_c49a5ec5","line":400,"range":{"start_line":399,"start_character":0,"end_line":400,"end_character":21},"updated":"2016-05-18 04:15:55.000000000","message":"In order to avoid noise on IRC, it is possible to clone PT","commit_id":"6da669fd9547af981b256f899e6ee465ae1497e1"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"b5a8f8224ad0538f34f17e64095f190bc610ff62","unresolved":false,"context_lines":[{"line_number":396,"context_line":"  export DIB_REPOREF_puppet_tripleo\u003drefs/changes/25/310725/14"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"Also, is possible in order to not create"},{"line_number":400,"context_line":"noise in IRC, cloning PT and apply the changes from your github account."},{"line_number":401,"context_line":"In some cases this is particular useful as there is no need to update the patchset number."},{"line_number":402,"context_line":"::"},{"line_number":403,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"bab6814e_1673eab2","line":400,"range":{"start_line":399,"start_character":0,"end_line":400,"end_character":21},"in_reply_to":"bab6814e_c49a5ec5","updated":"2016-05-18 10:30:05.000000000","message":"Done","commit_id":"6da669fd9547af981b256f899e6ee465ae1497e1"}],"doc/source/tht_walkthrough/changes-puppet-tripleo.rst":[{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"9add14ac033791cbd8a669ef0d8fc2221cab6b27","unresolved":false,"context_lines":[{"line_number":25,"context_line":"This step will reference how the puppet logic should be organized in puppet-tripleo."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Inside the manifests folder, add the service manifest following"},{"line_number":28,"context_line":"the folder structure (manifests/services/time/ntp.pp) as:"},{"line_number":29,"context_line":"::"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  class tripleo::services::time::ntp ("}],"source_content_type":"text/x-rst","patch_set":14,"id":"bab6814e_46145943","line":28,"range":{"start_line":28,"start_character":22,"end_line":28,"end_character":52},"updated":"2016-05-19 14:43:59.000000000","message":"maybe inside ``?","commit_id":"e4699afb7e2d712bea65ecb94630d0b259a2cd05"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"befe57fabf23623e47d5e2f4f8f11401580e26d6","unresolved":false,"context_lines":[{"line_number":25,"context_line":"This step will reference how the puppet logic should be organized in puppet-tripleo."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Inside the manifests folder, add the service manifest following"},{"line_number":28,"context_line":"the folder structure (manifests/services/time/ntp.pp) as:"},{"line_number":29,"context_line":"::"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  class tripleo::services::time::ntp ("}],"source_content_type":"text/x-rst","patch_set":14,"id":"bab6814e_eb8c1f81","line":28,"range":{"start_line":28,"start_character":22,"end_line":28,"end_character":52},"in_reply_to":"bab6814e_46145943","updated":"2016-05-19 19:38:21.000000000","message":"Done","commit_id":"e4699afb7e2d712bea65ecb94630d0b259a2cd05"},{"author":{"_account_id":7294,"name":"Leif Madsen","email":"lmadsen@redhat.com","username":"leifmadsen"},"change_message_id":"93499d7a310545bdd28658c6ebb32fe225edaaa4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Updating puppet-tripleo"},{"line_number":2,"context_line":"-----------------------"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"The following changes affects puppet-tripleo to add the composable roles logic"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Folder structure convention"},{"line_number":7,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_eb7d3fb2","line":4,"range":{"start_line":4,"start_character":22,"end_line":4,"end_character":29},"updated":"2016-05-19 20:12:18.000000000","message":"affect?","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"82918dc7a313357cdfb9b4009b81ecf2ee61d3c6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Updating puppet-tripleo"},{"line_number":2,"context_line":"-----------------------"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"The following changes affects puppet-tripleo to add the composable roles logic"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Folder structure convention"},{"line_number":7,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_8c5d947b","line":4,"range":{"start_line":4,"start_character":22,"end_line":4,"end_character":29},"in_reply_to":"bab6814e_eb7d3fb2","updated":"2016-05-20 08:32:58.000000000","message":"Done","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"8e8fcd62577cdc9246e9eb20db20bc1dc8cf02b1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Updating puppet-tripleo"},{"line_number":2,"context_line":"-----------------------"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"The following changes affect puppet-tripleo to add the composable roles logic."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Folder structure convention"},{"line_number":7,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7aa08908_8439c8d9","line":4,"updated":"2016-06-08 08:58:53.000000000","message":"The puppet manifests that currently define overcloud node configuration are moved from the tripleo-heat-templates to new puppet-tripleo class definitions as part of the composable roles approach. This section considers the addition of the ntp definition to puppet-tripleo.","commit_id":"992e8ab995fd7b0721db22fd98565583597a6ffa"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"19969919ea75525879e2deb1e7b9548a523de2fe","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Updating puppet-tripleo"},{"line_number":2,"context_line":"-----------------------"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"The following changes affect puppet-tripleo to add the composable roles logic."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Folder structure convention"},{"line_number":7,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7aa08908_e63249a6","line":4,"in_reply_to":"7aa08908_8439c8d9","updated":"2016-06-08 11:31:06.000000000","message":"Done","commit_id":"992e8ab995fd7b0721db22fd98565583597a6ffa"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"8e8fcd62577cdc9246e9eb20db20bc1dc8cf02b1","unresolved":false,"context_lines":[{"line_number":11,"context_line":"::"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"  manifests"},{"line_number":14,"context_line":"    services          ---\u003e To host all services."},{"line_number":15,"context_line":"      time            ---\u003e Specific folder for time services (NTP, timezone, Chrony among others)."},{"line_number":16,"context_line":"        ntp.pp        ---\u003e Puppet manifest to configure the service."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"7aa08908_24b8d4c7","line":14,"updated":"2016-06-08 08:58:53.000000000","message":"this is a lie ccamacho shame and i thought you were one of the good guys :/ (\"profile\" :) )\n\n[UPDATE]: so I sanity checked because you use it below as /manifests/services. Looking at the reviews indeed you are adding this to a new services directory:\n\ntht has +        include ::tripleo::services::time::ntp\npuppet-tripleo\n\ni guess there must be a reason? Why can\u0027t we just have ::tripleo::profile::ntp or similar so it is more consistent? (heh sry I realise this belongs on that review really)","commit_id":"992e8ab995fd7b0721db22fd98565583597a6ffa"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"19969919ea75525879e2deb1e7b9548a523de2fe","unresolved":false,"context_lines":[{"line_number":11,"context_line":"::"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"  manifests"},{"line_number":14,"context_line":"    services          ---\u003e To host all services."},{"line_number":15,"context_line":"      time            ---\u003e Specific folder for time services (NTP, timezone, Chrony among others)."},{"line_number":16,"context_line":"        ntp.pp        ---\u003e Puppet manifest to configure the service."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"7aa08908_c6746d37","line":14,"in_reply_to":"7aa08908_24b8d4c7","updated":"2016-06-08 11:31:06.000000000","message":"You are right xD, the current Ntp submission is not aligned with other submissions as this was from the very beginning, now is all fixed.","commit_id":"992e8ab995fd7b0721db22fd98565583597a6ffa"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"8e8fcd62577cdc9246e9eb20db20bc1dc8cf02b1","unresolved":false,"context_lines":[{"line_number":18,"context_line":".. note::"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  The same naming convention is used in the ``templates`` directory if"},{"line_number":21,"context_line":"  required."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Adding the puppet manifest"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7aa08908_0496783e","line":21,"updated":"2016-06-08 08:58:53.000000000","message":"since we already have this directory structure would be nice to point to it i mean in the github repo like https://github.com/openstack/puppet-tripleo/tree/806b9879c948462d381f8924616205e37e0e3785/manifests/profile","commit_id":"992e8ab995fd7b0721db22fd98565583597a6ffa"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"19969919ea75525879e2deb1e7b9548a523de2fe","unresolved":false,"context_lines":[{"line_number":18,"context_line":".. note::"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  The same naming convention is used in the ``templates`` directory if"},{"line_number":21,"context_line":"  required."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Adding the puppet manifest"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7aa08908_e666c94f","line":21,"in_reply_to":"7aa08908_0496783e","updated":"2016-06-08 11:31:06.000000000","message":"Done","commit_id":"992e8ab995fd7b0721db22fd98565583597a6ffa"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"581dfaa49cf1b008316439a9d7ee47bc2db98c2f","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        include ::ntp"},{"line_number":49,"context_line":"      }"},{"line_number":50,"context_line":"    }"},{"line_number":51,"context_line":"  }"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"If users have followed all the previous steps, they should be able to configure"},{"line_number":54,"context_line":"their services using the composable services within roles guidelines."}],"source_content_type":"text/x-rst","patch_set":36,"id":"1aa78d24_6d6ae7ef","line":51,"updated":"2016-07-06 08:11:19.000000000","message":"just pointing out it may be confusing if someone were to go looking for tripleo::profile::base::time::ntp since it doesn\u0027t exist (we previously had a note about the way this ultimately landed)","commit_id":"16263bd480f4e0cf1bdcd5f01ee5bae3fe0b7d7a"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"fece84f9405510cfd039df8463d1cc7229b10a58","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        include ::ntp"},{"line_number":49,"context_line":"      }"},{"line_number":50,"context_line":"    }"},{"line_number":51,"context_line":"  }"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"If users have followed all the previous steps, they should be able to configure"},{"line_number":54,"context_line":"their services using the composable services within roles guidelines."}],"source_content_type":"text/x-rst","patch_set":36,"id":"1aa78d24_963e3b8a","line":51,"in_reply_to":"1aa78d24_6d6ae7ef","updated":"2016-07-06 10:18:51.000000000","message":"I think the note is not needed as we have the code of ntp.pp there.","commit_id":"16263bd480f4e0cf1bdcd5f01ee5bae3fe0b7d7a"}],"doc/source/tht_walkthrough/changes-tht.rst":[{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"9add14ac033791cbd8a669ef0d8fc2221cab6b27","unresolved":false,"context_lines":[{"line_number":70,"context_line":"Step 2 - overcloud-resource-registry-puppet.yaml resource registry changes"},{"line_number":71,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"The resource OS::TripleO::Services::Ntp must be defined in the resource"},{"line_number":74,"context_line":"registry (``overcloud-resource-registry-puppet.yaml``)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Create a new resource to configure your service using the folder naming convention."}],"source_content_type":"text/x-rst","patch_set":14,"id":"bab6814e_ab3a3096","line":73,"range":{"start_line":73,"start_character":13,"end_line":73,"end_character":39},"updated":"2016-05-19 14:43:59.000000000","message":"maybe inside ``?","commit_id":"e4699afb7e2d712bea65ecb94630d0b259a2cd05"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"befe57fabf23623e47d5e2f4f8f11401580e26d6","unresolved":false,"context_lines":[{"line_number":70,"context_line":"Step 2 - overcloud-resource-registry-puppet.yaml resource registry changes"},{"line_number":71,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"The resource OS::TripleO::Services::Ntp must be defined in the resource"},{"line_number":74,"context_line":"registry (``overcloud-resource-registry-puppet.yaml``)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Create a new resource to configure your service using the folder naming convention."}],"source_content_type":"text/x-rst","patch_set":14,"id":"bab6814e_cbde7b6c","line":73,"range":{"start_line":73,"start_character":13,"end_line":73,"end_character":39},"in_reply_to":"bab6814e_ab3a3096","updated":"2016-05-19 19:38:21.000000000","message":"Done","commit_id":"e4699afb7e2d712bea65ecb94630d0b259a2cd05"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"9add14ac033791cbd8a669ef0d8fc2221cab6b27","unresolved":false,"context_lines":[{"line_number":125,"context_line":"      MysqlVirtualIPUri: {get_attr: [VipMap, net_ip_uri_map, {get_param: [ServiceNetMap, MysqlNetwork]}]}"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"Note"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Is available the support for controller services, new Heat features must be defined in"},{"line_number":131,"context_line":"order to apply the same behaviour to other roles (compute, storage), current work defined"}],"source_content_type":"text/x-rst","patch_set":14,"id":"bab6814e_2bc0007c","line":128,"range":{"start_line":128,"start_character":0,"end_line":128,"end_character":4},"updated":"2016-05-19 14:43:59.000000000","message":".. note::","commit_id":"e4699afb7e2d712bea65ecb94630d0b259a2cd05"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"befe57fabf23623e47d5e2f4f8f11401580e26d6","unresolved":false,"context_lines":[{"line_number":125,"context_line":"      MysqlVirtualIPUri: {get_attr: [VipMap, net_ip_uri_map, {get_param: [ServiceNetMap, MysqlNetwork]}]}"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"Note"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Is available the support for controller services, new Heat features must be defined in"},{"line_number":131,"context_line":"order to apply the same behaviour to other roles (compute, storage), current work defined"}],"source_content_type":"text/x-rst","patch_set":14,"id":"bab6814e_6bce6fb5","line":128,"range":{"start_line":128,"start_character":0,"end_line":128,"end_character":4},"in_reply_to":"bab6814e_2bc0007c","updated":"2016-05-19 19:38:21.000000000","message":"Done","commit_id":"e4699afb7e2d712bea65ecb94630d0b259a2cd05"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"9add14ac033791cbd8a669ef0d8fc2221cab6b27","unresolved":false,"context_lines":[{"line_number":135,"context_line":"Step 4 - Create the services yaml files"},{"line_number":136,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Create: puppet/services/time/ntp-base.yaml"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"This file will have all the configuration details for the service to be configured."},{"line_number":141,"context_line":"::"}],"source_content_type":"text/x-rst","patch_set":14,"id":"bab6814e_4b6e2430","line":138,"range":{"start_line":138,"start_character":8,"end_line":138,"end_character":42},"updated":"2016-05-19 14:43:59.000000000","message":"same: maybe inside ``?","commit_id":"e4699afb7e2d712bea65ecb94630d0b259a2cd05"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"befe57fabf23623e47d5e2f4f8f11401580e26d6","unresolved":false,"context_lines":[{"line_number":135,"context_line":"Step 4 - Create the services yaml files"},{"line_number":136,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Create: puppet/services/time/ntp-base.yaml"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"This file will have all the configuration details for the service to be configured."},{"line_number":141,"context_line":"::"}],"source_content_type":"text/x-rst","patch_set":14,"id":"bab6814e_cb4cbb44","line":138,"range":{"start_line":138,"start_character":8,"end_line":138,"end_character":42},"in_reply_to":"bab6814e_4b6e2430","updated":"2016-05-19 19:38:21.000000000","message":"Done","commit_id":"e4699afb7e2d712bea65ecb94630d0b259a2cd05"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"9add14ac033791cbd8a669ef0d8fc2221cab6b27","unresolved":false,"context_lines":[{"line_number":175,"context_line":"          tripleo::services::time::ntp::ntpinterfaces: {get_param: NtpInterfaces}"},{"line_number":176,"context_line":"          tripleo::services::time::ntp::ntppackagemanaged: {get_param: NtpPackageManaged}"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"Create: puppet/services/time/ntp.yaml"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"This file will link all the configuration parameters and call the PT manifest to configure the"},{"line_number":181,"context_line":"service."}],"source_content_type":"text/x-rst","patch_set":14,"id":"bab6814e_beec2590","line":178,"range":{"start_line":178,"start_character":8,"end_line":178,"end_character":37},"updated":"2016-05-19 14:43:59.000000000","message":"same here","commit_id":"e4699afb7e2d712bea65ecb94630d0b259a2cd05"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"befe57fabf23623e47d5e2f4f8f11401580e26d6","unresolved":false,"context_lines":[{"line_number":175,"context_line":"          tripleo::services::time::ntp::ntpinterfaces: {get_param: NtpInterfaces}"},{"line_number":176,"context_line":"          tripleo::services::time::ntp::ntppackagemanaged: {get_param: NtpPackageManaged}"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"Create: puppet/services/time/ntp.yaml"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"This file will link all the configuration parameters and call the PT manifest to configure the"},{"line_number":181,"context_line":"service."}],"source_content_type":"text/x-rst","patch_set":14,"id":"bab6814e_ab47b71b","line":178,"range":{"start_line":178,"start_character":8,"end_line":178,"end_character":37},"in_reply_to":"bab6814e_beec2590","updated":"2016-05-19 19:38:21.000000000","message":"Done","commit_id":"e4699afb7e2d712bea65ecb94630d0b259a2cd05"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"9add14ac033791cbd8a669ef0d8fc2221cab6b27","unresolved":false,"context_lines":[{"line_number":177,"context_line":""},{"line_number":178,"context_line":"Create: puppet/services/time/ntp.yaml"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"This file will link all the configuration parameters and call the PT manifest to configure the"},{"line_number":181,"context_line":"service."},{"line_number":182,"context_line":"::"},{"line_number":183,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"bab6814e_eb9c385f","line":180,"range":{"start_line":180,"start_character":66,"end_line":180,"end_character":68},"updated":"2016-05-19 14:43:59.000000000","message":"NTP?","commit_id":"e4699afb7e2d712bea65ecb94630d0b259a2cd05"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"befe57fabf23623e47d5e2f4f8f11401580e26d6","unresolved":false,"context_lines":[{"line_number":177,"context_line":""},{"line_number":178,"context_line":"Create: puppet/services/time/ntp.yaml"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"This file will link all the configuration parameters and call the PT manifest to configure the"},{"line_number":181,"context_line":"service."},{"line_number":182,"context_line":"::"},{"line_number":183,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"bab6814e_abc69746","line":180,"range":{"start_line":180,"start_character":66,"end_line":180,"end_character":68},"in_reply_to":"bab6814e_eb9c385f","updated":"2016-05-19 19:38:21.000000000","message":"Done","commit_id":"e4699afb7e2d712bea65ecb94630d0b259a2cd05"},{"author":{"_account_id":7294,"name":"Leif Madsen","email":"lmadsen@redhat.com","username":"leifmadsen"},"change_message_id":"93499d7a310545bdd28658c6ebb32fe225edaaa4","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":".. note::"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  No templates or puppet manifests must be defined in this repository,"},{"line_number":21,"context_line":"  they should go to the puppet-tripleo repository instead."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_1dd44645","line":20,"range":{"start_line":20,"start_character":35,"end_line":20,"end_character":39},"updated":"2016-05-19 20:12:18.000000000","message":"may","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"82918dc7a313357cdfb9b4009b81ecf2ee61d3c6","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":".. note::"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  No templates or puppet manifests must be defined in this repository,"},{"line_number":21,"context_line":"  they should go to the puppet-tripleo repository instead."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_92280a88","line":20,"range":{"start_line":20,"start_character":35,"end_line":20,"end_character":39},"in_reply_to":"bab6814e_1dd44645","updated":"2016-05-20 08:32:58.000000000","message":"Done","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":7294,"name":"Leif Madsen","email":"lmadsen@redhat.com","username":"leifmadsen"},"change_message_id":"93499d7a310545bdd28658c6ebb32fe225edaaa4","unresolved":false,"context_lines":[{"line_number":23,"context_line":".. note::"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  The use of the \u003cservice\u003e-base.yaml file depends if the tripleo-heat-templates service"},{"line_number":26,"context_line":"  is applied using different environments, for example,"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Changes list"},{"line_number":29,"context_line":"~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_3d382aa0","line":26,"range":{"start_line":26,"start_character":47,"end_line":26,"end_character":54},"updated":"2016-05-19 20:12:18.000000000","message":"Missing example?","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"82918dc7a313357cdfb9b4009b81ecf2ee61d3c6","unresolved":false,"context_lines":[{"line_number":23,"context_line":".. note::"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  The use of the \u003cservice\u003e-base.yaml file depends if the tripleo-heat-templates service"},{"line_number":26,"context_line":"  is applied using different environments, for example,"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Changes list"},{"line_number":29,"context_line":"~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_722da694","line":26,"range":{"start_line":26,"start_character":47,"end_line":26,"end_character":54},"in_reply_to":"bab6814e_3d382aa0","updated":"2016-05-20 08:32:58.000000000","message":"Done","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":7294,"name":"Leif Madsen","email":"lmadsen@redhat.com","username":"leifmadsen"},"change_message_id":"93499d7a310545bdd28658c6ebb32fe225edaaa4","unresolved":false,"context_lines":[{"line_number":48,"context_line":"Remove all puppet references for the composable service"},{"line_number":49,"context_line":"from the current manifests (*.pp)."},{"line_number":50,"context_line":"All the puppet logic will live in the puppet-tripleo repository"},{"line_number":51,"context_line":"based on a configuration step, so forth is mandatory"},{"line_number":52,"context_line":"to remove all the puppet references from tripleo-heat-templates."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"The updated .pp files for the NTP example were:"}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_3d066ace","line":51,"range":{"start_line":51,"start_character":34,"end_line":51,"end_character":39},"updated":"2016-05-19 20:12:18.000000000","message":"s/forth/it/ ?  this read weird...","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"82918dc7a313357cdfb9b4009b81ecf2ee61d3c6","unresolved":false,"context_lines":[{"line_number":48,"context_line":"Remove all puppet references for the composable service"},{"line_number":49,"context_line":"from the current manifests (*.pp)."},{"line_number":50,"context_line":"All the puppet logic will live in the puppet-tripleo repository"},{"line_number":51,"context_line":"based on a configuration step, so forth is mandatory"},{"line_number":52,"context_line":"to remove all the puppet references from tripleo-heat-templates."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"The updated .pp files for the NTP example were:"}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_32303ee8","line":51,"range":{"start_line":51,"start_character":34,"end_line":51,"end_character":39},"in_reply_to":"bab6814e_3d066ace","updated":"2016-05-20 08:32:58.000000000","message":"Done","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":7294,"name":"Leif Madsen","email":"lmadsen@redhat.com","username":"leifmadsen"},"change_message_id":"93499d7a310545bdd28658c6ebb32fe225edaaa4","unresolved":false,"context_lines":[{"line_number":125,"context_line":"      MysqlVirtualIPUri: {get_attr: [VipMap, net_ip_uri_map, {get_param: [ServiceNetMap, MysqlNetwork]}]}"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"..Note::"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Is available the support for controller services, new Heat features must be defined in"},{"line_number":131,"context_line":"order to apply the same behaviour to other roles (compute, storage), current work defined"}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_1d644647","line":128,"range":{"start_line":128,"start_character":0,"end_line":128,"end_character":8},"updated":"2016-05-19 20:12:18.000000000","message":".. note::\n\nfor consistency","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"82918dc7a313357cdfb9b4009b81ecf2ee61d3c6","unresolved":false,"context_lines":[{"line_number":125,"context_line":"      MysqlVirtualIPUri: {get_attr: [VipMap, net_ip_uri_map, {get_param: [ServiceNetMap, MysqlNetwork]}]}"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"..Note::"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Is available the support for controller services, new Heat features must be defined in"},{"line_number":131,"context_line":"order to apply the same behaviour to other roles (compute, storage), current work defined"}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_d26c52d2","line":128,"range":{"start_line":128,"start_character":0,"end_line":128,"end_character":8},"in_reply_to":"bab6814e_1d644647","updated":"2016-05-20 08:32:58.000000000","message":"Done","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":7294,"name":"Leif Madsen","email":"lmadsen@redhat.com","username":"leifmadsen"},"change_message_id":"93499d7a310545bdd28658c6ebb32fe225edaaa4","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"..Note::"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Is available the support for controller services, new Heat features must be defined in"},{"line_number":131,"context_line":"order to apply the same behaviour to other roles (compute, storage), current work defined"},{"line_number":132,"context_line":"in: https://etherpad.openstack.org/p/tripleo-composable-services"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_ddf8fe4b","line":130,"range":{"start_line":130,"start_character":0,"end_line":130,"end_character":2},"updated":"2016-05-19 20:12:18.000000000","message":"what is available? Sentence needs refinement.","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"82918dc7a313357cdfb9b4009b81ecf2ee61d3c6","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"..Note::"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Is available the support for controller services, new Heat features must be defined in"},{"line_number":131,"context_line":"order to apply the same behaviour to other roles (compute, storage), current work defined"},{"line_number":132,"context_line":"in: https://etherpad.openstack.org/p/tripleo-composable-services"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_b2442e1b","line":130,"range":{"start_line":130,"start_character":0,"end_line":130,"end_character":2},"in_reply_to":"bab6814e_ddf8fe4b","updated":"2016-05-20 08:32:58.000000000","message":"Done","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":7294,"name":"Leif Madsen","email":"lmadsen@redhat.com","username":"leifmadsen"},"change_message_id":"93499d7a310545bdd28658c6ebb32fe225edaaa4","unresolved":false,"context_lines":[{"line_number":128,"context_line":"..Note::"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Is available the support for controller services, new Heat features must be defined in"},{"line_number":131,"context_line":"order to apply the same behaviour to other roles (compute, storage), current work defined"},{"line_number":132,"context_line":"in: https://etherpad.openstack.org/p/tripleo-composable-services"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_1dc0c6df","line":131,"range":{"start_line":131,"start_character":66,"end_line":131,"end_character":68},"updated":"2016-05-19 20:12:18.000000000","message":"Probably full stop here (.)","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"82918dc7a313357cdfb9b4009b81ecf2ee61d3c6","unresolved":false,"context_lines":[{"line_number":128,"context_line":"..Note::"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Is available the support for controller services, new Heat features must be defined in"},{"line_number":131,"context_line":"order to apply the same behaviour to other roles (compute, storage), current work defined"},{"line_number":132,"context_line":"in: https://etherpad.openstack.org/p/tripleo-composable-services"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_92600aa7","line":131,"range":{"start_line":131,"start_character":66,"end_line":131,"end_character":68},"in_reply_to":"bab6814e_1dc0c6df","updated":"2016-05-20 08:32:58.000000000","message":"Done","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b3769cb2fa7e3b3fe99942115c0b3f25877183ad","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":".. note::"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"  No templates or puppet manifests may be defined in this repository, they"},{"line_number":22,"context_line":"  should go to the puppet-tripleo repository instead."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":19,"id":"bab6814e_8c13cdb7","line":21,"updated":"2016-05-26 08:25:50.000000000","message":"I guess you meant \u0027no puppet\u0027 so either remove \u0027templates\u0027 or move the word puppet first (No puppet templates or manifests) ... cos the tht otherwise is all about templates ;)","commit_id":"450e2fbb2c050339fceda5e76b74ec46f52ecd0f"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"71b7b21687bea364480b009af0c0c75bcf7eeaed","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":".. note::"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"  No templates or puppet manifests may be defined in this repository, they"},{"line_number":22,"context_line":"  should go to the puppet-tripleo repository instead."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":19,"id":"bab6814e_c7b12e03","line":21,"in_reply_to":"bab6814e_8c13cdb7","updated":"2016-05-26 08:48:07.000000000","message":"You are right, \"templates\" is gone.\nDone","commit_id":"450e2fbb2c050339fceda5e76b74ec46f52ecd0f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b3769cb2fa7e3b3fe99942115c0b3f25877183ad","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":".. note::"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"  The use of the \u003cservice\u003e-base.yaml file depends if the tripleo-heat-templates"},{"line_number":27,"context_line":"  service is applied using different environments, for example, check"},{"line_number":28,"context_line":"  :ref:`duplicated-parameters`."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"bab6814e_ecf6d98d","line":26,"updated":"2016-05-26 08:25:50.000000000","message":"I\u0027d try reword this slightly as it may not be clear what is meant here wrt environments. You could point to something like https://review.openstack.org/#/c/313577/ as an example, which uses a base class for the heat\u003c--\u003erabbit config. I\u0027d say more like, the use of a base class is necessary in cases where a given \u0027service\u0027 (e.g. \"heat\") is comprised of a number of individual component services (e.g. heat-api, heat-engine) which need to share some of the base configuration (such as rabbit credentials). \n\nUsing a base class in those cases means we don\u0027t need to duplicate that configuration.","commit_id":"450e2fbb2c050339fceda5e76b74ec46f52ecd0f"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"71b7b21687bea364480b009af0c0c75bcf7eeaed","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":".. note::"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"  The use of the \u003cservice\u003e-base.yaml file depends if the tripleo-heat-templates"},{"line_number":27,"context_line":"  service is applied using different environments, for example, check"},{"line_number":28,"context_line":"  :ref:`duplicated-parameters`."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"bab6814e_671842d4","line":26,"in_reply_to":"bab6814e_ecf6d98d","updated":"2016-05-26 08:48:07.000000000","message":"Done","commit_id":"450e2fbb2c050339fceda5e76b74ec46f52ecd0f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"33a06dcb16e63ddca9cd6c92ac54cfdd8761b574","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"The list of changes in THT are:"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- If existing puppet modules for the added feature are present in"},{"line_number":41,"context_line":"  tripleo-heat-templates, remove them, as they will be reintroduced in"},{"line_number":42,"context_line":"  puppet-tripleo."},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":24,"id":"7aa08908_3b8fce76","line":40,"updated":"2016-06-16 07:39:06.000000000","message":"If there is any configuration of the given feature/service in any of the tripleo-heat-templates puppet/manifests/*.pp then this will need to be removed and migrated to  puppet-tripleo","commit_id":"cf7cfe935aafa436566c056976925db56f690d4c"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"ec62bad7c5a65fa184fb765f55d4ca695c5f2032","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"The list of changes in THT are:"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- If existing puppet modules for the added feature are present in"},{"line_number":41,"context_line":"  tripleo-heat-templates, remove them, as they will be reintroduced in"},{"line_number":42,"context_line":"  puppet-tripleo."},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":24,"id":"7aa08908_4c62dbda","line":40,"in_reply_to":"7aa08908_3b8fce76","updated":"2016-06-16 10:14:52.000000000","message":"Done","commit_id":"cf7cfe935aafa436566c056976925db56f690d4c"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"7cdc6dc35a96b4d5e42405093eabce1f88df057a","unresolved":false,"context_lines":[{"line_number":102,"context_line":"Step 3 - overcloud.yaml initial changes"},{"line_number":103,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"It is mandatory to link our new feature to the ControllerServices parameter,"},{"line_number":106,"context_line":"which defines all the services enabled by default in the controller(s)."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"From ``overcloud.yaml`` in the parameters section find:"},{"line_number":109,"context_line":"::"}],"source_content_type":"text/x-rst","patch_set":24,"id":"7aa08908_693d3e2c","line":106,"range":{"start_line":105,"start_character":0,"end_line":106,"end_character":71},"updated":"2016-06-15 11:19:20.000000000","message":"It\u0027s not mandatory really. Services such as Sahara are optional and don\u0027t go in this list.","commit_id":"cf7cfe935aafa436566c056976925db56f690d4c"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"ec62bad7c5a65fa184fb765f55d4ca695c5f2032","unresolved":false,"context_lines":[{"line_number":102,"context_line":"Step 3 - overcloud.yaml initial changes"},{"line_number":103,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"It is mandatory to link our new feature to the ControllerServices parameter,"},{"line_number":106,"context_line":"which defines all the services enabled by default in the controller(s)."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"From ``overcloud.yaml`` in the parameters section find:"},{"line_number":109,"context_line":"::"}],"source_content_type":"text/x-rst","patch_set":24,"id":"7aa08908_2cf2ef06","line":106,"range":{"start_line":105,"start_character":0,"end_line":106,"end_character":71},"in_reply_to":"7aa08908_693d3e2c","updated":"2016-06-16 10:14:52.000000000","message":"Done","commit_id":"cf7cfe935aafa436566c056976925db56f690d4c"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"33ec92efef09d26d5269b0f9296009ad25938c24","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":".. note::"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"  Only for the controller role is available the deployment of services using"},{"line_number":140,"context_line":"  the composable services approach, new Heat features must be defined in order"},{"line_number":141,"context_line":"  to apply the same behaviour to other roles (compute, storage). Current work"},{"line_number":142,"context_line":"  defined in: https://etherpad.openstack.org/p/tripleo-composable-services"}],"source_content_type":"text/x-rst","patch_set":24,"id":"7aa08908_3229cf38","line":139,"range":{"start_line":139,"start_character":2,"end_line":139,"end_character":6},"updated":"2016-06-15 15:58:51.000000000","message":"The grammar looks a bit weird to me (although i\u0027m not native english speaker). What about something like:\nThe deployment of services using that composable services approach is only available for the controller role. To apply the same behaviour to other roles (compute, storage...), new Heat features must be defined.","commit_id":"cf7cfe935aafa436566c056976925db56f690d4c"},{"author":{"_account_id":7294,"name":"Leif Madsen","email":"lmadsen@redhat.com","username":"leifmadsen"},"change_message_id":"4a1e868e9ba3d33dbafc375f33bc4f44bd44ceee","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":".. note::"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"  Only for the controller role is available the deployment of services using"},{"line_number":140,"context_line":"  the composable services approach, new Heat features must be defined in order"},{"line_number":141,"context_line":"  to apply the same behaviour to other roles (compute, storage). Current work"},{"line_number":142,"context_line":"  defined in: https://etherpad.openstack.org/p/tripleo-composable-services"}],"source_content_type":"text/x-rst","patch_set":24,"id":"7aa08908_b5f3e69e","line":139,"range":{"start_line":139,"start_character":2,"end_line":139,"end_character":6},"in_reply_to":"7aa08908_3229cf38","updated":"2016-06-15 17:09:31.000000000","message":"\"The deployment of services using the...\" s/that/the/\n\nOtherwise, +1 on this change.","commit_id":"cf7cfe935aafa436566c056976925db56f690d4c"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"ec62bad7c5a65fa184fb765f55d4ca695c5f2032","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":".. note::"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"  Only for the controller role is available the deployment of services using"},{"line_number":140,"context_line":"  the composable services approach, new Heat features must be defined in order"},{"line_number":141,"context_line":"  to apply the same behaviour to other roles (compute, storage). Current work"},{"line_number":142,"context_line":"  defined in: https://etherpad.openstack.org/p/tripleo-composable-services"}],"source_content_type":"text/x-rst","patch_set":24,"id":"7aa08908_2caaef85","line":139,"range":{"start_line":139,"start_character":2,"end_line":139,"end_character":6},"in_reply_to":"7aa08908_3229cf38","updated":"2016-06-16 10:14:52.000000000","message":"Done","commit_id":"cf7cfe935aafa436566c056976925db56f690d4c"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"ec62bad7c5a65fa184fb765f55d4ca695c5f2032","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":".. note::"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"  Only for the controller role is available the deployment of services using"},{"line_number":140,"context_line":"  the composable services approach, new Heat features must be defined in order"},{"line_number":141,"context_line":"  to apply the same behaviour to other roles (compute, storage). Current work"},{"line_number":142,"context_line":"  defined in: https://etherpad.openstack.org/p/tripleo-composable-services"}],"source_content_type":"text/x-rst","patch_set":24,"id":"7aa08908_0cad739b","line":139,"range":{"start_line":139,"start_character":2,"end_line":139,"end_character":6},"in_reply_to":"7aa08908_b5f3e69e","updated":"2016-06-16 10:14:52.000000000","message":"Done","commit_id":"cf7cfe935aafa436566c056976925db56f690d4c"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"7cdc6dc35a96b4d5e42405093eabce1f88df057a","unresolved":false,"context_lines":[{"line_number":140,"context_line":"  the composable services approach, new Heat features must be defined in order"},{"line_number":141,"context_line":"  to apply the same behaviour to other roles (compute, storage). Current work"},{"line_number":142,"context_line":"  defined in: https://etherpad.openstack.org/p/tripleo-composable-services"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Step 4 - Create the services yaml files"},{"line_number":146,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":24,"id":"7aa08908_e9764e0b","line":143,"updated":"2016-06-15 11:19:20.000000000","message":"Somewhere here we need to specify that if we want to enable optional services, we need to provide the whole default list of ControllerServiceChain items with the extra services added to that list.","commit_id":"cf7cfe935aafa436566c056976925db56f690d4c"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"ec62bad7c5a65fa184fb765f55d4ca695c5f2032","unresolved":false,"context_lines":[{"line_number":140,"context_line":"  the composable services approach, new Heat features must be defined in order"},{"line_number":141,"context_line":"  to apply the same behaviour to other roles (compute, storage). Current work"},{"line_number":142,"context_line":"  defined in: https://etherpad.openstack.org/p/tripleo-composable-services"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Step 4 - Create the services yaml files"},{"line_number":146,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":24,"id":"7aa08908_8c520334","line":143,"in_reply_to":"7aa08908_e9764e0b","updated":"2016-06-16 10:14:52.000000000","message":"Done","commit_id":"cf7cfe935aafa436566c056976925db56f690d4c"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"33a06dcb16e63ddca9cd6c92ac54cfdd8761b574","unresolved":false,"context_lines":[{"line_number":189,"context_line":""},{"line_number":190,"context_line":"  If it is needed, the templates can be decomposed to remove"},{"line_number":191,"context_line":"  duplicated parameters among different deployment environments"},{"line_number":192,"context_line":"  (i.e. using pacemaker). To do this follow to the"},{"line_number":193,"context_line":"  section :ref:`duplicated-parameters`."}],"source_content_type":"text/x-rst","patch_set":24,"id":"7aa08908_1b5132d9","line":192,"updated":"2016-06-16 07:39:06.000000000","message":"s/to the/the  or just \u0027see section\u0027","commit_id":"cf7cfe935aafa436566c056976925db56f690d4c"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"ec62bad7c5a65fa184fb765f55d4ca695c5f2032","unresolved":false,"context_lines":[{"line_number":189,"context_line":""},{"line_number":190,"context_line":"  If it is needed, the templates can be decomposed to remove"},{"line_number":191,"context_line":"  duplicated parameters among different deployment environments"},{"line_number":192,"context_line":"  (i.e. using pacemaker). To do this follow to the"},{"line_number":193,"context_line":"  section :ref:`duplicated-parameters`."}],"source_content_type":"text/x-rst","patch_set":24,"id":"7aa08908_6c0b572c","line":192,"in_reply_to":"7aa08908_1b5132d9","updated":"2016-06-16 10:14:52.000000000","message":"Done","commit_id":"cf7cfe935aafa436566c056976925db56f690d4c"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"c9a4e8c9a560538fc58fdb281c629a70e0f97f9e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  puppet"},{"line_number":14,"context_line":"    services          ---\u003e To host all services."},{"line_number":15,"context_line":"      \u003cservice type\u003e             ---\u003e Folder to store a specific type services (If time, will store time based services like: NTP, timezone, Chrony among others)."},{"line_number":16,"context_line":"        \u003cservice name\u003e.yaml      ---\u003e Main service manifest."},{"line_number":17,"context_line":"        \u003cservice name\u003e-base.yaml ---\u003e Main service configuration file."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_66f024fe","line":16,"range":{"start_line":16,"start_character":38,"end_line":16,"end_character":42},"updated":"2016-06-30 10:10:39.000000000","message":"This is a bit confusing due to the use of the word \"manifest\" here - I\u0027d say \"Heat template defining per-service configuration\"","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"8bd8802106afad25b4dcda5cebf8c9cdb3d9dc8a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  puppet"},{"line_number":14,"context_line":"    services          ---\u003e To host all services."},{"line_number":15,"context_line":"      \u003cservice type\u003e             ---\u003e Folder to store a specific type services (If time, will store time based services like: NTP, timezone, Chrony among others)."},{"line_number":16,"context_line":"        \u003cservice name\u003e.yaml      ---\u003e Main service manifest."},{"line_number":17,"context_line":"        \u003cservice name\u003e-base.yaml ---\u003e Main service configuration file."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_a01aa27a","line":16,"range":{"start_line":16,"start_character":38,"end_line":16,"end_character":42},"in_reply_to":"3aaa91ec_66f024fe","updated":"2016-07-01 16:09:27.000000000","message":"Done","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"c9a4e8c9a560538fc58fdb281c629a70e0f97f9e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    services          ---\u003e To host all services."},{"line_number":15,"context_line":"      \u003cservice type\u003e             ---\u003e Folder to store a specific type services (If time, will store time based services like: NTP, timezone, Chrony among others)."},{"line_number":16,"context_line":"        \u003cservice name\u003e.yaml      ---\u003e Main service manifest."},{"line_number":17,"context_line":"        \u003cservice name\u003e-base.yaml ---\u003e Main service configuration file."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":".. note::"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_c64f5832","line":17,"range":{"start_line":17,"start_character":51,"end_line":17,"end_character":64},"updated":"2016-06-30 10:10:39.000000000","message":"Again, this isn\u0027t strictly accurate, I\u0027d say \"Heat template defining common service configuration\"","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"8bd8802106afad25b4dcda5cebf8c9cdb3d9dc8a","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    services          ---\u003e To host all services."},{"line_number":15,"context_line":"      \u003cservice type\u003e             ---\u003e Folder to store a specific type services (If time, will store time based services like: NTP, timezone, Chrony among others)."},{"line_number":16,"context_line":"        \u003cservice name\u003e.yaml      ---\u003e Main service manifest."},{"line_number":17,"context_line":"        \u003cservice name\u003e-base.yaml ---\u003e Main service configuration file."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":".. note::"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_0010d658","line":17,"range":{"start_line":17,"start_character":51,"end_line":17,"end_character":64},"in_reply_to":"3aaa91ec_c64f5832","updated":"2016-07-01 16:09:27.000000000","message":"Done","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"c9a4e8c9a560538fc58fdb281c629a70e0f97f9e","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":".. note::"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"  The use of a base class (\u003cservice\u003e-base.yaml) is necessary in cases where"},{"line_number":27,"context_line":"  a given \u0027service\u0027 (e.g. \"heat\") is comprised of a number of individual"},{"line_number":28,"context_line":"  component services (e.g. heat-api, heat-engine) which need to share some"},{"line_number":29,"context_line":"  of the base configuration (such as rabbit credentials)."}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_e669b48d","line":26,"range":{"start_line":26,"start_character":20,"end_line":26,"end_character":25},"updated":"2016-06-30 10:10:39.000000000","message":"It\u0027s not a class, it\u0027s a \"base heat template\"","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"8bd8802106afad25b4dcda5cebf8c9cdb3d9dc8a","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":".. note::"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"  The use of a base class (\u003cservice\u003e-base.yaml) is necessary in cases where"},{"line_number":27,"context_line":"  a given \u0027service\u0027 (e.g. \"heat\") is comprised of a number of individual"},{"line_number":28,"context_line":"  component services (e.g. heat-api, heat-engine) which need to share some"},{"line_number":29,"context_line":"  of the base configuration (such as rabbit credentials)."}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_fb1d7b63","line":26,"range":{"start_line":26,"start_character":20,"end_line":26,"end_character":25},"in_reply_to":"3aaa91ec_e669b48d","updated":"2016-07-01 16:09:27.000000000","message":"Done","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"c9a4e8c9a560538fc58fdb281c629a70e0f97f9e","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  a given \u0027service\u0027 (e.g. \"heat\") is comprised of a number of individual"},{"line_number":28,"context_line":"  component services (e.g. heat-api, heat-engine) which need to share some"},{"line_number":29,"context_line":"  of the base configuration (such as rabbit credentials)."},{"line_number":30,"context_line":"  Using a base class in those cases means we don\u0027t need to"},{"line_number":31,"context_line":"  duplicate that configuration."},{"line_number":32,"context_line":"  Refer to: https://review.openstack.org/#/c/313577/ for further details."},{"line_number":33,"context_line":"  Also, refer to :ref:`duplicated-parameters` for an use-case description."}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_26061cce","line":30,"range":{"start_line":30,"start_character":15,"end_line":30,"end_character":20},"updated":"2016-06-30 10:10:39.000000000","message":"s/base class/base template/","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"8bd8802106afad25b4dcda5cebf8c9cdb3d9dc8a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  a given \u0027service\u0027 (e.g. \"heat\") is comprised of a number of individual"},{"line_number":28,"context_line":"  component services (e.g. heat-api, heat-engine) which need to share some"},{"line_number":29,"context_line":"  of the base configuration (such as rabbit credentials)."},{"line_number":30,"context_line":"  Using a base class in those cases means we don\u0027t need to"},{"line_number":31,"context_line":"  duplicate that configuration."},{"line_number":32,"context_line":"  Refer to: https://review.openstack.org/#/c/313577/ for further details."},{"line_number":33,"context_line":"  Also, refer to :ref:`duplicated-parameters` for an use-case description."}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_5b2f6f88","line":30,"range":{"start_line":30,"start_character":15,"end_line":30,"end_character":20},"in_reply_to":"3aaa91ec_26061cce","updated":"2016-07-01 16:09:27.000000000","message":"Done","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"c9a4e8c9a560538fc58fdb281c629a70e0f97f9e","unresolved":false,"context_lines":[{"line_number":45,"context_line":"- Create a service type specific folder in the root services folder"},{"line_number":46,"context_line":"  (``puppet/services/time``)."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"- Create a main service file inside the puppet/services folder"},{"line_number":49,"context_line":"  (``puppet/services/time/ntp.yaml``)."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- Create a main configuration file linked to the main service file in the same"}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_26d45c1e","line":48,"range":{"start_line":48,"start_character":24,"end_line":48,"end_character":28},"updated":"2016-06-30 10:10:39.000000000","message":"s/main service file/heat template for the service/","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"8bd8802106afad25b4dcda5cebf8c9cdb3d9dc8a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"- Create a service type specific folder in the root services folder"},{"line_number":46,"context_line":"  (``puppet/services/time``)."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"- Create a main service file inside the puppet/services folder"},{"line_number":49,"context_line":"  (``puppet/services/time/ntp.yaml``)."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- Create a main configuration file linked to the main service file in the same"}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_1b91679b","line":48,"range":{"start_line":48,"start_character":24,"end_line":48,"end_character":28},"in_reply_to":"3aaa91ec_26d45c1e","updated":"2016-07-01 16:09:27.000000000","message":"Done","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"c9a4e8c9a560538fc58fdb281c629a70e0f97f9e","unresolved":false,"context_lines":[{"line_number":48,"context_line":"- Create a main service file inside the puppet/services folder"},{"line_number":49,"context_line":"  (``puppet/services/time/ntp.yaml``)."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- Create a main configuration file linked to the main service file in the same"},{"line_number":52,"context_line":"  folder (``puppet/services/time/ntp-base.yaml``)."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Step 1 - Updating puppet references"}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_46b6c8f9","line":51,"range":{"start_line":51,"start_character":16,"end_line":51,"end_character":29},"updated":"2016-06-30 10:10:39.000000000","message":"\"Optionally, create a common heat template to reuse common configuration data, which is referenced from each per-service heat template\"","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"8bd8802106afad25b4dcda5cebf8c9cdb3d9dc8a","unresolved":false,"context_lines":[{"line_number":48,"context_line":"- Create a main service file inside the puppet/services folder"},{"line_number":49,"context_line":"  (``puppet/services/time/ntp.yaml``)."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- Create a main configuration file linked to the main service file in the same"},{"line_number":52,"context_line":"  folder (``puppet/services/time/ntp-base.yaml``)."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Step 1 - Updating puppet references"}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_7be50b37","line":51,"range":{"start_line":51,"start_character":16,"end_line":51,"end_character":29},"in_reply_to":"3aaa91ec_46b6c8f9","updated":"2016-07-01 16:09:27.000000000","message":"Done","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"c9a4e8c9a560538fc58fdb281c629a70e0f97f9e","unresolved":false,"context_lines":[{"line_number":57,"context_line":"Remove all puppet references for the composable service from the current"},{"line_number":58,"context_line":"manifests (*.pp). All the puppet logic will live in the puppet-tripleo"},{"line_number":59,"context_line":"repository based on a configuration step, so it is mandatory to remove all the"},{"line_number":60,"context_line":"puppet references from tripleo-heat-templates."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"The updated .pp files for the NTP example were:"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_2689fc26","line":60,"range":{"start_line":60,"start_character":36,"end_line":60,"end_character":45},"updated":"2016-06-30 10:10:39.000000000","message":"This is fine, but I think we\u0027ll want to remove this commentary of the current refactoring work when it\u0027s completed, and explain things more in terms of how to integrate a new service (e.g the supported interfaces, vs the steps to refactor)","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"8bd8802106afad25b4dcda5cebf8c9cdb3d9dc8a","unresolved":false,"context_lines":[{"line_number":57,"context_line":"Remove all puppet references for the composable service from the current"},{"line_number":58,"context_line":"manifests (*.pp). All the puppet logic will live in the puppet-tripleo"},{"line_number":59,"context_line":"repository based on a configuration step, so it is mandatory to remove all the"},{"line_number":60,"context_line":"puppet references from tripleo-heat-templates."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"The updated .pp files for the NTP example were:"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_db007f69","line":60,"range":{"start_line":60,"start_character":36,"end_line":60,"end_character":45},"in_reply_to":"3aaa91ec_2689fc26","updated":"2016-07-01 16:09:27.000000000","message":"Agreed, but for now I think there are a lot of people trying to get some documentation about how to start migrating services to composable roles.\n\nI\u0027ll add a task to my todo list to update this when no more work related to migrating services is needed anymore.","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"c9a4e8c9a560538fc58fdb281c629a70e0f97f9e","unresolved":false,"context_lines":[{"line_number":82,"context_line":"registry (``overcloud-resource-registry-puppet.yaml``)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Create a new resource to configure your service using the folder naming"},{"line_number":85,"context_line":"convention."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"Update this file as:"},{"line_number":88,"context_line":"::"}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_c6a758a5","line":85,"range":{"start_line":85,"start_character":0,"end_line":85,"end_character":10},"updated":"2016-06-30 10:10:39.000000000","message":"\"Create a new resource type alias which references the per-service heat template file, as described above:\"","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"8bd8802106afad25b4dcda5cebf8c9cdb3d9dc8a","unresolved":false,"context_lines":[{"line_number":82,"context_line":"registry (``overcloud-resource-registry-puppet.yaml``)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Create a new resource to configure your service using the folder naming"},{"line_number":85,"context_line":"convention."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"Update this file as:"},{"line_number":88,"context_line":"::"}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_fb09fb85","line":85,"range":{"start_line":85,"start_character":0,"end_line":85,"end_character":10},"in_reply_to":"3aaa91ec_c6a758a5","updated":"2016-07-01 16:09:27.000000000","message":"Done","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"c9a4e8c9a560538fc58fdb281c629a70e0f97f9e","unresolved":false,"context_lines":[{"line_number":85,"context_line":"convention."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"Update this file as:"},{"line_number":88,"context_line":"::"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"  # services"},{"line_number":91,"context_line":"  OS::TripleO::Services: puppet/services/services.yaml"}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_26de1c11","line":88,"range":{"start_line":88,"start_character":0,"end_line":88,"end_character":2},"updated":"2016-06-30 10:10:39.000000000","message":"If you choose to use my alternative wording above, this can be removed.","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"8bd8802106afad25b4dcda5cebf8c9cdb3d9dc8a","unresolved":false,"context_lines":[{"line_number":85,"context_line":"convention."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"Update this file as:"},{"line_number":88,"context_line":"::"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"  # services"},{"line_number":91,"context_line":"  OS::TripleO::Services: puppet/services/services.yaml"}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_9b9717eb","line":88,"range":{"start_line":88,"start_character":0,"end_line":88,"end_character":2},"in_reply_to":"3aaa91ec_26de1c11","updated":"2016-07-01 16:09:27.000000000","message":"Done","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"c9a4e8c9a560538fc58fdb281c629a70e0f97f9e","unresolved":false,"context_lines":[{"line_number":103,"context_line":"Step 3 - overcloud.yaml initial changes"},{"line_number":104,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Mandatory services should be linked to the ControllerServices parameter,"},{"line_number":107,"context_line":"which defines all the services enabled by default in the controller(s)."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"From ``overcloud.yaml`` in the parameters section find:"}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_c6d598e5","line":106,"range":{"start_line":106,"start_character":29,"end_line":106,"end_character":35},"updated":"2016-06-30 10:10:39.000000000","message":"s/linked/added and s/parameter/\"parameter default value\"","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"8bd8802106afad25b4dcda5cebf8c9cdb3d9dc8a","unresolved":false,"context_lines":[{"line_number":103,"context_line":"Step 3 - overcloud.yaml initial changes"},{"line_number":104,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Mandatory services should be linked to the ControllerServices parameter,"},{"line_number":107,"context_line":"which defines all the services enabled by default in the controller(s)."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"From ``overcloud.yaml`` in the parameters section find:"}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_7ba86b21","line":106,"range":{"start_line":106,"start_character":29,"end_line":106,"end_character":35},"in_reply_to":"3aaa91ec_c6d598e5","updated":"2016-07-01 16:09:27.000000000","message":"Done","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"c9a4e8c9a560538fc58fdb281c629a70e0f97f9e","unresolved":false,"context_lines":[{"line_number":133,"context_line":"    properties:"},{"line_number":134,"context_line":"      Services: {get_param: ControllerServices}"},{"line_number":135,"context_line":"      EndpointMap: {get_attr: [EndpointMap, endpoint_map]}"},{"line_number":136,"context_line":"      MysqlVirtualIPUri: {get_attr: [VipMap, net_ip_uri_map, {get_param: [ServiceNetMap, MysqlNetwork]}]}"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":".. note::"},{"line_number":139,"context_line":""}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_a655ec50","line":136,"range":{"start_line":136,"start_character":6,"end_line":136,"end_character":23},"updated":"2016-06-30 10:10:39.000000000","message":"This can be removed since https://review.openstack.org/#/c/305751/ landed","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"8bd8802106afad25b4dcda5cebf8c9cdb3d9dc8a","unresolved":false,"context_lines":[{"line_number":133,"context_line":"    properties:"},{"line_number":134,"context_line":"      Services: {get_param: ControllerServices}"},{"line_number":135,"context_line":"      EndpointMap: {get_attr: [EndpointMap, endpoint_map]}"},{"line_number":136,"context_line":"      MysqlVirtualIPUri: {get_attr: [VipMap, net_ip_uri_map, {get_param: [ServiceNetMap, MysqlNetwork]}]}"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":".. note::"},{"line_number":139,"context_line":""}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_db6fdffa","line":136,"range":{"start_line":136,"start_character":6,"end_line":136,"end_character":23},"in_reply_to":"3aaa91ec_a655ec50","updated":"2016-07-01 16:09:27.000000000","message":"Done","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"c9a4e8c9a560538fc58fdb281c629a70e0f97f9e","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":".. note::"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"  Additional roles were created to deploy services in compute and storage nodes."},{"line_number":141,"context_line":"  The current status of all composable roles and services is defined"},{"line_number":142,"context_line":"  in: https://etherpad.openstack.org/p/tripleo-composable-services."},{"line_number":143,"context_line":""}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_46a1a845","line":140,"range":{"start_line":140,"start_character":24,"end_line":140,"end_character":31},"updated":"2016-06-30 10:10:39.000000000","message":"We have to be careful with terminology here - we didn\u0027t create additional roles, we created new service definitions.  A role is e.g \"controller\", and a service is e.g \"nova api\" - we haven\u0027t started adding support for custom roles (e.g additional or fully composable roles) yet, although the custom-roles blueprint aims to do this.","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"8bd8802106afad25b4dcda5cebf8c9cdb3d9dc8a","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":".. note::"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"  Additional roles were created to deploy services in compute and storage nodes."},{"line_number":141,"context_line":"  The current status of all composable roles and services is defined"},{"line_number":142,"context_line":"  in: https://etherpad.openstack.org/p/tripleo-composable-services."},{"line_number":143,"context_line":""}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_fb38dbf0","line":140,"range":{"start_line":140,"start_character":24,"end_line":140,"end_character":31},"in_reply_to":"3aaa91ec_46a1a845","updated":"2016-07-01 16:09:27.000000000","message":"Done","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"c9a4e8c9a560538fc58fdb281c629a70e0f97f9e","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"  Additional roles were created to deploy services in compute and storage nodes."},{"line_number":141,"context_line":"  The current status of all composable roles and services is defined"},{"line_number":142,"context_line":"  in: https://etherpad.openstack.org/p/tripleo-composable-services."},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"THT changes for all the different roles are covered in:"},{"line_number":145,"context_line":""}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_e6a7f44d","line":142,"range":{"start_line":142,"start_character":4,"end_line":142,"end_character":5},"updated":"2016-06-30 10:10:39.000000000","message":"Maybe we should just remove this paragraph and the link to the etherpad - that\u0027s a living document we\u0027re using for development, and probably not something that relevant to user orientated docs?","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"8bd8802106afad25b4dcda5cebf8c9cdb3d9dc8a","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"  Additional roles were created to deploy services in compute and storage nodes."},{"line_number":141,"context_line":"  The current status of all composable roles and services is defined"},{"line_number":142,"context_line":"  in: https://etherpad.openstack.org/p/tripleo-composable-services."},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"THT changes for all the different roles are covered in:"},{"line_number":145,"context_line":""}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_3b0a6328","line":142,"range":{"start_line":142,"start_character":4,"end_line":142,"end_character":5},"in_reply_to":"3aaa91ec_e6a7f44d","updated":"2016-07-01 16:09:27.000000000","message":"Done","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"c9a4e8c9a560538fc58fdb281c629a70e0f97f9e","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"  In the case of the controller services, they are defined as part of the ControllerServiceChain"},{"line_number":157,"context_line":"  resource. If it is needed to add optional services, they need to be appended to the current"},{"line_number":158,"context_line":"  services list defined in the ControllerServices parameter."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Step 4 - Create the services yaml files"}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_a6784cc5","line":158,"range":{"start_line":158,"start_character":27,"end_line":158,"end_character":30},"updated":"2016-06-30 10:10:39.000000000","message":"I\u0027d say \"defined by the default value of the ControllerServices parameter.\"","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"8bd8802106afad25b4dcda5cebf8c9cdb3d9dc8a","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"  In the case of the controller services, they are defined as part of the ControllerServiceChain"},{"line_number":157,"context_line":"  resource. If it is needed to add optional services, they need to be appended to the current"},{"line_number":158,"context_line":"  services list defined in the ControllerServices parameter."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Step 4 - Create the services yaml files"}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_a6011a07","line":158,"range":{"start_line":158,"start_character":27,"end_line":158,"end_character":30},"in_reply_to":"3aaa91ec_a6784cc5","updated":"2016-07-01 16:09:27.000000000","message":"Done","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"c9a4e8c9a560538fc58fdb281c629a70e0f97f9e","unresolved":false,"context_lines":[{"line_number":195,"context_line":"          ntp::ntpservers: {get_param: NtpServers}"},{"line_number":196,"context_line":"          ntp::ntpinterfaces: {get_param: NtpInterfaces}"},{"line_number":197,"context_line":"        step_config: |"},{"line_number":198,"context_line":"          include ::tripleo::profile::base::time::ntp"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":".. note::"},{"line_number":201,"context_line":""}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_215f26e6","line":198,"range":{"start_line":198,"start_character":27,"end_line":198,"end_character":29},"updated":"2016-06-30 10:10:39.000000000","message":"It would be helpful to mention the required interfaces here, e.g:\n\n\"It is required for all service templates to accpet the EndpointMap parameter, all other parameters are optional and may be defined per-service.  Note that care should be taken to avoid naming collisions between service parameters, e.g via using the service name as a prefix, \"Ntp\" in this example\"\n\nAlso for outputs:\n\n\"Service templates should output a role_data value, which is a mapping containing \"config_settings\" which is a mapping of hiera key/value pairs required to configure the service, and \"step_config\", which is a puppet manifest fragment that references the puppet-tripleo profile that configures the service.\"","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"8bd8802106afad25b4dcda5cebf8c9cdb3d9dc8a","unresolved":false,"context_lines":[{"line_number":195,"context_line":"          ntp::ntpservers: {get_param: NtpServers}"},{"line_number":196,"context_line":"          ntp::ntpinterfaces: {get_param: NtpInterfaces}"},{"line_number":197,"context_line":"        step_config: |"},{"line_number":198,"context_line":"          include ::tripleo::profile::base::time::ntp"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":".. note::"},{"line_number":201,"context_line":""}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_739a4f70","line":198,"range":{"start_line":198,"start_character":27,"end_line":198,"end_character":29},"in_reply_to":"3aaa91ec_215f26e6","updated":"2016-07-01 16:09:27.000000000","message":"Done","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"}],"doc/source/tht_walkthrough/design-patterns.rst":[{"author":{"_account_id":7294,"name":"Leif Madsen","email":"lmadsen@redhat.com","username":"leifmadsen"},"change_message_id":"93499d7a310545bdd28658c6ebb32fe225edaaa4","unresolved":false,"context_lines":[{"line_number":30,"context_line":"      value:"},{"line_number":31,"context_line":"        rplset_name: {get_param: MongoDbReplset}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"In this way we will be able to reference this common parameter among all the yaml files requiring it."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Referencing the common parameter:"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_bd5ffa3f","line":33,"range":{"start_line":33,"start_character":41,"end_line":33,"end_character":45},"updated":"2016-05-19 20:12:18.000000000","message":"the? (using \u0027this\u0027 multiple times)","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"82918dc7a313357cdfb9b4009b81ecf2ee61d3c6","unresolved":false,"context_lines":[{"line_number":30,"context_line":"      value:"},{"line_number":31,"context_line":"        rplset_name: {get_param: MongoDbReplset}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"In this way we will be able to reference this common parameter among all the yaml files requiring it."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Referencing the common parameter:"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_32683e87","line":33,"range":{"start_line":33,"start_character":41,"end_line":33,"end_character":45},"in_reply_to":"bab6814e_bd5ffa3f","updated":"2016-05-20 08:32:58.000000000","message":"Done","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"c9a4e8c9a560538fc58fdb281c629a70e0f97f9e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"~~~~~~~~~~~~~~~~~~~~~"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Problem: Having duplicated parameters in yaml files using the same"},{"line_number":9,"context_line":"\u003cservice\u003e-base.yaml file."},{"line_number":10,"context_line":"Example: MongoDB service using rplset name with pacemaker and without"},{"line_number":11,"context_line":"pacemaker."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_c199027b","line":9,"range":{"start_line":9,"start_character":10,"end_line":9,"end_character":14},"updated":"2016-06-30 10:10:39.000000000","message":"This is conflating the problem (duplicate parameters) with the solution \"-base.yaml)\n\nI\u0027d say something like:\n\n\"When defining multiple related services, it can be necessary to define the same parameters (such as rabbit or DB credentials) in multiple service templates.  To avoid this, it is possible to define a \"base\" heat template that contains the common parameters and config_settings mapping for those services that require it\"","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"8bd8802106afad25b4dcda5cebf8c9cdb3d9dc8a","unresolved":false,"context_lines":[{"line_number":6,"context_line":"~~~~~~~~~~~~~~~~~~~~~"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Problem: Having duplicated parameters in yaml files using the same"},{"line_number":9,"context_line":"\u003cservice\u003e-base.yaml file."},{"line_number":10,"context_line":"Example: MongoDB service using rplset name with pacemaker and without"},{"line_number":11,"context_line":"pacemaker."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_73d6cff2","line":9,"range":{"start_line":9,"start_character":10,"end_line":9,"end_character":14},"in_reply_to":"3aaa91ec_c199027b","updated":"2016-07-01 16:09:27.000000000","message":"Done","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"c9a4e8c9a560538fc58fdb281c629a70e0f97f9e","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    aux_parameters:"},{"line_number":33,"context_line":"      description: Additional parameters referenced outside the base file"},{"line_number":34,"context_line":"      value:"},{"line_number":35,"context_line":"        rplset_name: {get_param: MongoDbReplset}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"In this way we will be able to reference the common parameter among all the"},{"line_number":38,"context_line":"yaml files requiring it."}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_41b6b2f9","line":35,"range":{"start_line":35,"start_character":22,"end_line":35,"end_character":31},"updated":"2016-06-30 10:10:39.000000000","message":"I don\u0027t think we should document using non-standard outputs here.  I know this will work, but we should encourage a completely standardized interface for all service templates, e.g:\n\nhttps://github.com/openstack/tripleo-heat-templates/blob/master/puppet/services/heat-base.yaml#L31\n\nSo here we should output role_data, and show how to merge the config_settings below.\n\nAlso, both of these examples should show the EndpointMap parameter, or folks will copy/paste these and complain when they don\u0027t work..","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"8bd8802106afad25b4dcda5cebf8c9cdb3d9dc8a","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    aux_parameters:"},{"line_number":33,"context_line":"      description: Additional parameters referenced outside the base file"},{"line_number":34,"context_line":"      value:"},{"line_number":35,"context_line":"        rplset_name: {get_param: MongoDbReplset}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"In this way we will be able to reference the common parameter among all the"},{"line_number":38,"context_line":"yaml files requiring it."}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_d676910b","line":35,"range":{"start_line":35,"start_character":22,"end_line":35,"end_character":31},"in_reply_to":"3aaa91ec_41b6b2f9","updated":"2016-07-01 16:09:27.000000000","message":"Done","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"c9a4e8c9a560538fc58fdb281c629a70e0f97f9e","unresolved":false,"context_lines":[{"line_number":62,"context_line":"In this case mongodb.yaml can use this common parameter, and assign it to a"},{"line_number":63,"context_line":"specific puppet manifest parameter depending on the chosen environment."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"If using the parameter \u0027EndpointMap\u0027 in the base file, is mandatory to passing it from the service file."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"In the service file:"},{"line_number":68,"context_line":"::"}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_61964e3f","line":65,"range":{"start_line":65,"start_character":35,"end_line":65,"end_character":36},"updated":"2016-06-30 10:10:39.000000000","message":"Yeah, I suppose we could document that the EndpointMap is optional in the base template, but it might be easier and more consistent to just document always having it in all service templates?","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"8bd8802106afad25b4dcda5cebf8c9cdb3d9dc8a","unresolved":false,"context_lines":[{"line_number":62,"context_line":"In this case mongodb.yaml can use this common parameter, and assign it to a"},{"line_number":63,"context_line":"specific puppet manifest parameter depending on the chosen environment."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"If using the parameter \u0027EndpointMap\u0027 in the base file, is mandatory to passing it from the service file."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"In the service file:"},{"line_number":68,"context_line":"::"}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_d69211fc","line":65,"range":{"start_line":65,"start_character":35,"end_line":65,"end_character":36},"in_reply_to":"3aaa91ec_61964e3f","updated":"2016-07-01 16:09:27.000000000","message":"Done","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"}],"doc/source/tht_walkthrough/introduction.rst":[{"author":{"_account_id":7294,"name":"Leif Madsen","email":"lmadsen@redhat.com","username":"leifmadsen"},"change_message_id":"93499d7a310545bdd28658c6ebb32fe225edaaa4","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"All the puppet manifests are called in the tripleo-heat-templates"},{"line_number":15,"context_line":"folder: ``puppet/manifests``. In order"},{"line_number":16,"context_line":"to properly organize and  structure the code, all manifests will be re-defined in"},{"line_number":17,"context_line":"the puppet-tripleo repository, and adapted to the composable"},{"line_number":18,"context_line":"services architecture (https://blueprints.launchpad.net/tripleo/+spec/composable-services-within-roles)."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_7d13d266","line":16,"range":{"start_line":16,"start_character":25,"end_line":16,"end_character":26},"updated":"2016-05-19 20:12:18.000000000","message":"extra space","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"82918dc7a313357cdfb9b4009b81ecf2ee61d3c6","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"All the puppet manifests are called in the tripleo-heat-templates"},{"line_number":15,"context_line":"folder: ``puppet/manifests``. In order"},{"line_number":16,"context_line":"to properly organize and  structure the code, all manifests will be re-defined in"},{"line_number":17,"context_line":"the puppet-tripleo repository, and adapted to the composable"},{"line_number":18,"context_line":"services architecture (https://blueprints.launchpad.net/tripleo/+spec/composable-services-within-roles)."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_f21fd605","line":16,"range":{"start_line":16,"start_character":25,"end_line":16,"end_character":26},"in_reply_to":"bab6814e_7d13d266","updated":"2016-05-20 08:32:58.000000000","message":"Done","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":7294,"name":"Leif Madsen","email":"lmadsen@redhat.com","username":"leifmadsen"},"change_message_id":"93499d7a310545bdd28658c6ebb32fe225edaaa4","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"The use case for this example uses NTP as a service"},{"line_number":21,"context_line":"installed by default among the OpenStack deployment."},{"line_number":22,"context_line":"In this particular case, NTP is installed and configured based in the code"},{"line_number":23,"context_line":"from puppet manifests:"},{"line_number":24,"context_line":"``puppet/manifests/overcloud_cephstorage.pp``,"},{"line_number":25,"context_line":"``puppet/manifests/overcloud_volume.pp``,"}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_800a8d1f","line":22,"range":{"start_line":22,"start_character":63,"end_line":22,"end_character":65},"updated":"2016-05-19 20:12:18.000000000","message":"on","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"82918dc7a313357cdfb9b4009b81ecf2ee61d3c6","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"The use case for this example uses NTP as a service"},{"line_number":21,"context_line":"installed by default among the OpenStack deployment."},{"line_number":22,"context_line":"In this particular case, NTP is installed and configured based in the code"},{"line_number":23,"context_line":"from puppet manifests:"},{"line_number":24,"context_line":"``puppet/manifests/overcloud_cephstorage.pp``,"},{"line_number":25,"context_line":"``puppet/manifests/overcloud_volume.pp``,"}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_92d5aa1d","line":22,"range":{"start_line":22,"start_character":63,"end_line":22,"end_character":65},"in_reply_to":"bab6814e_800a8d1f","updated":"2016-05-20 08:32:58.000000000","message":"Done","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":7294,"name":"Leif Madsen","email":"lmadsen@redhat.com","username":"leifmadsen"},"change_message_id":"93499d7a310545bdd28658c6ebb32fe225edaaa4","unresolved":false,"context_lines":[{"line_number":27,"context_line":"``puppet/manifests/overcloud_compute.pp``,"},{"line_number":28,"context_line":"``puppet/manifests/overcloud_controller.pp`` and"},{"line_number":29,"context_line":"``puppet/manifests/overcloud_controller_pacemaker.pp``"},{"line_number":30,"context_line":"Which means that NTP will be installed everywhere in the overcloud."},{"line_number":31,"context_line":"So there is no need to add more code. Instead"},{"line_number":32,"context_line":"we need to refactor the code from those files in order move it to puppet-tripleo."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Also is important to notice that the NTP puppet module is already"}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_6024c9ae","line":31,"range":{"start_line":30,"start_character":66,"end_line":31,"end_character":1},"updated":"2016-05-19 20:12:18.000000000","message":", so\n\nno real need for separate sentence.","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"82918dc7a313357cdfb9b4009b81ecf2ee61d3c6","unresolved":false,"context_lines":[{"line_number":27,"context_line":"``puppet/manifests/overcloud_compute.pp``,"},{"line_number":28,"context_line":"``puppet/manifests/overcloud_controller.pp`` and"},{"line_number":29,"context_line":"``puppet/manifests/overcloud_controller_pacemaker.pp``"},{"line_number":30,"context_line":"Which means that NTP will be installed everywhere in the overcloud."},{"line_number":31,"context_line":"So there is no need to add more code. Instead"},{"line_number":32,"context_line":"we need to refactor the code from those files in order move it to puppet-tripleo."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Also is important to notice that the NTP puppet module is already"}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_d2dbb24d","line":31,"range":{"start_line":30,"start_character":66,"end_line":31,"end_character":1},"in_reply_to":"bab6814e_6024c9ae","updated":"2016-05-20 08:32:58.000000000","message":"Done","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":7294,"name":"Leif Madsen","email":"lmadsen@redhat.com","username":"leifmadsen"},"change_message_id":"93499d7a310545bdd28658c6ebb32fe225edaaa4","unresolved":false,"context_lines":[{"line_number":32,"context_line":"we need to refactor the code from those files in order move it to puppet-tripleo."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Also is important to notice that the NTP puppet module is already"},{"line_number":35,"context_line":"included in the repository tripleo-puppet-elements, so forth, we can use"},{"line_number":36,"context_line":"the manifests from NTP in any node from the overcloud."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"In the case of needing"}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_40754596","line":35,"range":{"start_line":35,"start_character":52,"end_line":35,"end_character":64},"updated":"2016-05-19 20:12:18.000000000","message":"so we","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"82918dc7a313357cdfb9b4009b81ecf2ee61d3c6","unresolved":false,"context_lines":[{"line_number":32,"context_line":"we need to refactor the code from those files in order move it to puppet-tripleo."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Also is important to notice that the NTP puppet module is already"},{"line_number":35,"context_line":"included in the repository tripleo-puppet-elements, so forth, we can use"},{"line_number":36,"context_line":"the manifests from NTP in any node from the overcloud."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"In the case of needing"}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_d2b29205","line":35,"range":{"start_line":35,"start_character":52,"end_line":35,"end_character":64},"in_reply_to":"bab6814e_40754596","updated":"2016-05-20 08:32:58.000000000","message":"Done","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":7294,"name":"Leif Madsen","email":"lmadsen@redhat.com","username":"leifmadsen"},"change_message_id":"93499d7a310545bdd28658c6ebb32fe225edaaa4","unresolved":false,"context_lines":[{"line_number":36,"context_line":"the manifests from NTP in any node from the overcloud."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"In the case of needing"},{"line_number":39,"context_line":"a new third-party puppet module, should be added in tripleo-puppet-elements"},{"line_number":40,"context_line":"(installed by default in all nodes) and referenced from a puppet manifest"},{"line_number":41,"context_line":"in puppet-tripleo."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_607209af","line":39,"range":{"start_line":39,"start_character":33,"end_line":39,"end_character":39},"updated":"2016-05-19 20:12:18.000000000","message":"it should?","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"82918dc7a313357cdfb9b4009b81ecf2ee61d3c6","unresolved":false,"context_lines":[{"line_number":36,"context_line":"the manifests from NTP in any node from the overcloud."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"In the case of needing"},{"line_number":39,"context_line":"a new third-party puppet module, should be added in tripleo-puppet-elements"},{"line_number":40,"context_line":"(installed by default in all nodes) and referenced from a puppet manifest"},{"line_number":41,"context_line":"in puppet-tripleo."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_f2cd1686","line":39,"range":{"start_line":39,"start_character":33,"end_line":39,"end_character":39},"in_reply_to":"bab6814e_607209af","updated":"2016-05-20 08:32:58.000000000","message":"Done","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":7294,"name":"Leif Madsen","email":"lmadsen@redhat.com","username":"leifmadsen"},"change_message_id":"93499d7a310545bdd28658c6ebb32fe225edaaa4","unresolved":false,"context_lines":[{"line_number":40,"context_line":"(installed by default in all nodes) and referenced from a puppet manifest"},{"line_number":41,"context_line":"in puppet-tripleo."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"This tutorial is divided in several steps, according"},{"line_number":44,"context_line":"different changes that needs to be added"},{"line_number":45,"context_line":"to the structure of tripleo-heat-templates and puppet-tripleo."},{"line_number":46,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_e0b55931","line":43,"range":{"start_line":43,"start_character":43,"end_line":43,"end_character":52},"updated":"2016-05-19 20:12:18.000000000","message":"according to","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":7294,"name":"Leif Madsen","email":"lmadsen@redhat.com","username":"leifmadsen"},"change_message_id":"93499d7a310545bdd28658c6ebb32fe225edaaa4","unresolved":false,"context_lines":[{"line_number":40,"context_line":"(installed by default in all nodes) and referenced from a puppet manifest"},{"line_number":41,"context_line":"in puppet-tripleo."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"This tutorial is divided in several steps, according"},{"line_number":44,"context_line":"different changes that needs to be added"},{"line_number":45,"context_line":"to the structure of tripleo-heat-templates and puppet-tripleo."},{"line_number":46,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_409c25c0","line":43,"range":{"start_line":43,"start_character":25,"end_line":43,"end_character":27},"updated":"2016-05-19 20:12:18.000000000","message":"into","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"82918dc7a313357cdfb9b4009b81ecf2ee61d3c6","unresolved":false,"context_lines":[{"line_number":40,"context_line":"(installed by default in all nodes) and referenced from a puppet manifest"},{"line_number":41,"context_line":"in puppet-tripleo."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"This tutorial is divided in several steps, according"},{"line_number":44,"context_line":"different changes that needs to be added"},{"line_number":45,"context_line":"to the structure of tripleo-heat-templates and puppet-tripleo."},{"line_number":46,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_72a8068e","line":43,"range":{"start_line":43,"start_character":25,"end_line":43,"end_character":27},"in_reply_to":"bab6814e_409c25c0","updated":"2016-05-20 08:32:58.000000000","message":"Done","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"82918dc7a313357cdfb9b4009b81ecf2ee61d3c6","unresolved":false,"context_lines":[{"line_number":40,"context_line":"(installed by default in all nodes) and referenced from a puppet manifest"},{"line_number":41,"context_line":"in puppet-tripleo."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"This tutorial is divided in several steps, according"},{"line_number":44,"context_line":"different changes that needs to be added"},{"line_number":45,"context_line":"to the structure of tripleo-heat-templates and puppet-tripleo."},{"line_number":46,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_b2aeee95","line":43,"range":{"start_line":43,"start_character":43,"end_line":43,"end_character":52},"in_reply_to":"bab6814e_e0b55931","updated":"2016-05-20 08:32:58.000000000","message":"Done","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":7294,"name":"Leif Madsen","email":"lmadsen@redhat.com","username":"leifmadsen"},"change_message_id":"93499d7a310545bdd28658c6ebb32fe225edaaa4","unresolved":false,"context_lines":[{"line_number":41,"context_line":"in puppet-tripleo."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"This tutorial is divided in several steps, according"},{"line_number":44,"context_line":"different changes that needs to be added"},{"line_number":45,"context_line":"to the structure of tripleo-heat-templates and puppet-tripleo."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Repositories referenced in this guide"}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_c097758e","line":44,"range":{"start_line":44,"start_character":23,"end_line":44,"end_character":28},"updated":"2016-05-19 20:12:18.000000000","message":"need","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"82918dc7a313357cdfb9b4009b81ecf2ee61d3c6","unresolved":false,"context_lines":[{"line_number":41,"context_line":"in puppet-tripleo."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"This tutorial is divided in several steps, according"},{"line_number":44,"context_line":"different changes that needs to be added"},{"line_number":45,"context_line":"to the structure of tripleo-heat-templates and puppet-tripleo."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Repositories referenced in this guide"}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_92064a84","line":44,"range":{"start_line":44,"start_character":23,"end_line":44,"end_character":28},"in_reply_to":"bab6814e_c097758e","updated":"2016-05-20 08:32:58.000000000","message":"Done","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":7294,"name":"Leif Madsen","email":"lmadsen@redhat.com","username":"leifmadsen"},"change_message_id":"93499d7a310545bdd28658c6ebb32fe225edaaa4","unresolved":false,"context_lines":[{"line_number":52,"context_line":"- puppet-tripleo: Custom TripleO puppet manifests to deploy the overcloud."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"- tripleo-puppet-elements: third-party puppet modules (Not used in this tutorial,"},{"line_number":55,"context_line":"  but needs to be used for adding additional puppet modules)."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Gerrit patches used in this example"},{"line_number":58,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_a0d99185","line":55,"range":{"start_line":55,"start_character":59,"end_line":55,"end_character":61},"updated":"2016-05-19 20:12:18.000000000","message":"period on the inside of the brace:  .)","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"82918dc7a313357cdfb9b4009b81ecf2ee61d3c6","unresolved":false,"context_lines":[{"line_number":52,"context_line":"- puppet-tripleo: Custom TripleO puppet manifests to deploy the overcloud."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"- tripleo-puppet-elements: third-party puppet modules (Not used in this tutorial,"},{"line_number":55,"context_line":"  but needs to be used for adding additional puppet modules)."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Gerrit patches used in this example"},{"line_number":58,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_92912a4a","line":55,"range":{"start_line":55,"start_character":59,"end_line":55,"end_character":61},"in_reply_to":"bab6814e_a0d99185","updated":"2016-05-20 08:32:58.000000000","message":"Done","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":7294,"name":"Leif Madsen","email":"lmadsen@redhat.com","username":"leifmadsen"},"change_message_id":"93499d7a310545bdd28658c6ebb32fe225edaaa4","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"The controller services are defined and configured via Heat resource chains."},{"line_number":70,"context_line":"In the proposed patch (https://review.openstack.org/#/c/259568)"},{"line_number":71,"context_line":"will be wired a new Heat feature"},{"line_number":72,"context_line":"that allows to dynamically include a set of nested"},{"line_number":73,"context_line":"stacks representing individual services via a Heat resource chain."},{"line_number":74,"context_line":"The current example"}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_20d48145","line":71,"range":{"start_line":71,"start_character":0,"end_line":71,"end_character":4},"updated":"2016-05-19 20:12:18.000000000","message":"controller services will","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":7294,"name":"Leif Madsen","email":"lmadsen@redhat.com","username":"leifmadsen"},"change_message_id":"93499d7a310545bdd28658c6ebb32fe225edaaa4","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"The controller services are defined and configured via Heat resource chains."},{"line_number":70,"context_line":"In the proposed patch (https://review.openstack.org/#/c/259568)"},{"line_number":71,"context_line":"will be wired a new Heat feature"},{"line_number":72,"context_line":"that allows to dynamically include a set of nested"},{"line_number":73,"context_line":"stacks representing individual services via a Heat resource chain."},{"line_number":74,"context_line":"The current example"}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_203be19d","line":71,"range":{"start_line":71,"start_character":13,"end_line":71,"end_character":15},"updated":"2016-05-19 20:12:18.000000000","message":"to a","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"82918dc7a313357cdfb9b4009b81ecf2ee61d3c6","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"The controller services are defined and configured via Heat resource chains."},{"line_number":70,"context_line":"In the proposed patch (https://review.openstack.org/#/c/259568)"},{"line_number":71,"context_line":"will be wired a new Heat feature"},{"line_number":72,"context_line":"that allows to dynamically include a set of nested"},{"line_number":73,"context_line":"stacks representing individual services via a Heat resource chain."},{"line_number":74,"context_line":"The current example"}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_b2b38ee8","line":71,"range":{"start_line":71,"start_character":13,"end_line":71,"end_character":15},"in_reply_to":"bab6814e_203be19d","updated":"2016-05-20 08:32:58.000000000","message":"Done","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"82918dc7a313357cdfb9b4009b81ecf2ee61d3c6","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"The controller services are defined and configured via Heat resource chains."},{"line_number":70,"context_line":"In the proposed patch (https://review.openstack.org/#/c/259568)"},{"line_number":71,"context_line":"will be wired a new Heat feature"},{"line_number":72,"context_line":"that allows to dynamically include a set of nested"},{"line_number":73,"context_line":"stacks representing individual services via a Heat resource chain."},{"line_number":74,"context_line":"The current example"}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_12cd3a66","line":71,"range":{"start_line":71,"start_character":0,"end_line":71,"end_character":4},"in_reply_to":"bab6814e_20d48145","updated":"2016-05-20 08:32:58.000000000","message":"Done","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":7294,"name":"Leif Madsen","email":"lmadsen@redhat.com","username":"leifmadsen"},"change_message_id":"93499d7a310545bdd28658c6ebb32fe225edaaa4","unresolved":false,"context_lines":[{"line_number":77,"context_line":".. note::"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"  Additional Heat features must be defined in order to apply"},{"line_number":80,"context_line":"  the same behaviour to other roles (compute, storage),"},{"line_number":81,"context_line":"  current work defined in: https://etherpad.openstack.org/p/tripleo-composable-services"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_c073f57e","line":81,"range":{"start_line":80,"start_character":54,"end_line":81,"end_character":3},"updated":"2016-05-19 20:12:18.000000000","message":". C  (new sentence)","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"82918dc7a313357cdfb9b4009b81ecf2ee61d3c6","unresolved":false,"context_lines":[{"line_number":77,"context_line":".. note::"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"  Additional Heat features must be defined in order to apply"},{"line_number":80,"context_line":"  the same behaviour to other roles (compute, storage),"},{"line_number":81,"context_line":"  current work defined in: https://etherpad.openstack.org/p/tripleo-composable-services"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_92df6a0c","line":81,"range":{"start_line":80,"start_character":54,"end_line":81,"end_character":3},"in_reply_to":"bab6814e_c073f57e","updated":"2016-05-20 08:32:58.000000000","message":"Done","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":7294,"name":"Leif Madsen","email":"lmadsen@redhat.com","username":"leifmadsen"},"change_message_id":"779029ee53a25362f90194a823605ee615536d8c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"no need to add more code. Instead we need to refactor the code from those files"},{"line_number":32,"context_line":"in order move it to puppet-tripleo."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Also is important to notice that the NTP puppet module is already included in"},{"line_number":35,"context_line":"the repository tripleo-puppet-elements, so we can use the manifests from NTP in"},{"line_number":36,"context_line":"any node from the overcloud."},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":18,"id":"bab6814e_c1f3099e","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":7},"updated":"2016-05-25 13:30:48.000000000","message":"Also it is","commit_id":"cd9ff2c1b7a9c2abde004804f4e07574180941dd"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"7b419e1df37b31fc5095c5aef43595e30927e057","unresolved":false,"context_lines":[{"line_number":31,"context_line":"no need to add more code. Instead we need to refactor the code from those files"},{"line_number":32,"context_line":"in order move it to puppet-tripleo."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Also is important to notice that the NTP puppet module is already included in"},{"line_number":35,"context_line":"the repository tripleo-puppet-elements, so we can use the manifests from NTP in"},{"line_number":36,"context_line":"any node from the overcloud."},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":18,"id":"bab6814e_241b031d","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":7},"in_reply_to":"bab6814e_c1f3099e","updated":"2016-05-25 13:39:21.000000000","message":"Done","commit_id":"cd9ff2c1b7a9c2abde004804f4e07574180941dd"},{"author":{"_account_id":7294,"name":"Leif Madsen","email":"lmadsen@redhat.com","username":"leifmadsen"},"change_message_id":"779029ee53a25362f90194a823605ee615536d8c","unresolved":false,"context_lines":[{"line_number":46,"context_line":"Repositories referenced in this guide"},{"line_number":47,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"- tripleo-heat-templates: All the THT logic."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- puppet-tripleo: Custom TripleO puppet manifests to deploy the overcloud."},{"line_number":52,"context_line":""}],"source_content_type":"text/x-rst","patch_set":18,"id":"bab6814e_a18365cb","line":49,"range":{"start_line":49,"start_character":26,"end_line":49,"end_character":43},"updated":"2016-05-25 13:30:48.000000000","message":"All the tripleo-heat-templates (aka THT) logic.\n\nI think this makes the acronym more clear, and defined properly.","commit_id":"cd9ff2c1b7a9c2abde004804f4e07574180941dd"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"7b419e1df37b31fc5095c5aef43595e30927e057","unresolved":false,"context_lines":[{"line_number":46,"context_line":"Repositories referenced in this guide"},{"line_number":47,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"- tripleo-heat-templates: All the THT logic."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- puppet-tripleo: Custom TripleO puppet manifests to deploy the overcloud."},{"line_number":52,"context_line":""}],"source_content_type":"text/x-rst","patch_set":18,"id":"bab6814e_e4ce1b82","line":49,"range":{"start_line":49,"start_character":26,"end_line":49,"end_character":43},"in_reply_to":"bab6814e_a18365cb","updated":"2016-05-25 13:39:21.000000000","message":"Done","commit_id":"cd9ff2c1b7a9c2abde004804f4e07574180941dd"},{"author":{"_account_id":7294,"name":"Leif Madsen","email":"lmadsen@redhat.com","username":"leifmadsen"},"change_message_id":"779029ee53a25362f90194a823605ee615536d8c","unresolved":false,"context_lines":[{"line_number":51,"context_line":"- puppet-tripleo: Custom TripleO puppet manifests to deploy the overcloud."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"- tripleo-puppet-elements: third-party puppet modules. (Not used in this"},{"line_number":54,"context_line":"  tutorial, but needs to be used for adding additional puppet modules)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Gerrit patches used in this example"},{"line_number":57,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":18,"id":"bab6814e_e1544d55","line":54,"range":{"start_line":54,"start_character":62,"end_line":54,"end_character":70},"updated":"2016-05-25 13:30:48.000000000","message":"modules.)","commit_id":"cd9ff2c1b7a9c2abde004804f4e07574180941dd"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"7b419e1df37b31fc5095c5aef43595e30927e057","unresolved":false,"context_lines":[{"line_number":51,"context_line":"- puppet-tripleo: Custom TripleO puppet manifests to deploy the overcloud."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"- tripleo-puppet-elements: third-party puppet modules. (Not used in this"},{"line_number":54,"context_line":"  tutorial, but needs to be used for adding additional puppet modules)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Gerrit patches used in this example"},{"line_number":57,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":18,"id":"bab6814e_c4c9577b","line":54,"range":{"start_line":54,"start_character":62,"end_line":54,"end_character":70},"in_reply_to":"bab6814e_e1544d55","updated":"2016-05-25 13:39:21.000000000","message":"Done","commit_id":"cd9ff2c1b7a9c2abde004804f4e07574180941dd"},{"author":{"_account_id":7294,"name":"Leif Madsen","email":"lmadsen@redhat.com","username":"leifmadsen"},"change_message_id":"779029ee53a25362f90194a823605ee615536d8c","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"The gerrit patches used to describe this walkthrough are:"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"- https://review.openstack.org/#/c/310421/ (Tripleo-Heat-Templates)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"- https://review.openstack.org/#/c/310725/ (Puppet-Tripleo)"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-rst","patch_set":18,"id":"bab6814e_a1e8857d","line":61,"range":{"start_line":61,"start_character":44,"end_line":61,"end_character":51},"updated":"2016-05-25 13:30:48.000000000","message":"TripleO  (since we\u0027re using uppercase here, or drop to all lowercase as previously used).","commit_id":"cd9ff2c1b7a9c2abde004804f4e07574180941dd"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"7b419e1df37b31fc5095c5aef43595e30927e057","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"The gerrit patches used to describe this walkthrough are:"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"- https://review.openstack.org/#/c/310421/ (Tripleo-Heat-Templates)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"- https://review.openstack.org/#/c/310725/ (Puppet-Tripleo)"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-rst","patch_set":18,"id":"bab6814e_e4957b40","line":61,"range":{"start_line":61,"start_character":44,"end_line":61,"end_character":51},"in_reply_to":"bab6814e_a1e8857d","updated":"2016-05-25 13:39:21.000000000","message":"Done","commit_id":"cd9ff2c1b7a9c2abde004804f4e07574180941dd"},{"author":{"_account_id":7294,"name":"Leif Madsen","email":"lmadsen@redhat.com","username":"leifmadsen"},"change_message_id":"779029ee53a25362f90194a823605ee615536d8c","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"- https://review.openstack.org/#/c/310421/ (Tripleo-Heat-Templates)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"- https://review.openstack.org/#/c/310725/ (Puppet-Tripleo)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Changes prerequisites"},{"line_number":66,"context_line":"~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":18,"id":"bab6814e_e1b0cd8d","line":63,"range":{"start_line":63,"start_character":51,"end_line":63,"end_character":58},"updated":"2016-05-25 13:30:48.000000000","message":"same as previous; TripleO","commit_id":"cd9ff2c1b7a9c2abde004804f4e07574180941dd"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"7b419e1df37b31fc5095c5aef43595e30927e057","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"- https://review.openstack.org/#/c/310421/ (Tripleo-Heat-Templates)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"- https://review.openstack.org/#/c/310725/ (Puppet-Tripleo)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Changes prerequisites"},{"line_number":66,"context_line":"~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":18,"id":"bab6814e_c4903751","line":63,"range":{"start_line":63,"start_character":51,"end_line":63,"end_character":58},"in_reply_to":"bab6814e_e1b0cd8d","updated":"2016-05-25 13:39:21.000000000","message":"Done","commit_id":"cd9ff2c1b7a9c2abde004804f4e07574180941dd"},{"author":{"_account_id":7294,"name":"Leif Madsen","email":"lmadsen@redhat.com","username":"leifmadsen"},"change_message_id":"779029ee53a25362f90194a823605ee615536d8c","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"The controller services are defined and configured via Heat resource chains. In"},{"line_number":69,"context_line":"the proposed patch (https://review.openstack.org/#/c/259568) controller"},{"line_number":70,"context_line":"services will be wired to a new Heat feature that allows to dynamically include"},{"line_number":71,"context_line":"a set of nested stacks representing individual services via a Heat resource"},{"line_number":72,"context_line":"chain. The current example will use this interface to decompose the controller"},{"line_number":73,"context_line":"role into isolated services."}],"source_content_type":"text/x-rst","patch_set":18,"id":"bab6814e_e1772dd2","line":70,"range":{"start_line":70,"start_character":50,"end_line":70,"end_character":59},"updated":"2016-05-25 13:30:48.000000000","message":"allows it to","commit_id":"cd9ff2c1b7a9c2abde004804f4e07574180941dd"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"7b419e1df37b31fc5095c5aef43595e30927e057","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"The controller services are defined and configured via Heat resource chains. In"},{"line_number":69,"context_line":"the proposed patch (https://review.openstack.org/#/c/259568) controller"},{"line_number":70,"context_line":"services will be wired to a new Heat feature that allows to dynamically include"},{"line_number":71,"context_line":"a set of nested stacks representing individual services via a Heat resource"},{"line_number":72,"context_line":"chain. The current example will use this interface to decompose the controller"},{"line_number":73,"context_line":"role into isolated services."}],"source_content_type":"text/x-rst","patch_set":18,"id":"bab6814e_e47c5b22","line":70,"range":{"start_line":70,"start_character":50,"end_line":70,"end_character":59},"in_reply_to":"bab6814e_e1772dd2","updated":"2016-05-25 13:39:21.000000000","message":"Done","commit_id":"cd9ff2c1b7a9c2abde004804f4e07574180941dd"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b3769cb2fa7e3b3fe99942115c0b3f25877183ad","unresolved":false,"context_lines":[{"line_number":14,"context_line":"``puppet/manifests``. In order to properly organize and structure the code, all"},{"line_number":15,"context_line":"manifests will be re-defined in the puppet-tripleo repository, and adapted to"},{"line_number":16,"context_line":"the composable services architecture"},{"line_number":17,"context_line":"(https://blueprints.launchpad.net/tripleo/+spec/composable-services-within-roles)."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"The use case for this example uses NTP as a service installed by default among"},{"line_number":20,"context_line":"the OpenStack deployment. In this particular case, NTP is installed and"}],"source_content_type":"text/x-rst","patch_set":19,"id":"bab6814e_cc3e758a","line":17,"updated":"2016-05-26 08:25:50.000000000","message":"make this a link pls (see tht_walkthrough)","commit_id":"450e2fbb2c050339fceda5e76b74ec46f52ecd0f"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"71b7b21687bea364480b009af0c0c75bcf7eeaed","unresolved":false,"context_lines":[{"line_number":14,"context_line":"``puppet/manifests``. In order to properly organize and structure the code, all"},{"line_number":15,"context_line":"manifests will be re-defined in the puppet-tripleo repository, and adapted to"},{"line_number":16,"context_line":"the composable services architecture"},{"line_number":17,"context_line":"(https://blueprints.launchpad.net/tripleo/+spec/composable-services-within-roles)."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"The use case for this example uses NTP as a service installed by default among"},{"line_number":20,"context_line":"the OpenStack deployment. In this particular case, NTP is installed and"}],"source_content_type":"text/x-rst","patch_set":19,"id":"bab6814e_278e3ad0","line":17,"in_reply_to":"bab6814e_cc3e758a","updated":"2016-05-26 08:48:07.000000000","message":"Done","commit_id":"450e2fbb2c050339fceda5e76b74ec46f52ecd0f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"cd44025376aabf204b97091bc3beed9543de81dc","unresolved":false,"context_lines":[{"line_number":6,"context_line":"the composable roles architecture."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"The first step will be to identify and isolate a functionality or feature that"},{"line_number":9,"context_line":"needs to be aligned with the composable roles approach. For instance, by"},{"line_number":10,"context_line":"checking ``tripleo-heat-templates/puppet/manifests/overcloud_controller.pp``"},{"line_number":11,"context_line":"and selecting an installed service (i.e. \u0027include ::ntp\u0027)."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-rst","patch_set":21,"id":"7aa08908_2dd80d1d","line":9,"updated":"2016-06-07 08:10:40.000000000","message":"(this could also be about adding a new service, I mean not just about making an existing service composable). The example here walks through the process of taking an existing deployed service, like NTP and aligning its implementation with the composable roles approach. A similar approach would be followed if you were adding an entirely new service to a tripleo deployment","commit_id":"bcb1a87ae0a7c24b22785d7cf539f755e6cb16c8"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"f9fdcdd224a5351f279cf5e33c70a8abfcc45c7e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"the composable roles architecture."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"The first step will be to identify and isolate a functionality or feature that"},{"line_number":9,"context_line":"needs to be aligned with the composable roles approach. For instance, by"},{"line_number":10,"context_line":"checking ``tripleo-heat-templates/puppet/manifests/overcloud_controller.pp``"},{"line_number":11,"context_line":"and selecting an installed service (i.e. \u0027include ::ntp\u0027)."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-rst","patch_set":21,"id":"7aa08908_b3457e18","line":9,"in_reply_to":"7aa08908_2dd80d1d","updated":"2016-06-07 09:01:16.000000000","message":"Done","commit_id":"bcb1a87ae0a7c24b22785d7cf539f755e6cb16c8"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"cd44025376aabf204b97091bc3beed9543de81dc","unresolved":false,"context_lines":[{"line_number":10,"context_line":"checking ``tripleo-heat-templates/puppet/manifests/overcloud_controller.pp``"},{"line_number":11,"context_line":"and selecting an installed service (i.e. \u0027include ::ntp\u0027)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"All the puppet manifests are called in the tripleo-heat-templates folder:"},{"line_number":14,"context_line":"``puppet/manifests``. In order to properly organize and structure the code, all"},{"line_number":15,"context_line":"manifests will be re-defined in the puppet-tripleo repository, and adapted to"},{"line_number":16,"context_line":"the composable services architecture"}],"source_content_type":"text/x-rst","patch_set":21,"id":"7aa08908_ad487d88","line":13,"updated":"2016-06-07 08:10:40.000000000","message":"The puppet manifests used to configure services on overcloud nodes currently reside in the tripleo-heat-templates repository, in the puppet/manifests folder and then you can even `point to it`_:\n\n.. _point to it: https://github.com/openstack/tripleo-heat-templates/tree/3d01f650f18b9e4f1892a6d9aa17f1bfc99b5091/puppet/manifests","commit_id":"bcb1a87ae0a7c24b22785d7cf539f755e6cb16c8"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"f9fdcdd224a5351f279cf5e33c70a8abfcc45c7e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"checking ``tripleo-heat-templates/puppet/manifests/overcloud_controller.pp``"},{"line_number":11,"context_line":"and selecting an installed service (i.e. \u0027include ::ntp\u0027)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"All the puppet manifests are called in the tripleo-heat-templates folder:"},{"line_number":14,"context_line":"``puppet/manifests``. In order to properly organize and structure the code, all"},{"line_number":15,"context_line":"manifests will be re-defined in the puppet-tripleo repository, and adapted to"},{"line_number":16,"context_line":"the composable services architecture"}],"source_content_type":"text/x-rst","patch_set":21,"id":"7aa08908_33aa2e71","line":13,"in_reply_to":"7aa08908_ad487d88","updated":"2016-06-07 09:01:16.000000000","message":"Done","commit_id":"bcb1a87ae0a7c24b22785d7cf539f755e6cb16c8"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"33a06dcb16e63ddca9cd6c92ac54cfdd8761b574","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"The initial scope of this tutorial is to create a brief walkthrough with some"},{"line_number":5,"context_line":"guidelines and naming conventions for future modules and features aligned with"},{"line_number":6,"context_line":"the composable roles architecture. Regarding the described example in this"},{"line_number":7,"context_line":"tutorial, which leads to align a service implementation with the composable"},{"line_number":8,"context_line":"roles approach, is important to notice that a similar approach would be"},{"line_number":9,"context_line":"followed if a user needed to add an entirely new service to a tripleo deployment."}],"source_content_type":"text/x-rst","patch_set":24,"id":"7aa08908_60636142","line":6,"updated":"2016-06-16 07:39:06.000000000","message":"example described","commit_id":"cf7cfe935aafa436566c056976925db56f690d4c"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"ec62bad7c5a65fa184fb765f55d4ca695c5f2032","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"The initial scope of this tutorial is to create a brief walkthrough with some"},{"line_number":5,"context_line":"guidelines and naming conventions for future modules and features aligned with"},{"line_number":6,"context_line":"the composable roles architecture. Regarding the described example in this"},{"line_number":7,"context_line":"tutorial, which leads to align a service implementation with the composable"},{"line_number":8,"context_line":"roles approach, is important to notice that a similar approach would be"},{"line_number":9,"context_line":"followed if a user needed to add an entirely new service to a tripleo deployment."}],"source_content_type":"text/x-rst","patch_set":24,"id":"7aa08908_8fd5d5e6","line":6,"in_reply_to":"7aa08908_60636142","updated":"2016-06-16 10:14:52.000000000","message":"Done","commit_id":"cf7cfe935aafa436566c056976925db56f690d4c"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"33a06dcb16e63ddca9cd6c92ac54cfdd8761b574","unresolved":false,"context_lines":[{"line_number":4,"context_line":"The initial scope of this tutorial is to create a brief walkthrough with some"},{"line_number":5,"context_line":"guidelines and naming conventions for future modules and features aligned with"},{"line_number":6,"context_line":"the composable roles architecture. Regarding the described example in this"},{"line_number":7,"context_line":"tutorial, which leads to align a service implementation with the composable"},{"line_number":8,"context_line":"roles approach, is important to notice that a similar approach would be"},{"line_number":9,"context_line":"followed if a user needed to add an entirely new service to a tripleo deployment."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-rst","patch_set":24,"id":"7aa08908_00537d6d","line":7,"updated":"2016-06-16 07:39:06.000000000","message":"align an _existing_ \u0027non-composable\u0027 service implementation (that is the point you are making here)","commit_id":"cf7cfe935aafa436566c056976925db56f690d4c"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"ec62bad7c5a65fa184fb765f55d4ca695c5f2032","unresolved":false,"context_lines":[{"line_number":4,"context_line":"The initial scope of this tutorial is to create a brief walkthrough with some"},{"line_number":5,"context_line":"guidelines and naming conventions for future modules and features aligned with"},{"line_number":6,"context_line":"the composable roles architecture. Regarding the described example in this"},{"line_number":7,"context_line":"tutorial, which leads to align a service implementation with the composable"},{"line_number":8,"context_line":"roles approach, is important to notice that a similar approach would be"},{"line_number":9,"context_line":"followed if a user needed to add an entirely new service to a tripleo deployment."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-rst","patch_set":24,"id":"7aa08908_ef10d9ad","line":7,"in_reply_to":"7aa08908_00537d6d","updated":"2016-06-16 10:14:52.000000000","message":"Done","commit_id":"cf7cfe935aafa436566c056976925db56f690d4c"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"33a06dcb16e63ddca9cd6c92ac54cfdd8761b574","unresolved":false,"context_lines":[{"line_number":5,"context_line":"guidelines and naming conventions for future modules and features aligned with"},{"line_number":6,"context_line":"the composable roles architecture. Regarding the described example in this"},{"line_number":7,"context_line":"tutorial, which leads to align a service implementation with the composable"},{"line_number":8,"context_line":"roles approach, is important to notice that a similar approach would be"},{"line_number":9,"context_line":"followed if a user needed to add an entirely new service to a tripleo deployment."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The first step will be to identify and isolate a functionality or feature that"}],"source_content_type":"text/x-rst","patch_set":24,"id":"7aa08908_20731917","line":8,"updated":"2016-06-16 07:39:06.000000000","message":"it is","commit_id":"cf7cfe935aafa436566c056976925db56f690d4c"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"ec62bad7c5a65fa184fb765f55d4ca695c5f2032","unresolved":false,"context_lines":[{"line_number":5,"context_line":"guidelines and naming conventions for future modules and features aligned with"},{"line_number":6,"context_line":"the composable roles architecture. Regarding the described example in this"},{"line_number":7,"context_line":"tutorial, which leads to align a service implementation with the composable"},{"line_number":8,"context_line":"roles approach, is important to notice that a similar approach would be"},{"line_number":9,"context_line":"followed if a user needed to add an entirely new service to a tripleo deployment."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The first step will be to identify and isolate a functionality or feature that"}],"source_content_type":"text/x-rst","patch_set":24,"id":"7aa08908_6f250909","line":8,"in_reply_to":"7aa08908_20731917","updated":"2016-06-16 10:14:52.000000000","message":"Done","commit_id":"cf7cfe935aafa436566c056976925db56f690d4c"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"33a06dcb16e63ddca9cd6c92ac54cfdd8761b574","unresolved":false,"context_lines":[{"line_number":11,"context_line":"The first step will be to identify and isolate a functionality or feature that"},{"line_number":12,"context_line":"needs to be aligned with the composable roles approach. For instance, by"},{"line_number":13,"context_line":"checking ``tripleo-heat-templates/puppet/manifests/overcloud_controller.pp``"},{"line_number":14,"context_line":"and selecting an installed service (i.e. \u0027include ::ntp\u0027)."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":".. _puppet/manifest: https://github.com/openstack/tripleo-heat-templates/tree/3d01f650f18b9e4f1892a6d9aa17f1bfc99b5091/puppet/manifests"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":24,"id":"7aa08908_e08471b2","line":14,"updated":"2016-06-16 07:39:06.000000000","message":"i\u0027d remove this bit; this is something we\u0027re all doing now, because we\u0027re trying to get all the services \u0027migrated\u0027. Or just make this more about the example itself. (just suggestiont) This tutorial walks through the steps needed to \u0027decompose\u0027 the ntp service and remove it from the tripleo-heat-templates puppet manifest at https://github.com/openstack/tripleo-heat-templates/blob/4bd42ea849e6d50d16610377b5e89504f5a4f412/puppet/manifests/overcloud_controller.pp#L31-L33","commit_id":"cf7cfe935aafa436566c056976925db56f690d4c"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"ec62bad7c5a65fa184fb765f55d4ca695c5f2032","unresolved":false,"context_lines":[{"line_number":11,"context_line":"The first step will be to identify and isolate a functionality or feature that"},{"line_number":12,"context_line":"needs to be aligned with the composable roles approach. For instance, by"},{"line_number":13,"context_line":"checking ``tripleo-heat-templates/puppet/manifests/overcloud_controller.pp``"},{"line_number":14,"context_line":"and selecting an installed service (i.e. \u0027include ::ntp\u0027)."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":".. _puppet/manifest: https://github.com/openstack/tripleo-heat-templates/tree/3d01f650f18b9e4f1892a6d9aa17f1bfc99b5091/puppet/manifests"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":24,"id":"7aa08908_0fa1e546","line":14,"in_reply_to":"7aa08908_e08471b2","updated":"2016-06-16 10:14:52.000000000","message":"Done","commit_id":"cf7cfe935aafa436566c056976925db56f690d4c"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"33ec92efef09d26d5269b0f9296009ad25938c24","unresolved":false,"context_lines":[{"line_number":16,"context_line":".. _puppet/manifest: https://github.com/openstack/tripleo-heat-templates/tree/3d01f650f18b9e4f1892a6d9aa17f1bfc99b5091/puppet/manifests"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"The puppet manifests used to configure services on overcloud nodes currently"},{"line_number":19,"context_line":"reside in the tripleo-heat-templates repository, in `puppet/manifest`_"},{"line_number":20,"context_line":"In order to properly organize and structure the code, all"},{"line_number":21,"context_line":"manifests will be re-defined in the puppet-tripleo repository, and adapted to"},{"line_number":22,"context_line":"the `composable services architecture`_"}],"source_content_type":"text/x-rst","patch_set":24,"id":"7aa08908_5233bb62","line":19,"range":{"start_line":19,"start_character":60,"end_line":19,"end_character":68},"updated":"2016-06-15 15:58:51.000000000","message":"puppet/manifests","commit_id":"cf7cfe935aafa436566c056976925db56f690d4c"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"33a06dcb16e63ddca9cd6c92ac54cfdd8761b574","unresolved":false,"context_lines":[{"line_number":16,"context_line":".. _puppet/manifest: https://github.com/openstack/tripleo-heat-templates/tree/3d01f650f18b9e4f1892a6d9aa17f1bfc99b5091/puppet/manifests"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"The puppet manifests used to configure services on overcloud nodes currently"},{"line_number":19,"context_line":"reside in the tripleo-heat-templates repository, in `puppet/manifest`_"},{"line_number":20,"context_line":"In order to properly organize and structure the code, all"},{"line_number":21,"context_line":"manifests will be re-defined in the puppet-tripleo repository, and adapted to"},{"line_number":22,"context_line":"the `composable services architecture`_"}],"source_content_type":"text/x-rst","patch_set":24,"id":"7aa08908_a0b9c97b","line":19,"range":{"start_line":19,"start_character":60,"end_line":19,"end_character":68},"in_reply_to":"7aa08908_5233bb62","updated":"2016-06-16 07:39:06.000000000","message":"+1. also you may need a newline here and don\u0027t forget the fullstop :) cos it renders like:\n\nThe puppet manifests used to configure services on overcloud nodes currently reside in the tripleo-heat-templates repository, in puppet/manifest In order to properly organize and structure the code","commit_id":"cf7cfe935aafa436566c056976925db56f690d4c"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"ec62bad7c5a65fa184fb765f55d4ca695c5f2032","unresolved":false,"context_lines":[{"line_number":16,"context_line":".. _puppet/manifest: https://github.com/openstack/tripleo-heat-templates/tree/3d01f650f18b9e4f1892a6d9aa17f1bfc99b5091/puppet/manifests"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"The puppet manifests used to configure services on overcloud nodes currently"},{"line_number":19,"context_line":"reside in the tripleo-heat-templates repository, in `puppet/manifest`_"},{"line_number":20,"context_line":"In order to properly organize and structure the code, all"},{"line_number":21,"context_line":"manifests will be re-defined in the puppet-tripleo repository, and adapted to"},{"line_number":22,"context_line":"the `composable services architecture`_"}],"source_content_type":"text/x-rst","patch_set":24,"id":"7aa08908_3ae6a1e8","line":19,"range":{"start_line":19,"start_character":60,"end_line":19,"end_character":68},"in_reply_to":"7aa08908_5233bb62","updated":"2016-06-16 10:14:52.000000000","message":"Done","commit_id":"cf7cfe935aafa436566c056976925db56f690d4c"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"ec62bad7c5a65fa184fb765f55d4ca695c5f2032","unresolved":false,"context_lines":[{"line_number":16,"context_line":".. _puppet/manifest: https://github.com/openstack/tripleo-heat-templates/tree/3d01f650f18b9e4f1892a6d9aa17f1bfc99b5091/puppet/manifests"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"The puppet manifests used to configure services on overcloud nodes currently"},{"line_number":19,"context_line":"reside in the tripleo-heat-templates repository, in `puppet/manifest`_"},{"line_number":20,"context_line":"In order to properly organize and structure the code, all"},{"line_number":21,"context_line":"manifests will be re-defined in the puppet-tripleo repository, and adapted to"},{"line_number":22,"context_line":"the `composable services architecture`_"}],"source_content_type":"text/x-rst","patch_set":24,"id":"7aa08908_fa2419b3","line":19,"range":{"start_line":19,"start_character":60,"end_line":19,"end_character":68},"in_reply_to":"7aa08908_a0b9c97b","updated":"2016-06-16 10:14:52.000000000","message":"Done","commit_id":"cf7cfe935aafa436566c056976925db56f690d4c"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"33a06dcb16e63ddca9cd6c92ac54cfdd8761b574","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Also it is important to notice that the NTP puppet module is already included in"},{"line_number":40,"context_line":"the repository tripleo-puppet-elements, so we can use the manifests from NTP in"},{"line_number":41,"context_line":"any node from the overcloud."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"In the case of needing a new third-party puppet module, it should be added in"},{"line_number":44,"context_line":"tripleo-puppet-elements (installed by default in all nodes) and referenced from"}],"source_content_type":"text/x-rst","patch_set":24,"id":"7aa08908_bb1e1e5d","line":41,"updated":"2016-06-16 07:39:06.000000000","message":"Since you mention this, you might want to elaborate a bit more here as it may not be obvious. You could point to it https://github.com/openstack/tripleo-puppet-elements/blob/ff06975baea97c0bc2011224a1b158f92d5a81fa/elements/overcloud-controller/pkg-map#L61 and add a note like \u0027tripleo-puppet-elements (from which the overcloud-full.qcow overcloud node image is created)\u0027, so the ntp package is available on all nodes.","commit_id":"cf7cfe935aafa436566c056976925db56f690d4c"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"ec62bad7c5a65fa184fb765f55d4ca695c5f2032","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Also it is important to notice that the NTP puppet module is already included in"},{"line_number":40,"context_line":"the repository tripleo-puppet-elements, so we can use the manifests from NTP in"},{"line_number":41,"context_line":"any node from the overcloud."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"In the case of needing a new third-party puppet module, it should be added in"},{"line_number":44,"context_line":"tripleo-puppet-elements (installed by default in all nodes) and referenced from"}],"source_content_type":"text/x-rst","patch_set":24,"id":"7aa08908_fa80994b","line":41,"in_reply_to":"7aa08908_bb1e1e5d","updated":"2016-06-16 10:14:52.000000000","message":"Done","commit_id":"cf7cfe935aafa436566c056976925db56f690d4c"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"786d771b84dc610bdaa2e4473b52615893ae247d","unresolved":false,"context_lines":[{"line_number":5,"context_line":"guidelines and naming conventions for future modules and features aligned with"},{"line_number":6,"context_line":"the composable roles architecture. Regarding the example described in this"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"tutorial, which leads to align an _existing_ \u0027non-composable\u0027 service implementation"},{"line_number":9,"context_line":"with the composable roles approach, it is important to notice that a similar approach would be"},{"line_number":10,"context_line":"followed if a user needed to add an entirely new service to a tripleo deployment."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-rst","patch_set":25,"id":"7aa08908_15338114","line":8,"updated":"2016-06-17 07:08:03.000000000","message":"nit, extra newline here\n\"\nRegarding the example described in this\n\ntutorial, which leads to align an _existing_ ‘non-composable’ service implementation with the composable roles approach, i\n\"","commit_id":"a73adb2c488d87f6a8a19d9f56ac36bb2008a2b0"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"391dfc39769fc83bbe61efb3300214d3bd97541f","unresolved":false,"context_lines":[{"line_number":5,"context_line":"guidelines and naming conventions for future modules and features aligned with"},{"line_number":6,"context_line":"the composable roles architecture. Regarding the example described in this"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"tutorial, which leads to align an _existing_ \u0027non-composable\u0027 service implementation"},{"line_number":9,"context_line":"with the composable roles approach, it is important to notice that a similar approach would be"},{"line_number":10,"context_line":"followed if a user needed to add an entirely new service to a tripleo deployment."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-rst","patch_set":25,"id":"7aa08908_5804157d","line":8,"in_reply_to":"7aa08908_15338114","updated":"2016-06-17 12:10:23.000000000","message":"Done","commit_id":"a73adb2c488d87f6a8a19d9f56ac36bb2008a2b0"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"786d771b84dc610bdaa2e4473b52615893ae247d","unresolved":false,"context_lines":[{"line_number":39,"context_line":"the tripleo-puppet-elements repository, so we can use the NTP manifests from"},{"line_number":40,"context_line":"node from the overcloud. For example, the `NTP`_ manifest reference is included"},{"line_number":41,"context_line":"in \u0027tripleo-puppet-elements (from which the overcloud-full.qcow overcloud node"},{"line_number":42,"context_line":"image is created)\u0027, so the ntp package will be available on all nodes."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"In the case of needing a new third-party puppet module, it should be added in"},{"line_number":45,"context_line":"tripleo-puppet-elements (installed by default in all nodes) and referenced from"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7aa08908_d88ad063","line":42,"updated":"2016-06-17 07:08:03.000000000","message":"just want to check clarify something cos this reads a bit weird now. Since you mentioned t-p-e I thought you were talking about the ntp package, which is why I pointed at the t-p-e for that. \n\nIf you mean the actual puppet-ntp puppet module, I believe we are consuming that from https://github.com/redhat-openstack/openstack-puppet-modules/tree/ab63b3886cf0b5e9bdb0a83322ba9b4af201dee3/ntp (so you should talk about adding your required puppet-module in the openstack-puppet-modules and make sure the package for that service is installed on the nodes you want it on with the t-p-e change)","commit_id":"a73adb2c488d87f6a8a19d9f56ac36bb2008a2b0"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"391dfc39769fc83bbe61efb3300214d3bd97541f","unresolved":false,"context_lines":[{"line_number":39,"context_line":"the tripleo-puppet-elements repository, so we can use the NTP manifests from"},{"line_number":40,"context_line":"node from the overcloud. For example, the `NTP`_ manifest reference is included"},{"line_number":41,"context_line":"in \u0027tripleo-puppet-elements (from which the overcloud-full.qcow overcloud node"},{"line_number":42,"context_line":"image is created)\u0027, so the ntp package will be available on all nodes."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"In the case of needing a new third-party puppet module, it should be added in"},{"line_number":45,"context_line":"tripleo-puppet-elements (installed by default in all nodes) and referenced from"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7aa08908_e5543555","line":42,"in_reply_to":"7aa08908_d88ad063","updated":"2016-06-17 12:10:23.000000000","message":"I think I got it this time (Too many repos).","commit_id":"a73adb2c488d87f6a8a19d9f56ac36bb2008a2b0"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"786d771b84dc610bdaa2e4473b52615893ae247d","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"In the case of needing a new third-party puppet module, it should be added in"},{"line_number":45,"context_line":"tripleo-puppet-elements (installed by default in all nodes) and referenced from"},{"line_number":46,"context_line":"a puppet manifest in puppet-tripleo."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"This tutorial is divided into several steps, according to different changes"},{"line_number":49,"context_line":"that need to be added to the structure of tripleo-heat-templates and"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7aa08908_38cf94b4","line":46,"updated":"2016-06-17 07:08:03.000000000","message":"do you mean openstack-puppet-modules here as above","commit_id":"a73adb2c488d87f6a8a19d9f56ac36bb2008a2b0"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"391dfc39769fc83bbe61efb3300214d3bd97541f","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"In the case of needing a new third-party puppet module, it should be added in"},{"line_number":45,"context_line":"tripleo-puppet-elements (installed by default in all nodes) and referenced from"},{"line_number":46,"context_line":"a puppet manifest in puppet-tripleo."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"This tutorial is divided into several steps, according to different changes"},{"line_number":49,"context_line":"that need to be added to the structure of tripleo-heat-templates and"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7aa08908_68badce2","line":46,"in_reply_to":"7aa08908_38cf94b4","updated":"2016-06-17 12:10:23.000000000","message":"Done","commit_id":"a73adb2c488d87f6a8a19d9f56ac36bb2008a2b0"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"25690fd584a8c542a5d08f825dd45956dbbb5e0f","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"In the case of needing a new third-party puppet module, it should be added in"},{"line_number":45,"context_line":"tripleo-puppet-elements (installed by default in all nodes) and referenced from"},{"line_number":46,"context_line":"a puppet manifest in puppet-tripleo."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"This tutorial is divided into several steps, according to different changes"},{"line_number":49,"context_line":"that need to be added to the structure of tripleo-heat-templates and"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7aa08908_d3459143","line":46,"in_reply_to":"7aa08908_38cf94b4","updated":"2016-06-17 07:30:22.000000000","message":"So, i think you did mean openstack-puppet-modules like at https://github.com/openstack/tripleo-puppet-elements/blob/master/elements/puppet-modules/source-repository-puppet-modules for a source install. But for a package install in that case it pulls in the openstack-puppet-modules https://github.com/openstack/tripleo-puppet-elements/blob/master/elements/puppet-modules/pkg-map","commit_id":"a73adb2c488d87f6a8a19d9f56ac36bb2008a2b0"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"391dfc39769fc83bbe61efb3300214d3bd97541f","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"In the case of needing a new third-party puppet module, it should be added in"},{"line_number":45,"context_line":"tripleo-puppet-elements (installed by default in all nodes) and referenced from"},{"line_number":46,"context_line":"a puppet manifest in puppet-tripleo."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"This tutorial is divided into several steps, according to different changes"},{"line_number":49,"context_line":"that need to be added to the structure of tripleo-heat-templates and"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7aa08908_48bf20d0","line":46,"in_reply_to":"7aa08908_d3459143","updated":"2016-06-17 12:10:23.000000000","message":"Done","commit_id":"a73adb2c488d87f6a8a19d9f56ac36bb2008a2b0"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"786d771b84dc610bdaa2e4473b52615893ae247d","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"- puppet-tripleo: Custom TripleO puppet manifests to deploy the overcloud."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"- tripleo-puppet-elements: third-party puppet modules. (Not used in this"},{"line_number":60,"context_line":"  tutorial, but needs to be used for adding additional puppet modules.)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Gerrit patches used in this example"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7aa08908_b871c479","line":59,"updated":"2016-06-17 07:08:03.000000000","message":"Do you mean t-p-e or o-p-m or both :)","commit_id":"a73adb2c488d87f6a8a19d9f56ac36bb2008a2b0"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"391dfc39769fc83bbe61efb3300214d3bd97541f","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"- puppet-tripleo: Custom TripleO puppet manifests to deploy the overcloud."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"- tripleo-puppet-elements: third-party puppet modules. (Not used in this"},{"line_number":60,"context_line":"  tutorial, but needs to be used for adding additional puppet modules.)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Gerrit patches used in this example"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7aa08908_e8cecc81","line":59,"in_reply_to":"7aa08908_b871c479","updated":"2016-06-17 12:10:23.000000000","message":"Done","commit_id":"a73adb2c488d87f6a8a19d9f56ac36bb2008a2b0"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"1e13016f263d1fe83882a7dba7118bb073d90f18","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Also it is important to notice that the NTP puppet module can be pulled from"},{"line_number":38,"context_line":"different sources depending if it will be used from a package or a source install."},{"line_number":39,"context_line":"In the case of a `package install`_ the package will be pulled from the openstack-puppet-modules repository."},{"line_number":40,"context_line":"If installed from a `source install`_ the sources will be pulled from the tripleo-puppet-elements repository."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":29,"id":"3aaa91ec_3f2b4f84","line":39,"updated":"2016-06-22 07:01:40.000000000","message":"may want to clarify here - or again, I wouldn\u0027t be against removing this paragraph altogether (not sure it adds much here)- after out chat with emilien yesterday - we no longer use o-p-m (sorry, that is my fault outdated understanding), and indeed https://github.com/redhat-openstack/openstack-puppet-modules/tree/master points to rdo.\n\nFor source it is as below, and we then use the file you point at to resolve to puppetlabs-ntp for the puppet-ntp module","commit_id":"a1bd382750c50eac675996bad6871e4e97d94a27"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"a9625c13fcc8798d8745246a92e7d75ec7d4a408","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Also it is important to notice that the NTP puppet module can be pulled from"},{"line_number":38,"context_line":"different sources depending if it will be used from a package or a source install."},{"line_number":39,"context_line":"In the case of a `package install`_ the package will be pulled from the openstack-puppet-modules repository."},{"line_number":40,"context_line":"If installed from a `source install`_ the sources will be pulled from the tripleo-puppet-elements repository."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":29,"id":"3aaa91ec_fdc6af47","line":39,"in_reply_to":"3aaa91ec_3f2b4f84","updated":"2016-06-23 08:06:35.000000000","message":"Hey Marios yesterday I was thinking about the best way of addressing this, and the final goal isn\u0027t to create more confusion. So I will remove this paragraph and we can add it latter on.","commit_id":"a1bd382750c50eac675996bad6871e4e97d94a27"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"965a77ed5bdabced395c1095b7d92a6818e44bcd","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Also it is important to notice that the NTP puppet module can be pulled from"},{"line_number":38,"context_line":"different sources depending if it will be used from a package or a source install."},{"line_number":39,"context_line":"In the case of a `package install`_ the package will be pulled from the openstack-puppet-modules repository."},{"line_number":40,"context_line":"If installed from a `source install`_ the sources will be pulled from the tripleo-puppet-elements repository."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":29,"id":"3aaa91ec_7fe2f704","line":39,"in_reply_to":"3aaa91ec_3f2b4f84","updated":"2016-06-22 07:06:11.000000000","message":"sorry.. the \u0027not sure it adds much here\u0027 was a bit strong... I guess the point you\u0027re really trying to make here is, when looking at adding composable service foo, you will need to make sure that you have foo installed as a service on the node; I think that is what you originally had here (wrt the ntp package itself if I recall). In which case you\u0027d point to openstack-puppet-modules to include the package in the overcloud-full.qcow2 image build.\n\nOnce you\u0027ve done that, you also need to make sure you can configure service foo using puppet, and the puppet-foo module. This part is what the text above, is now about. So, when I said remove alltogether, I really meant to say, you aren\u0027t including all the information here that I think you originally intended to. I leave it up to you if you want to include that info here or in another section (here is fine too imo, or not at all, just suggestion)","commit_id":"a1bd382750c50eac675996bad6871e4e97d94a27"},{"author":{"_account_id":7294,"name":"Leif Madsen","email":"lmadsen@redhat.com","username":"leifmadsen"},"change_message_id":"32ba642aeea27f36a2b635a53bab2773f4069b83","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Also it is important to notice that the NTP puppet module can be pulled from"},{"line_number":38,"context_line":"different sources depending if it will be used from a package or a source install."},{"line_number":39,"context_line":"In the case of a `package install`_ the package will be pulled from the openstack-puppet-modules repository."},{"line_number":40,"context_line":"If installed from a `source install`_ the sources will be pulled from the tripleo-puppet-elements repository."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":29,"id":"3aaa91ec_cc6d3606","line":39,"in_reply_to":"3aaa91ec_7fe2f704","updated":"2016-06-22 13:01:17.000000000","message":"Actually just reading this comment actually clued in a bit more about how this is generally going to work (and mind you, I haven\u0027t spent significant time studying the entire text), but that point around requiring the puppet module to be included in the overcloud-full image build really gave me a bit of an a-ha moment around tying things in my head.\n\nNot sure it makes sense here or somewhere else, but I think explicitly stating something like that would be useful for people to tie the pieces together.","commit_id":"a1bd382750c50eac675996bad6871e4e97d94a27"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"a9625c13fcc8798d8745246a92e7d75ec7d4a408","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Also it is important to notice that the NTP puppet module can be pulled from"},{"line_number":38,"context_line":"different sources depending if it will be used from a package or a source install."},{"line_number":39,"context_line":"In the case of a `package install`_ the package will be pulled from the openstack-puppet-modules repository."},{"line_number":40,"context_line":"If installed from a `source install`_ the sources will be pulled from the tripleo-puppet-elements repository."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":29,"id":"3aaa91ec_5dc6e348","line":39,"in_reply_to":"3aaa91ec_7fe2f704","updated":"2016-06-23 08:06:35.000000000","message":"Done","commit_id":"a1bd382750c50eac675996bad6871e4e97d94a27"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"a9625c13fcc8798d8745246a92e7d75ec7d4a408","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Also it is important to notice that the NTP puppet module can be pulled from"},{"line_number":38,"context_line":"different sources depending if it will be used from a package or a source install."},{"line_number":39,"context_line":"In the case of a `package install`_ the package will be pulled from the openstack-puppet-modules repository."},{"line_number":40,"context_line":"If installed from a `source install`_ the sources will be pulled from the tripleo-puppet-elements repository."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":29,"id":"3aaa91ec_5ddd430d","line":39,"in_reply_to":"3aaa91ec_cc6d3606","updated":"2016-06-23 08:06:35.000000000","message":"I will fix it in a next iteration.","commit_id":"a1bd382750c50eac675996bad6871e4e97d94a27"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"e8cb69da268d841ce8e2e877d0230ea005be7dba","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Also it is important to notice that the NTP puppet module can be pulled from"},{"line_number":38,"context_line":"different sources depending if it will be used from a package or a source install."},{"line_number":39,"context_line":"In the case of a `package install`_ the package will be pulled from the openstack-puppet-modules repository."},{"line_number":40,"context_line":"If installed from a `source install`_ the sources will be pulled from the tripleo-puppet-elements repository."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":29,"id":"3aaa91ec_af9a2e61","line":39,"in_reply_to":"3aaa91ec_fdc6af47","updated":"2016-06-23 08:25:07.000000000","message":"thanks Carlos and Leif - removing wfm for now... perhaps someone can add this comment into the doc as an iteration. OR, perhaps we have a gap in our docs and this could be the start of a new section? anyway, Leif thanks for taking the time to comment and welcome :)","commit_id":"a1bd382750c50eac675996bad6871e4e97d94a27"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"c9a4e8c9a560538fc58fdb281c629a70e0f97f9e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"the composable roles architecture. Regarding the example described in this"},{"line_number":7,"context_line":"tutorial, which leads to align an _existing_ \u0027non-composable\u0027 service implementation"},{"line_number":8,"context_line":"with the composable roles approach, it is important to notice that a similar approach would be"},{"line_number":9,"context_line":"followed if a user needed to add an entirely new service to a tripleo deployment."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":".. _puppet/manifests: https://github.com/openstack/tripleo-heat-templates/tree/3d01f650f18b9e4f1892a6d9aa17f1bfc99b5091/puppet/manifests"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_c1a742a5","line":9,"range":{"start_line":9,"start_character":49,"end_line":9,"end_character":56},"updated":"2016-06-30 10:10:39.000000000","message":"This is fine for a first pass, but I think pretty soon (when all the refactoring is completed) we\u0027ll need to rework this to only describe this in terms of integrating a new service.","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"8bd8802106afad25b4dcda5cebf8c9cdb3d9dc8a","unresolved":false,"context_lines":[{"line_number":6,"context_line":"the composable roles architecture. Regarding the example described in this"},{"line_number":7,"context_line":"tutorial, which leads to align an _existing_ \u0027non-composable\u0027 service implementation"},{"line_number":8,"context_line":"with the composable roles approach, it is important to notice that a similar approach would be"},{"line_number":9,"context_line":"followed if a user needed to add an entirely new service to a tripleo deployment."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":".. _puppet/manifests: https://github.com/openstack/tripleo-heat-templates/tree/3d01f650f18b9e4f1892a6d9aa17f1bfc99b5091/puppet/manifests"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_96a88922","line":9,"range":{"start_line":9,"start_character":49,"end_line":9,"end_character":56},"in_reply_to":"3aaa91ec_c1a742a5","updated":"2016-07-01 16:09:27.000000000","message":"Added as a TODO trello card.","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"c9a4e8c9a560538fc58fdb281c629a70e0f97f9e","unresolved":false,"context_lines":[{"line_number":77,"context_line":".. note::"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"  Additional Heat features must be defined in order to apply the same behaviour"},{"line_number":80,"context_line":"  to other roles (compute, storage). Current work defined in:"},{"line_number":81,"context_line":"  https://etherpad.openstack.org/p/tripleo-composable-services"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_41b232e6","line":80,"range":{"start_line":80,"start_character":27,"end_line":80,"end_character":34},"updated":"2016-06-30 10:10:39.000000000","message":"I\u0027m not sure this is accurate - what heat features are we blocked on?","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"8bd8802106afad25b4dcda5cebf8c9cdb3d9dc8a","unresolved":false,"context_lines":[{"line_number":77,"context_line":".. note::"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"  Additional Heat features must be defined in order to apply the same behaviour"},{"line_number":80,"context_line":"  to other roles (compute, storage). Current work defined in:"},{"line_number":81,"context_line":"  https://etherpad.openstack.org/p/tripleo-composable-services"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_f6462d7a","line":80,"range":{"start_line":80,"start_character":27,"end_line":80,"end_character":34},"in_reply_to":"3aaa91ec_41b232e6","updated":"2016-07-01 16:09:27.000000000","message":"Note not needed anymore.","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"}],"doc/source/tht_walkthrough/tht_walkthrough.rst":[{"author":{"_account_id":7294,"name":"Leif Madsen","email":"lmadsen@redhat.com","username":"leifmadsen"},"change_message_id":"93499d7a310545bdd28658c6ebb32fe225edaaa4","unresolved":false,"context_lines":[{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"This guide will be a walkthrough related to how to add new services"},{"line_number":5,"context_line":"to TripleO main repository tripleo-heat-templates)"},{"line_number":6,"context_line":"using part of the architecture already defined"},{"line_number":7,"context_line":"in https://blueprints.launchpad.net/tripleo/+spec/composable-services-within-roles"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_6013290e","line":5,"range":{"start_line":5,"start_character":27,"end_line":5,"end_character":28},"updated":"2016-05-19 20:12:18.000000000","message":"(t","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"82918dc7a313357cdfb9b4009b81ecf2ee61d3c6","unresolved":false,"context_lines":[{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"This guide will be a walkthrough related to how to add new services"},{"line_number":5,"context_line":"to TripleO main repository tripleo-heat-templates)"},{"line_number":6,"context_line":"using part of the architecture already defined"},{"line_number":7,"context_line":"in https://blueprints.launchpad.net/tripleo/+spec/composable-services-within-roles"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_d233b260","line":5,"range":{"start_line":5,"start_character":27,"end_line":5,"end_character":28},"in_reply_to":"bab6814e_6013290e","updated":"2016-05-20 08:32:58.000000000","message":"Done","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b3769cb2fa7e3b3fe99942115c0b3f25877183ad","unresolved":false,"context_lines":[{"line_number":4,"context_line":"This guide will be a walkthrough related to how to add new services to TripleO"},{"line_number":5,"context_line":"main repository (tripleo-heat-templates) using part of the architecture already"},{"line_number":6,"context_line":"defined in"},{"line_number":7,"context_line":"https://blueprints.launchpad.net/tripleo/+spec/composable-services-within-roles"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":".. include:: introduction.rst"}],"source_content_type":"text/x-rst","patch_set":19,"id":"bab6814e_0127a6ca","line":7,"updated":"2016-05-26 08:25:50.000000000","message":"make it an href/link - you are using it in a couple places\n\ndefined in `composable services spec`_\n\n\n.. _composable services spec: https://blueprints.launchpad.net/tripleo/+spec/composable-services-within-roles","commit_id":"450e2fbb2c050339fceda5e76b74ec46f52ecd0f"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"71b7b21687bea364480b009af0c0c75bcf7eeaed","unresolved":false,"context_lines":[{"line_number":4,"context_line":"This guide will be a walkthrough related to how to add new services to TripleO"},{"line_number":5,"context_line":"main repository (tripleo-heat-templates) using part of the architecture already"},{"line_number":6,"context_line":"defined in"},{"line_number":7,"context_line":"https://blueprints.launchpad.net/tripleo/+spec/composable-services-within-roles"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":".. include:: introduction.rst"}],"source_content_type":"text/x-rst","patch_set":19,"id":"bab6814e_27491ab8","line":7,"in_reply_to":"bab6814e_0127a6ca","updated":"2016-05-26 08:48:07.000000000","message":"Done","commit_id":"450e2fbb2c050339fceda5e76b74ec46f52ecd0f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"cd44025376aabf204b97091bc3beed9543de81dc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Composable roles tutorial"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"This guide will be a walkthrough related to how to add new services to TripleO"},{"line_number":5,"context_line":"main repository (tripleo-heat-templates) using part of the architecture already"},{"line_number":6,"context_line":"defined in"},{"line_number":7,"context_line":".. _composable services spec:"}],"source_content_type":"text/x-rst","patch_set":21,"id":"7aa08908_6dd4d546","line":4,"updated":"2016-06-07 08:10:40.000000000","message":"I think tripleo-heat-templates is definitely important as it is where we define what the deployment will look like, however I\u0027d avoid calling it the \u0027TripleO main repository\u0027. Also puppet-tripleo comes into play here as you note elsewhere.\n\nI generated the docs and this is the at the top of the page which is why I noticed it mostly.\n\ne.g.\n\nadd new services to a tripleo overcloud deployment, through additions to the tripleo-heat-templates and puppet-tripleo repositories.","commit_id":"bcb1a87ae0a7c24b22785d7cf539f755e6cb16c8"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"f9fdcdd224a5351f279cf5e33c70a8abfcc45c7e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Composable roles tutorial"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"This guide will be a walkthrough related to how to add new services to TripleO"},{"line_number":5,"context_line":"main repository (tripleo-heat-templates) using part of the architecture already"},{"line_number":6,"context_line":"defined in"},{"line_number":7,"context_line":".. _composable services spec:"}],"source_content_type":"text/x-rst","patch_set":21,"id":"7aa08908_d9cb0ba4","line":4,"in_reply_to":"7aa08908_6dd4d546","updated":"2016-06-07 09:01:16.000000000","message":"Done","commit_id":"bcb1a87ae0a7c24b22785d7cf539f755e6cb16c8"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"cd44025376aabf204b97091bc3beed9543de81dc","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"This guide will be a walkthrough related to how to add new services to TripleO"},{"line_number":5,"context_line":"main repository (tripleo-heat-templates) using part of the architecture already"},{"line_number":6,"context_line":"defined in"},{"line_number":7,"context_line":".. _composable services spec:"},{"line_number":8,"context_line":"https://blueprints.launchpad.net/tripleo/+spec/composable-services-within-roles"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-rst","patch_set":21,"id":"7aa08908_4df3d9d6","line":6,"updated":"2016-06-07 08:10:40.000000000","message":"here put `composable services spec`_","commit_id":"bcb1a87ae0a7c24b22785d7cf539f755e6cb16c8"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"f9fdcdd224a5351f279cf5e33c70a8abfcc45c7e","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"This guide will be a walkthrough related to how to add new services to TripleO"},{"line_number":5,"context_line":"main repository (tripleo-heat-templates) using part of the architecture already"},{"line_number":6,"context_line":"defined in"},{"line_number":7,"context_line":".. _composable services spec:"},{"line_number":8,"context_line":"https://blueprints.launchpad.net/tripleo/+spec/composable-services-within-roles"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-rst","patch_set":21,"id":"7aa08908_1915933f","line":6,"in_reply_to":"7aa08908_4df3d9d6","updated":"2016-06-07 09:01:16.000000000","message":"Done","commit_id":"bcb1a87ae0a7c24b22785d7cf539f755e6cb16c8"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"cd44025376aabf204b97091bc3beed9543de81dc","unresolved":false,"context_lines":[{"line_number":5,"context_line":"main repository (tripleo-heat-templates) using part of the architecture already"},{"line_number":6,"context_line":"defined in"},{"line_number":7,"context_line":".. _composable services spec:"},{"line_number":8,"context_line":"https://blueprints.launchpad.net/tripleo/+spec/composable-services-within-roles"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":".. include:: introduction.rst"}],"source_content_type":"text/x-rst","patch_set":21,"id":"7aa08908_0dd0b11e","line":8,"updated":"2016-06-07 08:10:40.000000000","message":"move this to the end, after the ../ includes and have it on one line like\n\n.. _composable services spec: https://blueprints.launchpad.net/tripleo/+spec/composable-services-within-roles\n\n\nand the link works","commit_id":"bcb1a87ae0a7c24b22785d7cf539f755e6cb16c8"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"f9fdcdd224a5351f279cf5e33c70a8abfcc45c7e","unresolved":false,"context_lines":[{"line_number":5,"context_line":"main repository (tripleo-heat-templates) using part of the architecture already"},{"line_number":6,"context_line":"defined in"},{"line_number":7,"context_line":".. _composable services spec:"},{"line_number":8,"context_line":"https://blueprints.launchpad.net/tripleo/+spec/composable-services-within-roles"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":".. include:: introduction.rst"}],"source_content_type":"text/x-rst","patch_set":21,"id":"7aa08908_d90aeb20","line":8,"in_reply_to":"7aa08908_0dd0b11e","updated":"2016-06-07 09:01:16.000000000","message":"I added the reference at the beginning of the file as I\u0027m calling it from other files also.\nDone","commit_id":"bcb1a87ae0a7c24b22785d7cf539f755e6cb16c8"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d72e96163064ab028c0652680d4072439efe7a95","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":".. include:: introduction.rst"},{"line_number":13,"context_line":".. include:: changes-tht.rst"},{"line_number":14,"context_line":".. include:: changes-puppet-tripleo.rst"},{"line_number":15,"context_line":".. include:: tips.rst"},{"line_number":16,"context_line":".. include:: design-patterns.rst"},{"line_number":17,"context_line":".. include:: summary.rst"}],"source_content_type":"text/x-rst","patch_set":28,"id":"5a9d85d2_f3b43af3","line":14,"range":{"start_line":14,"start_character":22,"end_line":14,"end_character":23},"updated":"2016-06-21 09:27:36.000000000","message":"so imo I would still incldue all the puppet-tripleo examples but perhaps add a note saying something like:\n\nthe example review initially moved the ntp puppet configuration to puppet-tripleo, which is the established pattern for the composable roles architecture. However during the review process it became evident that there wasn\u0027t really a need for a stand-alone puppet-tripleo ntp class, since we could include all the config on the tht side.  https://review.openstack.org/#/c/310421/44/puppet/services/time/ntp.yaml\n\nThe puppet-tripleo review  was ultimately abandoned https://review.openstack.org/#/c/310725/40/manifests/profile/base/time/ntp.pp, but it is referenced here to illustrate the established pattern for composable services; that is to move all the service specific config to a stand-alone file in the puppet/services directory of the tripleo-heat-templates and move any puppet specific config to dedicated puppet-tripleo service classes.","commit_id":"61ecc552977f04538cc80931363da0960d4e1f0e"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"95998727d55cbfb624262f44c0a42876f4bc2805","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":".. include:: introduction.rst"},{"line_number":13,"context_line":".. include:: changes-tht.rst"},{"line_number":14,"context_line":".. include:: changes-puppet-tripleo.rst"},{"line_number":15,"context_line":".. include:: tips.rst"},{"line_number":16,"context_line":".. include:: design-patterns.rst"},{"line_number":17,"context_line":".. include:: summary.rst"}],"source_content_type":"text/x-rst","patch_set":28,"id":"5a9d85d2_47f8e449","line":14,"range":{"start_line":14,"start_character":22,"end_line":14,"end_character":23},"in_reply_to":"5a9d85d2_f3b43af3","updated":"2016-06-21 10:46:30.000000000","message":"You are right!\nFiiiiixed :)","commit_id":"61ecc552977f04538cc80931363da0960d4e1f0e"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"c9a4e8c9a560538fc58fdb281c629a70e0f97f9e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Composable roles tutorial"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":".. _composable services architecture: https://blueprints.launchpad.net/tripleo/+spec/composable-services-within-roles"}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_61e48edf","line":1,"range":{"start_line":1,"start_character":17,"end_line":1,"end_character":25},"updated":"2016-06-30 10:10:39.000000000","message":"This should be composable services I think, folks will get confused re fully composable/custom roles otherwise.","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"8bd8802106afad25b4dcda5cebf8c9cdb3d9dc8a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Composable roles tutorial"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":".. _composable services architecture: https://blueprints.launchpad.net/tripleo/+spec/composable-services-within-roles"}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_76019d06","line":1,"range":{"start_line":1,"start_character":17,"end_line":1,"end_character":25},"in_reply_to":"3aaa91ec_61e48edf","updated":"2016-07-01 16:09:27.000000000","message":"Agreed","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"c9a4e8c9a560538fc58fdb281c629a70e0f97f9e","unresolved":false,"context_lines":[{"line_number":12,"context_line":".. note::"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"  Several reviews were used in favor of creating this tutorial, even so, when stablishing the patterns"},{"line_number":15,"context_line":"  for the composable roles architecture, it became evident that there is no need for a stand-alone"},{"line_number":16,"context_line":"  puppet-tripleo ntp class, since we could include all the config on the tripleo-heat-templates side"},{"line_number":17,"context_line":"  https://review.openstack.org/#/c/310421/44/puppet/services/time/ntp.yaml."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_01314a5a","line":15,"range":{"start_line":15,"start_character":21,"end_line":15,"end_character":26},"updated":"2016-06-30 10:10:39.000000000","message":"composable services and s/stablishing/establishing\n\nAlso I\u0027d say \"used in the process of creating this tutorial\"","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"8bd8802106afad25b4dcda5cebf8c9cdb3d9dc8a","unresolved":false,"context_lines":[{"line_number":12,"context_line":".. note::"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"  Several reviews were used in favor of creating this tutorial, even so, when stablishing the patterns"},{"line_number":15,"context_line":"  for the composable roles architecture, it became evident that there is no need for a stand-alone"},{"line_number":16,"context_line":"  puppet-tripleo ntp class, since we could include all the config on the tripleo-heat-templates side"},{"line_number":17,"context_line":"  https://review.openstack.org/#/c/310421/44/puppet/services/time/ntp.yaml."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_091e3e5f","line":15,"range":{"start_line":15,"start_character":21,"end_line":15,"end_character":26},"in_reply_to":"3aaa91ec_01314a5a","updated":"2016-07-01 16:09:27.000000000","message":"Done","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"c9a4e8c9a560538fc58fdb281c629a70e0f97f9e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  The puppet-tripleo review  was ultimately abandoned https://review.openstack.org/#/c/310725/40/manifests/profile/base/time/ntp.pp,"},{"line_number":20,"context_line":"  but it is referenced here to illustrate the established pattern for composable services; that is to move all the service specific"},{"line_number":21,"context_line":"  config to a stand-alone file in the puppet/services directory of the tripleo-heat-templates and move any puppet specific config"},{"line_number":22,"context_line":"  to dedicated puppet-tripleo service classes."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":".. note::"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_61800ec0","line":22,"range":{"start_line":22,"start_character":22,"end_line":22,"end_character":29},"updated":"2016-06-30 10:10:39.000000000","message":"Hmm - I\u0027m not sure these two paragraphs add that much - is this historical commentary/discussion helpful in our formal docs, or will it just cause confusion?","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"8bd8802106afad25b4dcda5cebf8c9cdb3d9dc8a","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  The puppet-tripleo review  was ultimately abandoned https://review.openstack.org/#/c/310725/40/manifests/profile/base/time/ntp.pp,"},{"line_number":20,"context_line":"  but it is referenced here to illustrate the established pattern for composable services; that is to move all the service specific"},{"line_number":21,"context_line":"  config to a stand-alone file in the puppet/services directory of the tripleo-heat-templates and move any puppet specific config"},{"line_number":22,"context_line":"  to dedicated puppet-tripleo service classes."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":".. note::"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_29917a9b","line":22,"range":{"start_line":22,"start_character":22,"end_line":22,"end_character":29},"in_reply_to":"3aaa91ec_61800ec0","updated":"2016-07-01 16:09:27.000000000","message":"Agreed, might cause confusion.","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"}],"doc/source/tht_walkthrough/tips.rst":[{"author":{"_account_id":7294,"name":"Leif Madsen","email":"lmadsen@redhat.com","username":"leifmadsen"},"change_message_id":"93499d7a310545bdd28658c6ebb32fe225edaaa4","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When adding new features to THT, in some cases dependencies should be merged first in order to test newer patches,"},{"line_number":10,"context_line":"with the following procedure, the user will be able to create the overcloud images using WorkInProgress patches"},{"line_number":11,"context_line":"from gerrit code review without having them merged (For CI testing purposes)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"If used third party repos included in the overcloud image, like i.e. the puppet-tripleo repository,"},{"line_number":14,"context_line":"your changes will not be available by default in the overcloud until you write them in the overcloud"}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_a01cf113","line":11,"range":{"start_line":11,"start_character":52,"end_line":11,"end_character":53},"updated":"2016-05-19 20:12:18.000000000","message":"f","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"82918dc7a313357cdfb9b4009b81ecf2ee61d3c6","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When adding new features to THT, in some cases dependencies should be merged first in order to test newer patches,"},{"line_number":10,"context_line":"with the following procedure, the user will be able to create the overcloud images using WorkInProgress patches"},{"line_number":11,"context_line":"from gerrit code review without having them merged (For CI testing purposes)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"If used third party repos included in the overcloud image, like i.e. the puppet-tripleo repository,"},{"line_number":14,"context_line":"your changes will not be available by default in the overcloud until you write them in the overcloud"}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_b238ae3e","line":11,"range":{"start_line":11,"start_character":52,"end_line":11,"end_character":53},"in_reply_to":"bab6814e_a01cf113","updated":"2016-05-20 08:32:58.000000000","message":"Done","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":7294,"name":"Leif Madsen","email":"lmadsen@redhat.com","username":"leifmadsen"},"change_message_id":"93499d7a310545bdd28658c6ebb32fe225edaaa4","unresolved":false,"context_lines":[{"line_number":10,"context_line":"with the following procedure, the user will be able to create the overcloud images using WorkInProgress patches"},{"line_number":11,"context_line":"from gerrit code review without having them merged (For CI testing purposes)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"If used third party repos included in the overcloud image, like i.e. the puppet-tripleo repository,"},{"line_number":14,"context_line":"your changes will not be available by default in the overcloud until you write them in the overcloud"},{"line_number":15,"context_line":"image (By default is: overcloud-full.qcow2)"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_e016f9ef","line":13,"range":{"start_line":13,"start_character":3,"end_line":13,"end_character":7},"updated":"2016-05-19 20:12:18.000000000","message":"using","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"82918dc7a313357cdfb9b4009b81ecf2ee61d3c6","unresolved":false,"context_lines":[{"line_number":10,"context_line":"with the following procedure, the user will be able to create the overcloud images using WorkInProgress patches"},{"line_number":11,"context_line":"from gerrit code review without having them merged (For CI testing purposes)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"If used third party repos included in the overcloud image, like i.e. the puppet-tripleo repository,"},{"line_number":14,"context_line":"your changes will not be available by default in the overcloud until you write them in the overcloud"},{"line_number":15,"context_line":"image (By default is: overcloud-full.qcow2)"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_d258d28c","line":13,"range":{"start_line":13,"start_character":3,"end_line":13,"end_character":7},"in_reply_to":"bab6814e_e016f9ef","updated":"2016-05-20 08:32:58.000000000","message":"Done","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":7294,"name":"Leif Madsen","email":"lmadsen@redhat.com","username":"leifmadsen"},"change_message_id":"93499d7a310545bdd28658c6ebb32fe225edaaa4","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"In order to avoid noise on IRC, it is possible to clone puppet-tripleo"},{"line_number":31,"context_line":"and apply the changes from your github account."},{"line_number":32,"context_line":"In some cases this is particular useful as there is no need to update the patchset number."},{"line_number":33,"context_line":"::"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  export DIB_INSTALLTYPE_puppet_tripleo\u003dsource"}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_20be41d4","line":32,"range":{"start_line":32,"start_character":22,"end_line":32,"end_character":32},"updated":"2016-05-19 20:12:18.000000000","message":"particularly","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"82918dc7a313357cdfb9b4009b81ecf2ee61d3c6","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"In order to avoid noise on IRC, it is possible to clone puppet-tripleo"},{"line_number":31,"context_line":"and apply the changes from your github account."},{"line_number":32,"context_line":"In some cases this is particular useful as there is no need to update the patchset number."},{"line_number":33,"context_line":"::"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  export DIB_INSTALLTYPE_puppet_tripleo\u003dsource"}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_f2251609","line":32,"range":{"start_line":32,"start_character":22,"end_line":32,"end_character":32},"in_reply_to":"bab6814e_20be41d4","updated":"2016-05-20 08:32:58.000000000","message":"Done","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":7294,"name":"Leif Madsen","email":"lmadsen@redhat.com","username":"leifmadsen"},"change_message_id":"93499d7a310545bdd28658c6ebb32fe225edaaa4","unresolved":false,"context_lines":[{"line_number":55,"context_line":"Debugging puppet-tripleo from overcloud images"},{"line_number":56,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"To check the current state of the overcloud images is possible to mount the .qcow2 file by:"},{"line_number":59,"context_line":"::"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  #Install the libguest tool:"}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_a078712c","line":58,"range":{"start_line":58,"start_character":0,"end_line":58,"end_character":90},"updated":"2016-05-19 20:12:18.000000000","message":"To check it is possible for the overcloud images to mount the .qcow2 file:","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"82918dc7a313357cdfb9b4009b81ecf2ee61d3c6","unresolved":false,"context_lines":[{"line_number":55,"context_line":"Debugging puppet-tripleo from overcloud images"},{"line_number":56,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"To check the current state of the overcloud images is possible to mount the .qcow2 file by:"},{"line_number":59,"context_line":"::"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  #Install the libguest tool:"}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_92c92a29","line":58,"range":{"start_line":58,"start_character":0,"end_line":58,"end_character":90},"in_reply_to":"bab6814e_a078712c","updated":"2016-05-20 08:32:58.000000000","message":"Done","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":7294,"name":"Leif Madsen","email":"lmadsen@redhat.com","username":"leifmadsen"},"change_message_id":"93499d7a310545bdd28658c6ebb32fe225edaaa4","unresolved":false,"context_lines":[{"line_number":74,"context_line":"  sudo umount /tmp/overcloud-full"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"From the mounted image file is also possible to run for testing purposes the puppet manifests by using ``puppet apply`` and including your manifests:"},{"line_number":78,"context_line":"::"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  sudo puppet apply -v --debug --modulepath\u003d/tmp/overcloud-full/opt/stack/puppet-modules -e \"include ::tripleo::services::time::ntp\""}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_00afbd81","line":77,"range":{"start_line":77,"start_character":51,"end_line":77,"end_character":55},"updated":"2016-05-19 20:12:18.000000000","message":", for","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":7294,"name":"Leif Madsen","email":"lmadsen@redhat.com","username":"leifmadsen"},"change_message_id":"93499d7a310545bdd28658c6ebb32fe225edaaa4","unresolved":false,"context_lines":[{"line_number":74,"context_line":"  sudo umount /tmp/overcloud-full"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"From the mounted image file is also possible to run for testing purposes the puppet manifests by using ``puppet apply`` and including your manifests:"},{"line_number":78,"context_line":"::"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  sudo puppet apply -v --debug --modulepath\u003d/tmp/overcloud-full/opt/stack/puppet-modules -e \"include ::tripleo::services::time::ntp\""}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_80b1ede3","line":77,"range":{"start_line":77,"start_character":72,"end_line":77,"end_character":74},"updated":"2016-05-19 20:12:18.000000000","message":", t","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":7294,"name":"Leif Madsen","email":"lmadsen@redhat.com","username":"leifmadsen"},"change_message_id":"93499d7a310545bdd28658c6ebb32fe225edaaa4","unresolved":false,"context_lines":[{"line_number":74,"context_line":"  sudo umount /tmp/overcloud-full"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"From the mounted image file is also possible to run for testing purposes the puppet manifests by using ``puppet apply`` and including your manifests:"},{"line_number":78,"context_line":"::"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  sudo puppet apply -v --debug --modulepath\u003d/tmp/overcloud-full/opt/stack/puppet-modules -e \"include ::tripleo::services::time::ntp\""}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_809a8d61","line":77,"range":{"start_line":77,"start_character":28,"end_line":77,"end_character":30},"updated":"2016-05-19 20:12:18.000000000","message":"it is","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"82918dc7a313357cdfb9b4009b81ecf2ee61d3c6","unresolved":false,"context_lines":[{"line_number":74,"context_line":"  sudo umount /tmp/overcloud-full"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"From the mounted image file is also possible to run for testing purposes the puppet manifests by using ``puppet apply`` and including your manifests:"},{"line_number":78,"context_line":"::"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  sudo puppet apply -v --debug --modulepath\u003d/tmp/overcloud-full/opt/stack/puppet-modules -e \"include ::tripleo::services::time::ntp\""}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_32f83e49","line":77,"range":{"start_line":77,"start_character":51,"end_line":77,"end_character":55},"in_reply_to":"bab6814e_00afbd81","updated":"2016-05-20 08:32:58.000000000","message":"Done","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"82918dc7a313357cdfb9b4009b81ecf2ee61d3c6","unresolved":false,"context_lines":[{"line_number":74,"context_line":"  sudo umount /tmp/overcloud-full"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"From the mounted image file is also possible to run for testing purposes the puppet manifests by using ``puppet apply`` and including your manifests:"},{"line_number":78,"context_line":"::"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  sudo puppet apply -v --debug --modulepath\u003d/tmp/overcloud-full/opt/stack/puppet-modules -e \"include ::tripleo::services::time::ntp\""}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_92976aeb","line":77,"range":{"start_line":77,"start_character":28,"end_line":77,"end_character":30},"in_reply_to":"bab6814e_809a8d61","updated":"2016-05-20 08:32:58.000000000","message":"Done","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"82918dc7a313357cdfb9b4009b81ecf2ee61d3c6","unresolved":false,"context_lines":[{"line_number":74,"context_line":"  sudo umount /tmp/overcloud-full"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"From the mounted image file is also possible to run for testing purposes the puppet manifests by using ``puppet apply`` and including your manifests:"},{"line_number":78,"context_line":"::"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  sudo puppet apply -v --debug --modulepath\u003d/tmp/overcloud-full/opt/stack/puppet-modules -e \"include ::tripleo::services::time::ntp\""}],"source_content_type":"text/x-rst","patch_set":15,"id":"bab6814e_729c860f","line":77,"range":{"start_line":77,"start_character":72,"end_line":77,"end_character":74},"in_reply_to":"bab6814e_80b1ede3","updated":"2016-05-20 08:32:58.000000000","message":"Done","commit_id":"5bba2d1437f3d8c696e685968decafe8bc89b1ea"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"df974e8312cfd386afdf126de75022e6da4c884a","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    mkdir ~/puppet-modules"},{"line_number":69,"context_line":"    pushd ~/puppet-modules"},{"line_number":70,"context_line":"      curl -O https://raw.githubusercontent.com/openstack/tripleo-puppet-elements/master/elements/puppet-modules/source-repository-puppet-modules"},{"line_number":71,"context_line":"      mapfile -t REPO_CLONES \u003c \u003c(cat source-repository-puppet-modules | awk \u0027{ print $4 \" \" $3 }\u0027 | sed -e \u0027s|/opt/stack/puppet-modules/||\u0027)"},{"line_number":72,"context_line":"      for CLONE in \"${REPO_CLONES[@]}\"; do"},{"line_number":73,"context_line":"        git clone $CLONE"},{"line_number":74,"context_line":"      done"}],"source_content_type":"text/x-rst","patch_set":23,"id":"7aa08908_7f45226d","line":71,"updated":"2016-06-14 15:13:10.000000000","message":"The source-repository-puppet-modules can have comments in it, like this:\n\n  # Note: TripleO does not ....\n\nwhich makes this snippet fails.\n\nOne working with comments:\n\n  mapfile -t REPO_CLONES \u003c \u003c(cat source-repository-puppet-modules | \\\n    awk \u0027/^ *[a-z]/{ print $4 \" \" $3 }\u0027 | \\\n    sed -e \u0027s|/opt/stack/puppet-modules/||\u0027)\n\nThis should cover most cases.","commit_id":"e5afab31ba21803d0f16e62daaf4ee30cbbd204d"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"ebf0bdaf05e1e0048b6a45b866ada28a6e68233b","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    mkdir ~/puppet-modules"},{"line_number":69,"context_line":"    pushd ~/puppet-modules"},{"line_number":70,"context_line":"      curl -O https://raw.githubusercontent.com/openstack/tripleo-puppet-elements/master/elements/puppet-modules/source-repository-puppet-modules"},{"line_number":71,"context_line":"      mapfile -t REPO_CLONES \u003c \u003c(cat source-repository-puppet-modules | awk \u0027{ print $4 \" \" $3 }\u0027 | sed -e \u0027s|/opt/stack/puppet-modules/||\u0027)"},{"line_number":72,"context_line":"      for CLONE in \"${REPO_CLONES[@]}\"; do"},{"line_number":73,"context_line":"        git clone $CLONE"},{"line_number":74,"context_line":"      done"}],"source_content_type":"text/x-rst","patch_set":23,"id":"7aa08908_75270163","line":71,"in_reply_to":"7aa08908_7f45226d","updated":"2016-06-14 15:24:15.000000000","message":"Done","commit_id":"e5afab31ba21803d0f16e62daaf4ee30cbbd204d"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"33ec92efef09d26d5269b0f9296009ad25938c24","unresolved":false,"context_lines":[{"line_number":7,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When adding new features to THT, in some cases dependencies should be merged"},{"line_number":10,"context_line":"first in order to test newer patches, with the following procedure, the user"},{"line_number":11,"context_line":"will be able to create the overcloud images using WorkInProgress patches from"},{"line_number":12,"context_line":"gerrit code review without having them merged (for CI testing purposes)."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-rst","patch_set":24,"id":"7aa08908_d2fa0b43","line":10,"range":{"start_line":10,"start_character":29,"end_line":10,"end_character":36},"updated":"2016-06-15 15:58:51.000000000","message":"i\u0027d rather separate in two sentences..\n\"... first in order to test newer patches. With the following procedure, ...\"","commit_id":"cf7cfe935aafa436566c056976925db56f690d4c"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"ec62bad7c5a65fa184fb765f55d4ca695c5f2032","unresolved":false,"context_lines":[{"line_number":7,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When adding new features to THT, in some cases dependencies should be merged"},{"line_number":10,"context_line":"first in order to test newer patches, with the following procedure, the user"},{"line_number":11,"context_line":"will be able to create the overcloud images using WorkInProgress patches from"},{"line_number":12,"context_line":"gerrit code review without having them merged (for CI testing purposes)."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-rst","patch_set":24,"id":"7aa08908_fa29b9f3","line":10,"range":{"start_line":10,"start_character":29,"end_line":10,"end_character":36},"in_reply_to":"7aa08908_d2fa0b43","updated":"2016-06-16 10:14:52.000000000","message":"Done","commit_id":"cf7cfe935aafa436566c056976925db56f690d4c"},{"author":{"_account_id":7294,"name":"Leif Madsen","email":"lmadsen@redhat.com","username":"leifmadsen"},"change_message_id":"4a1e868e9ba3d33dbafc375f33bc4f44bd44ceee","unresolved":false,"context_lines":[{"line_number":7,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When adding new features to THT, in some cases dependencies should be merged"},{"line_number":10,"context_line":"first in order to test newer patches, with the following procedure, the user"},{"line_number":11,"context_line":"will be able to create the overcloud images using WorkInProgress patches from"},{"line_number":12,"context_line":"gerrit code review without having them merged (for CI testing purposes)."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-rst","patch_set":24,"id":"7aa08908_f51baec8","line":10,"range":{"start_line":10,"start_character":29,"end_line":10,"end_character":36},"in_reply_to":"7aa08908_d2fa0b43","updated":"2016-06-15 17:09:31.000000000","message":"Further to the separation, I think the sentence should be flipped a bit:\n\n\"In some cases, dependencies should be merged first in order to test newer patches when adding new features to THT.\"","commit_id":"cf7cfe935aafa436566c056976925db56f690d4c"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"ec62bad7c5a65fa184fb765f55d4ca695c5f2032","unresolved":false,"context_lines":[{"line_number":7,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When adding new features to THT, in some cases dependencies should be merged"},{"line_number":10,"context_line":"first in order to test newer patches, with the following procedure, the user"},{"line_number":11,"context_line":"will be able to create the overcloud images using WorkInProgress patches from"},{"line_number":12,"context_line":"gerrit code review without having them merged (for CI testing purposes)."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-rst","patch_set":24,"id":"7aa08908_da2cbd03","line":10,"range":{"start_line":10,"start_character":29,"end_line":10,"end_character":36},"in_reply_to":"7aa08908_f51baec8","updated":"2016-06-16 10:14:52.000000000","message":"Done","commit_id":"cf7cfe935aafa436566c056976925db56f690d4c"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"33ec92efef09d26d5269b0f9296009ad25938c24","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  tar --exclude-vcs --show-transformed-names --transform \u0027s|puppet-modules/|opt/stack/puppet-modules/|\u0027 -czvf puppet-modules.tar.gz puppet-modules"},{"line_number":87,"context_line":"  upload-swift-artifacts -f puppet-modules.tar.gz --environment puppet-modules.yaml"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"This will generates the puppet-modules.yaml environment file, which can be"},{"line_number":90,"context_line":"added to the deployment command (\"-e puppet-modules.yaml\") and use cloned"},{"line_number":91,"context_line":"puppet modules"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-rst","patch_set":24,"id":"7aa08908_ed012806","line":89,"range":{"start_line":89,"start_character":10,"end_line":89,"end_character":19},"updated":"2016-06-15 15:58:51.000000000","message":"will generate","commit_id":"cf7cfe935aafa436566c056976925db56f690d4c"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"ec62bad7c5a65fa184fb765f55d4ca695c5f2032","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  tar --exclude-vcs --show-transformed-names --transform \u0027s|puppet-modules/|opt/stack/puppet-modules/|\u0027 -czvf puppet-modules.tar.gz puppet-modules"},{"line_number":87,"context_line":"  upload-swift-artifacts -f puppet-modules.tar.gz --environment puppet-modules.yaml"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"This will generates the puppet-modules.yaml environment file, which can be"},{"line_number":90,"context_line":"added to the deployment command (\"-e puppet-modules.yaml\") and use cloned"},{"line_number":91,"context_line":"puppet modules"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-rst","patch_set":24,"id":"7aa08908_7a25c908","line":89,"range":{"start_line":89,"start_character":10,"end_line":89,"end_character":19},"in_reply_to":"7aa08908_ed012806","updated":"2016-06-16 10:14:52.000000000","message":"Done","commit_id":"cf7cfe935aafa436566c056976925db56f690d4c"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"33ec92efef09d26d5269b0f9296009ad25938c24","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"After every manual change to any of the puppet modules it is possible to re-run"},{"line_number":94,"context_line":"the upload to swift, and re-run `overcloud deploy` with the new env file. This"},{"line_number":95,"context_line":"process will speed up the changes in the ovecloud images."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Debugging puppet-tripleo from overcloud images"},{"line_number":98,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":24,"id":"7aa08908_ad46004d","line":95,"range":{"start_line":95,"start_character":0,"end_line":95,"end_character":7},"updated":"2016-06-15 15:58:51.000000000","message":"There is this change https://review.openstack.org/#/c/299643/, that automates that swift upload","commit_id":"cf7cfe935aafa436566c056976925db56f690d4c"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"ec62bad7c5a65fa184fb765f55d4ca695c5f2032","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"After every manual change to any of the puppet modules it is possible to re-run"},{"line_number":94,"context_line":"the upload to swift, and re-run `overcloud deploy` with the new env file. This"},{"line_number":95,"context_line":"process will speed up the changes in the ovecloud images."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Debugging puppet-tripleo from overcloud images"},{"line_number":98,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":24,"id":"7aa08908_550d3e34","line":95,"range":{"start_line":95,"start_character":0,"end_line":95,"end_character":7},"in_reply_to":"7aa08908_ad46004d","updated":"2016-06-16 10:14:52.000000000","message":"Done","commit_id":"cf7cfe935aafa436566c056976925db56f690d4c"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"c9a4e8c9a560538fc58fdb281c629a70e0f97f9e","unresolved":false,"context_lines":[{"line_number":20,"context_line":"can:"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Create the overcloud image by following (:doc:`in_progress_review`) :"},{"line_number":24,"context_line":"::"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"  export DIB_INSTALLTYPE_puppet_tripleo\u003dsource"}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_219606f0","line":23,"range":{"start_line":23,"start_character":39,"end_line":23,"end_character":40},"updated":"2016-06-30 10:10:39.000000000","message":"If we\u0027re going to suggest rebuilding images, we should just reference http://docs.openstack.org/developer/tripleo-docs/advanced_deployment/in_progress_review.html - I think you\u0027re duplicating some of that content here, and if it\u0027s new content it should probably be a patch to that existing documentation, not a duplicate section on image building?","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"8bd8802106afad25b4dcda5cebf8c9cdb3d9dc8a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"can:"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Create the overcloud image by following (:doc:`in_progress_review`) :"},{"line_number":24,"context_line":"::"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"  export DIB_INSTALLTYPE_puppet_tripleo\u003dsource"}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_89186e20","line":23,"range":{"start_line":23,"start_character":39,"end_line":23,"end_character":40},"in_reply_to":"3aaa91ec_219606f0","updated":"2016-07-01 16:09:27.000000000","message":"Section removed as is not fully related to composable services.","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"c9a4e8c9a560538fc58fdb281c629a70e0f97f9e","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"  ./tripleo-ci/scripts/tripleo.sh --overcloud-images"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Pushing changes directly without re-creating the overcloud images"},{"line_number":59,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"On the undercloud as the stack user, clone the openstack modules using:"}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_416fd2fb","line":58,"range":{"start_line":58,"start_character":32,"end_line":58,"end_character":33},"updated":"2016-06-30 10:10:39.000000000","message":"I think this section should be a new page, probably in a different patch - similar to the image building content linked above - this is a generally useful workflow (that\u0027s currently not documented) and it\u0027s not specific to the composable services stuff or puppet-tripleo)","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"8bd8802106afad25b4dcda5cebf8c9cdb3d9dc8a","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"  ./tripleo-ci/scripts/tripleo.sh --overcloud-images"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Pushing changes directly without re-creating the overcloud images"},{"line_number":59,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"On the undercloud as the stack user, clone the openstack modules using:"}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_09dbde50","line":58,"range":{"start_line":58,"start_character":32,"end_line":58,"end_character":33},"in_reply_to":"3aaa91ec_416fd2fb","updated":"2016-07-01 16:09:27.000000000","message":"Section removed as is not fully related to composable services.","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"c9a4e8c9a560538fc58fdb281c629a70e0f97f9e","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        awk \u0027/^ *[a-z]/{ print $4 \" \" $3 }\u0027 | \\"},{"line_number":73,"context_line":"        sed -e \u0027s|/opt/stack/puppet-modules/||\u0027)"},{"line_number":74,"context_line":"      for CLONE in \"${REPO_CLONES[@]}\"; do"},{"line_number":75,"context_line":"        git clone $CLONE"},{"line_number":76,"context_line":"      done"},{"line_number":77,"context_line":"    popd"},{"line_number":78,"context_line":"  fi"}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_a10dd63f","line":75,"range":{"start_line":75,"start_character":19,"end_line":75,"end_character":24},"updated":"2016-06-30 10:10:39.000000000","message":"It might be simpler just to show how to clone one repo manually - in many cases you don\u0027t actually need to pull everything.  Maybe we should show both approaches (with the single repo approach first, as it\u0027s simpler)?","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"8bd8802106afad25b4dcda5cebf8c9cdb3d9dc8a","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        awk \u0027/^ *[a-z]/{ print $4 \" \" $3 }\u0027 | \\"},{"line_number":73,"context_line":"        sed -e \u0027s|/opt/stack/puppet-modules/||\u0027)"},{"line_number":74,"context_line":"      for CLONE in \"${REPO_CLONES[@]}\"; do"},{"line_number":75,"context_line":"        git clone $CLONE"},{"line_number":76,"context_line":"      done"},{"line_number":77,"context_line":"    popd"},{"line_number":78,"context_line":"  fi"}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_e9df7238","line":75,"range":{"start_line":75,"start_character":19,"end_line":75,"end_character":24},"in_reply_to":"3aaa91ec_a10dd63f","updated":"2016-07-01 16:09:27.000000000","message":"Section removed as is not fully related to composable services.","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"c9a4e8c9a560538fc58fdb281c629a70e0f97f9e","unresolved":false,"context_lines":[{"line_number":84,"context_line":"  set -eu"},{"line_number":85,"context_line":"  cd ~"},{"line_number":86,"context_line":"  tar --exclude-vcs --show-transformed-names --transform \u0027s|puppet-modules/|opt/stack/puppet-modules/|\u0027 -czvf puppet-modules.tar.gz puppet-modules"},{"line_number":87,"context_line":"  upload-swift-artifacts -f puppet-modules.tar.gz --environment puppet-modules.yaml"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"This will generate the puppet-modules.yaml environment file, which can be"},{"line_number":90,"context_line":"added to the deployment command (\"-e puppet-modules.yaml\") and use cloned"}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_0c2ce197","line":87,"range":{"start_line":87,"start_character":9,"end_line":87,"end_character":14},"updated":"2016-06-30 10:10:39.000000000","message":"This should reference upload-swift-artifacts, then it becomes simply\n\n  upload-swift-artifacts -d puppet-modules","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"8bd8802106afad25b4dcda5cebf8c9cdb3d9dc8a","unresolved":false,"context_lines":[{"line_number":84,"context_line":"  set -eu"},{"line_number":85,"context_line":"  cd ~"},{"line_number":86,"context_line":"  tar --exclude-vcs --show-transformed-names --transform \u0027s|puppet-modules/|opt/stack/puppet-modules/|\u0027 -czvf puppet-modules.tar.gz puppet-modules"},{"line_number":87,"context_line":"  upload-swift-artifacts -f puppet-modules.tar.gz --environment puppet-modules.yaml"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"This will generate the puppet-modules.yaml environment file, which can be"},{"line_number":90,"context_line":"added to the deployment command (\"-e puppet-modules.yaml\") and use cloned"}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_09a91e91","line":87,"range":{"start_line":87,"start_character":9,"end_line":87,"end_character":14},"in_reply_to":"3aaa91ec_0c2ce197","updated":"2016-07-01 16:09:27.000000000","message":"Section removed as is not fully related to composable services.","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"1a8b173a2ebe01b8458fe4ce96ad2175cddfdd91","unresolved":false,"context_lines":[{"line_number":84,"context_line":"  set -eu"},{"line_number":85,"context_line":"  cd ~"},{"line_number":86,"context_line":"  tar --exclude-vcs --show-transformed-names --transform \u0027s|puppet-modules/|opt/stack/puppet-modules/|\u0027 -czvf puppet-modules.tar.gz puppet-modules"},{"line_number":87,"context_line":"  upload-swift-artifacts -f puppet-modules.tar.gz --environment puppet-modules.yaml"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"This will generate the puppet-modules.yaml environment file, which can be"},{"line_number":90,"context_line":"added to the deployment command (\"-e puppet-modules.yaml\") and use cloned"}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_6c0f6539","line":87,"range":{"start_line":87,"start_character":9,"end_line":87,"end_character":14},"in_reply_to":"3aaa91ec_0c2ce197","updated":"2016-06-30 10:26:54.000000000","message":"Sorry, I meant upload-puppet-modules :)","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"8bd8802106afad25b4dcda5cebf8c9cdb3d9dc8a","unresolved":false,"context_lines":[{"line_number":84,"context_line":"  set -eu"},{"line_number":85,"context_line":"  cd ~"},{"line_number":86,"context_line":"  tar --exclude-vcs --show-transformed-names --transform \u0027s|puppet-modules/|opt/stack/puppet-modules/|\u0027 -czvf puppet-modules.tar.gz puppet-modules"},{"line_number":87,"context_line":"  upload-swift-artifacts -f puppet-modules.tar.gz --environment puppet-modules.yaml"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"This will generate the puppet-modules.yaml environment file, which can be"},{"line_number":90,"context_line":"added to the deployment command (\"-e puppet-modules.yaml\") and use cloned"}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_29e21a02","line":87,"range":{"start_line":87,"start_character":9,"end_line":87,"end_character":14},"in_reply_to":"3aaa91ec_6c0f6539","updated":"2016-07-01 16:09:27.000000000","message":"Section removed as is not fully related to composable services.","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"c9a4e8c9a560538fc58fdb281c629a70e0f97f9e","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"This will generate the puppet-modules.yaml environment file, which can be"},{"line_number":90,"context_line":"added to the deployment command (\"-e puppet-modules.yaml\") and use cloned"},{"line_number":91,"context_line":"puppet modules"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"After every manual change to any of the puppet modules it is possible to re-run"},{"line_number":94,"context_line":"the upload to swift, and re-run `overcloud deploy` with the new env file. This"}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_6c6be5b9","line":91,"range":{"start_line":91,"start_character":7,"end_line":91,"end_character":14},"updated":"2016-06-30 10:10:39.000000000","message":"the tripleo-common script creates the environment file for you automatically","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"8bd8802106afad25b4dcda5cebf8c9cdb3d9dc8a","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"This will generate the puppet-modules.yaml environment file, which can be"},{"line_number":90,"context_line":"added to the deployment command (\"-e puppet-modules.yaml\") and use cloned"},{"line_number":91,"context_line":"puppet modules"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"After every manual change to any of the puppet modules it is possible to re-run"},{"line_number":94,"context_line":"the upload to swift, and re-run `overcloud deploy` with the new env file. This"}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_c9b716f7","line":91,"range":{"start_line":91,"start_character":7,"end_line":91,"end_character":14},"in_reply_to":"3aaa91ec_6c6be5b9","updated":"2016-07-01 16:09:27.000000000","message":"Section removed as is not fully related to composable services.","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"c9a4e8c9a560538fc58fdb281c629a70e0f97f9e","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"  Also in https://review.openstack.org/#/c/299643/ is proposed the automation"},{"line_number":100,"context_line":"  of this process in order to save time when making changes to the puppet-tripleo"},{"line_number":101,"context_line":"  repository."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Debugging puppet-tripleo from overcloud images"},{"line_number":104,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_acde6d6a","line":101,"range":{"start_line":101,"start_character":2,"end_line":101,"end_character":12},"updated":"2016-06-30 10:10:39.000000000","message":"Ah, yeah - I just approved it :)","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"8bd8802106afad25b4dcda5cebf8c9cdb3d9dc8a","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"  Also in https://review.openstack.org/#/c/299643/ is proposed the automation"},{"line_number":100,"context_line":"  of this process in order to save time when making changes to the puppet-tripleo"},{"line_number":101,"context_line":"  repository."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Debugging puppet-tripleo from overcloud images"},{"line_number":104,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_a9bc4adc","line":101,"range":{"start_line":101,"start_character":2,"end_line":101,"end_character":12},"in_reply_to":"3aaa91ec_acde6d6a","updated":"2016-07-01 16:09:27.000000000","message":"Section removed as is not fully related to composable services.","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"c9a4e8c9a560538fc58fdb281c629a70e0f97f9e","unresolved":false,"context_lines":[{"line_number":100,"context_line":"  of this process in order to save time when making changes to the puppet-tripleo"},{"line_number":101,"context_line":"  repository."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Debugging puppet-tripleo from overcloud images"},{"line_number":104,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"For debugging purposes, it is possible to mount the overcloud .qcow2 file:"}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_2c5f1de6","line":103,"range":{"start_line":103,"start_character":17,"end_line":103,"end_character":24},"updated":"2016-06-30 10:10:39.000000000","message":"Again this is useful info, but IMO it should be a separate patch, adding a new page/section to http://docs.openstack.org/developer/tripleo-docs/troubleshooting/troubleshooting.html","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"8bd8802106afad25b4dcda5cebf8c9cdb3d9dc8a","unresolved":false,"context_lines":[{"line_number":100,"context_line":"  of this process in order to save time when making changes to the puppet-tripleo"},{"line_number":101,"context_line":"  repository."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Debugging puppet-tripleo from overcloud images"},{"line_number":104,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"For debugging purposes, it is possible to mount the overcloud .qcow2 file:"}],"source_content_type":"text/x-rst","patch_set":30,"id":"3aaa91ec_49ccc68a","line":103,"range":{"start_line":103,"start_character":17,"end_line":103,"end_character":24},"in_reply_to":"3aaa91ec_2c5f1de6","updated":"2016-07-01 16:09:27.000000000","message":"Section removed as is not fully related to composable services.","commit_id":"2ccebe6a1555168c68f97d484b8e5f1b54452fcb"}]}