)]}'
{"doc/source/install/advanced_deployment/container_image_prepare.rst":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"8905876ab3e8339eed96af996372e179f0b027ce","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    - set:"},{"line_number":49,"context_line":"        ceph_image: daemon"},{"line_number":50,"context_line":"        ceph_namespace: docker.io/ceph"},{"line_number":51,"context_line":"        ceph_tag: v3.0.3-stable-3.0-luminous-centos-7-x86_64"},{"line_number":52,"context_line":"        name_prefix: centos-binary-"},{"line_number":53,"context_line":"        name_suffix: \u0027\u0027"},{"line_number":54,"context_line":"        namespace: docker.io/tripleomaster"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dfbec78f_92d834ef","line":51,"range":{"start_line":51,"start_character":18,"end_line":51,"end_character":60},"updated":"2019-05-16 00:58:21.000000000","message":"v4.0.0-stable-4.0-nautilus-centos-7-x86_64","commit_id":"670ff4b2609de9b9499659c87a0bbec5e970fb5d"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"8905876ab3e8339eed96af996372e179f0b027ce","unresolved":false,"context_lines":[{"line_number":93,"context_line":"      set:"},{"line_number":94,"context_line":"        ceph_image: daemon"},{"line_number":95,"context_line":"        ceph_namespace: docker.io/ceph"},{"line_number":96,"context_line":"        ceph_tag: v3.0.3-stable-3.0-luminous-centos-7-x86_64"},{"line_number":97,"context_line":"        name_prefix: centos-binary-"},{"line_number":98,"context_line":"        name_suffix: \u0027\u0027"},{"line_number":99,"context_line":"        namespace: docker.io/tripleomaster"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dfbec78f_32e388a6","line":96,"range":{"start_line":96,"start_character":18,"end_line":96,"end_character":60},"updated":"2019-05-16 00:58:21.000000000","message":"v4.0.0-stable-4.0-nautilus-centos-7-x86_64","commit_id":"670ff4b2609de9b9499659c87a0bbec5e970fb5d"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"8905876ab3e8339eed96af996372e179f0b027ce","unresolved":false,"context_lines":[{"line_number":177,"context_line":"   its version and it\u0027s release, it is not the convention of"},{"line_number":178,"context_line":"   this project to provide tags with a string made from"},{"line_number":179,"context_line":"   \u0027{version}-{release}\u0027."},{"line_number":180,"context_line":"   For this reason the tag_from_label mechanism doesn\u0027t work"},{"line_number":181,"context_line":"   as expected and the \"ceph_tag\" defined in the template is"},{"line_number":182,"context_line":"   used."},{"line_number":183,"context_line":""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"Copying images with push_destination"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dfbec78f_f264104c","line":182,"range":{"start_line":180,"start_character":0,"end_line":182,"end_character":8},"updated":"2019-05-16 00:58:21.000000000","message":"Let\u0027s replace lines 180-182 with the following\n\nWhen using tag_from_label with Ceph an `includes` an `excludes` list may be used as described in the Layering image preparation entries section below.","commit_id":"670ff4b2609de9b9499659c87a0bbec5e970fb5d"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"14def294d2c485e650d2388d41fc83fc2e917bf3","unresolved":false,"context_lines":[{"line_number":177,"context_line":"   its version and it\u0027s release, it is not the convention of"},{"line_number":178,"context_line":"   this project to provide tags with a string made from"},{"line_number":179,"context_line":"   \u0027{version}-{release}\u0027."},{"line_number":180,"context_line":"   For this reason the tag_from_label mechanism doesn\u0027t work"},{"line_number":181,"context_line":"   as expected and the \"ceph_tag\" defined in the template is"},{"line_number":182,"context_line":"   used."},{"line_number":183,"context_line":""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"Copying images with push_destination"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dfbec78f_421add16","line":182,"range":{"start_line":180,"start_character":0,"end_line":182,"end_character":8},"in_reply_to":"dfbec78f_351b7273","updated":"2019-05-16 14:21:22.000000000","message":"Steve,\n\nI think we\u0027re in agreement here. I understand they\u0027re upstream docs. I was not trying to document a downstream tagging policy of a pre-release registry. I wanted to cover how to handle _any_ repository which doesn\u0027t follow the convention. I thought it valuable to connect `tag_from_label` (mentioned here) to the `exclude` example you provided and give a copy/paste example for ceph users.\n\n  John","commit_id":"670ff4b2609de9b9499659c87a0bbec5e970fb5d"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"b1dcb28775cda56da571c216dd47f9209d281d8a","unresolved":false,"context_lines":[{"line_number":177,"context_line":"   its version and it\u0027s release, it is not the convention of"},{"line_number":178,"context_line":"   this project to provide tags with a string made from"},{"line_number":179,"context_line":"   \u0027{version}-{release}\u0027."},{"line_number":180,"context_line":"   For this reason the tag_from_label mechanism doesn\u0027t work"},{"line_number":181,"context_line":"   as expected and the \"ceph_tag\" defined in the template is"},{"line_number":182,"context_line":"   used."},{"line_number":183,"context_line":""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"Copying images with push_destination"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dfbec78f_351b7273","line":182,"range":{"start_line":180,"start_character":0,"end_line":182,"end_character":8},"in_reply_to":"dfbec78f_f264104c","updated":"2019-05-16 01:46:26.000000000","message":"These are meant to be upstream docs, so it may not be appropriate to document the tagging policy of a downstream pre-release registry.\n\nHowever it would be useful to document a theoretical example of splitting out ceph to demonstrate disabling tag_from_label for a subset of images. How about the text here be reworked to be much briefer, and an example like from #230 gets inserted here?","commit_id":"670ff4b2609de9b9499659c87a0bbec5e970fb5d"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"8905876ab3e8339eed96af996372e179f0b027ce","unresolved":false,"context_lines":[{"line_number":256,"context_line":"services in the plan. `includes` matches take precedence over `excludes`"},{"line_number":257,"context_line":"matches, followed by role/service filtering. The image name must contain the"},{"line_number":258,"context_line":"value within it to be considered a match."},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"Modifying images during prepare"},{"line_number":261,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":262,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"dfbec78f_d2d22cd1","line":259,"updated":"2019-05-16 00:58:21.000000000","message":"Let\u0027s add the following here:\n\nAn `includes` and `excludes` entry can be used when using `tag_from_label` with Ceph as in the following:\n\n\nparameter_defaults:\n  ContainerImagePrepare:\n  - push_destination: true\n    set:\n      namespace: docker.io/tripleomaster\n      ...\n      tag: current-tripleo\n    tag_from_label: \u0027{version}-{release}\u0027\n    excludes: [ceph]\n  - push_destination: true\n    set:\n      ceph_image: daemon\n      ceph_namespace: docker.io/ceph\n      ceph_tag: v4.0.0-stable-4.0-nautilus-centos-7-x86_64\n    includes: [ceph]","commit_id":"670ff4b2609de9b9499659c87a0bbec5e970fb5d"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"53f2825ca3e2b0d14a0bbaeab4e095e2519bdc13","unresolved":false,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":"      tag_from_label: {version}-{release}"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":".. admonition:: tag_from_label for Ceph containers"},{"line_number":172,"context_line":"   :class: ceph"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"   Some external projects including Ceph don\u0027t follow the"},{"line_number":175,"context_line":"   same tagging convention used for the openstack containers."},{"line_number":176,"context_line":"   Though the registry for the ceph image can be queried for"},{"line_number":177,"context_line":"   its version and it\u0027s release, it is not the convention of"},{"line_number":178,"context_line":"   this project to provide tags with a string made from"},{"line_number":179,"context_line":"   \u0027{version}-{release}\u0027."},{"line_number":180,"context_line":"   When using tag_from_label with Ceph an `includes` and `excludes`"},{"line_number":181,"context_line":"   list may be used as described in the Layering image preparation"},{"line_number":182,"context_line":"   entries section below."},{"line_number":183,"context_line":""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"Copying images with push_destination"}],"source_content_type":"text/x-rst","patch_set":7,"id":"bfb3d3c7_8b566a06","line":182,"range":{"start_line":171,"start_character":0,"end_line":182,"end_character":25},"updated":"2019-05-20 12:24:29.000000000","message":"Francesco, I see you reverted my change from PS6. Was that intentional? I was trying to follow Steve\u0027s suggestion from May 15 visible in PS3.","commit_id":"c1f931042756ca5e48622c4a6622edf11ebfd07d"}]}