)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"74eba5d51fc88c731762839393f4d376e1240ec7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8e50d393_a641d2d5","updated":"2022-06-28 11:42:47.000000000","message":"Thanks, I\u0027ll address these","commit_id":"0541770c62f09e9cd6adb2638aba486404347310"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"73734c7e5e2a3cb79596a763ce0556d1a0377a08","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"548ac22a_2134387e","updated":"2022-06-28 10:50:35.000000000","message":"thank you for the clean up. i have a couple of inline comments we may want to address before merging.","commit_id":"0541770c62f09e9cd6adb2638aba486404347310"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"ce3b38f94796a3d22075691b867b029b38ac1dcc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"15b78a74_b8276a61","updated":"2022-11-01 06:03:53.000000000","message":"I think all of the concerns are addressed for this one. Most of the things are no longer required since they are covered elsewhere.","commit_id":"5eb3434113b40685105d053df5880553f3e88774"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0ad7f6b3674545419709b0072ef4bbc10f32c34c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"49544d21_39fb8ba5","updated":"2022-11-02 04:59:52.000000000","message":"Leaving comments for a few items I\u0027ve found. These can be covered in a separate follow-up patches.","commit_id":"5eb3434113b40685105d053df5880553f3e88774"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"de28fba433961e5c693b9fb9ae4f4c7e6403c8e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fe8f869a_71214c71","updated":"2022-11-02 05:52:11.000000000","message":"Let\u0027s merge this now and address the comments separately. We better improve the doc early instead of holding this for long until we fix the whole content.","commit_id":"5eb3434113b40685105d053df5880553f3e88774"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"c55dc2bdc4aa5884552980b7a93f7b6b7d07a3eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b4d9adb8_ddd8884d","updated":"2022-11-02 04:39:06.000000000","message":"There are still changes required and still not accurate, but we can merge as is if we want and do that in a followup.","commit_id":"5eb3434113b40685105d053df5880553f3e88774"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"aa2046d1d1cbc66e82b44914a177a152a17e8eb2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d5c7fcb0_f50cca57","updated":"2022-11-01 06:21:08.000000000","message":"recheck\n\nthe previous artifact expired. I\u0027ll check the rendered version once it is generated again.","commit_id":"5eb3434113b40685105d053df5880553f3e88774"}],"deploy-guide/source/deployment/ansible_config_download.rst":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"73734c7e5e2a3cb79596a763ce0556d1a0377a08","unresolved":true,"context_lines":[{"line_number":169,"context_line":"      overcloud-novacompute-2: compute-02-rack01"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"Write the contents to an environment file such as ``hostnamemap.yaml``, and"},{"line_number":172,"context_line":"pass the environment as part of the deployment command with ``-e``."},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"Ansible project directory"},{"line_number":175,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^"}],"source_content_type":"text/x-rst","patch_set":4,"id":"f3b3b8f8_9145230b","side":"PARENT","line":172,"updated":"2022-06-28 10:50:35.000000000","message":"This is likely still necessary, unless they just happen to name their servers the expected names.","commit_id":"49e4d903aa45465b0fa608997a466977b3896493"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"74eba5d51fc88c731762839393f4d376e1240ec7","unresolved":true,"context_lines":[{"line_number":169,"context_line":"      overcloud-novacompute-2: compute-02-rack01"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"Write the contents to an environment file such as ``hostnamemap.yaml``, and"},{"line_number":172,"context_line":"pass the environment as part of the deployment command with ``-e``."},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"Ansible project directory"},{"line_number":175,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5ee3e211_d7ff33e1","side":"PARENT","line":172,"in_reply_to":"f3b3b8f8_9145230b","updated":"2022-06-28 11:42:47.000000000","message":"I removed this because a user would have needed to complete the baremetal provision process (even if using pre-provisioned nodes) prior to running the overcloud deploy:\nhttps://docs.openstack.org/project-deploy-guide/tripleo-docs/latest/deployment/network_v2.html#provision-baremetal-instances\n\nSo they should already have a file with all of this information. I thought it might be confusing and potentially conflicting to leave this in. In lieu of this, I have linked to the baremetal deployment process here:\nhttps://review.opendev.org/c/openstack/tripleo-docs/+/847712/4/deploy-guide/source/deployment/ansible_config_download.rst#244\n\n\nBut maybe I need to mention it in this section as well to ensure users definitely have that file included in their deployment.","commit_id":"49e4d903aa45465b0fa608997a466977b3896493"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"73734c7e5e2a3cb79596a763ce0556d1a0377a08","unresolved":true,"context_lines":[{"line_number":280,"context_line":""},{"line_number":281,"context_line":"Alternatively, a user and key that are already authorized on the overcloud"},{"line_number":282,"context_line":"nodes can be used if that user and key are specified when running"},{"line_number":283,"context_line":"``tripleo-ansible-inventory``. See `Generate an inventory`_."},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"Run config-download"},{"line_number":286,"context_line":"^^^^^^^^^^^^^^^^^^^"}],"source_content_type":"text/x-rst","patch_set":4,"id":"4d4d26d3_13f255c9","side":"PARENT","line":283,"updated":"2022-06-28 10:50:35.000000000","message":"this is likely still needed, unless they also ran openstack overcloud deploy with --setup-only.","commit_id":"49e4d903aa45465b0fa608997a466977b3896493"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"d9b1e5039b2dd576e88b40437040b5d4d46d0163","unresolved":true,"context_lines":[{"line_number":280,"context_line":""},{"line_number":281,"context_line":"Alternatively, a user and key that are already authorized on the overcloud"},{"line_number":282,"context_line":"nodes can be used if that user and key are specified when running"},{"line_number":283,"context_line":"``tripleo-ansible-inventory``. See `Generate an inventory`_."},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"Run config-download"},{"line_number":286,"context_line":"^^^^^^^^^^^^^^^^^^^"}],"source_content_type":"text/x-rst","patch_set":4,"id":"8807414e_69fc1476","side":"PARENT","line":283,"in_reply_to":"4d4d26d3_13f255c9","updated":"2022-08-16 23:13:59.000000000","message":"I think we do this during the node provision step now? I\u0027ll double check on that.","commit_id":"49e4d903aa45465b0fa608997a466977b3896493"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"ce3b38f94796a3d22075691b867b029b38ac1dcc","unresolved":false,"context_lines":[{"line_number":280,"context_line":""},{"line_number":281,"context_line":"Alternatively, a user and key that are already authorized on the overcloud"},{"line_number":282,"context_line":"nodes can be used if that user and key are specified when running"},{"line_number":283,"context_line":"``tripleo-ansible-inventory``. See `Generate an inventory`_."},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"Run config-download"},{"line_number":286,"context_line":"^^^^^^^^^^^^^^^^^^^"}],"source_content_type":"text/x-rst","patch_set":4,"id":"df9e3fc7_0867541a","side":"PARENT","line":283,"in_reply_to":"8807414e_69fc1476","updated":"2022-11-01 06:03:53.000000000","message":"Done","commit_id":"49e4d903aa45465b0fa608997a466977b3896493"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"81af1a94ece5f74d01c58873e0715fc95c1afc12","unresolved":true,"context_lines":[{"line_number":295,"context_line":"The ansible data will be generated under a directory called ``config-download``"},{"line_number":296,"context_line":"as specified by the ``--config-dir`` CLI argument."},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"Generate an inventory"},{"line_number":299,"context_line":"^^^^^^^^^^^^^^^^^^^^^"},{"line_number":300,"context_line":"To generate an inventory file to use with ``ansible-playbook`` use the"},{"line_number":301,"context_line":"``tripleo-ansible-inventory`` command::"}],"source_content_type":"text/x-rst","patch_set":4,"id":"67a1f964_e2f781f6","side":"PARENT","line":298,"range":{"start_line":298,"start_character":0,"end_line":298,"end_character":21},"updated":"2022-08-11 08:30:39.000000000","message":"How user can generate inventory? \nIs there documentation for that in other docs?","commit_id":"49e4d903aa45465b0fa608997a466977b3896493"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"d9b1e5039b2dd576e88b40437040b5d4d46d0163","unresolved":true,"context_lines":[{"line_number":295,"context_line":"The ansible data will be generated under a directory called ``config-download``"},{"line_number":296,"context_line":"as specified by the ``--config-dir`` CLI argument."},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"Generate an inventory"},{"line_number":299,"context_line":"^^^^^^^^^^^^^^^^^^^^^"},{"line_number":300,"context_line":"To generate an inventory file to use with ``ansible-playbook`` use the"},{"line_number":301,"context_line":"``tripleo-ansible-inventory`` command::"}],"source_content_type":"text/x-rst","patch_set":4,"id":"92683df6_026f9dbf","side":"PARENT","line":298,"range":{"start_line":298,"start_character":0,"end_line":298,"end_character":21},"in_reply_to":"67a1f964_e2f781f6","updated":"2022-08-16 23:13:59.000000000","message":"I think the best bet is to just use the one that we create in the config-download directory. I\u0027m not sure if the validations team are planning on creating a new version of that script. But it\u0027s probably best to just use the inventory we create during the stack creation and config-download process.","commit_id":"49e4d903aa45465b0fa608997a466977b3896493"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"ff036899cf4a7cb422a1b909b4fb5e6bce814fe9","unresolved":false,"context_lines":[{"line_number":295,"context_line":"The ansible data will be generated under a directory called ``config-download``"},{"line_number":296,"context_line":"as specified by the ``--config-dir`` CLI argument."},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"Generate an inventory"},{"line_number":299,"context_line":"^^^^^^^^^^^^^^^^^^^^^"},{"line_number":300,"context_line":"To generate an inventory file to use with ``ansible-playbook`` use the"},{"line_number":301,"context_line":"``tripleo-ansible-inventory`` command::"}],"source_content_type":"text/x-rst","patch_set":4,"id":"a2faf3c6_f64a2c65","side":"PARENT","line":298,"range":{"start_line":298,"start_character":0,"end_line":298,"end_character":21},"in_reply_to":"92683df6_026f9dbf","updated":"2022-10-11 19:19:44.000000000","message":"Ack","commit_id":"49e4d903aa45465b0fa608997a466977b3896493"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"73734c7e5e2a3cb79596a763ce0556d1a0377a08","unresolved":true,"context_lines":[{"line_number":739,"context_line":""},{"line_number":740,"context_line":"It will generate the ``overcloudrc`` file in the current directory. The"},{"line_number":741,"context_line":"``--directory`` option can be used to generate it in a different location."},{"line_number":742,"context_line":"If needed, substitute the name of the deployment for overcloud."},{"line_number":743,"context_line":""},{"line_number":744,"context_line":"config-download with Heat SoftwareDeployment outputs"},{"line_number":745,"context_line":"----------------------------------------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"96ebd7f5_18a7e922","side":"PARENT","line":742,"updated":"2022-06-28 10:50:35.000000000","message":"this is done by --stack-only, so I suppose it\u0027s fair to remove it from here. I did try the command though, and didn\u0027t work, so I pushed up a patch for that:\n\nhttps://review.opendev.org/c/openstack/python-tripleoclient/+/847947","commit_id":"49e4d903aa45465b0fa608997a466977b3896493"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"74eba5d51fc88c731762839393f4d376e1240ec7","unresolved":false,"context_lines":[{"line_number":739,"context_line":""},{"line_number":740,"context_line":"It will generate the ``overcloudrc`` file in the current directory. The"},{"line_number":741,"context_line":"``--directory`` option can be used to generate it in a different location."},{"line_number":742,"context_line":"If needed, substitute the name of the deployment for overcloud."},{"line_number":743,"context_line":""},{"line_number":744,"context_line":"config-download with Heat SoftwareDeployment outputs"},{"line_number":745,"context_line":"----------------------------------------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1f929c08_f3cc45c1","side":"PARENT","line":742,"in_reply_to":"96ebd7f5_18a7e922","updated":"2022-06-28 11:42:47.000000000","message":"Ack","commit_id":"49e4d903aa45465b0fa608997a466977b3896493"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"73734c7e5e2a3cb79596a763ce0556d1a0377a08","unresolved":true,"context_lines":[{"line_number":746,"context_line":"``config-download`` does not support outputs on Heat"},{"line_number":747,"context_line":"SoftwareDeployment/SoftwareConfig resources. Often, ``deploy_steps_tasks`` can"},{"line_number":748,"context_line":"be used to reproduce the same behavior that would be handled by an output, by"},{"line_number":749,"context_line":"using Ansible tasks and the ``register`` keyword."}],"source_content_type":"text/x-rst","patch_set":4,"id":"a3ee169a_5fa1eaf8","side":"PARENT","line":749,"updated":"2022-06-28 10:50:35.000000000","message":"this is still relevant. in fact we still have examples in t-h-t of SoftwareConfig/SoftwarDeployment (not sure if they use outputs or not), but we should probably clean that up.","commit_id":"49e4d903aa45465b0fa608997a466977b3896493"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"74eba5d51fc88c731762839393f4d376e1240ec7","unresolved":false,"context_lines":[{"line_number":746,"context_line":"``config-download`` does not support outputs on Heat"},{"line_number":747,"context_line":"SoftwareDeployment/SoftwareConfig resources. Often, ``deploy_steps_tasks`` can"},{"line_number":748,"context_line":"be used to reproduce the same behavior that would be handled by an output, by"},{"line_number":749,"context_line":"using Ansible tasks and the ``register`` keyword."}],"source_content_type":"text/x-rst","patch_set":4,"id":"6d5ba5c3_ec312189","side":"PARENT","line":749,"in_reply_to":"a3ee169a_5fa1eaf8","updated":"2022-06-28 11:42:47.000000000","message":"Ack","commit_id":"49e4d903aa45465b0fa608997a466977b3896493"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"81af1a94ece5f74d01c58873e0715fc95c1afc12","unresolved":true,"context_lines":[{"line_number":262,"context_line":"You can then run ``ansible-playbook`` manually to configure the overcloud nodes::"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    ansible-playbook \\"},{"line_number":265,"context_line":"      -i inventory.yaml \\"},{"line_number":266,"context_line":"      --private-key /path/private/ssh/key \\"},{"line_number":267,"context_line":"      --become \\"},{"line_number":268,"context_line":"      config-download/deploy_steps_playbook.yaml"}],"source_content_type":"text/x-rst","patch_set":4,"id":"af25e3d4_57faf86d","line":265,"range":{"start_line":265,"start_character":0,"end_line":265,"end_character":25},"updated":"2022-08-11 08:30:39.000000000","message":"this is likely not a correct path, since we are not using  tripleo-ansible-inventory anymore","commit_id":"0541770c62f09e9cd6adb2638aba486404347310"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"ff036899cf4a7cb422a1b909b4fb5e6bce814fe9","unresolved":false,"context_lines":[{"line_number":262,"context_line":"You can then run ``ansible-playbook`` manually to configure the overcloud nodes::"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    ansible-playbook \\"},{"line_number":265,"context_line":"      -i inventory.yaml \\"},{"line_number":266,"context_line":"      --private-key /path/private/ssh/key \\"},{"line_number":267,"context_line":"      --become \\"},{"line_number":268,"context_line":"      config-download/deploy_steps_playbook.yaml"}],"source_content_type":"text/x-rst","patch_set":4,"id":"c0bc605f_cff4ff8a","line":265,"range":{"start_line":265,"start_character":0,"end_line":265,"end_character":25},"in_reply_to":"57c6bec7_318adf22","updated":"2022-10-11 19:19:44.000000000","message":"Done","commit_id":"0541770c62f09e9cd6adb2638aba486404347310"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"d9b1e5039b2dd576e88b40437040b5d4d46d0163","unresolved":true,"context_lines":[{"line_number":262,"context_line":"You can then run ``ansible-playbook`` manually to configure the overcloud nodes::"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    ansible-playbook \\"},{"line_number":265,"context_line":"      -i inventory.yaml \\"},{"line_number":266,"context_line":"      --private-key /path/private/ssh/key \\"},{"line_number":267,"context_line":"      --become \\"},{"line_number":268,"context_line":"      config-download/deploy_steps_playbook.yaml"}],"source_content_type":"text/x-rst","patch_set":4,"id":"57c6bec7_318adf22","line":265,"range":{"start_line":265,"start_character":0,"end_line":265,"end_character":25},"in_reply_to":"af25e3d4_57faf86d","updated":"2022-08-16 23:13:59.000000000","message":"I changed this to point to the default location for the config-download inventory.","commit_id":"0541770c62f09e9cd6adb2638aba486404347310"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"c55dc2bdc4aa5884552980b7a93f7b6b7d07a3eb","unresolved":true,"context_lines":[{"line_number":267,"context_line":""},{"line_number":268,"context_line":"This method is described in the following sections."},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"Enable tripleo-admin via SSH"},{"line_number":271,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":272,"context_line":"The tripleo-admin user must be `authorized on the overcloud nodes`_ for use by"},{"line_number":273,"context_line":"``ansible-playbook``, if using the default user set by"}],"source_content_type":"text/x-rst","patch_set":5,"id":"6ea5ca5e_440364bd","side":"PARENT","line":270,"range":{"start_line":270,"start_character":0,"end_line":270,"end_character":28},"updated":"2022-11-02 04:39:06.000000000","message":"This is still needed after --stack-only (specifically for pre-provisioned nodes not using metalsmith provisioning), either by running \u0027overcloud admin authorize or overcloud deploy --setup-only. Though now create tripleo-admin user with metalsmith provisioning and enable ssh for it on overcloud nodes, this step gives permissions to tripleo-admin on localhost[1]. It\u0027s little messy but that\u0027s how it works and I was trying to simplify it with[2].\n\n[1] https://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/playbooks/cli-enable-ssh-admin.yaml#L161\n[2] https://review.opendev.org/c/openstack/python-tripleoclient/+/857543","commit_id":"49e4d903aa45465b0fa608997a466977b3896493"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"c55dc2bdc4aa5884552980b7a93f7b6b7d07a3eb","unresolved":true,"context_lines":[{"line_number":39,"context_line":"templates and renders the required playbooks for the deployment."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"The difference with ``config-download`` is that although Heat creates all the"},{"line_number":42,"context_line":"deployment data necessary via SoftwareDeployment resources to perform the"},{"line_number":43,"context_line":"overcloud installation and configuration, it does not apply any of the software"},{"line_number":44,"context_line":"deployments. The data is only made available via the Heat API. Once the stack"},{"line_number":45,"context_line":"is created, deployment data is downloaded from Heat and ansible playbooks are"}],"source_content_type":"text/x-rst","patch_set":5,"id":"b1df85cb_5260bab2","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":48},"updated":"2022-11-02 04:39:06.000000000","message":"This is not correct. If we\u0027re differentiating from the old deployment method with heat SoftwareDeployment resources this has to be rephrased. We can probably get rid of it completely.","commit_id":"5eb3434113b40685105d053df5880553f3e88774"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"c55dc2bdc4aa5884552980b7a93f7b6b7d07a3eb","unresolved":true,"context_lines":[{"line_number":66,"context_line":"workflow steps are automated by tripleoclient. The workflow steps are summarized"},{"line_number":67,"context_line":"as:"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"#. Create deployment plan"},{"line_number":70,"context_line":"#. Create Heat stack"},{"line_number":71,"context_line":"#. Create software configuration within the Heat stack"},{"line_number":72,"context_line":"#. Create tripleo-admin ssh user"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5ae968f7_71f2f20c","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":25},"updated":"2022-11-02 04:39:06.000000000","message":"No deployment plan anymore.","commit_id":"5eb3434113b40685105d053df5880553f3e88774"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"c55dc2bdc4aa5884552980b7a93f7b6b7d07a3eb","unresolved":true,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"#. Create deployment plan"},{"line_number":70,"context_line":"#. Create Heat stack"},{"line_number":71,"context_line":"#. Create software configuration within the Heat stack"},{"line_number":72,"context_line":"#. Create tripleo-admin ssh user"},{"line_number":73,"context_line":"#. Download the software configuration from Heat"},{"line_number":74,"context_line":"#. Applying the downloaded software configuration to the overcloud nodes with"}],"source_content_type":"text/x-rst","patch_set":5,"id":"e7d367f2_f16d73f4","line":71,"range":{"start_line":71,"start_character":0,"end_line":71,"end_character":54},"updated":"2022-11-02 04:39:06.000000000","message":"This can be confused with heat sofware config, but in general this can mean all the service config.","commit_id":"5eb3434113b40685105d053df5880553f3e88774"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0ad7f6b3674545419709b0072ef4bbc10f32c34c","unresolved":true,"context_lines":[{"line_number":69,"context_line":"#. Create deployment plan"},{"line_number":70,"context_line":"#. Create Heat stack"},{"line_number":71,"context_line":"#. Create software configuration within the Heat stack"},{"line_number":72,"context_line":"#. Create tripleo-admin ssh user"},{"line_number":73,"context_line":"#. Download the software configuration from Heat"},{"line_number":74,"context_line":"#. Applying the downloaded software configuration to the overcloud nodes with"},{"line_number":75,"context_line":"   ``ansible-playbook``."}],"source_content_type":"text/x-rst","patch_set":5,"id":"51e9826f_509a982d","line":72,"range":{"start_line":72,"start_character":3,"end_line":72,"end_character":32},"updated":"2022-11-02 04:59:52.000000000","message":"Now tripleo-admin ssh user should be created during baremetal provisioning. We probably want to remove this or mention \"Ensure tripleo-admin ssh user\"","commit_id":"5eb3434113b40685105d053df5880553f3e88774"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0ad7f6b3674545419709b0072ef4bbc10f32c34c","unresolved":true,"context_lines":[{"line_number":70,"context_line":"#. Create Heat stack"},{"line_number":71,"context_line":"#. Create software configuration within the Heat stack"},{"line_number":72,"context_line":"#. Create tripleo-admin ssh user"},{"line_number":73,"context_line":"#. Download the software configuration from Heat"},{"line_number":74,"context_line":"#. Applying the downloaded software configuration to the overcloud nodes with"},{"line_number":75,"context_line":"   ``ansible-playbook``."},{"line_number":76,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"818ca90f_1b656fc6","line":73,"range":{"start_line":73,"start_character":3,"end_line":73,"end_character":48},"updated":"2022-11-02 04:59:52.000000000","message":"afaik we generate ansible playbooks before preparing tripleo-admin. We can fix this in a follow-up.","commit_id":"5eb3434113b40685105d053df5880553f3e88774"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0ad7f6b3674545419709b0072ef4bbc10f32c34c","unresolved":true,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"The following steps are done to create the ``tripleo-admin`` user:"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"#. Runs a playbook to create ``tripleo-admin`` on each node. Also, gives sudo"},{"line_number":85,"context_line":"   permissions to the user, as well as creates and stores a new ssh keypair"},{"line_number":86,"context_line":"   for ``tripleo-admin``."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"The values for these cli arguments must be the same for all nodes in the"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fd0cbdb1_97f2860d","line":86,"range":{"start_line":84,"start_character":3,"end_line":86,"end_character":25},"updated":"2022-11-02 04:59:52.000000000","message":"(can be left for follow-up) splitting this to multiple steps make more sense","commit_id":"5eb3434113b40685105d053df5880553f3e88774"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4caca10a4fdc223131739949261c94da0b6cdd95","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"The following steps are done to create the ``tripleo-admin`` user:"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"#. Runs a playbook to create ``tripleo-admin`` on each node. Also, gives sudo"},{"line_number":85,"context_line":"   permissions to the user, as well as creates and stores a new ssh keypair"},{"line_number":86,"context_line":"   for ``tripleo-admin``."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"The values for these cli arguments must be the same for all nodes in the"}],"source_content_type":"text/x-rst","patch_set":5,"id":"c23639d3_b7ef72d5","line":86,"range":{"start_line":84,"start_character":3,"end_line":86,"end_character":25},"in_reply_to":"fd0cbdb1_97f2860d","updated":"2022-11-02 06:15:13.000000000","message":"Pushed https://review.opendev.org/c/openstack/tripleo-docs/+/863195","commit_id":"5eb3434113b40685105d053df5880553f3e88774"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0ad7f6b3674545419709b0072ef4bbc10f32c34c","unresolved":true,"context_lines":[{"line_number":98,"context_line":"``config-download``::"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    --overcloud-ssh-user   # Initial ssh user used for creating tripleo-admin."},{"line_number":101,"context_line":"                           # Defaults to heat-admin"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    --overcloud-ssh-key    # Initial ssh private key (file path) to be used for"},{"line_number":104,"context_line":"                           # creating tripleo-admin."}],"source_content_type":"text/x-rst","patch_set":5,"id":"0ef532c2_38945ec1","line":101,"range":{"start_line":101,"start_character":41,"end_line":101,"end_character":51},"updated":"2022-11-02 04:59:52.000000000","message":"the current default is tripleo-admin","commit_id":"5eb3434113b40685105d053df5880553f3e88774"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0ad7f6b3674545419709b0072ef4bbc10f32c34c","unresolved":true,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":".. _deployment_status:"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":".. include:: deployment_status.rst"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":".. include:: deployment_log.rst"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7ac88b69_f25afbaf","line":123,"range":{"start_line":123,"start_character":13,"end_line":123,"end_character":34},"updated":"2022-11-02 04:59:52.000000000","message":"We also have to update this. This is still referring to mistral.\n\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_aa3/847712/5/check/build-openstack-deploy-guide/aa30026/docs/deployment/ansible_config_download.html#setting-the-status","commit_id":"5eb3434113b40685105d053df5880553f3e88774"}]}