)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"b4048f45537f00a6b61afb0577ae33641a206222","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"7009c867_a4b49b2c","updated":"2022-10-12 21:09:36.000000000","message":"i guess this also depends on the tripleo_nova_compute role landing","commit_id":"59751c2e2cbb65ced64465bf75681f1bc94f3d5a"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"826a903ec220f39aec88d837aa3f9a58447ebaa7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"3380f2e5_0b9d5578","in_reply_to":"7009c867_a4b49b2c","updated":"2022-10-13 11:39:49.000000000","message":"Yes, we should land those patches before releasing this doc update. Thanks for the review.","commit_id":"59751c2e2cbb65ced64465bf75681f1bc94f3d5a"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"0d3df6e7be904b067b960c7abef801d25d33ab16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"971849f2_86514981","updated":"2022-10-27 08:40:35.000000000","message":"@john do we want to have a note mentioning we still have bug #1994148 to solve but this is how the role should work once is included?\nI was thinking about merging this change but I\u0027m not sure we want to keep it on hold or just have a note and merge.","commit_id":"beac3367ead1e8e91c5bb18c27fcb5dd4e83fe01"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"939764b6cc49a3df1951362a176a6c1c28ca3496","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"3a7f6ccd_7b6403ce","updated":"2022-10-21 19:52:14.000000000","message":"Mikolaj, thank you for the review. I\u0027ve upladed PS14 which should address what you were asking about.\n\nAlso, now that the following have merged I think it\u0027s OK to merge this docs patch:\n\n- https://review.opendev.org/c/openstack/tripleo-ansible/+/858585\n- https://review.opendev.org/c/openstack/tripleo-ansible/+/860873\n- https://review.opendev.org/c/openstack/tripleo-ansible/+/859149\n","commit_id":"beac3367ead1e8e91c5bb18c27fcb5dd4e83fe01"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"12979b7c6d52fb133e10b94843fe8c8477e2118b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"9260444f_67a086bf","updated":"2022-10-27 10:04:30.000000000","message":"The description in this guide is correct. It is just a matter of solving bz mentioned by John.","commit_id":"beac3367ead1e8e91c5bb18c27fcb5dd4e83fe01"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"7c91fdb14f0429e0bbc546d7f3497140951b5081","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"476f6fb1_115d19b9","updated":"2022-10-25 16:20:24.000000000","message":"This document describes how things should work though we have a bug I need to fix.\n\n  https://bugs.launchpad.net/tripleo/+bug/1994148","commit_id":"beac3367ead1e8e91c5bb18c27fcb5dd4e83fe01"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"9143280c7f61728e4b4dc29935447fb4ee2f3403","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"dd43a9c8_f895ee35","in_reply_to":"971849f2_86514981","updated":"2022-10-27 20:35:43.000000000","message":"Thanks for the review. Let\u0027s wait until the bug is fixed.","commit_id":"beac3367ead1e8e91c5bb18c27fcb5dd4e83fe01"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"14fb923ca121fb65106e116c5a9d1f0af53b7216","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"db562fe9_f3ec10d6","updated":"2022-11-30 22:12:24.000000000","message":"I\u0027ve updated the doc to use the new Ansible role [1] which also solves [2]\n\n[1] https://review.opendev.org/c/openstack/tripleo-ansible/+/865197\n[2] https://bugs.launchpad.net/tripleo/+bug/1994148","commit_id":"0e8c26bdcda2aac2454f35f52af49fdfb3442b7f"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"03881f89ea93dc876b9fc5fd634ef4e796178ed5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"6b75f957_171c0f64","updated":"2023-01-10 13:40:17.000000000","message":"CI failure maybe related to\n\n https://review.opendev.org/c/openstack/tripleo-docs/+/868574\n \nrebased and trying again.","commit_id":"fb9fcb7275ab239c6bd5c29038d4e55ca2381569"}],"deploy-guide/source/features/ceph_external.rst":[{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"b4b08539486cb2ac58c81b7096a2d8c8d236ce52","unresolved":true,"context_lines":[{"line_number":269,"context_line":"The `tripleo_ceph_client`_ Ansible role may be used may be used"},{"line_number":270,"context_line":"standalone without tripleo-heat-templates or config-download."},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"A file, e.g. 08-ceph, like the following may be placed in the"},{"line_number":273,"context_line":"inventory directory::"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"  tripleo_ceph_cluster_fsid: \"604c9994-1d82-11ed-8ae5-5254003d6107\""}],"source_content_type":"text/x-rst","patch_set":13,"id":"46b6d842_57e092c0","line":272,"updated":"2022-10-21 13:03:34.000000000","message":"I believe these vars need to be defined in group_vars/compute if we want all computes to use external ceph(this would work the same as in your script https://github.com/fultonj/zed/blob/b6044b937ce9563509bde48f3132929168a952b1/standalone/ceph_vars.py#L22).","commit_id":"b49f7844ec5c999f177a1eb5a538d139d553f79d"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"16761dc987fcd972f756b8f36f55b61d06e0ca99","unresolved":false,"context_lines":[{"line_number":269,"context_line":"The `tripleo_ceph_client`_ Ansible role may be used may be used"},{"line_number":270,"context_line":"standalone without tripleo-heat-templates or config-download."},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"A file, e.g. 08-ceph, like the following may be placed in the"},{"line_number":273,"context_line":"inventory directory::"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"  tripleo_ceph_cluster_fsid: \"604c9994-1d82-11ed-8ae5-5254003d6107\""}],"source_content_type":"text/x-rst","patch_set":13,"id":"e15ab823_3d3ea37e","line":272,"in_reply_to":"46b6d842_57e092c0","updated":"2022-10-21 19:53:13.000000000","message":"Yes, please see PS14 which I believe now addresses this.\n\nhttps://review.opendev.org/c/openstack/tripleo-docs/+/859142/13..14/deploy-guide/source/features/ceph_external.rst","commit_id":"b49f7844ec5c999f177a1eb5a538d139d553f79d"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"b4b08539486cb2ac58c81b7096a2d8c8d236ce52","unresolved":true,"context_lines":[{"line_number":292,"context_line":"    - name: configure ceph client"},{"line_number":293,"context_line":"      import_role:"},{"line_number":294,"context_line":"        name: tripleo_ceph_client"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"Doing the above will result in the directory defined by"},{"line_number":297,"context_line":"`tripleo_ceph_client_config_home` being populated with two files:"},{"line_number":298,"context_line":"`ceph.client.openstack.keyring` (the cephx key) and `ceph.conf` (the"}],"source_content_type":"text/x-rst","patch_set":13,"id":"e1b61eca_c3e961c3","line":295,"updated":"2022-10-21 13:03:34.000000000","message":"There is no information about ceph_client group, which seems to be required by tripleo_ceph_client role.\n\nTASK [tripleo_ceph_client : set effective ceph_clients without limit] ************************************************************************************************************************************************************************\nfatal: [compute-2]: FAILED! \u003d\u003e {}\n\nMSG:\n\nThe task includes an option with an undefined variable. The error was: \u0027dict object\u0027 has no attribute \u0027ceph_client\u0027\n\nThe error appears to be in \u0027/home/stack/standalone-roles/tripleo-ansible/tripleo_ansible/roles/tripleo_ceph_client/tasks/sync.yml\u0027: line 20, column 7, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n  block:\n    - name: set effective ceph_clients without limit\n      ^ here","commit_id":"b49f7844ec5c999f177a1eb5a538d139d553f79d"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"16761dc987fcd972f756b8f36f55b61d06e0ca99","unresolved":false,"context_lines":[{"line_number":292,"context_line":"    - name: configure ceph client"},{"line_number":293,"context_line":"      import_role:"},{"line_number":294,"context_line":"        name: tripleo_ceph_client"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"Doing the above will result in the directory defined by"},{"line_number":297,"context_line":"`tripleo_ceph_client_config_home` being populated with two files:"},{"line_number":298,"context_line":"`ceph.client.openstack.keyring` (the cephx key) and `ceph.conf` (the"}],"source_content_type":"text/x-rst","patch_set":13,"id":"4c396d0a_f18cddc5","line":295,"in_reply_to":"e1b61eca_c3e961c3","updated":"2022-10-21 19:53:13.000000000","message":"Yes, please see PS14 which I believe now addresses this.\n\nhttps://review.opendev.org/c/openstack/tripleo-docs/+/859142/13..14/deploy-guide/source/features/ceph_external.rst","commit_id":"b49f7844ec5c999f177a1eb5a538d139d553f79d"}]}