)]}'
{"swift-storage-puppet.yaml":[{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"8449c910dce8e1c0eaee2a998a8117933406db1d","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    default: \u0027false\u0027"},{"line_number":28,"context_line":"    description: Value of mount_check in Swift account/container/object -server.conf"},{"line_number":29,"context_line":"    type: boolean"},{"line_number":30,"context_line":"  #FIXME: this is is not required. Leaving here for compatability with the overcloud template."},{"line_number":31,"context_line":"  NeutronEnableTunnelling:"},{"line_number":32,"context_line":"    default: \"True\""},{"line_number":33,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3a961159_85c1b431","line":30,"updated":"2015-01-12 12:02:29.000000000","message":"We may be able to clean up all the \"for compatibility\" parameters by moving to parameter defaults (global parameters):\n\nhttp://docs.openstack.org/developer/heat/template_guide/environment.html#define-defaults-to-parameters\n\nThis is a new feature we landed recently, where you can specify things you want globally available to all templates, but you don\u0027t necessarily have to define the parameters in the nested template if you don\u0027t need them (also, you don\u0027t need the scaffolding of passing properties into the resources down the tree).\n\nNot necessarily something to fix here, just FYI so we can consider a future cleanup.","commit_id":"5ca95a5ade473e80ca1515464423652bb9171dd7"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"06f607da83f59c70649e2591687b6165a95d8793","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    default: \u0027false\u0027"},{"line_number":28,"context_line":"    description: Value of mount_check in Swift account/container/object -server.conf"},{"line_number":29,"context_line":"    type: boolean"},{"line_number":30,"context_line":"  #FIXME: this is is not required. Leaving here for compatability with the overcloud template."},{"line_number":31,"context_line":"  NeutronEnableTunnelling:"},{"line_number":32,"context_line":"    default: \"True\""},{"line_number":33,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3a961159_81dfe1d5","line":30,"in_reply_to":"3a961159_85c1b431","updated":"2015-01-12 15:07:17.000000000","message":"There is a follow up patch that does the required cleanup here:\n\nhttps://review.openstack.org/#/c/146292/\n\nThese parameters are things we don\u0027t need globally (not just for Puppet). I just happened to notice them while reviewing all this during the puppet implementation.","commit_id":"5ca95a5ade473e80ca1515464423652bb9171dd7"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"8449c910dce8e1c0eaee2a998a8117933406db1d","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            storage:"},{"line_number":128,"context_line":"              raw_data: {get_file: puppet/hieradata/storage.yaml}"},{"line_number":129,"context_line":"              oac_data: # data we map in from other OAC configurations"},{"line_number":130,"context_line":"                tripleo::ringbuilder::devices: swift.devices"},{"line_number":131,"context_line":"              mapped_data: # data supplied directly to this deployment configuration, etc"},{"line_number":132,"context_line":"                swift::swift_hash_suffix: { get_input: swift_hash_suffix }"},{"line_number":133,"context_line":"                tripleo::ringbuilder::part_power: { get_input: swift_part_power }"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3a961159_456a6c1c","line":130,"updated":"2015-01-12 12:02:29.000000000","message":"This looks a little odd - can you clarify what oac_data is doing?\n\nIt looks a bit like we\u0027re somehow short-circuiting passing in the inputs by indirectly referencing data associated with some other config?","commit_id":"5ca95a5ade473e80ca1515464423652bb9171dd7"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"06f607da83f59c70649e2591687b6165a95d8793","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            storage:"},{"line_number":128,"context_line":"              raw_data: {get_file: puppet/hieradata/storage.yaml}"},{"line_number":129,"context_line":"              oac_data: # data we map in from other OAC configurations"},{"line_number":130,"context_line":"                tripleo::ringbuilder::devices: swift.devices"},{"line_number":131,"context_line":"              mapped_data: # data supplied directly to this deployment configuration, etc"},{"line_number":132,"context_line":"                swift::swift_hash_suffix: { get_input: swift_hash_suffix }"},{"line_number":133,"context_line":"                tripleo::ringbuilder::part_power: { get_input: swift_part_power }"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3a961159_8171a10e","line":130,"in_reply_to":"3a961159_456a6c1c","updated":"2015-01-12 15:07:17.000000000","message":"Steve: you are correct in that this indirectly references data associated with an \"external\" config. In this case swift.devices is obtained from the SwiftDevicesAndProxyConfig that is defined in overcloud-without-mergepy.yaml. Perhaps the oac data thing is a bit clever... but it works well and allows us to proceed without duplicating software config blobs all of the place. I\u0027m up for refactoring things to improve this however... but for now this works.","commit_id":"5ca95a5ade473e80ca1515464423652bb9171dd7"}]}