)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12398,"name":"Dan Sneddon","email":"dsneddon@redhat.com","username":"dsneddon"},"change_message_id":"73c31147d71b7239519380c651c8601662b73a14","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implement Advanced Firewalling support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Consumme puppet-tripleo to create/manage IPtables from Heat templates."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"WIP now, do not merge."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"fa32b979_7e66ca2a","line":9,"updated":"2015-06-26 15:30:05.000000000","message":"Nit: Consume instead of consumme","commit_id":"eef7eb0f1ffc321ed522a8a861420b9fa90d542e"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d065f941fc86a0d663d523b3609618bc15de5ae6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implement Advanced Firewalling support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Consumme puppet-tripleo to create/manage IPtables from Heat templates."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This review put in place the logic to enable and setup firewall rules."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"3a50d1a3_dc37b04b","line":9,"updated":"2015-07-27 07:58:18.000000000","message":"nit","commit_id":"41adf43b3aef8c68291ceca6e09d94223a8031fd"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"1dd64ddc75ddf8fe1d679164f152e75f1419267f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implement Advanced Firewalling support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Consumme puppet-tripleo to create/manage IPtables from Heat templates."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This review put in place the logic to enable and setup firewall rules."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"9a1a9d01_4930b601","line":9,"updated":"2015-09-28 08:39:45.000000000","message":"nit consumme","commit_id":"e91a12935438dee6898bde45e6792a3e48a97a48"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"3b865af54351d553405368daec27cf2ff247c344","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implement Advanced Firewalling support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Consumme puppet-tripleo to create/manage IPtables from Heat templates."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This review put in place the logic to enable and setup firewall rules."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"7a2fa921_51208c49","line":9,"in_reply_to":"9a1a9d01_4930b601","updated":"2015-10-13 02:31:52.000000000","message":"Done","commit_id":"e91a12935438dee6898bde45e6792a3e48a97a48"}],"controller.yaml":[{"author":{"_account_id":12398,"name":"Dan Sneddon","email":"dsneddon@redhat.com","username":"dsneddon"},"change_message_id":"0e6dac5cda18f00781cd7ad603f9a1dd518522fd","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    type: string"},{"line_number":70,"context_line":"  EnableFirewall:"},{"line_number":71,"context_line":"    default: false"},{"line_number":72,"context_line":"    description: Whether manage IPtables rules."},{"line_number":73,"context_line":"    type: boolean"},{"line_number":74,"context_line":"  EnableGalera:"},{"line_number":75,"context_line":"    default: true"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fa32b979_cb236fa6","line":72,"updated":"2015-06-16 02:35:09.000000000","message":"nit:\ndescription: Whether _to_ manage IPtables rules.","commit_id":"a437aea2857341d5ff86b293dae3255192d09418"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"1bac7e73e4b77999e664663152ee8f07f0f631fe","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    type: string"},{"line_number":70,"context_line":"  EnableFirewall:"},{"line_number":71,"context_line":"    default: false"},{"line_number":72,"context_line":"    description: Whether manage IPtables rules."},{"line_number":73,"context_line":"    type: boolean"},{"line_number":74,"context_line":"  EnableGalera:"},{"line_number":75,"context_line":"    default: true"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fa32b979_91133f0d","line":72,"in_reply_to":"fa32b979_cb236fa6","updated":"2015-06-16 13:59:14.000000000","message":"Done","commit_id":"a437aea2857341d5ff86b293dae3255192d09418"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"67749754e615cb62b539b7d8c9153fed358c08ba","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    description: Set to True to enable debugging on all services."},{"line_number":69,"context_line":"    type: string"},{"line_number":70,"context_line":"  ManageFirewall:"},{"line_number":71,"context_line":"    default: false"},{"line_number":72,"context_line":"    description: Whether to manage IPtables rules."},{"line_number":73,"context_line":"    type: boolean"},{"line_number":74,"context_line":"  EnableGalera:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ba3cc151_0dce285a","line":71,"updated":"2015-07-01 08:11:04.000000000","message":"We might even make all of these true by default?","commit_id":"1b429b323735a8deb119a5473776debde992030f"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"245a05bac8a9a90b11567cf0c30fca38f986891d","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    description: Set to True to enable debugging on all services."},{"line_number":69,"context_line":"    type: string"},{"line_number":70,"context_line":"  ManageFirewall:"},{"line_number":71,"context_line":"    default: false"},{"line_number":72,"context_line":"    description: Whether to manage IPtables rules."},{"line_number":73,"context_line":"    type: boolean"},{"line_number":74,"context_line":"  EnableGalera:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ba3cc151_fcfb5ebf","line":71,"in_reply_to":"ba3cc151_0dce285a","updated":"2015-07-01 15:03:52.000000000","message":"I don\u0027t agree. Firewalling should be disabled by default because it has a lot of downside and it also would not be backward compatible. But it\u0027s up to you guys :)","commit_id":"1b429b323735a8deb119a5473776debde992030f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d065f941fc86a0d663d523b3609618bc15de5ae6","unresolved":false,"context_lines":[{"line_number":245,"context_line":"    type: boolean"},{"line_number":246,"context_line":"  PurgeFirewallRules:"},{"line_number":247,"context_line":"    default: false"},{"line_number":248,"context_line":"    description: Whether IPtables rules should be purged before setting up the ones."},{"line_number":249,"context_line":"    type: boolean"},{"line_number":250,"context_line":"  MysqlClusterUniquePart:"},{"line_number":251,"context_line":"    description: A unique identifier of the MySQL cluster the controller is in."}],"source_content_type":"text/x-yaml","patch_set":19,"id":"3a50d1a3_fc2aace6","line":248,"updated":"2015-07-27 07:58:18.000000000","message":"needs some tweaking (new ones?)","commit_id":"41adf43b3aef8c68291ceca6e09d94223a8031fd"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"b3549702157f69bc2c74434f7071f437404b4ee7","unresolved":false,"context_lines":[{"line_number":261,"context_line":"    type: boolean"},{"line_number":262,"context_line":"  PurgeFirewallRules:"},{"line_number":263,"context_line":"    default: false"},{"line_number":264,"context_line":"    description: Whether IPtables rules should be purged before setting up the ones."},{"line_number":265,"context_line":"    type: boolean"},{"line_number":266,"context_line":"  MysqlClusterUniquePart:"},{"line_number":267,"context_line":"    description: A unique identifier of the MySQL cluster the controller is in."}],"source_content_type":"text/x-yaml","patch_set":22,"id":"1a4dcd0f_a92b2181","line":264,"updated":"2015-08-12 15:14:13.000000000","message":"Hehe still persisted \"ones\" vs. \"new ones\"\n\nProbably not a big deal as it\u0027s obvious what is meant, but would be nice to have it fixed nevertheless.","commit_id":"2163241798c9284207e5f430f12ca5566e018462"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"1dd64ddc75ddf8fe1d679164f152e75f1419267f","unresolved":false,"context_lines":[{"line_number":271,"context_line":"    type: boolean"},{"line_number":272,"context_line":"  PurgeFirewallRules:"},{"line_number":273,"context_line":"    default: false"},{"line_number":274,"context_line":"    description: Whether IPtables rules should be purged before setting up the ones."},{"line_number":275,"context_line":"    type: boolean"},{"line_number":276,"context_line":"  MysqlClusterUniquePart:"},{"line_number":277,"context_line":"    description: A unique identifier of the MySQL cluster the controller is in."}],"source_content_type":"text/x-yaml","patch_set":24,"id":"9a1a9d01_890d6e40","line":274,"updated":"2015-09-28 08:39:45.000000000","message":"new","commit_id":"e91a12935438dee6898bde45e6792a3e48a97a48"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"3b865af54351d553405368daec27cf2ff247c344","unresolved":false,"context_lines":[{"line_number":271,"context_line":"    type: boolean"},{"line_number":272,"context_line":"  PurgeFirewallRules:"},{"line_number":273,"context_line":"    default: false"},{"line_number":274,"context_line":"    description: Whether IPtables rules should be purged before setting up the ones."},{"line_number":275,"context_line":"    type: boolean"},{"line_number":276,"context_line":"  MysqlClusterUniquePart:"},{"line_number":277,"context_line":"    description: A unique identifier of the MySQL cluster the controller is in."}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7a2fa921_111a1418","line":274,"in_reply_to":"9a1a9d01_890d6e40","updated":"2015-10-13 02:31:52.000000000","message":"Done","commit_id":"e91a12935438dee6898bde45e6792a3e48a97a48"}],"environments/manage-firewall.yaml":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"a8a7d3abcf919dd44bffd98c38b31b6e9086faf6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"parameters:"},{"line_number":2,"context_line":"  ManageFirewall: true"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"3a29b11f_99e302d9","line":2,"updated":"2015-10-22 15:56:55.000000000","message":"Not sure we need a sample environment file for one param, but *shrug*.","commit_id":"6ef8c213e563ff17b560f73c56706e60c48bec09"}],"os-apply-config/controller.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"75853c0a0192fc9666f0f24e9450544b9f20b4b7","unresolved":false,"context_lines":[{"line_number":274,"context_line":"  PurgeFirewallRules:"},{"line_number":275,"context_line":"    default: false"},{"line_number":276,"context_line":"    description: Whether IPtables rules should be purged before setting up the new ones."},{"line_number":277,"context_line":"    type: boolean"},{"line_number":278,"context_line":"  MysqlClusterUniquePart:"},{"line_number":279,"context_line":"    description: A unique identifier of the MySQL cluster the controller is in."},{"line_number":280,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"fa80f949_98ca846d","line":277,"updated":"2015-11-05 08:00:03.000000000","message":"I would even just drop this file - eveything being added here is dependent on config via the tripleo puppet module (and by now there is a huge gap between the functionality included in the oac/ vs puppet/ templates as most reviews recently have ommitted to change the oac equivalents for the roles)","commit_id":"df9dd20c5adb2a09f5ee71df77ed3683568e0a00"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"cee370a7eaf652dfcb9c7ddf19c6aea27ccca70c","unresolved":false,"context_lines":[{"line_number":274,"context_line":"  PurgeFirewallRules:"},{"line_number":275,"context_line":"    default: false"},{"line_number":276,"context_line":"    description: Whether IPtables rules should be purged before setting up the new ones."},{"line_number":277,"context_line":"    type: boolean"},{"line_number":278,"context_line":"  MysqlClusterUniquePart:"},{"line_number":279,"context_line":"    description: A unique identifier of the MySQL cluster the controller is in."},{"line_number":280,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"fa80f949_f0d719eb","line":277,"in_reply_to":"fa80f949_507dc56c","updated":"2015-11-05 13:48:52.000000000","message":"sorry, as on irc, i just mean we no longer update thes os-apply-config templates (under the os-apply-config directory) since we are deploying with the /puppet/ templates.\n\nIt doesn\u0027t really matter if you do/don\u0027t include this file, am just saying we no longer include these in the changes we make to the templates","commit_id":"df9dd20c5adb2a09f5ee71df77ed3683568e0a00"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"0e01e2c502dca27e582c33f7cd2d7d160ca5f034","unresolved":false,"context_lines":[{"line_number":274,"context_line":"  PurgeFirewallRules:"},{"line_number":275,"context_line":"    default: false"},{"line_number":276,"context_line":"    description: Whether IPtables rules should be purged before setting up the new ones."},{"line_number":277,"context_line":"    type: boolean"},{"line_number":278,"context_line":"  MysqlClusterUniquePart:"},{"line_number":279,"context_line":"    description: A unique identifier of the MySQL cluster the controller is in."},{"line_number":280,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"fa80f949_507dc56c","line":277,"in_reply_to":"fa80f949_98ca846d","updated":"2015-11-05 13:42:46.000000000","message":"This comment looks really blurred to me, I don\u0027t understand, I\u0027m sorry.\n\nPlease take over my patch if you know what we need to do.\n\nThanks","commit_id":"df9dd20c5adb2a09f5ee71df77ed3683568e0a00"}],"overcloud-without-mergepy.yaml":[{"author":{"_account_id":12398,"name":"Dan Sneddon","email":"dsneddon@redhat.com","username":"dsneddon"},"change_message_id":"0e6dac5cda18f00781cd7ad603f9a1dd518522fd","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    default: \u0027br-ex\u0027"},{"line_number":264,"context_line":"    description: Interface where virtual ip will be assigned."},{"line_number":265,"context_line":"    type: string"},{"line_number":266,"context_line":"  EnableFirewall:"},{"line_number":267,"context_line":"    default: false"},{"line_number":268,"context_line":"    description: Whether manage IPtables rules."},{"line_number":269,"context_line":"    type: boolean"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fa32b979_ab7ceb72","line":266,"updated":"2015-06-16 02:35:09.000000000","message":"I think enable firewall might be misleading. If this is false, there might still be a firewall in place. it just isn\u0027t being managed by tripleo. The eventual setting is tripleo::manage_firewall, so maybe this should just be ManageFirewall and manage_firewall here in the Heat templates too?","commit_id":"a437aea2857341d5ff86b293dae3255192d09418"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"1bac7e73e4b77999e664663152ee8f07f0f631fe","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    default: \u0027br-ex\u0027"},{"line_number":264,"context_line":"    description: Interface where virtual ip will be assigned."},{"line_number":265,"context_line":"    type: string"},{"line_number":266,"context_line":"  EnableFirewall:"},{"line_number":267,"context_line":"    default: false"},{"line_number":268,"context_line":"    description: Whether manage IPtables rules."},{"line_number":269,"context_line":"    type: boolean"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fa32b979_b12d2348","line":266,"in_reply_to":"fa32b979_ab7ceb72","updated":"2015-06-16 13:59:14.000000000","message":"Done","commit_id":"a437aea2857341d5ff86b293dae3255192d09418"},{"author":{"_account_id":12398,"name":"Dan Sneddon","email":"dsneddon@redhat.com","username":"dsneddon"},"change_message_id":"0e6dac5cda18f00781cd7ad603f9a1dd518522fd","unresolved":false,"context_lines":[{"line_number":265,"context_line":"    type: string"},{"line_number":266,"context_line":"  EnableFirewall:"},{"line_number":267,"context_line":"    default: false"},{"line_number":268,"context_line":"    description: Whether manage IPtables rules."},{"line_number":269,"context_line":"    type: boolean"},{"line_number":270,"context_line":"  EnableGalera:"},{"line_number":271,"context_line":"    default: true"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fa32b979_6b3b43d2","line":268,"updated":"2015-06-16 02:35:09.000000000","message":"nit: same here","commit_id":"a437aea2857341d5ff86b293dae3255192d09418"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"1bac7e73e4b77999e664663152ee8f07f0f631fe","unresolved":false,"context_lines":[{"line_number":265,"context_line":"    type: string"},{"line_number":266,"context_line":"  EnableFirewall:"},{"line_number":267,"context_line":"    default: false"},{"line_number":268,"context_line":"    description: Whether manage IPtables rules."},{"line_number":269,"context_line":"    type: boolean"},{"line_number":270,"context_line":"  EnableGalera:"},{"line_number":271,"context_line":"    default: true"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fa32b979_f1040bc1","line":268,"in_reply_to":"fa32b979_6b3b43d2","updated":"2015-06-16 13:59:14.000000000","message":"Done","commit_id":"a437aea2857341d5ff86b293dae3255192d09418"}],"puppet/controller-puppet.yaml":[{"author":{"_account_id":12398,"name":"Dan Sneddon","email":"dsneddon@redhat.com","username":"dsneddon"},"change_message_id":"0e6dac5cda18f00781cd7ad603f9a1dd518522fd","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    type: string"},{"line_number":75,"context_line":"  EnableFirewall:"},{"line_number":76,"context_line":"    default: false"},{"line_number":77,"context_line":"    description: Whether manage IPtables rules."},{"line_number":78,"context_line":"    type: boolean"},{"line_number":79,"context_line":"  EnableGalera:"},{"line_number":80,"context_line":"    default: true"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fa32b979_8b36c7e5","line":77,"updated":"2015-06-16 02:35:09.000000000","message":"nit: same here","commit_id":"a437aea2857341d5ff86b293dae3255192d09418"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"1bac7e73e4b77999e664663152ee8f07f0f631fe","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    type: string"},{"line_number":75,"context_line":"  EnableFirewall:"},{"line_number":76,"context_line":"    default: false"},{"line_number":77,"context_line":"    description: Whether manage IPtables rules."},{"line_number":78,"context_line":"    type: boolean"},{"line_number":79,"context_line":"  EnableGalera:"},{"line_number":80,"context_line":"    default: true"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fa32b979_71279b64","line":77,"in_reply_to":"fa32b979_8b36c7e5","updated":"2015-06-16 13:59:14.000000000","message":"Done","commit_id":"a437aea2857341d5ff86b293dae3255192d09418"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"67749754e615cb62b539b7d8c9153fed358c08ba","unresolved":false,"context_lines":[{"line_number":638,"context_line":"            - - \u0027http://\u0027"},{"line_number":639,"context_line":"              - {get_param: KeystonePublicApiVirtualIP}"},{"line_number":640,"context_line":"              - \u0027:5000/v2.0/\u0027"},{"line_number":641,"context_line":"        enable_firewall: {get_param: ManageFirewall}"},{"line_number":642,"context_line":"        enable_galera: {get_param: EnableGalera}"},{"line_number":643,"context_line":"        enable_ceph_storage: {get_param: EnableCephStorage}"},{"line_number":644,"context_line":"        enable_swift_storage: {get_param: EnableSwiftStorage}"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ba3cc151_8d2f98f5","line":641,"updated":"2015-07-01 08:11:04.000000000","message":"We could name it \"manage_firewall\" to have it consistent with \"ManageFirewall\" and \"tripleo::manage_firewall\". Not a blocker though.","commit_id":"1b429b323735a8deb119a5473776debde992030f"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"245a05bac8a9a90b11567cf0c30fca38f986891d","unresolved":false,"context_lines":[{"line_number":638,"context_line":"            - - \u0027http://\u0027"},{"line_number":639,"context_line":"              - {get_param: KeystonePublicApiVirtualIP}"},{"line_number":640,"context_line":"              - \u0027:5000/v2.0/\u0027"},{"line_number":641,"context_line":"        enable_firewall: {get_param: ManageFirewall}"},{"line_number":642,"context_line":"        enable_galera: {get_param: EnableGalera}"},{"line_number":643,"context_line":"        enable_ceph_storage: {get_param: EnableCephStorage}"},{"line_number":644,"context_line":"        enable_swift_storage: {get_param: EnableSwiftStorage}"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ba3cc151_bcef16e8","line":641,"in_reply_to":"ba3cc151_8d2f98f5","updated":"2015-07-01 15:03:52.000000000","message":"ok will do.","commit_id":"1b429b323735a8deb119a5473776debde992030f"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"2854197b78dd4fe391c729ad2fb700c4b84a538f","unresolved":false,"context_lines":[{"line_number":638,"context_line":"            - - \u0027http://\u0027"},{"line_number":639,"context_line":"              - {get_param: KeystonePublicApiVirtualIP}"},{"line_number":640,"context_line":"              - \u0027:5000/v2.0/\u0027"},{"line_number":641,"context_line":"        enable_firewall: {get_param: ManageFirewall}"},{"line_number":642,"context_line":"        enable_galera: {get_param: EnableGalera}"},{"line_number":643,"context_line":"        enable_ceph_storage: {get_param: EnableCephStorage}"},{"line_number":644,"context_line":"        enable_swift_storage: {get_param: EnableSwiftStorage}"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ba3cc151_9a4ce477","line":641,"in_reply_to":"ba3cc151_bcef16e8","updated":"2015-07-06 20:18:16.000000000","message":"Done","commit_id":"1b429b323735a8deb119a5473776debde992030f"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"161349d2da00759bd6fe008d98881c10d19333d9","unresolved":false,"context_lines":[{"line_number":997,"context_line":"                redis::bind: {get_input: redis_network}"},{"line_number":998,"context_line":"                redis_vip: {get_input: redis_vip}"},{"line_number":999,"context_line":"                # Firewall"},{"line_number":1000,"context_line":"                # enable it for debug/testing purpose:"},{"line_number":1001,"context_line":"                tripleo::manage_firewall: true"},{"line_number":1002,"context_line":"                # tripleo::manage_firewall: {get_input: enable_firewall}"},{"line_number":1003,"context_line":"                #TODO(EmilienM) enable later, after testing"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ba3cc151_300a5f22","line":1000,"updated":"2015-07-01 08:15:32.000000000","message":"Unless i missed something, you\u0027ll also need this line here to make the manage_firewall variable accessible in hiera (the code below assumes we do the rename from enable_firewall to manage_firewall too):\n\n    manage_firewall: {get_input: manage_firewall}","commit_id":"1b429b323735a8deb119a5473776debde992030f"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"245a05bac8a9a90b11567cf0c30fca38f986891d","unresolved":false,"context_lines":[{"line_number":997,"context_line":"                redis::bind: {get_input: redis_network}"},{"line_number":998,"context_line":"                redis_vip: {get_input: redis_vip}"},{"line_number":999,"context_line":"                # Firewall"},{"line_number":1000,"context_line":"                # enable it for debug/testing purpose:"},{"line_number":1001,"context_line":"                tripleo::manage_firewall: true"},{"line_number":1002,"context_line":"                # tripleo::manage_firewall: {get_input: enable_firewall}"},{"line_number":1003,"context_line":"                #TODO(EmilienM) enable later, after testing"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ba3cc151_1ce72212","line":1000,"in_reply_to":"ba3cc151_300a5f22","updated":"2015-07-01 15:03:52.000000000","message":"yes, this is just for testing here. I\u0027ll add the parameter later.","commit_id":"1b429b323735a8deb119a5473776debde992030f"}],"puppet/controller.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"1dd64ddc75ddf8fe1d679164f152e75f1419267f","unresolved":false,"context_lines":[{"line_number":243,"context_line":"    type: boolean"},{"line_number":244,"context_line":"  PurgeFirewallRules:"},{"line_number":245,"context_line":"    default: false"},{"line_number":246,"context_line":"    description: Whether IPtables rules should be purged before setting up the ones."},{"line_number":247,"context_line":"    type: boolean"},{"line_number":248,"context_line":"  MysqlClusterUniquePart:"},{"line_number":249,"context_line":"    description: A unique identifier of the MySQL cluster the controller is in."}],"source_content_type":"text/x-yaml","patch_set":24,"id":"9a1a9d01_291c6276","line":246,"updated":"2015-09-28 08:39:45.000000000","message":"new ones (from v19)","commit_id":"e91a12935438dee6898bde45e6792a3e48a97a48"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"3b865af54351d553405368daec27cf2ff247c344","unresolved":false,"context_lines":[{"line_number":243,"context_line":"    type: boolean"},{"line_number":244,"context_line":"  PurgeFirewallRules:"},{"line_number":245,"context_line":"    default: false"},{"line_number":246,"context_line":"    description: Whether IPtables rules should be purged before setting up the ones."},{"line_number":247,"context_line":"    type: boolean"},{"line_number":248,"context_line":"  MysqlClusterUniquePart:"},{"line_number":249,"context_line":"    description: A unique identifier of the MySQL cluster the controller is in."}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7a2fa921_91dce447","line":246,"in_reply_to":"9a1a9d01_291c6276","updated":"2015-10-13 02:31:52.000000000","message":"Done","commit_id":"e91a12935438dee6898bde45e6792a3e48a97a48"}],"puppet/hieradata/controller.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"75853c0a0192fc9666f0f24e9450544b9f20b4b7","unresolved":false,"context_lines":[{"line_number":218,"context_line":"  \u0027122 swift proxy\u0027:"},{"line_number":219,"context_line":"    port:"},{"line_number":220,"context_line":"      - 8080"},{"line_number":221,"context_line":"      - 13080"},{"line_number":222,"context_line":"  \u0027123 swift storage\u0027:"},{"line_number":223,"context_line":"    port:"},{"line_number":224,"context_line":"      - 873"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"fa80f949_b882e8fe","line":221,"updated":"2015-11-05 08:00:03.000000000","message":"again here, as per https://github.com/openstack/puppet-tripleo/commit/37b58bef9e51d6a39cbd9f71e2df9f70148ccbb5 this port should be 13808 to resolve the conflict with nova","commit_id":"df9dd20c5adb2a09f5ee71df77ed3683568e0a00"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a1cd27f502e9214ab617839dc6d296785c150ba7","unresolved":false,"context_lines":[{"line_number":218,"context_line":"  \u0027122 swift proxy\u0027:"},{"line_number":219,"context_line":"    port:"},{"line_number":220,"context_line":"      - 8080"},{"line_number":221,"context_line":"      - 13080"},{"line_number":222,"context_line":"  \u0027123 swift storage\u0027:"},{"line_number":223,"context_line":"    port:"},{"line_number":224,"context_line":"      - 873"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"fa80f949_509aa564","line":221,"in_reply_to":"fa80f949_b882e8fe","updated":"2015-11-05 13:48:10.000000000","message":"Done","commit_id":"df9dd20c5adb2a09f5ee71df77ed3683568e0a00"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"75853c0a0192fc9666f0f24e9450544b9f20b4b7","unresolved":false,"context_lines":[{"line_number":232,"context_line":"  \u0027125 heat\u0027:"},{"line_number":233,"context_line":"    port:"},{"line_number":234,"context_line":"      - 8000"},{"line_number":235,"context_line":"      - 13000"},{"line_number":236,"context_line":"      - 8003"},{"line_number":237,"context_line":"      - 13003"},{"line_number":238,"context_line":"      - 8004"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"fa80f949_d829ec38","line":235,"updated":"2015-11-05 08:00:03.000000000","message":"this should be 13800 as per bnemec comment","commit_id":"df9dd20c5adb2a09f5ee71df77ed3683568e0a00"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a1cd27f502e9214ab617839dc6d296785c150ba7","unresolved":false,"context_lines":[{"line_number":232,"context_line":"  \u0027125 heat\u0027:"},{"line_number":233,"context_line":"    port:"},{"line_number":234,"context_line":"      - 8000"},{"line_number":235,"context_line":"      - 13000"},{"line_number":236,"context_line":"      - 8003"},{"line_number":237,"context_line":"      - 13003"},{"line_number":238,"context_line":"      - 8004"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"fa80f949_f0c0792c","line":235,"in_reply_to":"fa80f949_d829ec38","updated":"2015-11-05 13:48:10.000000000","message":"Done","commit_id":"df9dd20c5adb2a09f5ee71df77ed3683568e0a00"}],"puppet/manifests/overcloud_cephstorage.pp":[{"author":{"_account_id":12398,"name":"Dan Sneddon","email":"dsneddon@redhat.com","username":"dsneddon"},"change_message_id":"0e6dac5cda18f00781cd7ad603f9a1dd518522fd","unresolved":false,"context_lines":[{"line_number":33,"context_line":"}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"include ::ceph::profile::client"},{"line_number":36,"context_line":"include ::ceph::profile::osd"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa32b979_2be8db0f","line":36,"updated":"2015-06-16 02:35:09.000000000","message":"I\u0027m not sure if this is just my display, but it looks like there is an extra whitespace character after \u0027osd\u0027","commit_id":"a437aea2857341d5ff86b293dae3255192d09418"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"475a0513ef1b11abd65bec1af64362ef27367853","unresolved":false,"context_lines":[{"line_number":33,"context_line":"}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"include ::ceph::profile::client"},{"line_number":36,"context_line":"include ::ceph::profile::osd"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"fa32b979_9e46fc1f","line":36,"updated":"2015-06-22 19:42:59.000000000","message":"extra change here?","commit_id":"41073a433dee3cf69c9c993397069ea533277f4b"}],"puppet/manifests/overcloud_controller.pp":[{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"475a0513ef1b11abd65bec1af64362ef27367853","unresolved":false,"context_lines":[{"line_number":29,"context_line":"if str2bool(hiera(\u0027enable_firewall\u0027, \u0027true\u0027)) {"},{"line_number":30,"context_line":"  $rules \u003d {"},{"line_number":31,"context_line":"    # TCP rules"},{"line_number":32,"context_line":"    \u0027mongodb_config\u0027   \u003d\u003e { port \u003d\u003e 27019 },"},{"line_number":33,"context_line":"    \u0027mongodb_sharding\u0027 \u003d\u003e { port \u003d\u003e 27018 },"},{"line_number":34,"context_line":"    \u0027mongod\u0027           \u003d\u003e { port \u003d\u003e 27017 },"},{"line_number":35,"context_line":"    \u0027mysql\u0027            \u003d\u003e { port \u003d\u003e 3306 },"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"fa32b979_be40a008","line":32,"updated":"2015-06-22 19:42:59.000000000","message":"CI is complaining about this line. (Invalid value \\\"mongodb_config\\\").","commit_id":"41073a433dee3cf69c9c993397069ea533277f4b"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"589687ce5c9d47621af9fcc120488648cdb7dcad","unresolved":false,"context_lines":[{"line_number":29,"context_line":"if str2bool(hiera(\u0027enable_firewall\u0027, \u0027true\u0027)) {"},{"line_number":30,"context_line":"  $rules \u003d {"},{"line_number":31,"context_line":"    # TCP rules"},{"line_number":32,"context_line":"    \u0027mongodb_config\u0027   \u003d\u003e { port \u003d\u003e 27019 },"},{"line_number":33,"context_line":"    \u0027mongodb_sharding\u0027 \u003d\u003e { port \u003d\u003e 27018 },"},{"line_number":34,"context_line":"    \u0027mongod\u0027           \u003d\u003e { port \u003d\u003e 27017 },"},{"line_number":35,"context_line":"    \u0027mysql\u0027            \u003d\u003e { port \u003d\u003e 3306 },"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"fa32b979_161650f1","line":32,"in_reply_to":"fa32b979_be40a008","updated":"2015-06-22 20:47:23.000000000","message":"Done","commit_id":"41073a433dee3cf69c9c993397069ea533277f4b"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"475a0513ef1b11abd65bec1af64362ef27367853","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    \u0027redis_sentinel\u0027   \u003d\u003e { port \u003d\u003e 26379 },"},{"line_number":38,"context_line":"    \u0027haproxy_monitor\u0027  \u003d\u003e { port \u003d\u003e 10300 },"},{"line_number":39,"context_line":"    # UDP rules"},{"line_number":40,"context_line":"    \u0027ntp\u0027              \u003d\u003e { port \u003d\u003e 123, proto \u003d\u003e \u0027udp\u0027 },"},{"line_number":41,"context_line":"  }"},{"line_number":42,"context_line":"  create_resources(\u0027tripleo::firewall::rule\u0027, $rules)"},{"line_number":43,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"fa32b979_de280436","line":40,"updated":"2015-06-22 19:42:59.000000000","message":"Should we put all of these rules into a hieradata file directly? And then just enable them here via create_resources instead?","commit_id":"41073a433dee3cf69c9c993397069ea533277f4b"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"589687ce5c9d47621af9fcc120488648cdb7dcad","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    \u0027redis_sentinel\u0027   \u003d\u003e { port \u003d\u003e 26379 },"},{"line_number":38,"context_line":"    \u0027haproxy_monitor\u0027  \u003d\u003e { port \u003d\u003e 10300 },"},{"line_number":39,"context_line":"    # UDP rules"},{"line_number":40,"context_line":"    \u0027ntp\u0027              \u003d\u003e { port \u003d\u003e 123, proto \u003d\u003e \u0027udp\u0027 },"},{"line_number":41,"context_line":"  }"},{"line_number":42,"context_line":"  create_resources(\u0027tripleo::firewall::rule\u0027, $rules)"},{"line_number":43,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"fa32b979_56e37805","line":40,"in_reply_to":"fa32b979_de280436","updated":"2015-06-22 20:47:23.000000000","message":"sounds good. Next patchset will address that with a few rules to see how it works in CI","commit_id":"41073a433dee3cf69c9c993397069ea533277f4b"}],"puppet/manifests/overcloud_object.pp":[{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"378cb09163e112b094b2e07378240b5fc623d133","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  snmpd_config \u003d\u003e [ join([\u0027rouser \u0027, hiera(\u0027snmpd_readonly_user_name\u0027)]), \u0027proc  cron\u0027, \u0027includeAllDisks  10%\u0027, \u0027master agentx\u0027, \u0027trapsink localhost public\u0027, \u0027iquerySecName internalUser\u0027, \u0027rouser internalUser\u0027, \u0027defaultMonitors yes\u0027, \u0027linkUpDownNotifications yes\u0027 ],"},{"line_number":50,"context_line":"}"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"hiera_include(\u0027object_classes\u0027)"}],"source_content_type":"text/x-puppet","patch_set":19,"id":"1a4dcd0f_6ffd146d","line":52,"updated":"2015-08-06 17:49:51.000000000","message":"I think this has already been added in I61d64d2498bed5c49376dee917d106598392db51. (posted later but it landed first).","commit_id":"41adf43b3aef8c68291ceca6e09d94223a8031fd"},{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"d541cb330e0f044124165339ce06bddb52a5c6b7","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  snmpd_config \u003d\u003e [ join([\u0027rouser \u0027, hiera(\u0027snmpd_readonly_user_name\u0027)]), \u0027proc  cron\u0027, \u0027includeAllDisks  10%\u0027, \u0027master agentx\u0027, \u0027trapsink localhost public\u0027, \u0027iquerySecName internalUser\u0027, \u0027rouser internalUser\u0027, \u0027defaultMonitors yes\u0027, \u0027linkUpDownNotifications yes\u0027 ],"},{"line_number":50,"context_line":"}"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"hiera_include(\u0027object_classes\u0027)"}],"source_content_type":"text/x-puppet","patch_set":19,"id":"1a4dcd0f_39668451","line":52,"in_reply_to":"1a4dcd0f_6ffd146d","updated":"2015-08-12 14:04:30.000000000","message":"done","commit_id":"41adf43b3aef8c68291ceca6e09d94223a8031fd"}],"puppet/manifests/overcloud_volume.pp":[{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"378cb09163e112b094b2e07378240b5fc623d133","unresolved":false,"context_lines":[{"line_number":53,"context_line":"  snmpd_config \u003d\u003e [ join([\u0027rouser \u0027, hiera(\u0027snmpd_readonly_user_name\u0027)]), \u0027proc  cron\u0027, \u0027includeAllDisks  10%\u0027, \u0027master agentx\u0027, \u0027trapsink localhost public\u0027, \u0027iquerySecName internalUser\u0027, \u0027rouser internalUser\u0027, \u0027defaultMonitors yes\u0027, \u0027linkUpDownNotifications yes\u0027 ],"},{"line_number":54,"context_line":"}"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"hiera_include(\u0027volume_classes\u0027)"}],"source_content_type":"text/x-puppet","patch_set":19,"id":"1a4dcd0f_6f343449","line":56,"updated":"2015-08-06 17:49:51.000000000","message":"ditto here: Already done in I61d64d2498bed5c49376dee917d106598392db51 right?","commit_id":"41adf43b3aef8c68291ceca6e09d94223a8031fd"},{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"d541cb330e0f044124165339ce06bddb52a5c6b7","unresolved":false,"context_lines":[{"line_number":53,"context_line":"  snmpd_config \u003d\u003e [ join([\u0027rouser \u0027, hiera(\u0027snmpd_readonly_user_name\u0027)]), \u0027proc  cron\u0027, \u0027includeAllDisks  10%\u0027, \u0027master agentx\u0027, \u0027trapsink localhost public\u0027, \u0027iquerySecName internalUser\u0027, \u0027rouser internalUser\u0027, \u0027defaultMonitors yes\u0027, \u0027linkUpDownNotifications yes\u0027 ],"},{"line_number":54,"context_line":"}"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"hiera_include(\u0027volume_classes\u0027)"}],"source_content_type":"text/x-puppet","patch_set":19,"id":"1a4dcd0f_39cd2431","line":56,"in_reply_to":"1a4dcd0f_6f343449","updated":"2015-08-12 14:04:30.000000000","message":"done","commit_id":"41adf43b3aef8c68291ceca6e09d94223a8031fd"}]}