)]}'
{"puppet/manifests/overcloud_controller.pp":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"4a10f55d8c0b97794ea03d71ae8ab1d9e29bb0bb","unresolved":false,"context_lines":[{"line_number":346,"context_line":"    }"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"    cinder::backend::netapp { $cinder_netapp_backend :"},{"line_number":349,"context_line":"      netapp_login                 \u003d\u003e hiera(\u0027cinder::backend::netapp::netapp_login\u0027, undef),"},{"line_number":350,"context_line":"      netapp_password              \u003d\u003e hiera(\u0027cinder::backend::netapp::netapp_password\u0027, undef),"},{"line_number":351,"context_line":"      netapp_server_hostname       \u003d\u003e hiera(\u0027cinder::backend::netapp::netapp_server_hostname\u0027, undef),"},{"line_number":352,"context_line":"      netapp_server_port           \u003d\u003e hiera(\u0027cinder::backend::netapp::netapp_server_port\u0027, undef),"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa32b979_6b77c3d4","line":349,"updated":"2015-06-22 15:27:18.000000000","message":"this is not the case, they should work without the need to call hiera() explicitly, as it happens in other parts of the code","commit_id":"12e9c9ed0635d5f599629d7d8d7bf626e0b50f35"},{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"fbffa387237b8b4e7a356ffa750db6650db54703","unresolved":false,"context_lines":[{"line_number":346,"context_line":"    }"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"    cinder::backend::netapp { $cinder_netapp_backend :"},{"line_number":349,"context_line":"      netapp_login                 \u003d\u003e hiera(\u0027cinder::backend::netapp::netapp_login\u0027, undef),"},{"line_number":350,"context_line":"      netapp_password              \u003d\u003e hiera(\u0027cinder::backend::netapp::netapp_password\u0027, undef),"},{"line_number":351,"context_line":"      netapp_server_hostname       \u003d\u003e hiera(\u0027cinder::backend::netapp::netapp_server_hostname\u0027, undef),"},{"line_number":352,"context_line":"      netapp_server_port           \u003d\u003e hiera(\u0027cinder::backend::netapp::netapp_server_port\u0027, undef),"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa32b979_be04b914","line":349,"in_reply_to":"fa32b979_33946289","updated":"2015-06-24 16:06:57.000000000","message":"@Giulio: If we make the assumption we can have only 1 cinder netapp backend per deployment we can use cinder::volume::netapp[1].\n\nElse the only way to avoid that is to use create_resources() with the parameters being in the hiera file.\n\nElse the way it is done here is the only way that applies.\n\n[1] https://github.com/openstack/puppet-cinder/blob/master/manifests/volume/netapp.pp","commit_id":"12e9c9ed0635d5f599629d7d8d7bf626e0b50f35"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"de3d6dd959e6aaddc8ab2e6f849640653391378f","unresolved":false,"context_lines":[{"line_number":346,"context_line":"    }"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"    cinder::backend::netapp { $cinder_netapp_backend :"},{"line_number":349,"context_line":"      netapp_login                 \u003d\u003e hiera(\u0027cinder::backend::netapp::netapp_login\u0027, undef),"},{"line_number":350,"context_line":"      netapp_password              \u003d\u003e hiera(\u0027cinder::backend::netapp::netapp_password\u0027, undef),"},{"line_number":351,"context_line":"      netapp_server_hostname       \u003d\u003e hiera(\u0027cinder::backend::netapp::netapp_server_hostname\u0027, undef),"},{"line_number":352,"context_line":"      netapp_server_port           \u003d\u003e hiera(\u0027cinder::backend::netapp::netapp_server_port\u0027, undef),"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa32b979_b1c9bcae","line":349,"in_reply_to":"fa32b979_6b77c3d4","updated":"2015-06-22 15:51:01.000000000","message":"this should work by calling the block with:\n\n  class { \u0027::cinder::backend::netapp\u0027 :\n\nas pointed out on IRC by Ryan, this won\u0027t work if multiple backends of the same type are defined, calling hiera() with same arg won\u0027t do it either though.","commit_id":"12e9c9ed0635d5f599629d7d8d7bf626e0b50f35"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"ab3be7f5259faf00a8897d78144c66c64c772871","unresolved":false,"context_lines":[{"line_number":346,"context_line":"    }"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"    cinder::backend::netapp { $cinder_netapp_backend :"},{"line_number":349,"context_line":"      netapp_login                 \u003d\u003e hiera(\u0027cinder::backend::netapp::netapp_login\u0027, undef),"},{"line_number":350,"context_line":"      netapp_password              \u003d\u003e hiera(\u0027cinder::backend::netapp::netapp_password\u0027, undef),"},{"line_number":351,"context_line":"      netapp_server_hostname       \u003d\u003e hiera(\u0027cinder::backend::netapp::netapp_server_hostname\u0027, undef),"},{"line_number":352,"context_line":"      netapp_server_port           \u003d\u003e hiera(\u0027cinder::backend::netapp::netapp_server_port\u0027, undef),"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa32b979_33946289","line":349,"in_reply_to":"fa32b979_b1c9bcae","updated":"2015-06-24 15:51:56.000000000","message":"auch, cinder::backend::$type is a define, not a class, hiera databinding only works on classes","commit_id":"12e9c9ed0635d5f599629d7d8d7bf626e0b50f35"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"634953d6e3161dc8462115559267afab3b6ca3d1","unresolved":false,"context_lines":[{"line_number":346,"context_line":"    }"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"    cinder::backend::netapp { $cinder_netapp_backend :"},{"line_number":349,"context_line":"      netapp_login                 \u003d\u003e hiera(\u0027cinder::backend::netapp::netapp_login\u0027, undef),"},{"line_number":350,"context_line":"      netapp_password              \u003d\u003e hiera(\u0027cinder::backend::netapp::netapp_password\u0027, undef),"},{"line_number":351,"context_line":"      netapp_server_hostname       \u003d\u003e hiera(\u0027cinder::backend::netapp::netapp_server_hostname\u0027, undef),"},{"line_number":352,"context_line":"      netapp_server_port           \u003d\u003e hiera(\u0027cinder::backend::netapp::netapp_server_port\u0027, undef),"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa32b979_1e6b65b8","line":349,"in_reply_to":"fa32b979_be04b914","updated":"2015-06-24 16:10:03.000000000","message":"if create_resources would still force to us copy/paste the hiera calls then I think this is good for now","commit_id":"12e9c9ed0635d5f599629d7d8d7bf626e0b50f35"}],"puppet/manifests/overcloud_controller_pacemaker.pp":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"de3d6dd959e6aaddc8ab2e6f849640653391378f","unresolved":false,"context_lines":[{"line_number":596,"context_line":"    }"},{"line_number":597,"context_line":""},{"line_number":598,"context_line":"    cinder::backend::netapp { $cinder_netapp_backend :"},{"line_number":599,"context_line":"      netapp_login                 \u003d\u003e hiera(\u0027cinder::backend::netapp::netapp_login\u0027, undef),"},{"line_number":600,"context_line":"      netapp_password              \u003d\u003e hiera(\u0027cinder::backend::netapp::netapp_password\u0027, undef),"},{"line_number":601,"context_line":"      netapp_server_hostname       \u003d\u003e hiera(\u0027cinder::backend::netapp::netapp_server_hostname\u0027, undef),"},{"line_number":602,"context_line":"      netapp_server_port           \u003d\u003e hiera(\u0027cinder::backend::netapp::netapp_server_port\u0027, undef),"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa32b979_911b581c","line":599,"updated":"2015-06-22 15:51:01.000000000","message":"same as overcloud_controller.pp","commit_id":"12e9c9ed0635d5f599629d7d8d7bf626e0b50f35"}]}