)]}'
{"overcloud-without-mergepy.yaml":[{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"41548831ae708276e902a52421b01ec82c32c43d","unresolved":false,"context_lines":[{"line_number":392,"context_line":"    type: string"},{"line_number":393,"context_line":"    constraints:"},{"line_number":394,"context_line":"    - allowed_values: [\u0027swift\u0027, \u0027file\u0027, \u0027rbd\u0027]"},{"line_number":395,"context_line":"  GlanceFilePcmkDevice:"},{"line_number":396,"context_line":"    default: \u0027\u0027"},{"line_number":397,"context_line":"    description: \u003e"},{"line_number":398,"context_line":"      An exported storage device that should be mounted by Pacemaker"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7a2fa921_ecd90bf4","line":395,"updated":"2015-10-09 18:38:00.000000000","message":"Is there anyway to name these such that they aren\u0027t pacemaker specific? Like what if we do NFS support that doesn\u0027t use pacemaker at some point? If they only apply to pacemaker do they belong at the top or should we use parameter_defaults for them and only add them to the controller manifest.","commit_id":"4f90f6b89bcb50d65c737cf428d2ff10424b0f89"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"7c425d2c33f2242e4ecfe0c7ea6de4f82815824d","unresolved":false,"context_lines":[{"line_number":392,"context_line":"    type: string"},{"line_number":393,"context_line":"    constraints:"},{"line_number":394,"context_line":"    - allowed_values: [\u0027swift\u0027, \u0027file\u0027, \u0027rbd\u0027]"},{"line_number":395,"context_line":"  GlanceFilePcmkDevice:"},{"line_number":396,"context_line":"    default: \u0027\u0027"},{"line_number":397,"context_line":"    description: \u003e"},{"line_number":398,"context_line":"      An exported storage device that should be mounted by Pacemaker"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7a2fa921_870b692b","line":395,"in_reply_to":"7a2fa921_ecd90bf4","updated":"2015-10-12 10:59:06.000000000","message":"I think keeping the Pacemaker-specific parameter naming is good, because theoretically Pacemaker can use those parameters to mount also different filesystem types than just NFS. If we don\u0027t want to expose these in the top-level templates, i\u0027ll investigate the option of parameter_defaults + changing only controller manifest, as you suggested.","commit_id":"4f90f6b89bcb50d65c737cf428d2ff10424b0f89"}],"puppet/controller.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"6def244b08304854243bae0fc0424bc431552f3e","unresolved":false,"context_lines":[{"line_number":1074,"context_line":"                glance_file_pcmk_device: {get_param: GlanceFilePcmkDevice}"},{"line_number":1075,"context_line":"                glance_file_pcmk_fstype: {get_param: GlanceFilePcmkFstype}"},{"line_number":1076,"context_line":"                glance_file_pcmk_manage: {get_param: GlanceFilePcmkManage}"},{"line_number":1077,"context_line":"                glance_file_pcmk_options: {get_param: GlanceFilePcmkOptions}"},{"line_number":1078,"context_line":""},{"line_number":1079,"context_line":"                # Heat"},{"line_number":1080,"context_line":"                heat_stack_domain_admin_password: {get_input: heat_stack_domain_admin_password}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7a2fa921_44d58fe5","line":1077,"updated":"2015-10-09 10:07:42.000000000","message":"should these be get_input here (you added them above in the controller SoftwareDeployment inputs)","commit_id":"5dfdc6666b4ad006c6c715a82484ada9331ca1aa"}],"puppet/manifests/overcloud_controller_pacemaker.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"72fc867a20297f79252726509f504f83bba61c4f","unresolved":false,"context_lines":[{"line_number":531,"context_line":"      directory    \u003d\u003e hiera(\u0027glance_file_pcmk_directory\u0027),"},{"line_number":532,"context_line":"      fstype       \u003d\u003e hiera(\u0027glance_file_pcmk_fstype\u0027),"},{"line_number":533,"context_line":"      fsoptions    \u003d\u003e hiera(\u0027glance_file_pcmk_options\u0027, \u0027\u0027),"},{"line_number":534,"context_line":"      clone_params \u003d\u003e \u0027\u0027,"},{"line_number":535,"context_line":"    }"},{"line_number":536,"context_line":"  }"},{"line_number":537,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3a29b11f_45baf8c1","line":534,"updated":"2015-10-19 20:36:53.000000000","message":"you should use \u0027undef\u0027 instead of \u0027\u0027","commit_id":"3729e63b59b36615180e64ffdab9e1f6fd66796e"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"9ea7aed73f999909c8598284f06025515d407b4c","unresolved":false,"context_lines":[{"line_number":531,"context_line":"      directory    \u003d\u003e hiera(\u0027glance_file_pcmk_directory\u0027),"},{"line_number":532,"context_line":"      fstype       \u003d\u003e hiera(\u0027glance_file_pcmk_fstype\u0027),"},{"line_number":533,"context_line":"      fsoptions    \u003d\u003e hiera(\u0027glance_file_pcmk_options\u0027, \u0027\u0027),"},{"line_number":534,"context_line":"      clone_params \u003d\u003e \u0027\u0027,"},{"line_number":535,"context_line":"    }"},{"line_number":536,"context_line":"  }"},{"line_number":537,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3a29b11f_4b3957f1","line":534,"in_reply_to":"3a29b11f_45baf8c1","updated":"2015-10-21 10:57:25.000000000","message":"I think if i used undef, the resource wouldn\u0027t get cloned.","commit_id":"3729e63b59b36615180e64ffdab9e1f6fd66796e"}]}