)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"0fe477ffdf35e4a094a74661eb5e55eb1c599801","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jiri Stransky \u003cjistr@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-10-09 11:44:45 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Parametrize RabbitMQ FD limit"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: 1474586"},{"line_number":10,"context_line":"Change-Id: I62d31e483641ccb5cf489df81146ecb31d0c423f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7a2fa921_f348e78c","line":7,"updated":"2015-10-12 09:17:34.000000000","message":"parameterize\n\ncome on a single sentence here is hardly going to kill anyone, just copy/paste from the bug report \"As the pacemaker resource agent starts rabbitmq-server directly we can\u0027t use the normal limits.conf method via systemd to control the file_descriptors limit.\" so we set it via the templates and hieradata","commit_id":"ca93f4dbb8e3b8d9d03e18a2510a936ad2bd8a0a"}],"puppet/controller.yaml":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"6767326509c25c20dc87f2197c0903adffe799d2","unresolved":false,"context_lines":[{"line_number":881,"context_line":"        # We need to force the following into a string because \u0027unlimited\u0027 is a valid setting"},{"line_number":882,"context_line":"        rabbit_fd_limit:"},{"line_number":883,"context_line":"          str_replace:"},{"line_number":884,"context_line":"            template: \"\u0027LIMIT\u0027\""},{"line_number":885,"context_line":"            params:"},{"line_number":886,"context_line":"              LIMIT: {get_param: RabbitFDLimit}"},{"line_number":887,"context_line":"        ntp_servers:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a1a9d01_d10fe486","line":884,"updated":"2015-10-01 13:56:23.000000000","message":"Ideally puppetlabs-rabbitmq would be able to receive a number argument too. When it\u0027s fixed in puppetlabs-rabbitmq, this approach will keep working so i don\u0027t see a problem here.","commit_id":"1b523b5e342b2efd0544320537bf6e1551a60a81"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"a9748b21c6a3ad1625918bf40412f69a6d8bfdaf","unresolved":false,"context_lines":[{"line_number":883,"context_line":"          str_replace:"},{"line_number":884,"context_line":"            template: \"\u0027LIMIT\u0027\""},{"line_number":885,"context_line":"            params:"},{"line_number":886,"context_line":"              LIMIT: {get_param: RabbitFDLimit}"},{"line_number":887,"context_line":"        ntp_servers:"},{"line_number":888,"context_line":"          str_replace:"},{"line_number":889,"context_line":"            template: \u0027[\"server\"]\u0027"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7a2fa921_cc9ffa01","line":886,"updated":"2015-10-07 09:46:02.000000000","message":"Is this actually needed - the type of the parameter is string, so it should always provide a string?  Or are you saying puppet requires it to be single quoted?","commit_id":"1b523b5e342b2efd0544320537bf6e1551a60a81"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"733d59da56e349af7c264c79e48cf81a55e9aa9e","unresolved":false,"context_lines":[{"line_number":883,"context_line":"          str_replace:"},{"line_number":884,"context_line":"            template: \"\u0027LIMIT\u0027\""},{"line_number":885,"context_line":"            params:"},{"line_number":886,"context_line":"              LIMIT: {get_param: RabbitFDLimit}"},{"line_number":887,"context_line":"        ntp_servers:"},{"line_number":888,"context_line":"          str_replace:"},{"line_number":889,"context_line":"            template: \u0027[\"server\"]\u0027"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7a2fa921_bd39e0f4","line":886,"in_reply_to":"7a2fa921_29fbf2c2","updated":"2015-10-12 08:06:27.000000000","message":"Ouch.  That sounds like something the puppet implementation should really handle transparently :(","commit_id":"1b523b5e342b2efd0544320537bf6e1551a60a81"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"a2d9a40df3ddbb80d8fe6e5402e9ee44dbf24b86","unresolved":false,"context_lines":[{"line_number":883,"context_line":"          str_replace:"},{"line_number":884,"context_line":"            template: \"\u0027LIMIT\u0027\""},{"line_number":885,"context_line":"            params:"},{"line_number":886,"context_line":"              LIMIT: {get_param: RabbitFDLimit}"},{"line_number":887,"context_line":"        ntp_servers:"},{"line_number":888,"context_line":"          str_replace:"},{"line_number":889,"context_line":"            template: \u0027[\"server\"]\u0027"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7a2fa921_29fbf2c2","line":886,"in_reply_to":"7a2fa921_cc9ffa01","updated":"2015-10-07 14:14:37.000000000","message":"Yes when this is not in quotes [1] puppet fails because hiera is passing it as integer not string.\n\n1. https://github.com/puppetlabs/puppetlabs-rabbitmq/blob/1e2ea5cc4844722259173335f135709972fe6dcd/manifests/init.pp#L106","commit_id":"1b523b5e342b2efd0544320537bf6e1551a60a81"}],"puppet/hieradata/controller.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c3e2cce8e478a80377a14008d34d1e2d0930e807","unresolved":false,"context_lines":[{"line_number":14,"context_line":"rabbitmq_environment:"},{"line_number":15,"context_line":"  RABBITMQ_NODENAME: \"rabbit@%{::hostname}\""},{"line_number":16,"context_line":"  RABBITMQ_SERVER_ERL_ARGS: \u0027\"+K true +A30 +P 1048576 -kernel inet_default_connect_options [{nodelay,true},{raw,6,18,\u003c\u003c5000:64/native\u003e\u003e}] -kernel inet_default_listen_options [{raw,6,18,\u003c\u003c5000:64/native\u003e\u003e}]\"\u0027"},{"line_number":17,"context_line":"  ulimit -S -n \"%{hiera(\u0027rabbitmq::params::file_limit\u0027)}\""},{"line_number":18,"context_line":"rabbitmq_kernel_variables:"},{"line_number":19,"context_line":"  inet_dist_listen_min: \u002735672\u0027"},{"line_number":20,"context_line":"  inet_dist_listen_max: \u002735672\u0027"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9a41bdd9_c8d31ad4","line":17,"updated":"2015-07-15 07:44:57.000000000","message":"so does this just get executed (or rather, how does this...)","commit_id":"5c94b9be977d7f8e8e4e13e49e94a275e54b314b"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"01d5f1f2c35e8a6a9085723df3a59ef33c1205d9","unresolved":false,"context_lines":[{"line_number":14,"context_line":"rabbitmq_environment:"},{"line_number":15,"context_line":"  RABBITMQ_NODENAME: \"rabbit@%{::hostname}\""},{"line_number":16,"context_line":"  RABBITMQ_SERVER_ERL_ARGS: \u0027\"+K true +A30 +P 1048576 -kernel inet_default_connect_options [{nodelay,true},{raw,6,18,\u003c\u003c5000:64/native\u003e\u003e}] -kernel inet_default_listen_options [{raw,6,18,\u003c\u003c5000:64/native\u003e\u003e}]\"\u0027"},{"line_number":17,"context_line":"  ulimit -S -n \"%{hiera(\u0027rabbitmq::params::file_limit\u0027)}\""},{"line_number":18,"context_line":"rabbitmq_kernel_variables:"},{"line_number":19,"context_line":"  inet_dist_listen_min: \u002735672\u0027"},{"line_number":20,"context_line":"  inet_dist_listen_max: \u002735672\u0027"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9a41bdd9_5f6010cf","line":17,"in_reply_to":"9a41bdd9_294cfe9c","updated":"2015-07-15 12:11:02.000000000","message":"thanks for responding + explanation. in which case we can use that (can we? the : token? and if you find a neater way we can revisit and/or change if this doesn\u0027t land meantime)","commit_id":"5c94b9be977d7f8e8e4e13e49e94a275e54b314b"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"55ba37655d6b246f55bc3e2e99e345754d73389f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"rabbitmq_environment:"},{"line_number":15,"context_line":"  RABBITMQ_NODENAME: \"rabbit@%{::hostname}\""},{"line_number":16,"context_line":"  RABBITMQ_SERVER_ERL_ARGS: \u0027\"+K true +A30 +P 1048576 -kernel inet_default_connect_options [{nodelay,true},{raw,6,18,\u003c\u003c5000:64/native\u003e\u003e}] -kernel inet_default_listen_options [{raw,6,18,\u003c\u003c5000:64/native\u003e\u003e}]\"\u0027"},{"line_number":17,"context_line":"  ulimit -S -n \"%{hiera(\u0027rabbitmq::params::file_limit\u0027)}\""},{"line_number":18,"context_line":"rabbitmq_kernel_variables:"},{"line_number":19,"context_line":"  inet_dist_listen_min: \u002735672\u0027"},{"line_number":20,"context_line":"  inet_dist_listen_max: \u002735672\u0027"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9a41bdd9_294cfe9c","line":17,"in_reply_to":"9a41bdd9_c8d31ad4","updated":"2015-07-15 11:53:18.000000000","message":"the resulting rabbitmq-env.conf file is just sourced... so this is a suboptimal trick to execute the command when started by pacemaker, see https://bugzilla.redhat.com/show_bug.cgi?id\u003d1240587#c5\n\nthe problem is puppet expects a colon : to split the string into a var\u003dvalue pair ... damn!","commit_id":"5c94b9be977d7f8e8e4e13e49e94a275e54b314b"}]}