)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"d99b3c2bad16975d35b17544aafe7911f7b9e9c2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add TimeZone option for all node types"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fix BZ1238460"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I98123d894ce429c34744233fe3e631cbdd7c12b5"},{"line_number":12,"context_line":"Depends-On: Icf7c681f359e3e48b653ea4648db6a73b532d45e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a740942_15aedd2d","line":9,"updated":"2015-12-14 13:57:39.000000000","message":"There is a periodic discussion that we shouldn\u0027t link BZs to replace LaunchPad bug links from commit messages. I\u0027d perhaps consider these options:\n\n* not linking the BZ (this is more of a RFE than a bug after all)\n\n* reporting a LP bug and linking both the LP one and the BZ one.\n\nThe syntax for linking a LP bug is:\n\nCloses-Bug: #1234\n\n\nThe rationale behind this is that LaunchPad is the official upstream bug tracking tool (recognized by automation, used to track upstream backports etc.), so if some patch warrants a link to a bug tracking tool, the tool used should be LaunchPad.\n\nI think there is not a 100% consensus on this topic but what i wrote above seemed to get the most +1s on an upstream TripleO meeting a while ago.","commit_id":"79af4a3ad97daf05bcecab79ac678f3ed61d9f10"}],"overcloud-without-mergepy.yaml":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"d99b3c2bad16975d35b17544aafe7911f7b9e9c2","unresolved":false,"context_lines":[{"line_number":996,"context_line":"          SnmpdReadonlyUserPassword: {get_param: SnmpdReadonlyUserPassword}"},{"line_number":997,"context_line":"          ServiceNetMap: {get_param: ServiceNetMap}"},{"line_number":998,"context_line":"          EndpointMap: {get_attr: [EndpointMap, endpoint_map]}"},{"line_number":999,"context_line":"          TimeZone: {get_param: TimeZone}"},{"line_number":1000,"context_line":"          UpdateIdentifier: {get_param: UpdateIdentifier}"},{"line_number":1001,"context_line":"          Hostname:"},{"line_number":1002,"context_line":"            str_replace:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7a740942_75d5e119","line":999,"updated":"2015-12-14 13:57:39.000000000","message":"Would be nice to pass this in a somewhat consistent place in the param list, e.g. alphabetically right after \"ServiceNetMap\". (Same in the other files.)\n\nI know not all params are alphabetically sorted anyway, but at least personally i like if we don\u0027t shuffle things even more with new patches. Sticking to at least some ordering will make it easier to shuffle things later if we decide to make this rule stricter.\n\nOtherwise the patch looks good, thanks! I\u0027m kinda looking forward to setting my deployments to UTC, it will make debugging a lot easier. (Heat uses always UTC in CLI outputs, but all logs are in server timezone.)","commit_id":"79af4a3ad97daf05bcecab79ac678f3ed61d9f10"}]}
