)]}'
{"puppet/manifests/overcloud_controller_pacemaker.pp":[{"author":{"_account_id":4330,"name":"Tomas Sedovic","email":"tsedovic@redhat.com","username":"tomas-8c8"},"change_message_id":"005a8ac4a941412f6f6d74a805000cff0cb5578e","unresolved":false,"context_lines":[{"line_number":62,"context_line":"  $pacemaker_cluster_members \u003d downcase(regsubst(hiera(\u0027controller_node_names\u0027), \u0027,\u0027, \u0027 \u0027, \u0027G\u0027))"},{"line_number":63,"context_line":"  $corosync_ipv6 \u003d str2bool(hiera(\u0027corosync_ipv6\u0027, false))"},{"line_number":64,"context_line":"  if $corosync_ipv6 {"},{"line_number":65,"context_line":"    $cluster_setup_extras \u003d\u003e { \u0027--ipv6\u0027 \u003d\u003e \u0027\u0027 }"},{"line_number":66,"context_line":"  } else {"},{"line_number":67,"context_line":"    $cluster_setup_extras \u003d\u003e {}"},{"line_number":68,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da6ed579_fad91e84","line":65,"updated":"2016-01-13 19:00:18.000000000","message":"I was getting a syncax error here. This seems to fix it:\n\n    $cluster_setup_extras \u003d { \u0027--ipv6\u0027 \u003d\u003e \u0027\u0027 }","commit_id":"a8a5190f84591e0e7360096dbd95c117e038d004"},{"author":{"_account_id":4330,"name":"Tomas Sedovic","email":"tsedovic@redhat.com","username":"tomas-8c8"},"change_message_id":"005a8ac4a941412f6f6d74a805000cff0cb5578e","unresolved":false,"context_lines":[{"line_number":64,"context_line":"  if $corosync_ipv6 {"},{"line_number":65,"context_line":"    $cluster_setup_extras \u003d\u003e { \u0027--ipv6\u0027 \u003d\u003e \u0027\u0027 }"},{"line_number":66,"context_line":"  } else {"},{"line_number":67,"context_line":"    $cluster_setup_extras \u003d\u003e {}"},{"line_number":68,"context_line":"  }"},{"line_number":69,"context_line":"  user { \u0027hacluster\u0027:"},{"line_number":70,"context_line":"    ensure \u003d\u003e present,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da6ed579_5ad14a56","line":67,"updated":"2016-01-13 19:00:18.000000000","message":"$cluster_setup_extras \u003d {}","commit_id":"a8a5190f84591e0e7360096dbd95c117e038d004"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"f24cd7eb1a9bc22bb6bcaf7580799a3d3dfd57e3","unresolved":false,"context_lines":[{"line_number":62,"context_line":"  $pacemaker_cluster_members \u003d downcase(regsubst(hiera(\u0027controller_node_names\u0027), \u0027,\u0027, \u0027 \u0027, \u0027G\u0027))"},{"line_number":63,"context_line":"  $corosync_ipv6 \u003d str2bool(hiera(\u0027corosync_ipv6\u0027, false))"},{"line_number":64,"context_line":"  if $corosync_ipv6 {"},{"line_number":65,"context_line":"    $cluster_setup_extras \u003d { \u0027--ipv6\u0027 \u003d\u003e \u0027\u0027 }"},{"line_number":66,"context_line":"  } else {"},{"line_number":67,"context_line":"    $cluster_setup_extras \u003d {}"},{"line_number":68,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"5a5ae5dd_c52d7647","line":65,"updated":"2016-02-04 14:43:29.000000000","message":"I +2 this before, I\u0027m setting -1 because I think we should have a bigger conversation here.\n\nThe problem in this submission, and a few others, looks to me to be similar to what we did in Iec209ca83a5b0708ac828c4afaf9d2222e597f24 \n\nI think we can and should experiment with some sort of ipv6 hiera too","commit_id":"047e2fd986efebb1b91d62fc03d11fc9e9818680"}]}